)]}'
{"agent.yaml.template":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"3fce8e7e4f1435b126fc1d436b447afa82800226","unresolved":true,"context_lines":[{"line_number":33,"context_line":"  project_domain_name: {args.project_domain_name}"},{"line_number":34,"context_line":"  # Project id to be used by this agent"},{"line_number":35,"context_line":"  project_id: {args.project_id}"},{"line_number":36,"context_line":"  # Application credential secret, if app creds are used for authentication"},{"line_number":37,"context_line":"  application_credential_secret: {args.application_credential_secret}"},{"line_number":38,"context_line":"  # Application credential ID, if app creds are used for authentication."},{"line_number":39,"context_line":"  application_credential_id: {args.application_credential_id}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"35cd87c1_035dbc6b","line":36,"updated":"2021-03-24 10:24:09.000000000","message":"Please can we update the Monasca Agent documentation to make reference to these? If we are going to support both application_credential_id and application_credential_name, please explain the required fields for each case, or link to the Keystone doc which does so. Eg. if using application_credential_name, don\u0027t specify the application_credential_id, but you must include username and user_domain_name etc. Otherwise it isn\u0027t clear how to use it.","commit_id":"437546a83186a8e60dc7a5f461d26295bd9e4b4b"}],"monasca_agent/common/keystone.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"3fce8e7e4f1435b126fc1d436b447afa82800226","unresolved":true,"context_lines":[{"line_number":130,"context_line":"    \"\"\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    auth \u003d None"},{"line_number":133,"context_line":"    if (kwargs.get(\u0027application_credential_name\u0027, None) or"},{"line_number":134,"context_line":"            kwargs.get(\u0027application_credential_id\u0027, None)):"},{"line_number":135,"context_line":"        LOG.debug(\u0027Initializing keystone session using application credential\u0027)"},{"line_number":136,"context_line":"        auth \u003d identity.V3ApplicationCredential("}],"source_content_type":"text/x-python","patch_set":2,"id":"3cb45ad5_18f5fbe3","line":133,"updated":"2021-03-24 10:24:09.000000000","message":"nit: .get() returns None by default.","commit_id":"437546a83186a8e60dc7a5f461d26295bd9e4b4b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"3fce8e7e4f1435b126fc1d436b447afa82800226","unresolved":true,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    auth \u003d None"},{"line_number":133,"context_line":"    if (kwargs.get(\u0027application_credential_name\u0027, None) or"},{"line_number":134,"context_line":"            kwargs.get(\u0027application_credential_id\u0027, None)):"},{"line_number":135,"context_line":"        LOG.debug(\u0027Initializing keystone session using application credential\u0027)"},{"line_number":136,"context_line":"        auth \u003d identity.V3ApplicationCredential("},{"line_number":137,"context_line":"            auth_url\u003dkwargs.get(\u0027auth_url\u0027, None),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bb8c383e_884298ef","line":134,"updated":"2021-03-24 10:24:09.000000000","message":"Please could we do some more validation here? Like if application_credential_name is not None, but username is None, then raise an exception saying that fields are missing? I haven\u0027t looked, but can V3ApplicationCredential do any of the validation?","commit_id":"437546a83186a8e60dc7a5f461d26295bd9e4b4b"}],"monasca_setup/main.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"3fce8e7e4f1435b126fc1d436b447afa82800226","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        # Verify required options"},{"line_number":72,"context_line":"        basic_auth_present \u003d args.username and args.password"},{"line_number":73,"context_line":"        appcred_auth_present \u003d args.application_credential_id or args.application_credential_name"},{"line_number":74,"context_line":"        if (not basic_auth_present and not appcred_auth_present or"},{"line_number":75,"context_line":"                args.keystone_url is None):"},{"line_number":76,"context_line":"            LOG.error(\u0027Username, password and keystone_url are required when\u0027"},{"line_number":77,"context_line":"                      \u0027 running full configuration.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c27490a6_78c46173","line":74,"updated":"2021-03-24 10:24:09.000000000","message":"Perhaps we can do the validation here?","commit_id":"437546a83186a8e60dc7a5f461d26295bd9e4b4b"}],"tests/test_keystone.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"3fce8e7e4f1435b126fc1d436b447afa82800226","unresolved":true,"context_lines":[{"line_number":105,"context_line":"            \u0027service_type\u0027: self.default_service_type,"},{"line_number":106,"context_line":"            \u0027endpoint_type\u0027: self.default_endpoint_type,"},{"line_number":107,"context_line":"            \u0027region_name\u0027: self.default_region_name,"},{"line_number":108,"context_line":"        })"},{"line_number":109,"context_line":"        if use_appcred:"},{"line_number":110,"context_line":"            config.update({"},{"line_number":111,"context_line":"                \u0027application_credential_id\u0027: \u0027application_credential_id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a25a1a5_ebb09abb","line":108,"updated":"2021-03-24 10:24:09.000000000","message":"Please can we add some tests for any validation we add? Like checking we raise an exception if any app cred fields are missing?","commit_id":"437546a83186a8e60dc7a5f461d26295bd9e4b4b"}]}