)]}'
{"id":"openstack%2Fmonasca-agent~762221","triplet_id":"openstack%2Fmonasca-agent~master~I1918fda471e951f42db0d302e371108b664e936c","project":"openstack/monasca-agent","branch":"master","topic":"libvirt-plugin-change-conf-file","hashtags":[],"change_id":"I1918fda471e951f42db0d302e371108b664e936c","subject":"Set \u0027libvirt_type\u0027 and \u0027libvirt_uri\u0027 options in the \u0027libvirt\u0027 plugin to be defined in conf.d/libvirt.yaml","status":"MERGED","created":"2020-11-11 00:51:23.000000000","updated":"2021-02-19 15:36:46.000000000","submitted":"2020-11-12 14:17:37.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"762221-1605190657373-bced994f","meta_rev_id":"f6d17bb22b71dd4cc80bfba0feb0cb59143e6ad1","_number":762221,"virtual_id_number":762221,"owner":{"_account_id":31052,"name":"Yanos Angelopoulos","email":"yanos@admin.grnet.gr","username":"yan0s"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-11-12 14:17:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},{"value":0,"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},{"value":0,"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"all":[{"value":0,"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-11-12 14:02:19.000000000","_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},{"value":2,"date":"2020-11-11 10:30:48.000000000","_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},{"value":0,"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"all":[{"value":0,"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-11-12 14:02:19.000000000","_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},{"value":0,"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},{"value":0,"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},{"_account_id":33083,"name":"Giacomo Lanciano","email":"giacomo.lanciano@sns.it","username":"glanciano"}],"REVIEWER":[{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},{"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-11 01:04:34.000000000","updated_by":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"reviewer":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"state":"REVIEWER"},{"updated":"2020-11-11 10:30:48.000000000","updated_by":{"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},"reviewer":{"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},"state":"REVIEWER"},{"updated":"2020-11-11 10:31:30.000000000","updated_by":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"reviewer":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"state":"REVIEWER"},{"updated":"2020-11-12 14:02:19.000000000","updated_by":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"reviewer":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"state":"REVIEWER"},{"updated":"2020-11-12 14:17:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-15 14:57:05.000000000","updated_by":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"reviewer":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"state":"CC"},{"updated":"2021-02-19 15:36:46.000000000","updated_by":{"_account_id":33083,"name":"Giacomo Lanciano","email":"giacomo.lanciano@sns.it","username":"glanciano"},"reviewer":{"_account_id":33083,"name":"Giacomo Lanciano","email":"giacomo.lanciano@sns.it","username":"glanciano"},"state":"CC"}],"messages":[{"id":"f80920c9fa90554374d3aaa0a41bfe446982da77","author":{"_account_id":31052,"name":"Yanos Angelopoulos","email":"yanos@admin.grnet.gr","username":"yan0s"},"date":"2020-11-11 00:51:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f93413e40be6d837c857521663b2b15151394dec","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-11 01:33:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1c7c545671dd414aa0841dbb64025d6f : SUCCESS in 5m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6c493c5e46ae43318acdc9334bf5f3cb : SUCCESS in 5m 40s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bc67a45244174fb78d0d2012cb731b5c : SUCCESS in 6m 10s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6547353bf19a40ed9bf4c61836c0a515 : SUCCESS in 5m 19s (non-voting)\n- build-monasca-docker-image https://zuul.opendev.org/t/openstack/build/8b41732772f84de29a36df5990459a18 : SUCCESS in 26m 52s\n- monasca-tempest-python3-influxdb https://zuul.opendev.org/t/openstack/build/fbce02dc4c824532ac47fded1761142e : SUCCESS in 36m 24s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"57820bd1f2c01337fee0c71217b2fd9aba225bf5","author":{"_account_id":28062,"name":"Martin Chacon Piza","email":"martin@chaconpiza.com","username":"martinchacon"},"date":"2020-11-11 10:30:48.000000000","message":"Patch Set 1: Code-Review+2\n\nHi Yanos, thanks for your investigation and thanks for the fix.\n\nAt first glance it looks like we are using oslo-config [1] to handle the configuration like in the rest of Monasca modules. But you are right, monasca-agent is still using .yaml files instead of oslo-config .conf files.\n\nThe code in monasca_agent/collector/virt was derived from Ceilometer, and these are \"loose ends\".\n\nYanos, would you like to lead the migration to oslo-config?\nIt should be similar to this changes in Monasca-notification [2]\n\nOf course we will help you if you decide to take the migration.\n\n\n[1] https://opendev.org/openstack/monasca-agent/src/branch/master/monasca_agent/collector/virt/libvirt/inspector.py#L21\n\n[2] https://storyboard.openstack.org/#!/story/2000959","accounts_in_message":[],"_revision_number":1},{"id":"7b3fa5548e1c5754fa4c8512c442391c3902dd9c","author":{"_account_id":26141,"name":"Adrian Czarnecki","email":"adrian.czarnecki@ts.fujitsu.com","username":"czarneckia"},"date":"2020-11-12 14:02:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"75005b280b11df9e143530b4deb2bd469e9b775a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-12 14:02:31.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8b4108491e154b1696a769ca404703e8d5e72d74","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-12 14:17:36.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5d688d34bc7f40c0a1757a8f7dc58560 : SUCCESS in 7m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/619782d4d8114c8c9b205616ba70c8ce : SUCCESS in 5m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1119f070c45d483c94f16710b44c9201 : SUCCESS in 6m 03s","accounts_in_message":[],"_revision_number":1},{"id":"7899c4a58798fc39d2ca756476f295cc503c7a56","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-12 14:17:37.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"96d416410308e5d260bfab6504c7395c012d6548","author":{"_account_id":25277,"name":"Mariusz Karpiarz","email":"mariusz.karpiarz@codethink.co.uk","username":"mkarpiarz"},"date":"2020-12-15 14:57:05.000000000","message":"Patch Set 1:\n\nThanks for this fix. Shouldn\u0027t it be cherry-picked to all the active/supported branches?","accounts_in_message":[],"_revision_number":1},{"id":"f6d17bb22b71dd4cc80bfba0feb0cb59143e6ad1","author":{"_account_id":33083,"name":"Giacomo Lanciano","email":"giacomo.lanciano@sns.it","username":"glanciano"},"date":"2021-02-19 15:36:46.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e Thanks for this fix. Shouldn\u0027t it be cherry-picked to all the active/supported branches?\n\n+1","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"085f64578f40152273138898a0dc4566d327dc8f","revisions":{"085f64578f40152273138898a0dc4566d327dc8f":{"kind":"REWORK","_number":1,"created":"2020-11-11 00:51:23.000000000","uploader":{"_account_id":31052,"name":"Yanos Angelopoulos","email":"yanos@admin.grnet.gr","username":"yan0s"},"ref":"refs/changes/21/762221/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/monasca-agent","ref":"refs/changes/21/762221/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/21/762221/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/21/762221/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/monasca-agent refs/changes/21/762221/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/monasca-agent refs/changes/21/762221/1"}}},"commit":{"parents":[{"commit":"38c6f3af51c1ae6364531deb885af92eeee52186","subject":"Replace assertItemsEqual with assertCountEqual","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/38c6f3af51c1ae6364531deb885af92eeee52186"}]}],"author":{"name":"Yanos Angelopoulos","email":"yanos@admin.grnet.gr","date":"2020-11-11 00:40:33.000000000","tz":120},"committer":{"name":"Yanos Angelopoulos","email":"yanos@admin.grnet.gr","date":"2020-11-11 00:40:33.000000000","tz":120},"subject":"Set \u0027libvirt_type\u0027 and \u0027libvirt_uri\u0027 options in the \u0027libvirt\u0027 plugin to be defined in conf.d/libvirt.yaml","message":"Set \u0027libvirt_type\u0027 and \u0027libvirt_uri\u0027 options in the \u0027libvirt\u0027 plugin to be defined in conf.d/libvirt.yaml\n\nThe \u0027libvirt_type\u0027 and \u0027libvirt_uri\u0027 options are currently set by oslo configuration library.\nHowever, in \u0027monasca_agent/collector/virt/libvirt/inspector.py\u0027 file these options cannot be\nprovided by a configuration file. Changing this to retrieve both options from\n\u0027conf.d/libvirt.yaml\u0027 file.\n\nChange-Id: I1918fda471e951f42db0d302e371108b664e936c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/085f64578f40152273138898a0dc4566d327dc8f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/monasca-agent/commit/085f64578f40152273138898a0dc4566d327dc8f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}