)]}'
{"src/main/java/com/hpcloud/mon/infrastructure/persistence/influxdb/MeasurementInfluxDbRepositoryImpl.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"ada79c4c1b95d757174c37ce2be371045e0d2ce2","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      Utils.SerieNameDecoder serieNameDecoder;"},{"line_number":90,"context_line":"      try {"},{"line_number":91,"context_line":"        serieNameDecoder \u003d new Utils.SerieNameDecoder(serie.getName());"},{"line_number":92,"context_line":"      } catch (Exception e) {"},{"line_number":93,"context_line":"        logger.warn(\"Dropping series name that is not decodable: {}\", serie.getName(), e);"},{"line_number":94,"context_line":"        continue;"},{"line_number":95,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":2,"id":"fa98f980_7e6a25ee","line":92,"updated":"2014-09-11 21:25:43.000000000","message":"This just seems weird. You are catching Exception which I know means you want to catch the series name problem, but it will also catch NullPointerException, IllegalArgumentException, etc.\n\nThe main concern is that this hides programming errors.\n\nAnd the code isn\u0027t really any simpler","commit_id":"914919ba0bba7dbafafdac5e21a1ed34b0b42f95"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"695e111b2ae2370f266104fc324cf261cc6e51a0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      Utils.SerieNameDecoder serieNameDecoder;"},{"line_number":90,"context_line":"      try {"},{"line_number":91,"context_line":"        serieNameDecoder \u003d new Utils.SerieNameDecoder(serie.getName());"},{"line_number":92,"context_line":"      } catch (Exception e) {"},{"line_number":93,"context_line":"        logger.warn(\"Dropping series name that is not decodable: {}\", serie.getName(), e);"},{"line_number":94,"context_line":"        continue;"},{"line_number":95,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":2,"id":"fa98f980_244faa35","line":92,"in_reply_to":"fa98f980_7e6a25ee","updated":"2014-09-11 22:13:45.000000000","message":"The exceptions that you mention are Runtime/Unchecked exceptions.  This code will catch them and log them.  Yeah, they\u0027ll be logged as warnings.  We\u0027ll handle them gracefully, see them more quickly and be able to fix them.  If the check wasn\u0027t there, they\u0027d be caught most likely higher up the stack and logged as well.  Probably at error level, but then someone would need to check the log to see them as well.   The probability of these types of exceptions coming out of this method is extremely low.  Testing should find problems here.\n\nThe code locates the check in the proper place; the client doesn\u0027t have to do the check itself.  So, the code is safer and applies the DRY convention.\n\nWe could create a specific type of exception for this, but that seems overkill and not much value add.","commit_id":"914919ba0bba7dbafafdac5e21a1ed34b0b42f95"}]}