)]}'
{"monasca/common/repositories/influxdb/metrics_repository.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"074d528d2b59af5e03c0fe3df4b3727897206f10","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        statistics \u003d [statistic.replace(\u0027avg\u0027, \u0027mean\u0027) for statistic in"},{"line_number":81,"context_line":"                      statistics]"},{"line_number":82,"context_line":"        statistics \u003d [statistic.replace(statistic, statistic + \u0027(value)\u0027) for"},{"line_number":83,"context_line":"                      statistic in statistics]"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        statistic_string \u003d \",\".join(statistics)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_c7751d99","line":83,"updated":"2014-10-15 12:50:06.000000000","message":"This could be written simpler as:\n\nstatistics \u003d [statistic + \u0027(value)\u0027 for statistic in statistics]\n\nOr \n\nstatistics \u003d [statistic.replace(\u0027avg\u0027, \u0027mean\u0027) + \u0027(value)\u0027 for statistic in statistics]\n\nBut I would probably go for the two separate statements to be clear about what is happening","commit_id":"560b342bf5703739d9ec49b2855edc2d7b18b04f"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"074d528d2b59af5e03c0fe3df4b3727897206f10","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                if metric is None:"},{"line_number":352,"context_line":"                    continue"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"                # Replace \u0027sequence_number\u0027 -\u003e \u0027id\u0027 for column name"},{"line_number":355,"context_line":"                columns \u003d [column.replace(\u0027mean\u0027, \u0027avg\u0027) for column in"},{"line_number":356,"context_line":"                           serie[\u0027columns\u0027]]"},{"line_number":357,"context_line":"                # Replace \u0027time\u0027 -\u003e \u0027timestamp\u0027 for column name"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_a75c991a","line":354,"updated":"2014-10-15 12:50:06.000000000","message":"Either the comment or the code is wrong","commit_id":"560b342bf5703739d9ec49b2855edc2d7b18b04f"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"c84923f7ed9a37c0737d8ee7b63fbf3439958852","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                fmtd_pts_list_list \u003d []"},{"line_number":362,"context_line":"                for pts_list in serie[\u0027points\u0027]:"},{"line_number":363,"context_line":"                    # time is always the first point"},{"line_number":364,"context_line":"                    fmtd_pts_list \u003d ["},{"line_number":365,"context_line":"                        strftime(\"%Y-%m-%dT%H:%M:%SZ\", gmtime(pts_list[0]))]"},{"line_number":366,"context_line":"                    # the rest of the points are statistics. just pass them"},{"line_number":367,"context_line":"                    # thru unchanged."}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_ad00e834","line":364,"updated":"2014-10-15 15:26:59.000000000","message":"The simpler and I think clearer python way to do this is:\nfmtd_pts_list \u003d [strftime(\"%Y-%m-%dT%H:%M:%SZ\", gmtime(pts_list[0]))] + pts_list[1:]","commit_id":"dd21776e6bce4dd916a09ac7cc5847af4da5c87c"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"5dbe4ef4220b9bbcd2519392e3d30d6a1dc7f227","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                fmtd_pts_list_list \u003d []"},{"line_number":362,"context_line":"                for pts_list in serie[\u0027points\u0027]:"},{"line_number":363,"context_line":"                    # time is always the first point"},{"line_number":364,"context_line":"                    fmtd_pts_list \u003d ["},{"line_number":365,"context_line":"                        strftime(\"%Y-%m-%dT%H:%M:%SZ\", gmtime(pts_list[0]))]"},{"line_number":366,"context_line":"                    # the rest of the points are statistics. just pass them"},{"line_number":367,"context_line":"                    # thru unchanged."}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_08a3a2b2","line":364,"in_reply_to":"baa201ad_ad00e834","updated":"2014-10-15 15:44:25.000000000","message":"nice.","commit_id":"dd21776e6bce4dd916a09ac7cc5847af4da5c87c"}],"monasca/v2/reference/helpers.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"074d528d2b59af5e03c0fe3df4b3727897206f10","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    try:"},{"line_number":167,"context_line":"        params \u003d parse_query_string(req.query_string)"},{"line_number":168,"context_line":"        if \u0027statistics\u0027 in params:"},{"line_number":169,"context_line":"            return params[\u0027statistics\u0027].split(\u0027,\u0027)"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            raise Exception(\"Missing statistics\")"},{"line_number":172,"context_line":"    except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_c727ddb4","line":169,"updated":"2014-10-15 12:50:06.000000000","message":"There should be some validation for the statistics types","commit_id":"560b342bf5703739d9ec49b2855edc2d7b18b04f"}]}