)]}'
{"monasca/api/alarm_definitions_api_v2.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"532f100b4a0865e50a1722666f53d7dfdadf4df6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 IBM Corp"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Tong Li \u003clitong01@us.ibm.com\u003e"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_6b0aebd3","line":1,"updated":"2014-10-30 16:37:43.000000000","message":"HP copyright should be added","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b01b0e895e6e1920a21898cc6139b9baf3c96fd2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 IBM Corp"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Tong Li \u003clitong01@us.ibm.com\u003e"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_17051ec2","line":3,"updated":"2014-10-30 01:39:45.000000000","message":"This shouldn\u0027t be Tong, it should be Deklan","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"}],"monasca/common/repositories/Alarm_Definitions_Repository.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"532f100b4a0865e50a1722666f53d7dfdadf4df6","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":19,"context_line":"class AlarmDefinitionsRepository(object):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    @abc.abstractmethod"},{"line_number":22,"context_line":"    def create_alarm_definition(self, tenant_id, name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_96f3be09","line":19,"updated":"2014-10-30 16:37:43.000000000","message":"The file name should be \"alarm_definition_repository.py\", all lowercase.","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"}],"monasca/v2/common/schemas/alarm_definition_request_body_schema.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b01b0e895e6e1920a21898cc6139b9baf3c96fd2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"alarm_definition_schema \u003d {"},{"line_number":25,"context_line":"    Required(\u0027name\u0027): All(Any(str, unicode), Length(max\u003d100)),"},{"line_number":26,"context_line":"    Required(\u0027expression\u0027): All(Any(str, unicode), Length(max\u003d2048)),"},{"line_number":27,"context_line":"    Optional(\u0027description\u0027): All(Any(str, unicode), Length(max\u003d250)),"},{"line_number":28,"context_line":"    Optional(\u0027severity\u0027): All("}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_775f4273","line":25,"updated":"2014-10-30 01:39:45.000000000","message":"The schema limit is 250 for name","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b01b0e895e6e1920a21898cc6139b9baf3c96fd2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    Optional(\u0027description\u0027): All(Any(str, unicode), Length(max\u003d250)),"},{"line_number":28,"context_line":"    Optional(\u0027severity\u0027): All("},{"line_number":29,"context_line":"        Any(\u0027low\u0027, \u0027med\u0027, \u0027high\u0027, \u0027critical\u0027, \u0027LOW\u0027, \"MED\", \u0027HIGH\u0027,"},{"line_number":30,"context_line":"            \u0027CRITICAL\u0027)),"},{"line_number":31,"context_line":"    Optional(\u0027match_by\u0027): All(Any([unicode], [str]), Length(max\u003d255)),"},{"line_number":32,"context_line":"    Optional(\u0027ok_actions\u0027): All(Any([str], [unicode]), Length(max\u003d50)),"},{"line_number":33,"context_line":"    Optional(\u0027alarm_actions\u0027): All(Any([str], [unicode]), Length(max\u003d50)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_5799666d","line":30,"updated":"2014-10-30 01:39:45.000000000","message":"According to the schema file, the valid values are:\n\u0027LOW\u0027,\u0027MEDIUM\u0027,\u0027HIGH\u0027,\u0027CRITICAL\u0027\n\nNot MED","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"}],"monasca/v2/reference/alarm_definitions.py":[{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"17af64688c613cc44a754f88485bd33bf87bc951","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                                   invoke_on_load\u003dTrue,"},{"line_number":66,"context_line":"                                   invoke_args\u003d([\u0027events\u0027]))"},{"line_number":67,"context_line":"        self._message_queue \u003d mgr.driver"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _init_alarm_definitions_repo(self):"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_e681ad4b","line":68,"updated":"2014-10-30 17:28:11.000000000","message":"You can remove this, and replace it with a call to resource_api.init_driver to init self._message_queue.  That\u0027s what the other resources do","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"532f100b4a0865e50a1722666f53d7dfdadf4df6","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _init_alarm_definitions_repo(self):"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        pass"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        mgr \u003d driver.DriverManager(namespace\u003d\u0027monasca.repositories\u0027,"},{"line_number":74,"context_line":"                                   name\u003dcfg.CONF.repositories.alarm_definitions_driver,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_ab8853e8","line":71,"updated":"2014-10-30 16:37:43.000000000","message":"Should be removed","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"532f100b4a0865e50a1722666f53d7dfdadf4df6","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        undetermined_actions \u003d \\"},{"line_number":100,"context_line":"            helpers.get_query_alarm_definition_undetermined_actions("},{"line_number":101,"context_line":"            alarm_definition)"},{"line_number":102,"context_line":"        ok_actions \u003d helpers.get_query_ok_actions(alarm_definition)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        result \u003d self._alarm_definition_create(tenant_id, name, expression,"},{"line_number":105,"context_line":"                                               description, severity, match_by,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_eb5a5b4f","line":102,"updated":"2014-10-30 16:37:43.000000000","message":"Just wondering if these should be in helpers or as private methods in this class. Most of these helpers seem specific to alarm definitions.","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b01b0e895e6e1920a21898cc6139b9baf3c96fd2","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                                 alarm_actions, undetermined_actions,"},{"line_number":151,"context_line":"                                 ok_actions):"},{"line_number":152,"context_line":"        try:"},{"line_number":153,"context_line":"            sub_expr_list \u003d AlarmExprParser(expression).get_sub_expr_list()"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"            alarm_definition_id \u003d \\"},{"line_number":156,"context_line":"                self._alarm_definitions_repo.create_alarm_definition("}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_1760be34","line":153,"updated":"2014-10-30 01:39:45.000000000","message":"Somewhere in this path should be a check to ensure the name doesn\u0027t already exist for this tenant id","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b01b0e895e6e1920a21898cc6139b9baf3c96fd2","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        alarm_definition_created_event_msg[u\u0027alarm-definition-created\u0027]["},{"line_number":226,"context_line":"            u\u0027alarmSubExpressions\u0027] \u003d sub_expr_event_msg"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        self._send_event(alarm_definition_created_event_msg)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def _send_event(self, event_msg):"},{"line_number":231,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_37685af5","line":228,"updated":"2014-10-30 01:39:45.000000000","message":"The Java API deletes the Alarm Definition if the message can\u0027t be sent. This prevents thresh from getting out of sync. I\u0027m not sure if this is right, but we should be wary of changing behaviors","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"532f100b4a0865e50a1722666f53d7dfdadf4df6","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        self._send_event(alarm_definition_created_event_msg)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def _send_event(self, event_msg):"},{"line_number":231,"context_line":"        try:"},{"line_number":232,"context_line":"            self._message_queue.send_message("},{"line_number":233,"context_line":"                json.dumps(event_msg, ensure_ascii\u003dFalse).encode(\u0027utf8\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_9609fe2e","line":230,"updated":"2014-10-30 16:37:43.000000000","message":"Should probably be moved to a helper as this will be common across multiple resource classes.","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"}],"monasca/v2/reference/helpers.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b01b0e895e6e1920a21898cc6139b9baf3c96fd2","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def read_json_msg_body(req):"},{"line_number":30,"context_line":"    \u0027\u0027\u0027"},{"line_number":31,"context_line":"    Read the metrics from the http request and return them as JSON."},{"line_number":32,"context_line":"    :param req: HTTP request object."},{"line_number":33,"context_line":"    :return: Returns the metrics as a JSON object."},{"line_number":34,"context_line":"    :raises falcon.HTTPBadRequest:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_174a7e83","line":31,"updated":"2014-10-30 01:39:45.000000000","message":"Is this only metrics? Looks like it could be alarm definitions, notifications, etc.","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b01b0e895e6e1920a21898cc6139b9baf3c96fd2","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        raise falcon.HTTPBadRequest(\u0027Bad request\u0027, ex.message)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def get_query_alarm_definition_name(alarm_definition):"},{"line_number":136,"context_line":"    try:"},{"line_number":137,"context_line":"        if \u0027name\u0027 in alarm_definition:"},{"line_number":138,"context_line":"            name \u003d alarm_definition[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_573b26eb","line":135,"updated":"2014-10-30 01:39:45.000000000","message":"Seems like this one and next one could have a helper method where you passed in \u0027name\u0027 or \u0027expression\u0027","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b01b0e895e6e1920a21898cc6139b9baf3c96fd2","unresolved":false,"context_lines":[{"line_number":278,"context_line":"    if \u0027severity\u0027 in alarm_definition:"},{"line_number":279,"context_line":"        severity \u003d alarm_definition[\u0027severity\u0027]"},{"line_number":280,"context_line":"        severity \u003d severity.decode(\u0027utf8\u0027).lower()"},{"line_number":281,"context_line":"        if severity not in [\u0027low\u0027, \u0027med\u0027, \u0027high\u0027, \u0027critical\u0027]:"},{"line_number":282,"context_line":"            raise falcon.HTTPBadRequest(\u0027Bad request, Invalid severity\u0027)"},{"line_number":283,"context_line":"        return severity"},{"line_number":284,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_d72e36a5","line":281,"updated":"2014-10-30 01:39:45.000000000","message":"medium","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b01b0e895e6e1920a21898cc6139b9baf3c96fd2","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        return \u0027\u0027"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"def get_query_alarm_definition_match_by(alarm_definition):"},{"line_number":289,"context_line":"    if \u0027match_by\u0027 in alarm_definition:"},{"line_number":290,"context_line":"        match_by \u003d alarm_definition[\u0027match_by\u0027]"},{"line_number":291,"context_line":"        return match_by"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_b708ca2e","line":288,"updated":"2014-10-30 01:39:45.000000000","message":"These 4 are practically the same","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"}],"monasca/v2/reference/metrics.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b01b0e895e6e1920a21898cc6139b9baf3c96fd2","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                                         statistics, period)"},{"line_number":199,"context_line":"        res.body \u003d json.dumps(result, ensure_ascii\u003dFalse).encode(\u0027utf8\u0027)"},{"line_number":200,"context_line":"        res.status \u003d falcon.HTTP_200"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_820e2a33","line":201,"updated":"2014-10-30 01:39:45.000000000","message":"I don\u0027t think pep8 is going to like these blank lines at the end of the file","commit_id":"0104e4e5ea9df9e6419cced3d05860b987744adc"}]}
