)]}'
{"monasca/common/repositories/mysql/alarm_definitions_repository.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"c273bee72d225f0e2d72fedc2fffaf7dc3a92394","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                             from sub_alarm_definition_dimension"},{"line_number":110,"context_line":"                              where dimension_name\u003d\u0027{}\u0027 and value\u003d\u0027{}\u0027) as sadd{}"},{"line_number":111,"context_line":"                        on sadd{}.sub_alarm_definition_id \u003d sad.id"},{"line_number":112,"context_line":"                        \"\"\".format(n.encode(\u0027utf8\u0027), v.encode(\u0027utf8\u0027), i, i)"},{"line_number":113,"context_line":"                    i +\u003d 1"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"                select_clause +\u003d inner_join"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_27e988e6","line":112,"updated":"2014-11-07 15:51:50.000000000","message":"I know it is tempting to do this, but you just put in a sql injection vulnerability. You should add name and value to parms instead","commit_id":"6e1f8829fdbaf9ef9e5f17751ad58b990d4090a7"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"7c4e183fce42cddb904cb6b229403f245cb4bdf0","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                             from sub_alarm_definition_dimension"},{"line_number":110,"context_line":"                              where dimension_name\u003d\u0027{}\u0027 and value\u003d\u0027{}\u0027) as sadd{}"},{"line_number":111,"context_line":"                        on sadd{}.sub_alarm_definition_id \u003d sad.id"},{"line_number":112,"context_line":"                        \"\"\".format(n.encode(\u0027utf8\u0027), v.encode(\u0027utf8\u0027), i, i)"},{"line_number":113,"context_line":"                    i +\u003d 1"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"                select_clause +\u003d inner_join"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_0dc7d113","line":112,"in_reply_to":"7a8c0949_27e988e6","updated":"2014-11-07 17:06:40.000000000","message":"Done\n\nyeah, i thought the single quote solved the problem, but your right, it does not.","commit_id":"6e1f8829fdbaf9ef9e5f17751ad58b990d4090a7"},{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"be57408fdeb056430c380054963b322ec0812b08","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"            return rows"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        except Exception as ex:"},{"line_number":128,"context_line":"            LOG.exception(ex)"},{"line_number":129,"context_line":"            raise exceptions.RepositoryException(ex)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_27c6e89a","line":127,"updated":"2014-11-07 15:44:53.000000000","message":"Shouldn\u0027t this be a more specific sql exception base class.","commit_id":"6e1f8829fdbaf9ef9e5f17751ad58b990d4090a7"}],"monasca/v2/reference/alarm_definitions.py":[{"author":{"_account_id":11094,"name":"Tim Kuhlman","email":"timothy.kuhlman@canonical.com","username":"kuhlmant"},"change_message_id":"be57408fdeb056430c380054963b322ec0812b08","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"            result \u003d []"},{"line_number":167,"context_line":"            for alarm_definition_row in alarm_definition_rows:"},{"line_number":168,"context_line":"                ad \u003d {u\u0027id\u0027: alarm_definition_row.id.decode(\u0027utf8\u0027),"},{"line_number":169,"context_line":"                      u\u0027name\u0027: alarm_definition_row.name.decode(\"utf8\"),"},{"line_number":170,"context_line":"                      u\u0027description\u0027: alarm_definition_row.description.decode(\u0027utf8\u0027),"},{"line_number":171,"context_line":"                      u\u0027expression\u0027: alarm_definition_row.expression.decode(\u0027utf8\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8c0949_e7c860aa","line":168,"updated":"2014-11-07 15:44:53.000000000","message":"This seems like a good opportunity for a dictionary comprehension. Though I could also see arguments against it as it may make it a bit less readable.","commit_id":"6e1f8829fdbaf9ef9e5f17751ad58b990d4090a7"}]}