)]}'
{"monasca/common/repositories/alarm_definitions_repository.py":[{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"9f53717690967cd3adc4c93294cdf26766e7c3b9","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @abc.abstractmethod"},{"line_number":44,"context_line":"    def get_sub_alarm_definitions(self, alarm_definition_id):"},{"line_number":45,"context_line":"        pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @abc.abstractmethod"},{"line_number":48,"context_line":"    def get_alarm_definition(self, tenant_id, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_6e31100b","line":45,"updated":"2014-11-10 20:09:27.000000000","message":"to be consistent, i think this should be \"get_alarm_definitions\" instead of \"get_sub_alarm_definitions\".","commit_id":"281b905f602d3a3ca0b25384ac62d85e984e6e6f"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"68378341e4f2037f9189abd38893966c93ae1393","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @abc.abstractmethod"},{"line_number":44,"context_line":"    def get_sub_alarm_definitions(self, alarm_definition_id):"},{"line_number":45,"context_line":"        pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @abc.abstractmethod"},{"line_number":48,"context_line":"    def get_alarm_definition(self, tenant_id, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_89ee3621","line":45,"in_reply_to":"5a890539_6e31100b","updated":"2014-11-10 20:30:31.000000000","message":"i see where the confusion is. i forgot to add the     def get_alarm_definition_list(self, tenant_id, name, dimensions) method to the abstract class.  i think i\u0027ll rename this to get_alarm_definitions to be consistent as you suggested.","commit_id":"281b905f602d3a3ca0b25384ac62d85e984e6e6f"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"d6886356c83605234fc3e3d400a62ef0608f389e","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @abc.abstractmethod"},{"line_number":44,"context_line":"    def get_sub_alarm_definitions(self, alarm_definition_id):"},{"line_number":45,"context_line":"        pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @abc.abstractmethod"},{"line_number":48,"context_line":"    def get_alarm_definition(self, tenant_id, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_4948ce5b","line":45,"in_reply_to":"5a890539_6e31100b","updated":"2014-11-10 20:22:33.000000000","message":"only one definition is ever returned, so i think the singular form is more informative.","commit_id":"281b905f602d3a3ca0b25384ac62d85e984e6e6f"}],"monasca/expression_parser/alarm_expr_parser.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"2358bf4b9ee21ea071ba669e0e64767c0270d584","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    for expr in (expr0, expr1, expr2):"},{"line_number":283,"context_line":"        alarmExprParser \u003d AlarmExprParser(expr)"},{"line_number":284,"context_line":"        r \u003d alarmExprParser.sub_expr_list"},{"line_number":285,"context_line":"        for sub_expression in r:"},{"line_number":286,"context_line":"            print sub_expression.sub_expr_str"},{"line_number":287,"context_line":"            print sub_expression.fmtd_sub_expr_str"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_ce73e4af","line":284,"updated":"2014-11-10 19:21:15.000000000","message":"You should probably print out expr here so you know which sub_expression goes with which expr","commit_id":"ac0cfac262b7adfc0856f287d15e25077c7b53c0"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"3cfcd09d89d5fa7898b8d5ec6c39d1f88c4dd2c8","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    for expr in (expr0, expr1, expr2):"},{"line_number":283,"context_line":"        alarmExprParser \u003d AlarmExprParser(expr)"},{"line_number":284,"context_line":"        r \u003d alarmExprParser.sub_expr_list"},{"line_number":285,"context_line":"        for sub_expression in r:"},{"line_number":286,"context_line":"            print sub_expression.sub_expr_str"},{"line_number":287,"context_line":"            print sub_expression.fmtd_sub_expr_str"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_eecd0088","line":284,"in_reply_to":"5a890539_ce73e4af","updated":"2014-11-10 19:44:06.000000000","message":"Done","commit_id":"ac0cfac262b7adfc0856f287d15e25077c7b53c0"}],"monasca/v2/reference/alarm_definitions.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"2358bf4b9ee21ea071ba669e0e64767c0270d584","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        result \u003d self._alarm_definition_show(tenant_id, id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        helpers.add_links_to_resource(result, req.uri)"},{"line_number":105,"context_line":"        res.body \u003d json.dumps(result, ensure_ascii\u003dFalse).encode(\u0027utf8\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @resource_api.Restify(\u0027/v2.0/alarm-definitions/{id}\u0027, method\u003d\u0027put\u0027)"},{"line_number":108,"context_line":"    def do_put_alarm_definitions(self, req, res, id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_2e62a8d8","line":105,"updated":"2014-11-10 19:21:15.000000000","message":"Do you need to set res.status? You do in do_get_alarm_definitions?","commit_id":"ac0cfac262b7adfc0856f287d15e25077c7b53c0"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"3cfcd09d89d5fa7898b8d5ec6c39d1f88c4dd2c8","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        result \u003d self._alarm_definition_show(tenant_id, id)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        helpers.add_links_to_resource(result, req.uri)"},{"line_number":105,"context_line":"        res.body \u003d json.dumps(result, ensure_ascii\u003dFalse).encode(\u0027utf8\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @resource_api.Restify(\u0027/v2.0/alarm-definitions/{id}\u0027, method\u003d\u0027put\u0027)"},{"line_number":108,"context_line":"    def do_put_alarm_definitions(self, req, res, id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_4ec5345a","line":105,"in_reply_to":"5a890539_2e62a8d8","updated":"2014-11-10 19:44:06.000000000","message":"Done","commit_id":"ac0cfac262b7adfc0856f287d15e25077c7b53c0"}]}