)]}'
{"monasca/v2/reference/alarms.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eee92fe1b3617f5d66d8978422cd0d842263d680","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                    ad \u003d {u\u0027id\u0027: alarm_row.alarm_definition_id,"},{"line_number":133,"context_line":"                          u\u0027name\u0027: alarm_row.alarm_definition_name,"},{"line_number":134,"context_line":"                          u\u0027severity\u0027: alarm_row.severity, }"},{"line_number":135,"context_line":"                    helpers.add_links_to_resource(ad, req_uri)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"                    metrics \u003d []"},{"line_number":138,"context_line":"                    alarm \u003d {u\u0027id\u0027: alarm_row.alarm_id, u\u0027metrics\u0027: metrics,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_dc91a69b","line":135,"updated":"2014-11-12 17:16:22.000000000","message":"I don\u0027t think this is right. Check what this sets the link to. Should be something like http://10.22.156.13:8080/v2.0/alarm-definitions/6df2eb14-6813-4f2f-9c3e-29aef6188424\n\nI don\u0027t see how add_links_to_resource knows it is an alarm-definition, but I could be wrong","commit_id":"d09b26622d446644f9d003aeb482094c45665b15"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"aadaaeaccc9a94664b61633f3e2018821ae9d45c","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                    ad \u003d {u\u0027id\u0027: alarm_row.alarm_definition_id,"},{"line_number":133,"context_line":"                          u\u0027name\u0027: alarm_row.alarm_definition_name,"},{"line_number":134,"context_line":"                          u\u0027severity\u0027: alarm_row.severity, }"},{"line_number":135,"context_line":"                    helpers.add_links_to_resource(ad, req_uri)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"                    metrics \u003d []"},{"line_number":138,"context_line":"                    alarm \u003d {u\u0027id\u0027: alarm_row.alarm_id, u\u0027metrics\u0027: metrics,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_dc3a8633","line":135,"in_reply_to":"5a890539_dc91a69b","updated":"2014-11-12 17:29:05.000000000","message":"yea, you\u0027re right","commit_id":"d09b26622d446644f9d003aeb482094c45665b15"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"eee92fe1b3617f5d66d8978422cd0d842263d680","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                    ad \u003d {u\u0027id\u0027: alarm_row.alarm_definition_id,"},{"line_number":186,"context_line":"                          u\u0027name\u0027: alarm_row.alarm_definition_name,"},{"line_number":187,"context_line":"                          u\u0027severity\u0027: alarm_row.severity, }"},{"line_number":188,"context_line":"                    helpers.add_links_to_resource(ad, req_uri)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"                    metrics \u003d []"},{"line_number":191,"context_line":"                    alarm \u003d {u\u0027id\u0027: alarm_row.alarm_id, u\u0027metrics\u0027: metrics,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_bcddba72","line":188,"updated":"2014-11-12 17:16:22.000000000","message":"See above","commit_id":"d09b26622d446644f9d003aeb482094c45665b15"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"22ee8ae5334a8c391e4a335c9288a58e2874c761","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                                                  re.sub(\u0027alarms\u0027,"},{"line_number":138,"context_line":"                                                         \u0027alarm-definitions\u0027,"},{"line_number":139,"context_line":"                                                         req_uri),"},{"line_number":140,"context_line":"                                                  rel\u003dNone)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"                    metrics \u003d []"},{"line_number":143,"context_line":"                    alarm \u003d {u\u0027id\u0027: alarm_row.alarm_id, u\u0027metrics\u0027: metrics,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_d2cc2f64","line":140,"updated":"2014-11-12 18:29:07.000000000","message":"Why is rel None? Seems like it should be self. Java API returns this as the alarm_definition part of the alarm:\n\n  \"alarm_definition\": {\n    \"severity\": \"LOW\", \n    \"id\": \"6df2eb14-6813-4f2f-9c3e-29aef6188424\", \n    \"links\": [\n      {\n        \"href\": \"http://10.22.156.13:8080/v2.0/alarm-definitions/6df2eb14-6813-4f2f-9c3e-29aef6188424\", \n        \"rel\": \"self\"\n      }\n    ], \n    \"name\": \"test_alarm_def1\"\n  }","commit_id":"830e0bea85124e40bb43c6541c1cb59c46d96e78"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"6badc0a494b824a51955eee3d91e1c83f83c7b41","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                                                  re.sub(\u0027alarms\u0027,"},{"line_number":138,"context_line":"                                                         \u0027alarm-definitions\u0027,"},{"line_number":139,"context_line":"                                                         req_uri),"},{"line_number":140,"context_line":"                                                  rel\u003dNone)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"                    metrics \u003d []"},{"line_number":143,"context_line":"                    alarm \u003d {u\u0027id\u0027: alarm_row.alarm_id, u\u0027metrics\u0027: metrics,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_d2218ffd","line":140,"in_reply_to":"5a890539_d2cc2f64","updated":"2014-11-12 18:31:12.000000000","message":"the existing api is wrong.\n\nself is for the alarm. roland and i discussed this and decided to remove rel from the alarm-definition.","commit_id":"830e0bea85124e40bb43c6541c1cb59c46d96e78"}]}