)]}'
{"monasca/v2/reference/alarm_definitions.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9f2b86919260bc106bd08ced0d686936dcf6521c","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        helpers.add_links_to_resource(result, req.uri)"},{"line_number":156,"context_line":"        res.body \u003d json.dumps(result, ensure_ascii\u003dFalse).encode(\u0027utf8\u0027)"},{"line_number":157,"context_line":"        res.status \u003d falcon.HTTP_201"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @resource_api.Restify(\u0027/v2.0/alarm-definitions\u0027, method\u003d\u0027get\u0027)"},{"line_number":160,"context_line":"    def do_get_alarm_definitions(self, req, res):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_f6fe86ad","line":157,"updated":"2014-12-09 18:06:29.000000000","message":"I\u0027m pretty sure this should be a 200 (OK) not 201 (Created)","commit_id":"8dd63535bd9bec8cf1cb0344de1886b89b838e5a"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"61faca7ba08b38c5165bc5d0a5d9d15823935253","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        helpers.add_links_to_resource(result, req.uri)"},{"line_number":156,"context_line":"        res.body \u003d json.dumps(result, ensure_ascii\u003dFalse).encode(\u0027utf8\u0027)"},{"line_number":157,"context_line":"        res.status \u003d falcon.HTTP_201"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    @resource_api.Restify(\u0027/v2.0/alarm-definitions\u0027, method\u003d\u0027get\u0027)"},{"line_number":160,"context_line":"    def do_get_alarm_definitions(self, req, res):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_1906e5ce","line":157,"in_reply_to":"3a961159_f6fe86ad","updated":"2014-12-09 18:26:44.000000000","message":"Done","commit_id":"8dd63535bd9bec8cf1cb0344de1886b89b838e5a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9f2b86919260bc106bd08ced0d686936dcf6521c","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        helpers.add_links_to_resource(result, req.uri)"},{"line_number":217,"context_line":"        res.body \u003d json.dumps(result, ensure_ascii\u003dFalse).encode(\u0027utf8\u0027)"},{"line_number":218,"context_line":"        res.status \u003d falcon.HTTP_201"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @resource_api.Restify(\u0027/v2.0/alarm-definitions/{id}\u0027, method\u003d\u0027delete\u0027)"},{"line_number":221,"context_line":"    def do_delete_alarm_definitions(self, req, res, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_762a962d","line":218,"updated":"2014-12-09 18:06:29.000000000","message":"200","commit_id":"8dd63535bd9bec8cf1cb0344de1886b89b838e5a"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"61faca7ba08b38c5165bc5d0a5d9d15823935253","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        helpers.add_links_to_resource(result, req.uri)"},{"line_number":217,"context_line":"        res.body \u003d json.dumps(result, ensure_ascii\u003dFalse).encode(\u0027utf8\u0027)"},{"line_number":218,"context_line":"        res.status \u003d falcon.HTTP_201"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    @resource_api.Restify(\u0027/v2.0/alarm-definitions/{id}\u0027, method\u003d\u0027delete\u0027)"},{"line_number":221,"context_line":"    def do_delete_alarm_definitions(self, req, res, id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_3909e1dd","line":218,"in_reply_to":"3a961159_762a962d","updated":"2014-12-09 18:26:44.000000000","message":"Done","commit_id":"8dd63535bd9bec8cf1cb0344de1886b89b838e5a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9f2b86919260bc106bd08ced0d686936dcf6521c","unresolved":false,"context_lines":[{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        return result"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def _build_sub_alarm_def_update_event(self, sub_alarm_def_dict):"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        sub_alarm_def_event_dict \u003d {}"},{"line_number":418,"context_line":"        for id, sub_alarm_def in sub_alarm_def_dict.items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_96262215","line":415,"updated":"2014-12-09 18:06:29.000000000","message":"This is not really an event, just part of an event. I would just take out the _event of the name","commit_id":"8dd63535bd9bec8cf1cb0344de1886b89b838e5a"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"61faca7ba08b38c5165bc5d0a5d9d15823935253","unresolved":false,"context_lines":[{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        return result"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def _build_sub_alarm_def_update_event(self, sub_alarm_def_dict):"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        sub_alarm_def_event_dict \u003d {}"},{"line_number":418,"context_line":"        for id, sub_alarm_def in sub_alarm_def_dict.items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_59106d01","line":415,"in_reply_to":"3a961159_96262215","updated":"2014-12-09 18:26:44.000000000","message":"Done","commit_id":"8dd63535bd9bec8cf1cb0344de1886b89b838e5a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9f2b86919260bc106bd08ced0d686936dcf6521c","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                        alarm_definition_created_event_msg)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"def get_query_alarm_definition_name(alarm_definition, return_none\u003dFalse):"},{"line_number":553,"context_line":"    try:"},{"line_number":554,"context_line":"        if \u0027name\u0027 in alarm_definition:"},{"line_number":555,"context_line":"            name \u003d alarm_definition[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_56e83ab4","line":552,"updated":"2014-12-09 18:06:29.000000000","message":"Looks like there are two variations on these that could be done by helper methods. The only complications are the severity validation and actions_enabled extra handling\n\nThat would make this code simpler","commit_id":"8dd63535bd9bec8cf1cb0344de1886b89b838e5a"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"61faca7ba08b38c5165bc5d0a5d9d15823935253","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                        alarm_definition_created_event_msg)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"def get_query_alarm_definition_name(alarm_definition, return_none\u003dFalse):"},{"line_number":553,"context_line":"    try:"},{"line_number":554,"context_line":"        if \u0027name\u0027 in alarm_definition:"},{"line_number":555,"context_line":"            name \u003d alarm_definition[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_b96dd19b","line":552,"in_reply_to":"3a961159_56e83ab4","updated":"2014-12-09 18:26:44.000000000","message":"Agreed that there could be some cleanup/rafactoring here, but I don\u0027t want to do it at this juncture.","commit_id":"8dd63535bd9bec8cf1cb0344de1886b89b838e5a"}]}
