)]}'
{"etc/monasca.ini":[{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"059936b3d3cc5670872d2ce77a8c593013fa211c","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[pipeline:main]"},{"line_number":5,"context_line":"# Add validator in the pipeline so the metrics messages can be validated."},{"line_number":6,"context_line":"pipeline \u003d auth keystonecontext api"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[app:api]"},{"line_number":9,"context_line":"paste.app_factory \u003d monasca.api.server:api_app"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3a961159_c084aeb3","line":6,"updated":"2014-12-15 19:03:03.000000000","message":"I think it may be better just to add commented examples to enable keystone middleware such as this\n\n# use keystone authenticatation, use pipe line like this line.\n# pipeline \u003d keystonecontext api","commit_id":"bae5a92b166f7bacd3aec499d32046c7d59e6461"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"c283ad2a37b1c3d92f9c76b83a1163d555dc374d","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[pipeline:main]"},{"line_number":5,"context_line":"# Add validator in the pipeline so the metrics messages can be validated."},{"line_number":6,"context_line":"pipeline \u003d auth keystonecontext api"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[app:api]"},{"line_number":9,"context_line":"paste.app_factory \u003d monasca.api.server:api_app"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3a961159_61dcdc47","line":6,"in_reply_to":"3a961159_c084aeb3","updated":"2014-12-15 20:16:46.000000000","message":"I don\u0027t think so... We currently have no authentication, just the mock. So, shouldn\u0027t the default auth mode really be an auth process?","commit_id":"bae5a92b166f7bacd3aec499d32046c7d59e6461"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"ad083122714e3903a22e910d9114339b0afb0bcf","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[pipeline:main]"},{"line_number":5,"context_line":"# Add validator in the pipeline so the metrics messages can be validated."},{"line_number":6,"context_line":"pipeline \u003d auth keystonecontext api"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[app:api]"},{"line_number":9,"context_line":"paste.app_factory \u003d monasca.api.server:api_app"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a961159_a51ea672","line":6,"updated":"2015-01-20 15:28:35.000000000","message":"Should this be snake case?","commit_id":"cf7ee05da3c67328ccfe205b45fcfe2dd4fde165"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"a56c3f90271b1f58109957b5def61a9ad3c87bb0","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[pipeline:main]"},{"line_number":5,"context_line":"# Add validator in the pipeline so the metrics messages can be validated."},{"line_number":6,"context_line":"pipeline \u003d auth keystonecontext api"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[app:api]"},{"line_number":9,"context_line":"paste.app_factory \u003d monasca.api.server:api_app"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a961159_1c398fa3","line":6,"in_reply_to":"3a961159_a51ea672","updated":"2015-01-20 17:28:44.000000000","message":"Ok. Will change it in my next patch.","commit_id":"cf7ee05da3c67328ccfe205b45fcfe2dd4fde165"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"ad083122714e3903a22e910d9114339b0afb0bcf","unresolved":false,"context_lines":[{"line_number":18,"context_line":"use \u003d egg: monasca_api#metric_validator"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[filter:auth]"},{"line_number":21,"context_line":"paste.filter_factory \u003d keystonemiddleware.auth_token:filter_factory"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[filter:keystonecontext]"},{"line_number":24,"context_line":"paste.filter_factory \u003d monasca.middleware.auth:MonascaKeystoneContext.factory"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a961159_6884950b","line":21,"updated":"2015-01-20 15:28:35.000000000","message":"Snake case?","commit_id":"cf7ee05da3c67328ccfe205b45fcfe2dd4fde165"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"a56c3f90271b1f58109957b5def61a9ad3c87bb0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"use \u003d egg: monasca_api#metric_validator"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[filter:auth]"},{"line_number":21,"context_line":"paste.filter_factory \u003d keystonemiddleware.auth_token:filter_factory"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[filter:keystonecontext]"},{"line_number":24,"context_line":"paste.filter_factory \u003d monasca.middleware.auth:MonascaKeystoneContext.factory"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a961159_5c5a37f3","line":21,"in_reply_to":"3a961159_6884950b","updated":"2015-01-20 17:28:44.000000000","message":"If you\u0027re talking about \u0027keystonemiddleware\u0027, it\u0027s the name of the library, so, we can\u0027t change it.","commit_id":"cf7ee05da3c67328ccfe205b45fcfe2dd4fde165"}],"monasca/middleware/auth.py":[{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"059936b3d3cc5670872d2ce77a8c593013fa211c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\r"},{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations\r"},{"line_number":13,"context_line":"#    under the License.\r"},{"line_number":14,"context_line":"\"\"\"\r"},{"line_number":15,"context_line":"Auth Middleware Module.\r"},{"line_number":16,"context_line":"\r"},{"line_number":17,"context_line":"\"\"\"\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_606cda09","line":14,"updated":"2014-12-15 19:03:03.000000000","message":"not sure what editor you are using. maybe windows based editor.\nnot sure why it showed like that. I use eclipse, it worked quite well.","commit_id":"bae5a92b166f7bacd3aec499d32046c7d59e6461"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"c283ad2a37b1c3d92f9c76b83a1163d555dc374d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\r"},{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations\r"},{"line_number":13,"context_line":"#    under the License.\r"},{"line_number":14,"context_line":"\"\"\"\r"},{"line_number":15,"context_line":"Auth Middleware Module.\r"},{"line_number":16,"context_line":"\r"},{"line_number":17,"context_line":"\"\"\"\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_a1c24484","line":14,"in_reply_to":"3a961159_606cda09","updated":"2014-12-15 20:16:46.000000000","message":"IDK why it\u0027s like this... But I\u0027ll also check it in the next one.","commit_id":"bae5a92b166f7bacd3aec499d32046c7d59e6461"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"059936b3d3cc5670872d2ce77a8c593013fa211c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.context \u003d context\r"},{"line_number":35,"context_line":"        super(InjectContext, self).__init__(*args, **kwargs)\r"},{"line_number":36,"context_line":"\r"},{"line_number":37,"context_line":"    @webob.dec.wsgify(RequestClass\u003dwsgi.Request)\r"},{"line_number":38,"context_line":"    def __call__(self, req):\r"},{"line_number":39,"context_line":"        req.environ[\u0027monasca.context\u0027] \u003d self.context\r"},{"line_number":40,"context_line":"        return self.application\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_2049f28e","line":37,"updated":"2014-12-15 19:03:03.000000000","message":"this will introduce webob as dependency. Not sure if that is a good idea though.","commit_id":"bae5a92b166f7bacd3aec499d32046c7d59e6461"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"c283ad2a37b1c3d92f9c76b83a1163d555dc374d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.context \u003d context\r"},{"line_number":35,"context_line":"        super(InjectContext, self).__init__(*args, **kwargs)\r"},{"line_number":36,"context_line":"\r"},{"line_number":37,"context_line":"    @webob.dec.wsgify(RequestClass\u003dwsgi.Request)\r"},{"line_number":38,"context_line":"    def __call__(self, req):\r"},{"line_number":39,"context_line":"        req.environ[\u0027monasca.context\u0027] \u003d self.context\r"},{"line_number":40,"context_line":"        return self.application\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_e1bc4c09","line":37,"in_reply_to":"3a961159_2049f28e","updated":"2014-12-15 20:16:46.000000000","message":"why not? did we have some problem in Monasca with webob before?","commit_id":"bae5a92b166f7bacd3aec499d32046c7d59e6461"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"059936b3d3cc5670872d2ce77a8c593013fa211c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                                     user_auth_plugin\u003duser_auth_plugin)\r"},{"line_number":98,"context_line":"\r"},{"line_number":99,"context_line":"        req.environ[\u0027monasca.context\u0027] \u003d ctx\r"},{"line_number":100,"context_line":"        return self.application\r"},{"line_number":101,"context_line":"\r"},{"line_number":102,"context_line":"    def _get_roles(self, req):\r"},{"line_number":103,"context_line":"        \"\"\"Get the list of roles.\"\"\"\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_80162654","line":100,"updated":"2014-12-15 19:03:03.000000000","message":"I am not seeing anywhere that the token get verified. You do not\nwant this to actually do authentication and just to create a new \ncontext, right?","commit_id":"bae5a92b166f7bacd3aec499d32046c7d59e6461"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"c283ad2a37b1c3d92f9c76b83a1163d555dc374d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                                     user_auth_plugin\u003duser_auth_plugin)\r"},{"line_number":98,"context_line":"\r"},{"line_number":99,"context_line":"        req.environ[\u0027monasca.context\u0027] \u003d ctx\r"},{"line_number":100,"context_line":"        return self.application\r"},{"line_number":101,"context_line":"\r"},{"line_number":102,"context_line":"    def _get_roles(self, req):\r"},{"line_number":103,"context_line":"        \"\"\"Get the list of roles.\"\"\"\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_61577ccb","line":100,"in_reply_to":"3a961159_80162654","updated":"2014-12-15 20:16:46.000000000","message":"the token verification is made by keytonemiddleware. This is the called module where the process happens: https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token.py","commit_id":"bae5a92b166f7bacd3aec499d32046c7d59e6461"}],"requirements.txt":[{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"059936b3d3cc5670872d2ce77a8c593013fa211c","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"falcon\u003e\u003d0.1.9"},{"line_number":24,"context_line":"gunicorn\u003e\u003d19.1.0"},{"line_number":25,"context_line":"influxdb\u003e\u003d0.1.12"},{"line_number":26,"context_line":"keystonemiddleware"},{"line_number":27,"context_line":"MySQL-python"},{"line_number":28,"context_line":"oslo.config\u003e\u003d1.2.1"}],"source_content_type":"text/plain","patch_set":1,"id":"3a961159_3b2a037f","line":25,"updated":"2014-12-15 19:03:03.000000000","message":"your code is based on older code, I assume, you need to do a rebase first. these things have been moved to implementation specific requirement.txt.","commit_id":"bae5a92b166f7bacd3aec499d32046c7d59e6461"},{"author":{"_account_id":10046,"name":"Henrique Truta","email":"henrique@lsd.ufcg.edu.br","username":"henriquetruta"},"change_message_id":"c283ad2a37b1c3d92f9c76b83a1163d555dc374d","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"falcon\u003e\u003d0.1.9"},{"line_number":24,"context_line":"gunicorn\u003e\u003d19.1.0"},{"line_number":25,"context_line":"influxdb\u003e\u003d0.1.12"},{"line_number":26,"context_line":"keystonemiddleware"},{"line_number":27,"context_line":"MySQL-python"},{"line_number":28,"context_line":"oslo.config\u003e\u003d1.2.1"}],"source_content_type":"text/plain","patch_set":1,"id":"3a961159_61c93cac","line":25,"in_reply_to":"3a961159_3b2a037f","updated":"2014-12-15 20:16:46.000000000","message":"I\u0027ll check on that in my next patch.","commit_id":"bae5a92b166f7bacd3aec499d32046c7d59e6461"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"059936b3d3cc5670872d2ce77a8c593013fa211c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"falcon\u003e\u003d0.1.9"},{"line_number":24,"context_line":"gunicorn\u003e\u003d19.1.0"},{"line_number":25,"context_line":"influxdb\u003e\u003d0.1.12"},{"line_number":26,"context_line":"keystonemiddleware"},{"line_number":27,"context_line":"MySQL-python"},{"line_number":28,"context_line":"oslo.config\u003e\u003d1.2.1"},{"line_number":29,"context_line":"oslo.middleware"}],"source_content_type":"text/plain","patch_set":1,"id":"3a961159_1b7387b5","line":26,"updated":"2014-12-15 19:03:03.000000000","message":"I do not think you need this line.","commit_id":"bae5a92b166f7bacd3aec499d32046c7d59e6461"}]}