)]}'
{"monasca/common/repositories/influxdb/metrics_repository.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"a647e53ad797473cf6a7fbffc048ee8de494f096","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            if offset:"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"                offset_clause \u003d ("},{"line_number":417,"context_line":"                    (\u0027 and time \u003c {}s limit {}\u0027."},{"line_number":418,"context_line":"                     format(offset, str(constants.PAGE_LIMIT))))"},{"line_number":419,"context_line":"            else:"},{"line_number":420,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_3d0c823b","line":417,"updated":"2015-01-12 21:23:21.000000000","message":"I believe you don\u0027t need the ( on this line","commit_id":"482bf6b19a1fd04c426adf9f14b63311ad3fc719"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"3c4f9d0ef621c7db21a4c1b1967f53de2344805d","unresolved":false,"context_lines":[{"line_number":414,"context_line":"            if offset:"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"                offset_clause \u003d ("},{"line_number":417,"context_line":"                    (\u0027 and time \u003c {}s limit {}\u0027."},{"line_number":418,"context_line":"                     format(offset, str(constants.PAGE_LIMIT))))"},{"line_number":419,"context_line":"            else:"},{"line_number":420,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_fd4cba9f","line":417,"in_reply_to":"3a961159_3d0c823b","updated":"2015-01-12 21:43:43.000000000","message":"Done","commit_id":"482bf6b19a1fd04c426adf9f14b63311ad3fc719"}],"monasca/common/repositories/metrics_repository.py":[{"author":{"_account_id":12133,"name":"Cindy O\u0027Neill","email":"cindy.o-neill@hpe.com","username":"oneilcin"},"change_message_id":"d32c08199a52162ba069d3e8b6826e48abd608f2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @abc.abstractmethod"},{"line_number":37,"context_line":"    def alarm_history(self, tenant_id, alarm_id_list,"},{"line_number":38,"context_line":"                      offset, start_timestamp, end_timestamp):"},{"line_number":39,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_981ae46d","line":39,"updated":"2015-01-12 21:39:35.000000000","message":"Does the alarm_history abstract method belong here?  (This is the metrics_repository file I believe.)","commit_id":"482bf6b19a1fd04c426adf9f14b63311ad3fc719"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"3c4f9d0ef621c7db21a4c1b1967f53de2344805d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @abc.abstractmethod"},{"line_number":37,"context_line":"    def alarm_history(self, tenant_id, alarm_id_list,"},{"line_number":38,"context_line":"                      offset, start_timestamp, end_timestamp):"},{"line_number":39,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_18f19401","line":39,"in_reply_to":"3a961159_981ae46d","updated":"2015-01-12 21:43:43.000000000","message":"yeah, but the alarm history is in the influxdb. so... we put the code that access influxdb in the metrics_repository. i admit it is a bit confusing.","commit_id":"482bf6b19a1fd04c426adf9f14b63311ad3fc719"}],"monasca/v2/reference/alarms.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"a647e53ad797473cf6a7fbffc048ee8de494f096","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        helpers.validate_authorization(req, self._default_authorized_roles)"},{"line_number":97,"context_line":"        tenant_id \u003d helpers.get_tenant_id(req)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        query_parms \u003d falcon.uri.parse_query_string(req.query_string, )"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        offset \u003d helpers.normalize_offset(helpers.get_query_param(req,"},{"line_number":102,"context_line":"                                                                  \u0027offset\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_5d486e2e","line":99,"updated":"2015-01-12 21:23:21.000000000","message":"Extra comma","commit_id":"482bf6b19a1fd04c426adf9f14b63311ad3fc719"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"3c4f9d0ef621c7db21a4c1b1967f53de2344805d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        helpers.validate_authorization(req, self._default_authorized_roles)"},{"line_number":97,"context_line":"        tenant_id \u003d helpers.get_tenant_id(req)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        query_parms \u003d falcon.uri.parse_query_string(req.query_string, )"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        offset \u003d helpers.normalize_offset(helpers.get_query_param(req,"},{"line_number":102,"context_line":"                                                                  \u0027offset\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_7d58ca57","line":99,"in_reply_to":"3a961159_5d486e2e","updated":"2015-01-12 21:43:43.000000000","message":"Done","commit_id":"482bf6b19a1fd04c426adf9f14b63311ad3fc719"}],"monasca/v2/reference/helpers.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"a647e53ad797473cf6a7fbffc048ee8de494f096","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def normalize_offset(offset):"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    return u\u0027\u0027 if offset \u003d\u003d u\u0027x\u0027 else offset"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"def get_query_name(req, name_required\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_bdfdd2b3","line":136,"updated":"2015-01-12 21:23:21.000000000","message":"Why \u0027x\u0027?","commit_id":"482bf6b19a1fd04c426adf9f14b63311ad3fc719"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"3c4f9d0ef621c7db21a4c1b1967f53de2344805d","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def normalize_offset(offset):"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    return u\u0027\u0027 if offset \u003d\u003d u\u0027x\u0027 else offset"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"def get_query_name(req, name_required\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_780d3835","line":136,"in_reply_to":"3a961159_bdfdd2b3","updated":"2015-01-12 21:43:43.000000000","message":"Without a value for the query parameter, the python library will not pass the name on. With java, we could have a query parm \u0027offset\u003d\u0027 and the query parm name \u0027offset\u0027 would come thru with a value of null. Some way was needed to indicate an unknown offset. \u0027x\u0027 seemed like a good choice. When we make paging mandatory, the \u0027x\u0027 will go away.","commit_id":"482bf6b19a1fd04c426adf9f14b63311ad3fc719"}],"monasca/v2/reference/metrics.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"a647e53ad797473cf6a7fbffc048ee8de494f096","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                                                         end_timestamp,"},{"line_number":129,"context_line":"                                                         offset)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"            paginated_result \u003d []"},{"line_number":132,"context_line":"            for measurement in result:"},{"line_number":133,"context_line":"                paginated_result.append("},{"line_number":134,"context_line":"                    helpers.paginate_measurement(measurement, req_uri, offset))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_bd707241","line":131,"updated":"2015-01-12 21:23:21.000000000","message":"This piece of code seems to be changing the format of the returned json even if offset isn\u0027t given","commit_id":"482bf6b19a1fd04c426adf9f14b63311ad3fc719"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"3c4f9d0ef621c7db21a4c1b1967f53de2344805d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                                                         end_timestamp,"},{"line_number":129,"context_line":"                                                         offset)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"            paginated_result \u003d []"},{"line_number":132,"context_line":"            for measurement in result:"},{"line_number":133,"context_line":"                paginated_result.append("},{"line_number":134,"context_line":"                    helpers.paginate_measurement(measurement, req_uri, offset))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_18a35401","line":131,"in_reply_to":"3a961159_bd707241","updated":"2015-01-12 21:43:43.000000000","message":"Indeed. Fixed.","commit_id":"482bf6b19a1fd04c426adf9f14b63311ad3fc719"}]}
