)]}'
{"docs/monasca-api-spec.md":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"a9d50d603572012e92abf69a565a676bda4adbe2","unresolved":false,"context_lines":[{"line_number":462,"context_line":"\t| \u0027(\u0027 expression \u0027)\u0027     "},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"````"},{"line_number":465,"context_line":"Period must an integer multiple of 60.  The default period is 60 seconds."},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"The logical_operators are: `and` (also `\u0026\u0026`), `or` (also `||`)."},{"line_number":468,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":1,"id":"3a961159_6ea1cf94","line":465,"updated":"2015-01-13 18:59:12.000000000","message":"missing \"be\"?","commit_id":"055b4338e0125ae4878942a80b265912e7647f52"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"f2e3deaa9c30103752fd256b3cf40a86647e58fc","unresolved":false,"context_lines":[{"line_number":462,"context_line":"\t| \u0027(\u0027 expression \u0027)\u0027     "},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"````"},{"line_number":465,"context_line":"Period must an integer multiple of 60.  The default period is 60 seconds."},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"The logical_operators are: `and` (also `\u0026\u0026`), `or` (also `||`)."},{"line_number":468,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":1,"id":"3a961159_11978aec","line":465,"in_reply_to":"3a961159_6ea1cf94","updated":"2015-01-13 19:42:07.000000000","message":"Done","commit_id":"055b4338e0125ae4878942a80b265912e7647f52"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"a9d50d603572012e92abf69a565a676bda4adbe2","unresolved":false,"context_lines":[{"line_number":552,"context_line":""},{"line_number":553,"context_line":"### Changing Alarm Definitions"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"Once an Alarm Definition has been created, the value for match_by and any metrics in the expression cannot be changed. This is because those fields control the metrics used to create Alarms and Alarms may already have been created. The function, operator, period, periods and any boolean operators can change, but not the metrics in subexpressions or of the number sub expressions.  All other fields in an Alarm Definition can be changed."},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"The only option to change metrics or match_by is to delete the existing Alarm Definition and create a new one. Deleting an Alarm Definition will delete all Alarms associated with it."},{"line_number":558,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":1,"id":"3a961159_6ecf0f58","line":555,"updated":"2015-01-13 18:59:12.000000000","message":"\"or of the number\"?","commit_id":"055b4338e0125ae4878942a80b265912e7647f52"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"f2e3deaa9c30103752fd256b3cf40a86647e58fc","unresolved":false,"context_lines":[{"line_number":552,"context_line":""},{"line_number":553,"context_line":"### Changing Alarm Definitions"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"Once an Alarm Definition has been created, the value for match_by and any metrics in the expression cannot be changed. This is because those fields control the metrics used to create Alarms and Alarms may already have been created. The function, operator, period, periods and any boolean operators can change, but not the metrics in subexpressions or of the number sub expressions.  All other fields in an Alarm Definition can be changed."},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"The only option to change metrics or match_by is to delete the existing Alarm Definition and create a new one. Deleting an Alarm Definition will delete all Alarms associated with it."},{"line_number":558,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":1,"id":"3a961159_51a11245","line":555,"in_reply_to":"3a961159_6ecf0f58","updated":"2015-01-13 19:42:07.000000000","message":"Done","commit_id":"055b4338e0125ae4878942a80b265912e7647f52"}],"src/main/java/monasca/api/app/AlarmDefinitionService.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"d26149022f2ff1dfc667dd74bf6ff132a2fcf0ba","unresolved":false,"context_lines":[{"line_number":218,"context_line":"      }"},{"line_number":219,"context_line":"      else {"},{"line_number":220,"context_line":"        throw monasca.api.resource.exception.Exceptions.unprocessableEntity(\"metrics in subexpression must not change\");"},{"line_number":221,"context_line":"      }"},{"line_number":222,"context_line":"    }"},{"line_number":223,"context_line":"  }"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"3a961159_68c7fc65","line":221,"updated":"2015-01-13 23:35:17.000000000","message":"How does this check if the subexpressions are different. It looks like match_by and the number of subexpressions is checks, but if doesn\u0027t seem to check if the subexpressions are the same.","commit_id":"493267eff16b4690decba43d86ddf61e323efc12"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"a9584605d371ed096950b068fc2ee42cf5b51cf5","unresolved":false,"context_lines":[{"line_number":218,"context_line":"      }"},{"line_number":219,"context_line":"      else {"},{"line_number":220,"context_line":"        throw monasca.api.resource.exception.Exceptions.unprocessableEntity(\"metrics in subexpression must not change\");"},{"line_number":221,"context_line":"      }"},{"line_number":222,"context_line":"    }"},{"line_number":223,"context_line":"  }"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"3a961159_998e3878","line":221,"in_reply_to":"3a961159_68c7fc65","updated":"2015-01-14 01:10:36.000000000","message":"The calculations of what subexpressions have changed is really in subExpressionsFor(). This code just uses the result from subExpressionsFor() which is subExpressions to do the final validation","commit_id":"493267eff16b4690decba43d86ddf61e323efc12"}]}