)]}'
{"monasca/v2/reference/alarm_definitions.py":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"eab9969a665e61aabd3b09018d65d7a1fd4129be","unresolved":false,"context_lines":[{"line_number":483,"context_line":"        result \u003d ("},{"line_number":484,"context_line":"            {u\u0027alarm_actions\u0027: alarm_actions, u\u0027ok_actions\u0027: ok_actions,"},{"line_number":485,"context_line":"             u\u0027description\u0027: description, u\u0027match_by\u0027: match_by,"},{"line_number":486,"context_line":"             u\u0027severity\u0027: severity, u\u0027actions_enabled\u0027: u\u0027true\u0027,"},{"line_number":487,"context_line":"             u\u0027undetermined_actions\u0027: undetermined_actions,"},{"line_number":488,"context_line":"             u\u0027expression\u0027: expression, u\u0027id\u0027: alarm_definition_id,"},{"line_number":489,"context_line":"             u\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_431e50bc","line":486,"updated":"2015-02-04 21:45:18.000000000","message":"should we do \u0027severity.upper()\u0027 to ensure uppercase and document that it is always upper?","commit_id":"3ad8d26c1fcd2b923a1860870038ad40c8495a01"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"2397fd314a2f0e0d59ee2e964f084f69c137cbaf","unresolved":false,"context_lines":[{"line_number":483,"context_line":"        result \u003d ("},{"line_number":484,"context_line":"            {u\u0027alarm_actions\u0027: alarm_actions, u\u0027ok_actions\u0027: ok_actions,"},{"line_number":485,"context_line":"             u\u0027description\u0027: description, u\u0027match_by\u0027: match_by,"},{"line_number":486,"context_line":"             u\u0027severity\u0027: severity, u\u0027actions_enabled\u0027: u\u0027true\u0027,"},{"line_number":487,"context_line":"             u\u0027undetermined_actions\u0027: undetermined_actions,"},{"line_number":488,"context_line":"             u\u0027expression\u0027: expression, u\u0027id\u0027: alarm_definition_id,"},{"line_number":489,"context_line":"             u\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_e37024de","line":486,"in_reply_to":"da86d52c_431e50bc","updated":"2015-02-04 21:48:36.000000000","message":"I do the upper before inserting it into the database, but it wouldn\u0027t hurt to do it again. I\u0027ll add it in.\n\nIt is already documented that it returns upper case","commit_id":"3ad8d26c1fcd2b923a1860870038ad40c8495a01"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3eebee09c37c2925f95f9ff448d9e7edcda415f7","unresolved":false,"context_lines":[{"line_number":483,"context_line":"        result \u003d ("},{"line_number":484,"context_line":"            {u\u0027alarm_actions\u0027: alarm_actions, u\u0027ok_actions\u0027: ok_actions,"},{"line_number":485,"context_line":"             u\u0027description\u0027: description, u\u0027match_by\u0027: match_by,"},{"line_number":486,"context_line":"             u\u0027severity\u0027: severity, u\u0027actions_enabled\u0027: u\u0027true\u0027,"},{"line_number":487,"context_line":"             u\u0027undetermined_actions\u0027: undetermined_actions,"},{"line_number":488,"context_line":"             u\u0027expression\u0027: expression, u\u0027id\u0027: alarm_definition_id,"},{"line_number":489,"context_line":"             u\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_06b1c646","line":486,"in_reply_to":"da86d52c_e37024de","updated":"2015-02-04 21:54:27.000000000","message":"Actually, it is guaranteed to be upper case at this point because get_query_alarm_definition_severity() does the upper()\n\nBut, I think I will add the upper() on the return from the database","commit_id":"3ad8d26c1fcd2b923a1860870038ad40c8495a01"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"821fc95fc8c167ede86c3d9bdad95e538bc7f652","unresolved":false,"context_lines":[{"line_number":484,"context_line":"        result \u003d ("},{"line_number":485,"context_line":"            {u\u0027alarm_actions\u0027: alarm_actions, u\u0027ok_actions\u0027: ok_actions,"},{"line_number":486,"context_line":"             u\u0027description\u0027: description, u\u0027match_by\u0027: match_by,"},{"line_number":487,"context_line":"             u\u0027severity\u0027: severity, u\u0027actions_enabled\u0027: u\u0027true\u0027,"},{"line_number":488,"context_line":"             u\u0027undetermined_actions\u0027: undetermined_actions,"},{"line_number":489,"context_line":"             u\u0027expression\u0027: expression, u\u0027id\u0027: alarm_definition_id,"},{"line_number":490,"context_line":"             u\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_a4f1ae6c","line":487,"updated":"2015-02-05 18:10:24.000000000","message":"does this severity need an upper()?","commit_id":"8605a39e6c6aa47b753c6a98874bbe98623600c0"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"607799d1d0a1881a9fecc888ae397747f493e34c","unresolved":false,"context_lines":[{"line_number":484,"context_line":"        result \u003d ("},{"line_number":485,"context_line":"            {u\u0027alarm_actions\u0027: alarm_actions, u\u0027ok_actions\u0027: ok_actions,"},{"line_number":486,"context_line":"             u\u0027description\u0027: description, u\u0027match_by\u0027: match_by,"},{"line_number":487,"context_line":"             u\u0027severity\u0027: severity, u\u0027actions_enabled\u0027: u\u0027true\u0027,"},{"line_number":488,"context_line":"             u\u0027undetermined_actions\u0027: undetermined_actions,"},{"line_number":489,"context_line":"             u\u0027expression\u0027: expression, u\u0027id\u0027: alarm_definition_id,"},{"line_number":490,"context_line":"             u\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_24285e99","line":487,"in_reply_to":"da86d52c_a4f1ae6c","updated":"2015-02-05 18:14:31.000000000","message":"No. _alarm_definition_create is called from do_post_alarm_definitions() which gets the severity from get_query_alarm_definition_severity() which does the upper()","commit_id":"8605a39e6c6aa47b753c6a98874bbe98623600c0"}]}