)]}'
{"docs/monasca-api-spec.md":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"bae4cd1143d85e2b0331a5e02057f1692ad419a8","unresolved":false,"context_lines":[{"line_number":922,"context_line":"```"},{"line_number":923,"context_line":"___"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"# Metric Names"},{"line_number":926,"context_line":"Operations for accessing names of metrics."},{"line_number":927,"context_line":""},{"line_number":928,"context_line":"## List names"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba7be1f8_e56a9180","line":925,"updated":"2015-02-26 23:36:13.000000000","message":"You also need to update the table of contents. I installed doctoc on my mini-mon and ran it through. https://github.com/thlorenz/doctoc#installation\n\nYou have to change the first line of /usr/local/bin/doctoc to use nodejs not node","commit_id":"7fe5df2e1b6aeeee05381d55ebcc0580e3dcb2f3"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"4d3148b1bbc7716e9a86e2a20901347d6f0dfc5d","unresolved":false,"context_lines":[{"line_number":922,"context_line":"```"},{"line_number":923,"context_line":"___"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"# Metric Names"},{"line_number":926,"context_line":"Operations for accessing names of metrics."},{"line_number":927,"context_line":""},{"line_number":928,"context_line":"## List names"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba7be1f8_562bee2f","line":925,"in_reply_to":"ba7be1f8_e56a9180","updated":"2015-02-27 16:30:26.000000000","message":"Done","commit_id":"7fe5df2e1b6aeeee05381d55ebcc0580e3dcb2f3"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"2e1b2d218b34276e8b9fdbc80c3c29d5a997e7cf","unresolved":false,"context_lines":[{"line_number":938,"context_line":"None."},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"#### Query Parameters"},{"line_number":941,"context_line":"* name (string(255), optional) - A metric name to filter metrics by."},{"line_number":942,"context_line":"* dimensions (string, optional) - A dictionary to filter metrics by specified as a comma separated array of (key, value) pairs as `key1:value1,key2:value2, ...`"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"#### Request Body"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba7be1f8_7e57f526","line":941,"updated":"2015-02-27 13:43:42.000000000","message":"Not sure that name should be a query parameter or part of the resource, as in \n\nGET /v2.0/metrics/names/{name}?dimensions\n\nI think it should be the latter though.\n\nIf you supply a nem dont\u0027 you just get one metric back though. Isn\u0027t \"name\" as a query parameter pretty useless?\n\nHowever, I didn\u0027t think we were going to add query parameters to this right now as in just give me all the names.","commit_id":"7fe5df2e1b6aeeee05381d55ebcc0580e3dcb2f3"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"4d3148b1bbc7716e9a86e2a20901347d6f0dfc5d","unresolved":false,"context_lines":[{"line_number":938,"context_line":"None."},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"#### Query Parameters"},{"line_number":941,"context_line":"* name (string(255), optional) - A metric name to filter metrics by."},{"line_number":942,"context_line":"* dimensions (string, optional) - A dictionary to filter metrics by specified as a comma separated array of (key, value) pairs as `key1:value1,key2:value2, ...`"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"#### Request Body"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba7be1f8_f5ce9bb3","line":941,"in_reply_to":"ba7be1f8_7e57f526","updated":"2015-02-27 16:30:26.000000000","message":"The thought was to allow filtering by dimensions, but the system currently requires a name if dimensions are present. Additionally, influx would support regular expressions for the name parameter, if our api allowed it, which could be very useful. I\u0027m planning on looking into both of these afterwards.","commit_id":"7fe5df2e1b6aeeee05381d55ebcc0580e3dcb2f3"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"74c2b4547aad41b45a15e2cfe7d1f58d8294b49f","unresolved":false,"context_lines":[{"line_number":938,"context_line":"None."},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"#### Query Parameters"},{"line_number":941,"context_line":"* name (string(255), optional) - A metric name to filter metrics by."},{"line_number":942,"context_line":"* dimensions (string, optional) - A dictionary to filter metrics by specified as a comma separated array of (key, value) pairs as `key1:value1,key2:value2, ...`"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"#### Request Body"}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba7be1f8_0ba3f69e","line":941,"in_reply_to":"ba7be1f8_f5ce9bb3","updated":"2015-02-28 14:37:38.000000000","message":"I think filtering by dimensions is useful.\n\nI\u0027m not sure the query \n\nGET /v2.0/metrics/names/{name} is useful\n\nAll we are doing is returning an array of names in the JSON response, so if the name exists in thiscase, you would get an array back with one element in it. \n\nI could see how regex on names is useful, as in give me all the metric names that match \"cpu.*\". That would be modeled as a query filter parameter.","commit_id":"7fe5df2e1b6aeeee05381d55ebcc0580e3dcb2f3"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"2e1b2d218b34276e8b9fdbc80c3c29d5a997e7cf","unresolved":false,"context_lines":[{"line_number":939,"context_line":""},{"line_number":940,"context_line":"#### Query Parameters"},{"line_number":941,"context_line":"* name (string(255), optional) - A metric name to filter metrics by."},{"line_number":942,"context_line":"* dimensions (string, optional) - A dictionary to filter metrics by specified as a comma separated array of (key, value) pairs as `key1:value1,key2:value2, ...`"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"#### Request Body"},{"line_number":945,"context_line":"None."}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba7be1f8_393917d9","line":942,"updated":"2015-02-27 13:43:42.000000000","message":"Looking at how we describe this elsewhere in the document we use the following description.\n\ndimensions ({string(255): string(255)}, optional) - A dictionary consisting of (key, value) pairs used to uniquely identify a metric.\n\nI think we should use something that is consistent a well as define the max length.","commit_id":"7fe5df2e1b6aeeee05381d55ebcc0580e3dcb2f3"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"4d3148b1bbc7716e9a86e2a20901347d6f0dfc5d","unresolved":false,"context_lines":[{"line_number":939,"context_line":""},{"line_number":940,"context_line":"#### Query Parameters"},{"line_number":941,"context_line":"* name (string(255), optional) - A metric name to filter metrics by."},{"line_number":942,"context_line":"* dimensions (string, optional) - A dictionary to filter metrics by specified as a comma separated array of (key, value) pairs as `key1:value1,key2:value2, ...`"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"#### Request Body"},{"line_number":945,"context_line":"None."}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba7be1f8_f00dc938","line":942,"in_reply_to":"ba7be1f8_393917d9","updated":"2015-02-27 16:30:26.000000000","message":"The request body descriptions use that, but I can only find one instance of that format in the query parameters. Should they all change to that format?","commit_id":"7fe5df2e1b6aeeee05381d55ebcc0580e3dcb2f3"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"74c2b4547aad41b45a15e2cfe7d1f58d8294b49f","unresolved":false,"context_lines":[{"line_number":939,"context_line":""},{"line_number":940,"context_line":"#### Query Parameters"},{"line_number":941,"context_line":"* name (string(255), optional) - A metric name to filter metrics by."},{"line_number":942,"context_line":"* dimensions (string, optional) - A dictionary to filter metrics by specified as a comma separated array of (key, value) pairs as `key1:value1,key2:value2, ...`"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"#### Request Body"},{"line_number":945,"context_line":"None."}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba7be1f8_6ba8f277","line":942,"in_reply_to":"ba7be1f8_f00dc938","updated":"2015-02-28 14:37:38.000000000","message":"I think consistency is good, so we should probably match the existing description, unless you think your description is better, in which case we should modify the old one too.","commit_id":"7fe5df2e1b6aeeee05381d55ebcc0580e3dcb2f3"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"2e1b2d218b34276e8b9fdbc80c3c29d5a997e7cf","unresolved":false,"context_lines":[{"line_number":971,"context_line":"   {"},{"line_number":972,"context_line":"      \"name\":\"name2\""},{"line_number":973,"context_line":"   }"},{"line_number":974,"context_line":"]"},{"line_number":975,"context_line":"```"},{"line_number":976,"context_line":"___"},{"line_number":977,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba7be1f8_19aa93d4","line":974,"updated":"2015-02-27 13:43:42.000000000","message":"Response body should be\n\n{\n    \"elements\" : [{names}],\n    \"links\": []\n}","commit_id":"7fe5df2e1b6aeeee05381d55ebcc0580e3dcb2f3"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"4d3148b1bbc7716e9a86e2a20901347d6f0dfc5d","unresolved":false,"context_lines":[{"line_number":971,"context_line":"   {"},{"line_number":972,"context_line":"      \"name\":\"name2\""},{"line_number":973,"context_line":"   }"},{"line_number":974,"context_line":"]"},{"line_number":975,"context_line":"```"},{"line_number":976,"context_line":"___"},{"line_number":977,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba7be1f8_76955287","line":974,"in_reply_to":"ba7be1f8_19aa93d4","updated":"2015-02-27 16:30:26.000000000","message":"This response body will only appear if the \"offset\" query parameter is present. I didn\u0027t add it since the other response bodies do not reflect this (ex. the list metrics response body)","commit_id":"7fe5df2e1b6aeeee05381d55ebcc0580e3dcb2f3"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"74c2b4547aad41b45a15e2cfe7d1f58d8294b49f","unresolved":false,"context_lines":[{"line_number":971,"context_line":"   {"},{"line_number":972,"context_line":"      \"name\":\"name2\""},{"line_number":973,"context_line":"   }"},{"line_number":974,"context_line":"]"},{"line_number":975,"context_line":"```"},{"line_number":976,"context_line":"___"},{"line_number":977,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":4,"id":"ba7be1f8_8bb606db","line":974,"in_reply_to":"ba7be1f8_76955287","updated":"2015-02-28 14:37:38.000000000","message":"Yeah, we need to get all our documentation updated to show the optional \"links\" in the response objects at some point.","commit_id":"7fe5df2e1b6aeeee05381d55ebcc0580e3dcb2f3"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9d9adad4aba0e9ed45f7b1c67837ee310e43f218","unresolved":false,"context_lines":[{"line_number":1028,"context_line":"* 200 - OK"},{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"#### Response Body"},{"line_number":1031,"context_line":"Returns a JSON array of metric name objects for each unique metric name (not including dimensions) with the following fields:"},{"line_number":1032,"context_line":""},{"line_number":1033,"context_line":"* name (string(255)) - A name of a metric."},{"line_number":1034,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":8,"id":"1a6ced46_a1e22e9d","line":1031,"updated":"2015-03-23 15:43:09.000000000","message":"Actually this returns a JSON object that contains a JSON Array","commit_id":"da757bdeb88e07693d93e3d01ce5fb2920a1e996"}],"java/src/main/java/monasca/api/domain/model/metric/MetricDefinitionRepo.java":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"2e5d170e0326513a23e71a9449012fd0849cb77f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                              String offset)"},{"line_number":31,"context_line":"      throws Exception;"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  List\u003cMetricName\u003e listNames(String tenantId, String offset) throws Exception;"},{"line_number":34,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":3,"id":"ba7be1f8_3f3da28f","line":33,"updated":"2015-02-26 18:28:11.000000000","message":"Probably should name this \u0027findNames\u0027 to be consistent. Also, we may be passed partial names or regexes and \u0027findNames\u0027 would be more apt.","commit_id":"5ef62d07d4d0a0c1d679281a0305149f91586d2b"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"cc6b2b93e00a72eab52ec22b7e9f18c567a08c18","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                              String offset)"},{"line_number":31,"context_line":"      throws Exception;"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  List\u003cMetricName\u003e listNames(String tenantId, String offset) throws Exception;"},{"line_number":34,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":3,"id":"ba7be1f8_d19d5668","line":33,"in_reply_to":"ba7be1f8_3f3da28f","updated":"2015-02-26 20:41:22.000000000","message":"Yes, that sounds better. The resource doesn\u0027t actually accept name or dimension filtering right now. Should that be included?","commit_id":"5ef62d07d4d0a0c1d679281a0305149f91586d2b"}],"java/src/main/java/monasca/api/domain/model/metric/MetricName.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"29bf3823e81dfc87eeb05f4b3a095f0cb41898e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"package monasca.api.domain.model.metric;"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import com.codahale.metrics.Metric;"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-java","patch_set":5,"id":"ba7be1f8_fb6d2533","line":1,"updated":"2015-03-03 18:22:07.000000000","message":"You must add the copyright","commit_id":"fccc15dc764f2e1c29a7e5aa7234a991bc4e0085"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"29bf3823e81dfc87eeb05f4b3a095f0cb41898e2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  @Override"},{"line_number":64,"context_line":"  public int compareTo(Object o) {"},{"line_number":65,"context_line":"    MetricName other \u003d (MetricName) o;"},{"line_number":66,"context_line":"    if(this.equals(other))"},{"line_number":67,"context_line":"      return 0;"},{"line_number":68,"context_line":"    return this.name.compareTo(other.name);"},{"line_number":69,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":5,"id":"ba7be1f8_dbd301d3","line":66,"updated":"2015-03-03 18:22:07.000000000","message":"This is not the correct formatting","commit_id":"fccc15dc764f2e1c29a7e5aa7234a991bc4e0085"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9d9adad4aba0e9ed45f7b1c67837ee310e43f218","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"public class MetricName extends AbstractEntity implements Comparable {"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  public String id;"},{"line_number":23,"context_line":"  public String name;"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  public MetricName(String id, String name) {"}],"source_content_type":"text/x-java","patch_set":8,"id":"1a6ced46_c163aa18","line":22,"updated":"2015-03-23 15:43:09.000000000","message":"Since you have getters and setters, these should be private","commit_id":"da757bdeb88e07693d93e3d01ce5fb2920a1e996"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"813bd2b0ad2400c3e92b3d48497969da191fedcd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except"},{"line_number":5,"context_line":" * in compliance with the License. You may obtain a copy of the License at"}],"source_content_type":"text/x-java","patch_set":9,"id":"1a6ced46_d7817a90","line":2,"updated":"2015-03-24 14:51:48.000000000","message":"2015","commit_id":"a3fb43984729e4dd8ecf8bd7793066b34f60a146"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"b2608e5974abe06966a779639ba403b628e54fa0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except"},{"line_number":5,"context_line":" * in compliance with the License. You may obtain a copy of the License at"}],"source_content_type":"text/x-java","patch_set":9,"id":"1a6ced46_952455b0","line":2,"in_reply_to":"1a6ced46_d7817a90","updated":"2015-03-24 16:55:04.000000000","message":"Done","commit_id":"a3fb43984729e4dd8ecf8bd7793066b34f60a146"}],"java/src/main/java/monasca/api/infrastructure/persistence/influxdb/InfluxV8MetricDefinitionRepo.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"17aa6d27bcfb3f0b56429a25514ad6bff680f74f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import org.slf4j.Logger;"},{"line_number":21,"context_line":"import org.slf4j.LoggerFactory;"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import java.util.*;"},{"line_number":24,"context_line":"import java.util.concurrent.TimeUnit;"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import monasca.api.ApiConfig;"}],"source_content_type":"text/x-java","patch_set":1,"id":"ba7be1f8_a6e46aac","line":23,"updated":"2015-02-25 16:21:53.000000000","message":"Coding standards say never do a import with a *","commit_id":"05ce9f197338cff51718e5e101bc4d5b73603b0d"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"edcb9564c66abfd128f5e9f80e2ad95490520c47","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import org.slf4j.Logger;"},{"line_number":21,"context_line":"import org.slf4j.LoggerFactory;"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import java.util.*;"},{"line_number":24,"context_line":"import java.util.concurrent.TimeUnit;"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import monasca.api.ApiConfig;"}],"source_content_type":"text/x-java","patch_set":1,"id":"ba7be1f8_f429a88a","line":23,"in_reply_to":"ba7be1f8_a6e46aac","updated":"2015-02-25 16:30:35.000000000","message":"Automatic change, I\u0027ll see how to turn of the automatic imports","commit_id":"05ce9f197338cff51718e5e101bc4d5b73603b0d"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"17aa6d27bcfb3f0b56429a25514ad6bff680f74f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    return metricDefinitionList;"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  public List\u003cString\u003e listNames(String tenantId) throws Exception{"},{"line_number":115,"context_line":"    String serieNameRegex \u003d buildSerieNameRegex(tenantId, config.region, null, null);"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    String query \u003d String.format(\"list series /%1$s/\", serieNameRegex);"}],"source_content_type":"text/x-java","patch_set":1,"id":"ba7be1f8_46a2ce4b","line":114,"updated":"2015-02-25 16:21:53.000000000","message":"Should be a space before the {\n\nCheck all method declarations","commit_id":"05ce9f197338cff51718e5e101bc4d5b73603b0d"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"2e5d170e0326513a23e71a9449012fd0849cb77f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        MetricName metricName \u003d new MetricName(serieNameDecoder.getMetricName(),"},{"line_number":160,"context_line":"                                               serieNameDecoder.getMetricName());"},{"line_number":161,"context_line":"        metricNameSet.add(metricName);"},{"line_number":162,"context_line":"        System.out.println(metricName);"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if (offset !\u003d null) {"},{"line_number":165,"context_line":"          if (metricNameSet.size() \u003e\u003d Paged.LIMIT) {"}],"source_content_type":"text/x-java","patch_set":3,"id":"ba7be1f8_3f31225a","line":162,"updated":"2015-02-26 18:28:11.000000000","message":"This should be logged, not sent to sysout.","commit_id":"5ef62d07d4d0a0c1d679281a0305149f91586d2b"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"cc6b2b93e00a72eab52ec22b7e9f18c567a08c18","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        MetricName metricName \u003d new MetricName(serieNameDecoder.getMetricName(),"},{"line_number":160,"context_line":"                                               serieNameDecoder.getMetricName());"},{"line_number":161,"context_line":"        metricNameSet.add(metricName);"},{"line_number":162,"context_line":"        System.out.println(metricName);"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        if (offset !\u003d null) {"},{"line_number":165,"context_line":"          if (metricNameSet.size() \u003e\u003d Paged.LIMIT) {"}],"source_content_type":"text/x-java","patch_set":3,"id":"ba7be1f8_f167bab5","line":162,"in_reply_to":"ba7be1f8_3f31225a","updated":"2015-02-26 20:41:22.000000000","message":"Oh, actually I don\u0027t need that line, I\u0027ll just remove it.","commit_id":"5ef62d07d4d0a0c1d679281a0305149f91586d2b"}],"java/src/main/java/monasca/api/infrastructure/persistence/influxdb/InfluxV9MetricDefinitionRepo.java":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"2e5d170e0326513a23e71a9449012fd0849cb77f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  public List\u003cMetricName\u003e listNames(String tenantId, String offset) throws Exception {"},{"line_number":85,"context_line":"    throw new NotImplementedException();"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  private List\u003cMetricDefinition\u003e metricDefinitionList(Series series) {"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    List\u003cMetricDefinition\u003e metricDefinitionList \u003d new ArrayList\u003c\u003e();"}],"source_content_type":"text/x-java","patch_set":3,"id":"ba7be1f8_bf235203","line":87,"updated":"2015-02-26 18:28:11.000000000","message":"For v9, we need to have a limit passed in.","commit_id":"5ef62d07d4d0a0c1d679281a0305149f91586d2b"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"cc6b2b93e00a72eab52ec22b7e9f18c567a08c18","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  public List\u003cMetricName\u003e listNames(String tenantId, String offset) throws Exception {"},{"line_number":85,"context_line":"    throw new NotImplementedException();"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  private List\u003cMetricDefinition\u003e metricDefinitionList(Series series) {"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    List\u003cMetricDefinition\u003e metricDefinitionList \u003d new ArrayList\u003c\u003e();"}],"source_content_type":"text/x-java","patch_set":3,"id":"ba7be1f8_31a5d2b5","line":87,"in_reply_to":"ba7be1f8_bf235203","updated":"2015-02-26 20:41:22.000000000","message":"Should I add that now? The find method above doesn\u0027t include it currently either.","commit_id":"5ef62d07d4d0a0c1d679281a0305149f91586d2b"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9d9adad4aba0e9ed45f7b1c67837ee310e43f218","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        for (String[] values : serie.getValues()) {"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"          MetricDefinition"},{"line_number":157,"context_line":"              m \u003d"},{"line_number":158,"context_line":"              new MetricDefinition(serie.getName(), dims(values, serie.getColumns()));"},{"line_number":159,"context_line":"          m.setId(String.valueOf(index++));"}],"source_content_type":"text/x-java","patch_set":8,"id":"1a6ced46_9c48355d","line":156,"updated":"2015-03-23 15:43:09.000000000","message":"Do not reformat code you aren\u0027t working on","commit_id":"da757bdeb88e07693d93e3d01ce5fb2920a1e996"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9d9adad4aba0e9ed45f7b1c67837ee310e43f218","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"      Serie serie \u003d series.getSeries()[0];"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"      for(String[] values : serie.getValues()){"},{"line_number":180,"context_line":"        MetricName"},{"line_number":181,"context_line":"            m \u003d"}],"source_content_type":"text/x-java","patch_set":8,"id":"1a6ced46_dca0edf6","line":178,"updated":"2015-03-23 15:43:09.000000000","message":"You have an extra blank line here","commit_id":"da757bdeb88e07693d93e3d01ce5fb2920a1e996"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9d9adad4aba0e9ed45f7b1c67837ee310e43f218","unresolved":false,"context_lines":[{"line_number":176,"context_line":"      Serie serie \u003d series.getSeries()[0];"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"      for(String[] values : serie.getValues()){"},{"line_number":180,"context_line":"        MetricName"},{"line_number":181,"context_line":"            m \u003d"},{"line_number":182,"context_line":"            new MetricName(String.valueOf(index++), values[0]);"}],"source_content_type":"text/x-java","patch_set":8,"id":"1a6ced46_9c8d957e","line":179,"updated":"2015-03-23 15:43:09.000000000","message":"Should be a space after the for and before the {","commit_id":"da757bdeb88e07693d93e3d01ce5fb2920a1e996"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"813bd2b0ad2400c3e92b3d48497969da191fedcd","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    int startIndex \u003d this.influxV9Utils.startIndex(offset);"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    String"},{"line_number":120,"context_line":"        q \u003d"},{"line_number":121,"context_line":"        String.format(\"show measurements where %1$s %2$s %3$s %4$s %5$s\","},{"line_number":122,"context_line":"                      this.influxV9Utils.tenantIdPart(tenantId),"},{"line_number":123,"context_line":"                      this.influxV9Utils.regionPart(this.region),"}],"source_content_type":"text/x-java","patch_set":9,"id":"1a6ced46_b2bfacfb","line":120,"updated":"2015-03-24 14:51:48.000000000","message":"Just wondering why the extra line here","commit_id":"a3fb43984729e4dd8ecf8bd7793066b34f60a146"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"b2608e5974abe06966a779639ba403b628e54fa0","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    int startIndex \u003d this.influxV9Utils.startIndex(offset);"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    String"},{"line_number":120,"context_line":"        q \u003d"},{"line_number":121,"context_line":"        String.format(\"show measurements where %1$s %2$s %3$s %4$s %5$s\","},{"line_number":122,"context_line":"                      this.influxV9Utils.tenantIdPart(tenantId),"},{"line_number":123,"context_line":"                      this.influxV9Utils.regionPart(this.region),"}],"source_content_type":"text/x-java","patch_set":9,"id":"1a6ced46_552add7e","line":120,"in_reply_to":"1a6ced46_b2bfacfb","updated":"2015-03-24 16:55:04.000000000","message":"I think is was an auto-formatting thing, the method above has the same problem. Fixed","commit_id":"a3fb43984729e4dd8ecf8bd7793066b34f60a146"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"c48125635d9daa2097c7ba669df9f36e66282dc5","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    int startIndex \u003d this.influxV9Utils.startIndex(offset);"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    String q \u003d"},{"line_number":119,"context_line":"        String.format(\"show measurements where %1$s %2$s %3$s %4$s %5$s\","},{"line_number":120,"context_line":"                      this.influxV9Utils.tenantIdPart(tenantId),"},{"line_number":121,"context_line":"                      this.influxV9Utils.regionPart(this.region),"},{"line_number":122,"context_line":"                      this.influxV9Utils.dimPart(dimensions),"}],"source_content_type":"text/x-java","patch_set":10,"id":"1a6ced46_2b38a29f","line":119,"updated":"2015-03-24 17:02:37.000000000","message":"can we put the \u0027where...\u0027 part on a new line? it\u0027s kind of a convention that the rest of the code follows.","commit_id":"4a3d6bbd2c8b095055f27f6aafac85e94c857a74"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"0f0ce4963b4b57e9f6d3b03d25361e624bd3f5eb","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    int startIndex \u003d this.influxV9Utils.startIndex(offset);"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    String q \u003d"},{"line_number":119,"context_line":"        String.format(\"show measurements where %1$s %2$s %3$s %4$s %5$s\","},{"line_number":120,"context_line":"                      this.influxV9Utils.tenantIdPart(tenantId),"},{"line_number":121,"context_line":"                      this.influxV9Utils.regionPart(this.region),"},{"line_number":122,"context_line":"                      this.influxV9Utils.dimPart(dimensions),"}],"source_content_type":"text/x-java","patch_set":10,"id":"1a6ced46_8f6441e6","line":119,"in_reply_to":"1a6ced46_2b38a29f","updated":"2015-03-24 17:19:02.000000000","message":"Done","commit_id":"4a3d6bbd2c8b095055f27f6aafac85e94c857a74"}],"java/src/main/resources/api-config.yml":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"17aa6d27bcfb3f0b56429a25514ad6bff680f74f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  checkConnectionWhileIdle: false"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"middleware:"},{"line_number":64,"context_line":"  enabled: false"},{"line_number":65,"context_line":"  serverVIP: 192.168.10.5"},{"line_number":66,"context_line":"  serverPort: 5000"},{"line_number":67,"context_line":"  connTimeout: 500"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba7be1f8_660fd237","line":64,"updated":"2015-02-25 16:21:53.000000000","message":"Maybe we\u0027ll have to vote on this setting. Turning this off requires me to turn it back on when debugging keystone problems","commit_id":"05ce9f197338cff51718e5e101bc4d5b73603b0d"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"edcb9564c66abfd128f5e9f80e2ad95490520c47","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  checkConnectionWhileIdle: false"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"middleware:"},{"line_number":64,"context_line":"  enabled: false"},{"line_number":65,"context_line":"  serverVIP: 192.168.10.5"},{"line_number":66,"context_line":"  serverPort: 5000"},{"line_number":67,"context_line":"  connTimeout: 500"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba7be1f8_299f6d04","line":64,"in_reply_to":"ba7be1f8_660fd237","updated":"2015-02-25 16:30:35.000000000","message":"Whoops, didn\u0027t mean to add this to my commit. I\u0027ll revert it in the next patch set","commit_id":"05ce9f197338cff51718e5e101bc4d5b73603b0d"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"17aa6d27bcfb3f0b56429a25514ad6bff680f74f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"logging:"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  # The default level of all loggers. Can be OFF, ERROR, WARN, INFO, DEBUG, TRACE, or ALL."},{"line_number":93,"context_line":"  level: info"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  # Logger-specific levels."},{"line_number":96,"context_line":"  loggers:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba7be1f8_6916c54d","line":93,"updated":"2015-02-25 16:21:53.000000000","message":"I like debug, your mileage may vary","commit_id":"05ce9f197338cff51718e5e101bc4d5b73603b0d"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"edcb9564c66abfd128f5e9f80e2ad95490520c47","unresolved":false,"context_lines":[{"line_number":90,"context_line":"logging:"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  # The default level of all loggers. Can be OFF, ERROR, WARN, INFO, DEBUG, TRACE, or ALL."},{"line_number":93,"context_line":"  level: info"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  # Logger-specific levels."},{"line_number":96,"context_line":"  loggers:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba7be1f8_8975b9cc","line":93,"in_reply_to":"ba7be1f8_6916c54d","updated":"2015-02-25 16:30:35.000000000","message":"Same comment as above","commit_id":"05ce9f197338cff51718e5e101bc4d5b73603b0d"}]}