)]}'
{"README.md":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"43dee03b6ab961563aeb06ae469d752fe63bdba8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"* adminUser - Admin user name"},{"line_number":50,"context_line":"* adminPassword - Admin user password"},{"line_number":51,"context_line":"* adminProjectId - Specify the project ID the api should use to request an admin token. If blank, the admin user\u0027s default project will be used. If present, this field overrides the adminProjectName field."},{"line_number":52,"context_line":"* adminProjectName - Specify the project name the api should use to request an admin token. If blank, the admin user\u0027s default project will be used. This may be overridden by the adminProjectId setting."},{"line_number":53,"context_line":"* adminToken - A valid admin user token if adminAuthMethod is token"},{"line_number":54,"context_line":"* timeToCacheToken - How long the Monasca API should cache the user\u0027s token before checking it again"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":2,"id":"9a80dd14_d8129957","line":52,"updated":"2015-03-11 17:28:01.000000000","message":"I think this could be a little clearer. Maybe something like adminProjectId has precedence over adminProjectName","commit_id":"f8e53ca2864d452d594daff1c50770b97c038296"}],"java/src/main/java/monasca/api/MonApiApplication.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"43dee03b6ab961563aeb06ae469d752fe63bdba8","unresolved":false,"context_lines":[{"line_number":157,"context_line":"      authInitParams.put(\"AdminAuthMethod\", config.middleware.adminAuthMethod);"},{"line_number":158,"context_line":"      authInitParams.put(\"AdminUser\", config.middleware.adminUser);"},{"line_number":159,"context_line":"      authInitParams.put(\"AdminPassword\", config.middleware.adminPassword);"},{"line_number":160,"context_line":"      authInitParams.put(\"AdminProjectId\", config.middleware.adminProjectId);"},{"line_number":161,"context_line":"      authInitParams.put(\"AdminProjectName\", config.middleware.adminProjectName);"},{"line_number":162,"context_line":"      authInitParams.put(\"MaxTokenCacheSize\", config.middleware.maxTokenCacheSize);"},{"line_number":163,"context_line":"      setIfNotNull(authInitParams, AuthConstants.TRUSTSTORE, config.middleware.truststore);"}],"source_content_type":"text/x-java","patch_set":2,"id":"9a80dd14_b87165aa","line":160,"updated":"2015-03-11 17:28:01.000000000","message":"This should be AuthConstants.ADMIN_PROJECT_ID which you can do once the common change has been merged","commit_id":"f8e53ca2864d452d594daff1c50770b97c038296"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"43dee03b6ab961563aeb06ae469d752fe63bdba8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"      authInitParams.put(\"AdminUser\", config.middleware.adminUser);"},{"line_number":159,"context_line":"      authInitParams.put(\"AdminPassword\", config.middleware.adminPassword);"},{"line_number":160,"context_line":"      authInitParams.put(\"AdminProjectId\", config.middleware.adminProjectId);"},{"line_number":161,"context_line":"      authInitParams.put(\"AdminProjectName\", config.middleware.adminProjectName);"},{"line_number":162,"context_line":"      authInitParams.put(\"MaxTokenCacheSize\", config.middleware.maxTokenCacheSize);"},{"line_number":163,"context_line":"      setIfNotNull(authInitParams, AuthConstants.TRUSTSTORE, config.middleware.truststore);"},{"line_number":164,"context_line":"      setIfNotNull(authInitParams, AuthConstants.TRUSTSTORE_PASS, config.middleware.truststorePassword);"}],"source_content_type":"text/x-java","patch_set":2,"id":"9a80dd14_186271d8","line":161,"updated":"2015-03-11 17:28:01.000000000","message":"This should be AuthConstants.ADMIN_PROJECT_NAME which you can do once the common change has been merged","commit_id":"f8e53ca2864d452d594daff1c50770b97c038296"}],"java/src/main/java/monasca/api/infrastructure/middleware/MiddlewareConfiguration.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"43dee03b6ab961563aeb06ae469d752fe63bdba8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  @JsonProperty"},{"line_number":60,"context_line":"  public String adminPassword;"},{"line_number":61,"context_line":"  @JsonProperty"},{"line_number":62,"context_line":"  public String adminProjectId;"},{"line_number":63,"context_line":"  @JsonProperty"},{"line_number":64,"context_line":"  public String adminProjectName;"},{"line_number":65,"context_line":"  @JsonProperty"}],"source_content_type":"text/x-java","patch_set":2,"id":"9a80dd14_0390464d","line":62,"updated":"2015-03-11 17:28:01.000000000","message":"You should set a default of \"\" so that this will work with old config files. Otherwise, I get:\n\nException in thread \"main\" java.lang.IllegalArgumentException: non-null value required for init parameter AdminProjectId\n        at org.eclipse.jetty.servlet.Holder$HolderRegistration.setInitParameters(Holder.java:411)\n        at monasca.api.MonApiApplication.run(MonApiApplication.java:177)\n        at monasca.api.MonApiApplication.run(MonApiApplication.java:62)","commit_id":"f8e53ca2864d452d594daff1c50770b97c038296"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"43dee03b6ab961563aeb06ae469d752fe63bdba8","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  @JsonProperty"},{"line_number":62,"context_line":"  public String adminProjectId;"},{"line_number":63,"context_line":"  @JsonProperty"},{"line_number":64,"context_line":"  public String adminProjectName;"},{"line_number":65,"context_line":"  @JsonProperty"},{"line_number":66,"context_line":"  public String maxTokenCacheSize \u003d \"1048576\";"},{"line_number":67,"context_line":"  @JsonProperty"}],"source_content_type":"text/x-java","patch_set":2,"id":"9a80dd14_63882223","line":64,"updated":"2015-03-11 17:28:01.000000000","message":"Same for this one","commit_id":"f8e53ca2864d452d594daff1c50770b97c038296"}]}