)]}'
{"monasca_api/common/repositories/influxdb/metrics_repository.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"e85114e94a0b34d356ba1792822aca1bd79926f0","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                            value_meta \u003d json.loads(point[2])"},{"line_number":272,"context_line":"                        except Exception as ex:"},{"line_number":273,"context_line":"                            pass"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"                        measurements_list.append([point[0],"},{"line_number":276,"context_line":"                                                  point[1],"},{"line_number":277,"context_line":"                                                  value_meta])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_b20339b8","line":274,"updated":"2015-06-05 17:26:58.000000000","message":"Should point[2] always exist now?  Do we want to log something here even if it\u0027s just a debug?","commit_id":"bb0c571ab977062f4191aed9c05a4a39c386c583"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"3199dbeafabe1c9371f124d6516ca7281c392eaf","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                            value_meta \u003d json.loads(point[2])"},{"line_number":272,"context_line":"                        except Exception as ex:"},{"line_number":273,"context_line":"                            pass"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"                        measurements_list.append([point[0],"},{"line_number":276,"context_line":"                                                  point[1],"},{"line_number":277,"context_line":"                                                  value_meta])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_f95e3444","line":274,"in_reply_to":"3afb71cf_b20339b8","updated":"2015-06-05 20:23:19.000000000","message":"Yeah, it should always exit now. This is a temp work-around. Ryan is going to apply his fixes after I get my review completely merged. If I ever get through flake8?","commit_id":"bb0c571ab977062f4191aed9c05a4a39c386c583"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"a38748899085cc2f087c9968f28b55e4f4feac46","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                            value_meta \u003d json.loads(point[2])"},{"line_number":272,"context_line":"                        except Exception as ex:"},{"line_number":273,"context_line":"                            pass"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"                        measurements_list.append([point[0],"},{"line_number":276,"context_line":"                                                  point[1],"},{"line_number":277,"context_line":"                                                  value_meta])"}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_3a42703f","line":274,"updated":"2015-06-06 17:04:27.000000000","message":"i\u0027m not sure why this is necessary. we should have an empty string at the least for value_meta. I did not see a problem parsing the value_meta when i was developing. have you seen problems with value_meta?","commit_id":"538cfc04ff1da3bd86649a116ef4fda6cdea434e"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"73aaf9042c2a80e78ea345f8fbd392fd0511f775","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                            value_meta \u003d json.loads(point[2])"},{"line_number":272,"context_line":"                        except Exception as ex:"},{"line_number":273,"context_line":"                            pass"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"                        measurements_list.append([point[0],"},{"line_number":276,"context_line":"                                                  point[1],"},{"line_number":277,"context_line":"                                                  value_meta])"}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_f576293d","line":274,"in_reply_to":"3afb71cf_3a42703f","updated":"2015-06-07 03:21:23.000000000","message":"I thought we discussed this the other day. Yes, we are hitting problems. point[2] is an empty string and json.loads throws an exception on an empty string.\n\nRyan has another potential fix in the works or will remove this code completely in a subsequent commit, by checking for an empty string, rather than catching an exception.","commit_id":"538cfc04ff1da3bd86649a116ef4fda6cdea434e"}],"monasca_api/v2/reference/metrics.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"e240e27420251a8e96a27c2124581e49e564b79d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                                 False)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if merge_metrics_flag is not False:"},{"line_number":38,"context_line":"        return helpers.str_2_bool(merge_metrics_flag)"},{"line_number":39,"context_line":"    else:"},{"line_number":40,"context_line":"        return False"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_8f580bfc","line":38,"updated":"2015-06-06 04:37:43.000000000","message":"You\u0027re doing str to bool here but the if above is looks like it\u0027s assuming merge_metrics_flag is already bool.  Is this just a python thing or is there a mismatch here?","commit_id":"538cfc04ff1da3bd86649a116ef4fda6cdea434e"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"73aaf9042c2a80e78ea345f8fbd392fd0511f775","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                                 False)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if merge_metrics_flag is not False:"},{"line_number":38,"context_line":"        return helpers.str_2_bool(merge_metrics_flag)"},{"line_number":39,"context_line":"    else:"},{"line_number":40,"context_line":"        return False"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_2b26a4ce","line":38,"in_reply_to":"3afb71cf_5a73ecb1","updated":"2015-06-07 03:21:23.000000000","message":"Done","commit_id":"538cfc04ff1da3bd86649a116ef4fda6cdea434e"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"08c3614405b8f8bdebd3974dc08146faadab6f51","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                                 False)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if merge_metrics_flag is not False:"},{"line_number":38,"context_line":"        return helpers.str_2_bool(merge_metrics_flag)"},{"line_number":39,"context_line":"    else:"},{"line_number":40,"context_line":"        return False"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_efee5feb","line":38,"in_reply_to":"3afb71cf_8f580bfc","updated":"2015-06-06 04:54:00.000000000","message":"Hopefully, I re-factored the code correctly by just removing some duplicated code. Did I change the overall result somehow to what was there previously?\n\nAnyway, the way I read this is that\n\n1. We\u0027re going to try and get the optional \"merge_metrics\" query parameter from the http request.\n2. If it is not supplied, then helpers.get_query_param returns a default value of False.\n3. If it is supplied, then helpers.get_query_parm returns a string which then needs to be converted to a boolean.\n\nYes, that is a bit ugly, but I think I just copied what was there and removed the duplicate code in two spots.\n\nThe problem is that merge_metrics_flag is either False or a string, which must then be converted to True or False.","commit_id":"538cfc04ff1da3bd86649a116ef4fda6cdea434e"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"a38748899085cc2f087c9968f28b55e4f4feac46","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                                 False)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if merge_metrics_flag is not False:"},{"line_number":38,"context_line":"        return helpers.str_2_bool(merge_metrics_flag)"},{"line_number":39,"context_line":"    else:"},{"line_number":40,"context_line":"        return False"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_5a73ecb1","line":38,"in_reply_to":"3afb71cf_8f580bfc","updated":"2015-06-06 17:04:27.000000000","message":"if merge_metrics flag is not False (boolean) then it is either True (boolean) or some string. That string then needs to be interpreted as either True (boolean) or False (boolean). in this case, anything other than \"true\" ignoring case, is considered False. Some comments here could make this more clear.","commit_id":"538cfc04ff1da3bd86649a116ef4fda6cdea434e"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"87a8f1737e9502eedb9554bad827d59e341ee27c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                                 False)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if merge_metrics_flag is not False:"},{"line_number":38,"context_line":"        return helpers.str_2_bool(merge_metrics_flag)"},{"line_number":39,"context_line":"    else:"},{"line_number":40,"context_line":"        return False"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3afb71cf_8fab6b89","line":38,"in_reply_to":"3afb71cf_efee5feb","updated":"2015-06-06 04:58:10.000000000","message":"I don\u0027t think you changed anything.  The diff view here threw me off, I thought this was new code.  The explanation makes sense as well though it does make it read strangely.","commit_id":"538cfc04ff1da3bd86649a116ef4fda6cdea434e"}],"requirements.txt":[{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"5c477b111fcc4fe873925905f87c33fa872441fe","unresolved":false,"context_lines":[{"line_number":8,"context_line":"pastedeploy\u003e\u003d1.3.3"},{"line_number":9,"context_line":"pbr\u003e\u003d0.6,!\u003d0.7,\u003c1.0"},{"line_number":10,"context_line":"python-dateutil\u003e\u003d1.5"},{"line_number":11,"context_line":"six\u003e\u003d1.7.0"},{"line_number":12,"context_line":"ujson\u003e\u003d1.33"},{"line_number":13,"context_line":"pyparsing\u003e\u003d2.0.3"},{"line_number":14,"context_line":"voluptuous\u003e\u003d0.8.7"}],"source_content_type":"text/plain","patch_set":1,"id":"3afb71cf_7da0f7f4","line":11,"updated":"2015-06-05 16:24:59.000000000","message":"Doesn\u0027t this need to specify simport as well?","commit_id":"00ff3b670c67c6d6ecdb7c42d43ad9d8e8c8a7a2"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"1b9dd0f6849aa6f68b23b41b3d3d354a09d2fd9c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"pastedeploy\u003e\u003d1.3.3"},{"line_number":9,"context_line":"pbr\u003e\u003d0.6,!\u003d0.7,\u003c1.0"},{"line_number":10,"context_line":"python-dateutil\u003e\u003d1.5"},{"line_number":11,"context_line":"six\u003e\u003d1.7.0"},{"line_number":12,"context_line":"ujson\u003e\u003d1.33"},{"line_number":13,"context_line":"pyparsing\u003e\u003d2.0.3"},{"line_number":14,"context_line":"voluptuous\u003e\u003d0.8.7"}],"source_content_type":"text/plain","patch_set":1,"id":"3afb71cf_9d605337","line":11,"in_reply_to":"3afb71cf_7da0f7f4","updated":"2015-06-05 20:23:09.000000000","message":"Done. Added in my latest commit.","commit_id":"00ff3b670c67c6d6ecdb7c42d43ad9d8e8c8a7a2"}]}