)]}'
{"monasca_api/tests/test_versions.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"ddbbb46f4027c10a9c1b4212c3e4680fbc3a7553","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from monasca_api.v2.reference import versions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"base_url \u003d \u0027http://falconframework.org/\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestVersions(testing.TestBase):"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_8f459018","line":23,"updated":"2015-07-24 19:41:35.000000000","message":"I see this base url used in the tests but why does it point to falconframework.org?  Is that required for the falcon testing library?","commit_id":"7c1f71964fe36c807ebe79b4263430800d725453"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"93ec54e5e4f9518fdfc9d244dd58d5c88a65d2a3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from monasca_api.v2.reference import versions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"base_url \u003d \u0027http://falconframework.org/\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestVersions(testing.TestBase):"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_9b4944ba","line":23,"in_reply_to":"3a50d1a3_8f459018","updated":"2015-07-25 15:42:20.000000000","message":"Yes, this is the base in the Falcon testing framework.","commit_id":"7c1f71964fe36c807ebe79b4263430800d725453"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"29fe503989e7c43eeea77c6ae8710af0f33bfbea","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from monasca_api.v2.reference import versions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"base_url \u003d \u0027http://falconframework.org/\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestVersions(testing.TestBase):"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_0f7c0e71","line":23,"in_reply_to":"3a50d1a3_9b4944ba","updated":"2015-07-26 01:34:18.000000000","message":"Maybe I should strip the base path off, or compare the tail of the url, so I don\u0027t have to worry about this.","commit_id":"7c1f71964fe36c807ebe79b4263430800d725453"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"29fe503989e7c43eeea77c6ae8710af0f33bfbea","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.assertIn(\u0027id\u0027, version)"},{"line_number":54,"context_line":"        self.assertIn(\u0027links\u0027, version)"},{"line_number":55,"context_line":"        self.assertIn(\u0027status\u0027, version)"},{"line_number":56,"context_line":"        self.assertIn(\u0027updated\u0027, version)"},{"line_number":57,"context_line":"        self.assertEqual(version[\u0027id\u0027], u\u0027v2.0\u0027)"},{"line_number":58,"context_line":"        self.assertEqual(version[\u0027status\u0027], u\u0027CURRENT\u0027)"},{"line_number":59,"context_line":"        date_object \u003d datetime.datetime.strptime(version[\u0027updated\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_2f7f8a67","line":56,"updated":"2015-07-26 01:34:18.000000000","message":"Maybe I should do a set comparision, so I don\u0027t have to do a separate test for each field.","commit_id":"7c1f71964fe36c807ebe79b4263430800d725453"}],"tox.ini":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"ddbbb46f4027c10a9c1b4212c3e4680fbc3a7553","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# H405  multi line docstring summary not separated with an empty line"},{"line_number":39,"context_line":"# H904  Wrap long lines in parentheses instead of a backslash"},{"line_number":40,"context_line":"ignore \u003d F821,H201,H302,H305,H307,H405,H904"},{"line_number":41,"context_line":"max-complexity \u003d 50"},{"line_number":42,"context_line":"max-line-length \u003d 120"},{"line_number":43,"context_line":"builtins \u003d _"},{"line_number":44,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,tools,build"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3a50d1a3_efe69443","line":41,"updated":"2015-07-24 19:41:35.000000000","message":"If we\u0027re going to set it to 50 do we really want to set it at all?  We have a couple functions in the api that hit 12, one function that hits 15, and one that hits 26.  All of those are already very complex functions.  A value of 50 would be unmaintainable.","commit_id":"7c1f71964fe36c807ebe79b4263430800d725453"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"96e179d0aaedf9d47a1ac0ef0adb9b3ab4b70a24","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# H405  multi line docstring summary not separated with an empty line"},{"line_number":39,"context_line":"# H904  Wrap long lines in parentheses instead of a backslash"},{"line_number":40,"context_line":"ignore \u003d F821,H201,H302,H305,H307,H405,H904"},{"line_number":41,"context_line":"max-complexity \u003d 50"},{"line_number":42,"context_line":"max-line-length \u003d 120"},{"line_number":43,"context_line":"builtins \u003d _"},{"line_number":44,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,tools,build"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3a50d1a3_a943936b","line":41,"in_reply_to":"3a50d1a3_dbfd8c3c","updated":"2015-07-26 17:22:17.000000000","message":"I tend to use 10 or 15 when I\u0027m checking the code for real.  Right now we only have one function worse than those measures and it\u0027s probably worth looking at that function anyway.  It\u0027d be nice if we could get to the point where 15 is a viable upper limit and start dialing that down over time when we can.\n\nThe value of complexity measurements is a bit contentious though so it\u0027d be worth getting the opinion of everyone else on the team too.","commit_id":"7c1f71964fe36c807ebe79b4263430800d725453"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"93ec54e5e4f9518fdfc9d244dd58d5c88a65d2a3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# H405  multi line docstring summary not separated with an empty line"},{"line_number":39,"context_line":"# H904  Wrap long lines in parentheses instead of a backslash"},{"line_number":40,"context_line":"ignore \u003d F821,H201,H302,H305,H307,H405,H904"},{"line_number":41,"context_line":"max-complexity \u003d 50"},{"line_number":42,"context_line":"max-line-length \u003d 120"},{"line_number":43,"context_line":"builtins \u003d _"},{"line_number":44,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,tools,build"}],"source_content_type":"text/x-properties","patch_set":3,"id":"3a50d1a3_dbfd8c3c","line":41,"in_reply_to":"3a50d1a3_efe69443","updated":"2015-07-25 15:42:20.000000000","message":"I copied this config from the monasca-events-api at,\n\nhttps://github.com/hpcloud-mon/monasca-events-api/blob/master/tox.ini\n\nNot sure what is a good setting. Do you have a suggestion?","commit_id":"7c1f71964fe36c807ebe79b4263430800d725453"}]}