)]}'
{"java/src/main/java/monasca/api/infrastructure/persistence/influxdb/InfluxV9Utils.java":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"0e7e3e990431e7c7a12d3637ab2d6ddcd1a2568b","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        convertible \u003d offset;"},{"line_number":142,"context_line":"      }"},{"line_number":143,"context_line":"      offset \u003d Conversions.variantToDateTime(convertible).toString(ISODateTimeFormat.dateTime());"},{"line_number":144,"context_line":"    }"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    return String.format(\" and time \u003e \u0027%1$s\u0027\", offset);"},{"line_number":147,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":3,"id":"9a1a9d01_a6b13c03","line":144,"updated":"2015-09-29 14:15:32.000000000","message":"Can you explain why this change is necessary? What bug does it fix?","commit_id":"924896e31d9c4ea624e6c4e2402dfa7e846ebf8e"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"39c667f26483aef8df290a459ac21059d0bf4dbd","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        convertible \u003d offset;"},{"line_number":142,"context_line":"      }"},{"line_number":143,"context_line":"      offset \u003d Conversions.variantToDateTime(convertible).toString(ISODateTimeFormat.dateTime());"},{"line_number":144,"context_line":"    }"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    return String.format(\" and time \u003e \u0027%1$s\u0027\", offset);"},{"line_number":147,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":3,"id":"9a1a9d01_2ff7218c","line":144,"in_reply_to":"9a1a9d01_a6b13c03","updated":"2015-09-30 06:05:37.000000000","message":"It looks like sorting with offset understood as timestamp does not work with InfluxDB 0.9.1. However if such value is transformed to ISO (as presented here) format sorting starts to work. I confirmed that behavior from Influx console hence this change + paging in alarm history started to work.","commit_id":"924896e31d9c4ea624e6c4e2402dfa7e846ebf8e"},{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"cef1eca2f68f29c41cb3eb8d52b4ec91622d894e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"      offset \u003d Conversions.variantToDateTime(convertible).toString(ISODateTimeFormat.dateTime());"},{"line_number":144,"context_line":"    }"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    return String.format(\" and time \u003e\u003d \u0027%1$s\u0027\", offset);"},{"line_number":147,"context_line":"  }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  public String privateRegionPart(String region) {"}],"source_content_type":"text/x-java","patch_set":9,"id":"ba8a016a_72f8db7b","line":146,"updated":"2015-11-18 17:39:24.000000000","message":"Why \u0027\u003e\u003d\u0027? I thought we wanted strictly \u0027\u003e\u0027. If we use greater than or equal, then we can repeat the same results in the next page.","commit_id":"e8ccd912ac0c70aa900fe14bcf0e2546f7d72629"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"b194c09581645c62c38d0ac830e7098939789334","unresolved":false,"context_lines":[{"line_number":143,"context_line":"      offset \u003d Conversions.variantToDateTime(convertible).toString(ISODateTimeFormat.dateTime());"},{"line_number":144,"context_line":"    }"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    return String.format(\" and time \u003e\u003d \u0027%1$s\u0027\", offset);"},{"line_number":147,"context_line":"  }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  public String privateRegionPart(String region) {"}],"source_content_type":"text/x-java","patch_set":9,"id":"ba8a016a_28e93fb7","line":146,"in_reply_to":"ba8a016a_72f8db7b","updated":"2015-11-19 20:48:42.000000000","message":"That made tests to pass, I was too happy about that to look in the UI, However that makes it somehow interesting...I need to go to UI to see what\u0027s going on there. Will do that tomorrow morning.","commit_id":"e8ccd912ac0c70aa900fe14bcf0e2546f7d72629"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"99ece0c072b065af26837bfd0b686990b109b732","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import java.util.regex.Matcher;"},{"line_number":24,"context_line":"import java.util.regex.Pattern;"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import org.apache.commons.lang3.StringUtils;"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"import monasca.common.util.Conversions;"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-java","patch_set":19,"id":"fa69d971_79b2fa07","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":44},"updated":"2016-01-05 14:54:06.000000000","message":"Please put it together with other org.* imports.","commit_id":"4ac32e634d5f0980b9c314387ee68c137d91378c"}],"java/src/main/java/monasca/api/resource/AlarmResource.java":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"0e7e3e990431e7c7a12d3637ab2d6ddcd1a2568b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        Strings.isNullOrEmpty(dimensionsStr) ? null : Validation"},{"line_number":136,"context_line":"            .parseAndValidateDimensions(dimensionsStr);"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    final int numericLimit \u003d this.persistUtils.getLimit(limit);"},{"line_number":139,"context_line":"    return Links.paginate(numericLimit,"},{"line_number":140,"context_line":"                          stateHistoryRepo.find(tenantId, dimensions, startTime,"},{"line_number":141,"context_line":"                                                endTime, offset, numericLimit), uriInfo);"}],"source_content_type":"text/x-java","patch_set":3,"id":"9a1a9d01_867bd827","line":138,"updated":"2015-09-29 14:15:32.000000000","message":"If we do this in this resource, then all the resources should be changed to be consistent.","commit_id":"924896e31d9c4ea624e6c4e2402dfa7e846ebf8e"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"39c667f26483aef8df290a459ac21059d0bf4dbd","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        Strings.isNullOrEmpty(dimensionsStr) ? null : Validation"},{"line_number":136,"context_line":"            .parseAndValidateDimensions(dimensionsStr);"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    final int numericLimit \u003d this.persistUtils.getLimit(limit);"},{"line_number":139,"context_line":"    return Links.paginate(numericLimit,"},{"line_number":140,"context_line":"                          stateHistoryRepo.find(tenantId, dimensions, startTime,"},{"line_number":141,"context_line":"                                                endTime, offset, numericLimit), uriInfo);"}],"source_content_type":"text/x-java","patch_set":3,"id":"9a1a9d01_cf1f85b5","line":138,"in_reply_to":"9a1a9d01_867bd827","updated":"2015-09-30 06:05:37.000000000","message":"No problem, but I think that\u0027s whole different story and it\u0027d be better to take care of that in another change, wouldn\u0027t it ? For sake of such change, if we agree for that, I can revert it here and take care of that later. What do you think ?","commit_id":"924896e31d9c4ea624e6c4e2402dfa7e846ebf8e"}],"monasca_tempest_tests/tests/api/test_alarms_state_history.py":[{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"934e5602382121534db674cd09fc6ce95fa9a32c","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                    # test goes through each el_id with each limit to check"},{"line_number":308,"context_line":"                    # if paging works correctly"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"                    params \u003d \u0027?limit\u003d%s\u0026offset\u003d%s\u0027 % (str(limit), str(el_id))"},{"line_number":311,"context_line":"                    resp, response_body \u003d (self.monasca_client"},{"line_number":312,"context_line":"                                           .list_alarms_state_history(params))"},{"line_number":313,"context_line":"                    elements \u003d response_body[\u0027elements\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a7e1126_e2baeebf","line":310,"range":{"start_line":310,"start_character":70,"end_line":310,"end_character":75},"updated":"2015-12-18 00:45:07.000000000","message":"Hi Tomasz, I tried this earlier and seems like using \"timestamp\" for offset instead of \"id\" gives better results.","commit_id":"0f73cb3828c11d9003538318e97848daa06ed668"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"95cf1c7d0cff8185b701515cea9acd423d9c7a04","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                    # test goes through each el_id with each limit to check"},{"line_number":308,"context_line":"                    # if paging works correctly"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"                    params \u003d \u0027?limit\u003d%s\u0026offset\u003d%s\u0027 % (str(limit), str(el_id))"},{"line_number":311,"context_line":"                    resp, response_body \u003d (self.monasca_client"},{"line_number":312,"context_line":"                                           .list_alarms_state_history(params))"},{"line_number":313,"context_line":"                    elements \u003d response_body[\u0027elements\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a7e1126_5da3994f","line":310,"range":{"start_line":310,"start_character":70,"end_line":310,"end_character":75},"in_reply_to":"3a7e1126_e2baeebf","updated":"2015-12-18 07:45:44.000000000","message":"Hi Kaiyan, it really shouldn\u0027t be any difference. ID is actually timestamp, just written as number of miliseconds.","commit_id":"0f73cb3828c11d9003538318e97848daa06ed668"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"7b8e3d38013c9240637f08f27ea47d1a4b23590a","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                list_alarm_state_history(alarm_id, query_parms)"},{"line_number":262,"context_line":"            elements_new \u003d response_body[\u0027elements\u0027]"},{"line_number":263,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":264,"context_line":"            self.assertEqual(0, len(elements_new))"},{"line_number":265,"context_line":"        else:"},{"line_number":266,"context_line":"            error_msg \u003d \"Failed test_list_alarm_state_history_with_offset\" \\"},{"line_number":267,"context_line":"                        \"_limit: at least one alarms state history is needed.\""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a7e1126_9063bf41","line":264,"range":{"start_line":264,"start_character":29,"end_line":264,"end_character":30},"updated":"2015-12-21 18:16:33.000000000","message":"Why should this expect 0 results? With offset\u003d1 and limit\u003d1 this should return the second element in the original list","commit_id":"9baa9e7e3a1e86868c38d607f1a2f1ff4e93edc8"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"be203f04dac137e7daa64d111405b262605654a1","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                list_alarm_state_history(alarm_id, query_parms)"},{"line_number":262,"context_line":"            elements_new \u003d response_body[\u0027elements\u0027]"},{"line_number":263,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":264,"context_line":"            self.assertEqual(0, len(elements_new))"},{"line_number":265,"context_line":"        else:"},{"line_number":266,"context_line":"            error_msg \u003d \"Failed test_list_alarm_state_history_with_offset\" \\"},{"line_number":267,"context_line":"                        \"_limit: at least one alarms state history is needed.\""}],"source_content_type":"text/x-python","patch_set":18,"id":"3a7e1126_beaeb37e","line":264,"range":{"start_line":264,"start_character":29,"end_line":264,"end_character":30},"in_reply_to":"3a7e1126_9063bf41","updated":"2015-12-22 09:01:52.000000000","message":"Hmm...test was failing locally, but perhaps it was just local issue as many others I think I am experiencing with tempests.","commit_id":"9baa9e7e3a1e86868c38d607f1a2f1ff4e93edc8"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"99ece0c072b065af26837bfd0b686990b109b732","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            elements_new \u003d response_body[\u0027elements\u0027]"},{"line_number":263,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":264,"context_line":"            self.assertEqual(1, len(elements_new))"},{"line_number":265,"context_line":"            self.assertEqual(element, elements_new[0])"},{"line_number":266,"context_line":"        else:"},{"line_number":267,"context_line":"            error_msg \u003d \"Failed test_list_alarm_state_history_with_offset\" \\"},{"line_number":268,"context_line":"                        \"_limit: at least one alarms state history is needed.\""}],"source_content_type":"text/x-python","patch_set":19,"id":"fa69d971_f9a82a22","side":"PARENT","line":265,"range":{"start_line":265,"start_character":12,"end_line":265,"end_character":54},"updated":"2016-01-05 14:54:06.000000000","message":"I have tested that assertion together with https://review.openstack.org/261079 applied and it passes, so I would prefer to leave it.","commit_id":"86c6d55af75b6d076b6168952ceee3234bb766d1"}]}