)]}'
{"java/src/main/java/monasca/api/app/validation/ValueMetaValidation.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"351633afeaa66d09449c00668e8ba46419481928","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  // ^^    ^^^     ^^    \u003c-- extra chars"},{"line_number":38,"context_line":"  //"},{"line_number":39,"context_line":"  private static final int VALUE_META_EXTRA_CHARS \u003d 7;"},{"line_number":40,"context_line":"  private static final int VALUE_META_VALUE_MAX_LENGTH \u003d 2048 - (VALUE_META_NAME_MAX_LENGTH + VALUE_META_EXTRA_CHARS);"},{"line_number":41,"context_line":"  private static final Map\u003cString, String\u003e EMPTY_VALUE_META \u003d Collections"},{"line_number":42,"context_line":"      .unmodifiableMap(new HashMap\u003cString, String\u003e());"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"9a1a9d01_ebc5143d","line":40,"updated":"2015-10-02 20:16:20.000000000","message":"Actually, I believe this calculation should be VALUE_META_VALUE_MAX_LENGTH -2 /* for curly brackets */ - 4 * valueMetas.size /* to handle double quotes */\n\nBut, since it will add backslashes before any embedded double quotes, even that is not sufficient. Maybe, it should just convert it to json and see if that will fit in 2048","commit_id":"279a7addd863fc97868f02ea7ad1129a105d6d10"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"f8b806efcf4278d4b5a4708d292812aa7fae9f33","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  // ^^    ^^^     ^^    \u003c-- extra chars"},{"line_number":38,"context_line":"  //"},{"line_number":39,"context_line":"  private static final int VALUE_META_EXTRA_CHARS \u003d 7;"},{"line_number":40,"context_line":"  private static final int VALUE_META_VALUE_MAX_LENGTH \u003d 2048 - (VALUE_META_NAME_MAX_LENGTH + VALUE_META_EXTRA_CHARS);"},{"line_number":41,"context_line":"  private static final Map\u003cString, String\u003e EMPTY_VALUE_META \u003d Collections"},{"line_number":42,"context_line":"      .unmodifiableMap(new HashMap\u003cString, String\u003e());"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"7a2fa921_eba0f1a7","line":40,"in_reply_to":"9a1a9d01_ebc5143d","updated":"2015-10-05 16:25:29.000000000","message":"That\u0027s a great suggestion craig -- thanks for the review -- will try the json conversion pre-length check...","commit_id":"279a7addd863fc97868f02ea7ad1129a105d6d10"}]}