)]}'
{"monasca_tempest_tests/tests/api/base.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"21ac758050dc94d63c11481dd178bc79dffa1252","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        super(BaseMonascaTest, cls).resource_cleanup()"},{"line_number":47,"context_line":"        resp, response_body \u003d cls.monasca_client.list_alarm_definitions()"},{"line_number":48,"context_line":"        elements \u003d response_body[\u0027elements\u0027]"},{"line_number":49,"context_line":"        if len(elements) !\u003d 0:"},{"line_number":50,"context_line":"            for i in range(0, len(elements)):"},{"line_number":51,"context_line":"                id \u003d elements[i][\u0027id\u0027]"},{"line_number":52,"context_line":"                resp, response_body \u003d cls.monasca_client. \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_6b81378f","line":49,"updated":"2015-10-27 17:48:46.000000000","message":"This is equivalent to:\n\nif elements:\n\nwhich is considered more \"pythonic\"","commit_id":"736ca3630f25bbcd1f64b410079b07f5eb9a659b"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"21ac758050dc94d63c11481dd178bc79dffa1252","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        resp, response_body \u003d cls.monasca_client.list_alarm_definitions()"},{"line_number":48,"context_line":"        elements \u003d response_body[\u0027elements\u0027]"},{"line_number":49,"context_line":"        if len(elements) !\u003d 0:"},{"line_number":50,"context_line":"            for i in range(0, len(elements)):"},{"line_number":51,"context_line":"                id \u003d elements[i][\u0027id\u0027]"},{"line_number":52,"context_line":"                resp, response_body \u003d cls.monasca_client. \\"},{"line_number":53,"context_line":"                    delete_alarm_definition(id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_4b4f9b92","line":50,"updated":"2015-10-27 17:48:46.000000000","message":"This should just be:\n\nfor element in elements:\n   id \u003d element[\u0027id\u0027]","commit_id":"736ca3630f25bbcd1f64b410079b07f5eb9a659b"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"21ac758050dc94d63c11481dd178bc79dffa1252","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        if len(elements) !\u003d 0:"},{"line_number":50,"context_line":"            for i in range(0, len(elements)):"},{"line_number":51,"context_line":"                id \u003d elements[i][\u0027id\u0027]"},{"line_number":52,"context_line":"                resp, response_body \u003d cls.monasca_client. \\"},{"line_number":53,"context_line":"                    delete_alarm_definition(id)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        resp, response_body \u003d cls.monasca_client.list_notification_methods()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_ab5e6f43","line":52,"updated":"2015-10-27 17:48:46.000000000","message":"You don\u0027t use reap, response_body so no point in setting them","commit_id":"736ca3630f25bbcd1f64b410079b07f5eb9a659b"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"21ac758050dc94d63c11481dd178bc79dffa1252","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        resp, response_body \u003d cls.monasca_client.list_notification_methods()"},{"line_number":56,"context_line":"        elements \u003d response_body[\u0027elements\u0027]"},{"line_number":57,"context_line":"        if len(elements) !\u003d 0:"},{"line_number":58,"context_line":"            for i in range(0, len(elements)):"},{"line_number":59,"context_line":"                id \u003d elements[i][\u0027id\u0027]"},{"line_number":60,"context_line":"                resp, response_body \u003d cls.monasca_client.\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_0b40c355","line":57,"updated":"2015-10-27 17:48:46.000000000","message":"See above","commit_id":"736ca3630f25bbcd1f64b410079b07f5eb9a659b"}],"monasca_tempest_tests/tests/api/helpers.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"21ac758050dc94d63c11481dd178bc79dffa1252","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            self.assertEqual(204, resp.status)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    # Delete alarm definitions"},{"line_number":138,"context_line":"    resp, response_body \u003d self.monasca_client.list_alarm_definitions()"},{"line_number":139,"context_line":"    elements \u003d response_body[\u0027elements\u0027]"},{"line_number":140,"context_line":"    if len(elements) \u003e 0:"},{"line_number":141,"context_line":"        for i in range(0, len(elements)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_ae419d3b","line":138,"updated":"2015-10-27 17:48:46.000000000","message":"Deleting the Alarm Definition will delete all of the Alarms for this Alarm Definition. Are you just testing deleting alarms?","commit_id":"736ca3630f25bbcd1f64b410079b07f5eb9a659b"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"21ac758050dc94d63c11481dd178bc79dffa1252","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    cls.rule \u003d {\u0027expression\u0027: \u0027mem_total_mb \u003e 0\u0027}"},{"line_number":151,"context_line":"    alarm_def_id \u003d []"},{"line_number":152,"context_line":"    for i in range(0, NUM_ALARM_DEFINITIONS):"},{"line_number":153,"context_line":"        alarm_definition \u003d create_alarm_definition("},{"line_number":154,"context_line":"            name\u003d\u0027alarm-definition-\u0027 + str(i),"},{"line_number":155,"context_line":"            description\u003ddata_utils.rand_name(\u0027description\u0027),"},{"line_number":156,"context_line":"            expression\u003dexpression)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_8e1aa16d","line":153,"updated":"2015-10-27 17:48:46.000000000","message":"I\u0027d like to see match_by set. That is an important part of Alarm Definitions and Alarms","commit_id":"736ca3630f25bbcd1f64b410079b07f5eb9a659b"}]}