)]}'
{"monasca_tempest_tests/tests/api/test_alarm_definitions.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"53488a255dea2430100c15fea51642d09cf8a86b","unresolved":false,"context_lines":[{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        # Update alarm definition"},{"line_number":504,"context_line":"        updated_name \u003d data_utils.rand_name(\u0027updated_name\u0027)"},{"line_number":505,"context_line":"        updated_description \u003d \u0027updated description\u0027"},{"line_number":506,"context_line":"        updated_expression \u003d response_body[\u0027expression\u0027]"},{"line_number":507,"context_line":"        updated_match_by \u003d [\u0027hostname\u0027]"},{"line_number":508,"context_line":"        self.assertRaises(exceptions.UnprocessableEntity,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_445e4177","line":505,"updated":"2015-10-30 19:48:29.000000000","message":"You should just reuse the name and description from the original alarm definition since you are testing only match-by","commit_id":"27884872505a97199b665fb843db94c3bdab0ba4"}],"monasca_tempest_tests/tests/api/test_alarms.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"53488a255dea2430100c15fea51642d09cf8a86b","unresolved":false,"context_lines":[{"line_number":392,"context_line":"            resp, response_body \u003d self.monasca_client.list_alarms()"},{"line_number":393,"context_line":"            elements \u003d response_body[\u0027elements\u0027]"},{"line_number":394,"context_line":"            if len(elements) \u003e\u003d 2:"},{"line_number":395,"context_line":"                break"},{"line_number":396,"context_line":"        resp, response_body \u003d self.monasca_client.list_alarms()"},{"line_number":397,"context_line":"        elements \u003d response_body[\u0027elements\u0027]"},{"line_number":398,"context_line":"        self.assertEqual(len(elements), 2)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_44a3a14f","line":395,"updated":"2015-10-30 19:48:29.000000000","message":"This for loop is the same as the for loop above (except for the len(element) check, I suggest you make a helper method to reduce duplicated code.","commit_id":"27884872505a97199b665fb843db94c3bdab0ba4"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"53488a255dea2430100c15fea51642d09cf8a86b","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            match_by\u003dmatch_by)"},{"line_number":414,"context_line":"        self.monasca_client.create_alarm_definitions(alarm_definition)"},{"line_number":415,"context_line":"        # create some metrics"},{"line_number":416,"context_line":"        for i in range(0, 180):"},{"line_number":417,"context_line":"            metric1 \u003d helpers.create_metric("},{"line_number":418,"context_line":"                name\u003d\u0027cpu.idle_perc\u0027,"},{"line_number":419,"context_line":"                dimensions\u003d{\u0027service\u0027: \u0027monitoring\u0027, \u0027hostname\u0027: \u0027mini-mon\u0027})"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_c48fb1ca","line":416,"updated":"2015-10-30 19:48:29.000000000","message":"Looks like more duplicated code","commit_id":"27884872505a97199b665fb843db94c3bdab0ba4"}]}