)]}'
{"etc/api-config.conf":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"92f01cc3d81cd350c40aa582572ecfba65db21c2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"[repositories]"},{"line_number":39,"context_line":"# The driver to use for the metrics repository"},{"line_number":40,"context_line":"# metrics_driver \u003d monasca_api.common.repositories.influxdb.metrics_repository:MetricsRepository"},{"line_number":41,"context_line":"metrics_driver \u003d monasca_api.common.repositories.cassandra.metrics_repository:MetricsRepository"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# The driver to use for the alarm definitions repository"},{"line_number":44,"context_line":"alarm_definitions_driver \u003d monasca_api.common.repositories.mysql.alarm_definitions_repository:AlarmDefinitionsRepository"}],"source_content_type":"text/plain","patch_set":2,"id":"da85f559_58351a44","line":41,"updated":"2015-11-11 21:25:22.000000000","message":"Probably don\u0027t want to change the default until this is completely up and running. Although leaving this there and commented out seems like a good idea.","commit_id":"89c21858b7faaac580d9301f045e9bf67e93df12"}],"monasca_api/common/repositories/cassandra/data_queries_base.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"92f01cc3d81cd350c40aa582572ecfba65db21c2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_b8652646","line":2,"updated":"2015-11-11 21:25:22.000000000","message":"Need to change to 2015.","commit_id":"89c21858b7faaac580d9301f045e9bf67e93df12"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"92f01cc3d81cd350c40aa582572ecfba65db21c2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from datetime import datetime"},{"line_number":21,"context_line":"import math"},{"line_number":22,"context_line":"import pytz"},{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# ------------------------"},{"line_number":26,"context_line":"# Abstract Base Class"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_b3878960","line":23,"updated":"2015-11-11 21:25:22.000000000","message":"I\u0027m assuming that this ordering will fail. See, http://docs.openstack.org/developer/hacking/, for more details on ordering of imports.","commit_id":"89c21858b7faaac580d9301f045e9bf67e93df12"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"92f01cc3d81cd350c40aa582572ecfba65db21c2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.tenant_id \u003d tenant_id"},{"line_number":39,"context_line":"        self.region \u003d region"},{"line_number":40,"context_line":"        self.table_name \u003d table_name"},{"line_number":41,"context_line":"        self.key_extractor \u003d key_extractor"},{"line_number":42,"context_line":"        super(DataQuery, self).__init__()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def build(self, fields, name, dimensions, limit):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_f5a5eb03","line":41,"updated":"2015-11-11 21:25:22.000000000","message":"Just as a style recommendation it might be good to declare the private variables with a leading underscore \"_\".\n\nUnless they are supposed to be protected.","commit_id":"89c21858b7faaac580d9301f045e9bf67e93df12"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"92f01cc3d81cd350c40aa582572ecfba65db21c2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.region \u003d region"},{"line_number":40,"context_line":"        self.table_name \u003d table_name"},{"line_number":41,"context_line":"        self.key_extractor \u003d key_extractor"},{"line_number":42,"context_line":"        super(DataQuery, self).__init__()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def build(self, fields, name, dimensions, limit):"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_75ba5b25","line":42,"updated":"2015-11-11 21:25:22.000000000","message":"Should super be declared first in __init__?","commit_id":"89c21858b7faaac580d9301f045e9bf67e93df12"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"92f01cc3d81cd350c40aa582572ecfba65db21c2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.key_extractor \u003d key_extractor"},{"line_number":42,"context_line":"        super(DataQuery, self).__init__()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def build(self, fields, name, dimensions, limit):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        allow_filter_clause \u003d \u0027\u0027"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_d5e30704","line":44,"updated":"2015-11-11 21:25:22.000000000","message":"probably should be declared private, as in _build, with a more descriptive name to identify what you are building. \n\ndef _build_foo_bar","commit_id":"89c21858b7faaac580d9301f045e9bf67e93df12"}]}