)]}'
{"monasca_api/v2/reference/helpers.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"ae128388c9827a74b076075af47a2d60827d6012","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    try:"},{"line_number":123,"context_line":"        params \u003d falcon.uri.parse_query_string(req.query_string)"},{"line_number":124,"context_line":"        if param_name in params:"},{"line_number":125,"context_line":"            if isinstance(params[param_name], list):"},{"line_number":126,"context_line":"                param_val \u003d params[param_name][0].decode(\u0027utf8\u0027)"},{"line_number":127,"context_line":"            else:"},{"line_number":128,"context_line":"                param_val \u003d params[param_name].decode(\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_69460d51","line":125,"updated":"2015-11-13 22:07:38.000000000","message":"There are a couple of places where the falcon behavior makes sense, for example on dimension arguments for a measurement-list:\n\nmeasurement-list?dimension\u003dservice:monitoring\u0026dimension\u003dhostname:mini-mon\n\nInstead we make them specify it this way:\n\nmeasurement-list?dimension\u003dservice:monitoring,hostname:mini-mon\n\nThe Falcon behavior implies that a significant number of people believe the first is a legitimate form","commit_id":"6f924db98dc44d19370fcd1c77c9ab1df9e1f10a"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"8a5ea10c0b27ebe19e4176651ab5eef1df46e14e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    try:"},{"line_number":123,"context_line":"        params \u003d falcon.uri.parse_query_string(req.query_string)"},{"line_number":124,"context_line":"        if param_name in params:"},{"line_number":125,"context_line":"            if isinstance(params[param_name], list):"},{"line_number":126,"context_line":"                param_val \u003d params[param_name][0].decode(\u0027utf8\u0027)"},{"line_number":127,"context_line":"            else:"},{"line_number":128,"context_line":"                param_val \u003d params[param_name].decode(\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_98aff9e2","line":125,"in_reply_to":"da85f559_5d2f43a1","updated":"2015-11-14 03:47:25.000000000","message":"Just to add extra confusion the falcon behaviour is deliberate and not any sort of accidental bug.","commit_id":"6f924db98dc44d19370fcd1c77c9ab1df9e1f10a"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"dc5489f832d46fa8718d4374172ebb0adaec6b50","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    try:"},{"line_number":123,"context_line":"        params \u003d falcon.uri.parse_query_string(req.query_string)"},{"line_number":124,"context_line":"        if param_name in params:"},{"line_number":125,"context_line":"            if isinstance(params[param_name], list):"},{"line_number":126,"context_line":"                param_val \u003d params[param_name][0].decode(\u0027utf8\u0027)"},{"line_number":127,"context_line":"            else:"},{"line_number":128,"context_line":"                param_val \u003d params[param_name].decode(\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_5d2f43a1","line":125,"in_reply_to":"da85f559_69460d51","updated":"2015-11-14 03:24:02.000000000","message":"It seems strange to have a query parameter that can be specified multiple time. Functions/methods in programming languages don\u0027t allow this. However, this isn\u0027t a function/method. Is it normal in a http query parameter list to specify multiple values (an array), each separately. \n\nI\u0027m not sure that Falcon was doing this because they thought it was a legitimate parameter list. It could have just been an oversight on their part, or just left it as an unspecified policy/limit.\n\nOur API doesn\u0027t expressly state that query parameters must be unique, but I\u0027m wondering if we should go back and add that.\n\nAdditionally, in the above, you have \"dimension\u003dservice\", but the query parameter is \"dimensions\", plural, so it seems to me like specifying the \"dimensions\" query parameter once is what we want.\n\nWe could update the API spec to state that query parameters can only be specified once.","commit_id":"6f924db98dc44d19370fcd1c77c9ab1df9e1f10a"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"8c7d2768a911a839395d0b79adca4e85c7c1b42e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    try:"},{"line_number":123,"context_line":"        params \u003d falcon.uri.parse_query_string(req.query_string)"},{"line_number":124,"context_line":"        if param_name in params:"},{"line_number":125,"context_line":"            if isinstance(params[param_name], list):"},{"line_number":126,"context_line":"                param_val \u003d params[param_name][0].decode(\u0027utf8\u0027)"},{"line_number":127,"context_line":"            else:"},{"line_number":128,"context_line":"                param_val \u003d params[param_name].decode(\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_d8e7c1aa","line":125,"in_reply_to":"da85f559_98aff9e2","updated":"2015-11-14 05:23:14.000000000","message":"so much for the oversight argument :-)","commit_id":"6f924db98dc44d19370fcd1c77c9ab1df9e1f10a"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"c4dff5dcdeab7ecade13016120742a816fba4f67","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    try:"},{"line_number":123,"context_line":"        params \u003d falcon.uri.parse_query_string(req.query_string)"},{"line_number":124,"context_line":"        if param_name in params:"},{"line_number":125,"context_line":"            if isinstance(params[param_name], list):"},{"line_number":126,"context_line":"                param_val \u003d params[param_name][0].decode(\u0027utf8\u0027)"},{"line_number":127,"context_line":"            else:"},{"line_number":128,"context_line":"                param_val \u003d params[param_name].decode(\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_1f031a75","line":125,"in_reply_to":"da85f559_d8e7c1aa","updated":"2015-11-16 17:02:42.000000000","message":"Well, as of right now, the java API will not create lists when the same query parameter is submitted multiple times. It will take the first value it finds.","commit_id":"6f924db98dc44d19370fcd1c77c9ab1df9e1f10a"}]}