)]}'
{"monasca_api/common/repositories/influxdb/metrics_repository.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"49f03a156f8bf74abd6d23c142a2056566dbb75a","unresolved":false,"context_lines":[{"line_number":496,"context_line":"                                   u\u0027reason_data\u0027: point[6],"},{"line_number":497,"context_line":"                                   u\u0027sub_alarms\u0027: json.loads(point[7]),"},{"line_number":498,"context_line":"                                   u\u0027id\u0027: str(self._get_millis_from_timestamp("},{"line_number":499,"context_line":"                                       datetime.utcnow()))}"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"                    # java api formats these during json serialization"},{"line_number":502,"context_line":"                    if alarm_point[u\u0027sub_alarms\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_dc16a7f0","line":499,"updated":"2015-11-18 02:32:15.000000000","message":"utcnow() is not a good value to use as an id. If you do a query twice that includes a specific alarm history, it will have two different ids which will be very confusing. The timestamp would be better.","commit_id":"2cf77a1c2722db242d5a09f072a2a7e8f1075ad8"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"a2323445e00f1c3637aa624c29a5dee6dcae9204","unresolved":false,"context_lines":[{"line_number":496,"context_line":"                                   u\u0027reason_data\u0027: point[6],"},{"line_number":497,"context_line":"                                   u\u0027sub_alarms\u0027: json.loads(point[7]),"},{"line_number":498,"context_line":"                                   u\u0027id\u0027: str(self._get_millis_from_timestamp("},{"line_number":499,"context_line":"                                       datetime.utcnow()))}"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"                    # java api formats these during json serialization"},{"line_number":502,"context_line":"                    if alarm_point[u\u0027sub_alarms\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_50161656","line":499,"in_reply_to":"ba8a016a_b00422c0","updated":"2015-11-18 05:35:25.000000000","message":"I had missed porting from java to python. Thank you for making me realize!","commit_id":"2cf77a1c2722db242d5a09f072a2a7e8f1075ad8"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"fbfedb7483aa42f7b84fac7b69899b9034bb1eaf","unresolved":false,"context_lines":[{"line_number":496,"context_line":"                                   u\u0027reason_data\u0027: point[6],"},{"line_number":497,"context_line":"                                   u\u0027sub_alarms\u0027: json.loads(point[7]),"},{"line_number":498,"context_line":"                                   u\u0027id\u0027: str(self._get_millis_from_timestamp("},{"line_number":499,"context_line":"                                       datetime.utcnow()))}"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"                    # java api formats these during json serialization"},{"line_number":502,"context_line":"                    if alarm_point[u\u0027sub_alarms\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_b00422c0","line":499,"in_reply_to":"ba8a016a_bcfde33b","updated":"2015-11-18 05:06:53.000000000","message":"The change you made matches exactly what the Java API does","commit_id":"2cf77a1c2722db242d5a09f072a2a7e8f1075ad8"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"71204443d5726e524c5a1d0d5129cd8ccdcd8204","unresolved":false,"context_lines":[{"line_number":496,"context_line":"                                   u\u0027reason_data\u0027: point[6],"},{"line_number":497,"context_line":"                                   u\u0027sub_alarms\u0027: json.loads(point[7]),"},{"line_number":498,"context_line":"                                   u\u0027id\u0027: str(self._get_millis_from_timestamp("},{"line_number":499,"context_line":"                                       datetime.utcnow()))}"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"                    # java api formats these during json serialization"},{"line_number":502,"context_line":"                    if alarm_point[u\u0027sub_alarms\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_bcfde33b","line":499,"in_reply_to":"ba8a016a_dc16a7f0","updated":"2015-11-18 02:48:34.000000000","message":"I ported from Java source.\nI think id should not change whenever it is queried too.\nI will fix with timestamp you mentioned.\nThank you.","commit_id":"2cf77a1c2722db242d5a09f072a2a7e8f1075ad8"}],"monasca_api/tests/test_alarms.py":[{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"e77fc86bdfd59ef83292c8910b427f9ba84e6de7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        u\"sub_alarm_state\": u\"ALARM\","},{"line_number":68,"context_line":"        u\"current_values\": [50.1],"},{"line_number":69,"context_line":"    }]),"},{"line_number":70,"context_line":"    (u\"id\", u\"1420070400000\"),"},{"line_number":71,"context_line":"))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_7a14499f","line":70,"updated":"2015-11-18 12:07:16.000000000","message":"By putting this entry in here, the mock data returned by the InfluxDB mock in InfluxClientAlarmHistoryResponseFixture will now include an \"id\" field.\n\nOne fix would be to amend the _setUp metod to add \"delete mock_data[u\u0027id\u0027]\"","commit_id":"79d47c3cd2c797969a70973ea934f8eef834c2ce"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"c0e8fd5ea4063babc9ef35d5425ef3708896b3c8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        u\"sub_alarm_state\": u\"ALARM\","},{"line_number":68,"context_line":"        u\"current_values\": [50.1],"},{"line_number":69,"context_line":"    }]),"},{"line_number":70,"context_line":"    (u\"id\", u\"1420070400000\"),"},{"line_number":71,"context_line":"))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_f72d8b46","line":70,"in_reply_to":"ba8a016a_7a14499f","updated":"2015-11-19 00:40:25.000000000","message":"Thank you for review. I fixed this as you mentioned. And I added \"tenant_id\" to mock, because query response from InfluxDB has tenant_id. I\u0027d like you to reexamine the patch set 5. Best Regards.","commit_id":"79d47c3cd2c797969a70973ea934f8eef834c2ce"},{"author":{"_account_id":15799,"name":"Ben Motz","email":"ben.launchpad@ouat.co.uk","username":"bmotz"},"change_message_id":"bda4d75c4843efa8a888d187a413eb278d8ae05b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        del mock_data[u\"sub_alarms\"][0][u\"sub_alarm_expression\"][u\"dimensions\"]"},{"line_number":118,"context_line":"        mock_data[u\"sub_alarms\"] \u003d json.dumps(mock_data[u\"sub_alarms\"])"},{"line_number":119,"context_line":"        mock_data[u\"metrics\"] \u003d json.dumps(mock_data[u\"metrics\"])"},{"line_number":120,"context_line":"        mock_data[u\"tenant_id\"] \u003d TENANT_ID"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        self.mock.return_value.query.return_value.raw \u003d {"},{"line_number":123,"context_line":"            \"series\": [self._build_series(\"alarm_state_history\", mock_data)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_81adc89c","line":120,"updated":"2015-11-19 11:54:38.000000000","message":"Why not just leave the original code, which had  (u\"tenant_id\", TENANT_ID) in ALARM_HISTORY? (Which would also make the change on line 188 unnecessary)","commit_id":"942618b9a7ae7a5b2a660ba6f90cf1b3949167e1"}]}
