)]}'
{"monasca_tempest_tests/tests/api/test_alarm_definitions.py":[{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"b25035f06522e205c80ec284ee86aa78b28da493","unresolved":false,"context_lines":[{"line_number":572,"context_line":"                alarm_definition)"},{"line_number":573,"context_line":"            self.assertEqual(201, resp.status)"},{"line_number":574,"context_line":"            alarm_def_ids.append(response_body[\u0027id\u0027])"},{"line_number":575,"context_line":"        if num \u003d\u003d 1:"},{"line_number":576,"context_line":"            return alarm_def_ids, response_body"},{"line_number":577,"context_line":"        else:"},{"line_number":578,"context_line":"            return alarm_def_ids"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_9c07bf80","line":575,"updated":"2015-11-23 23:15:48.000000000","message":"Having a variable number of returns is very confusing, this method could should return the list of alarm definitions instead","commit_id":"4ff36f770cac60b30fce442d0a1c3c688c4f8d44"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0d57e632d2d77a4d36a7a1cc828f30f49832e7a9","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        resp, response_body \u003d self.monasca_client.get_alarm_definition("},{"line_number":383,"context_line":"            response_body_list[0][\u0027id\u0027])"},{"line_number":384,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":385,"context_line":"        self._verify_element_set(response_body)"},{"line_number":386,"context_line":"        links \u003d response_body[\u0027links\u0027]"},{"line_number":387,"context_line":"        self._verify_list_alarm_definitions_links(links)"},{"line_number":388,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_4eeee6b5","line":385,"updated":"2015-11-30 15:42:07.000000000","message":"This is missing something like _verify_list_alarm_definitions_elements(). I don\u0027t see anything that verifies the name, expression, etc. matches what it should be.","commit_id":"df09e90dd5a29ad2b9bfa31d317e850e383e3c69"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0d57e632d2d77a4d36a7a1cc828f30f49832e7a9","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            description\u003dupdated_description,"},{"line_number":404,"context_line":"            actions_enabled\u003d\u0027true\u0027"},{"line_number":405,"context_line":"        )"},{"line_number":406,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        # Validate fields updated"},{"line_number":409,"context_line":"        resp, response_body \u003d self.monasca_client.get_alarm_definition("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_8e85aeae","line":406,"updated":"2015-11-30 15:42:07.000000000","message":"You also need to verify response_body has the fields set correctly.","commit_id":"df09e90dd5a29ad2b9bfa31d317e850e383e3c69"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"c724a4f8a27cbc798981b57607ad58f5e9c2fe1e","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            description\u003dupdated_description,"},{"line_number":404,"context_line":"            actions_enabled\u003d\u0027true\u0027"},{"line_number":405,"context_line":"        )"},{"line_number":406,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        # Validate fields updated"},{"line_number":409,"context_line":"        resp, response_body \u003d self.monasca_client.get_alarm_definition("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_70193c79","line":406,"in_reply_to":"9a8ffd7b_2487fe13","updated":"2015-11-30 18:28:09.000000000","message":"You need to check both. I have seen bugs where patch returned the correct values but didn\u0027t actually save the values in the database. That is why you do the get check, but the patch should also return the correct values so you need to validate that as well.","commit_id":"df09e90dd5a29ad2b9bfa31d317e850e383e3c69"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"c8167cf37dc19575a93e025ee4dd9d48ad27c7df","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            description\u003dupdated_description,"},{"line_number":404,"context_line":"            actions_enabled\u003d\u0027true\u0027"},{"line_number":405,"context_line":"        )"},{"line_number":406,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        # Validate fields updated"},{"line_number":409,"context_line":"        resp, response_body \u003d self.monasca_client.get_alarm_definition("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_2487fe13","line":406,"in_reply_to":"9a8ffd7b_8e85aeae","updated":"2015-11-30 17:35:20.000000000","message":"Yes but instead of checking the response body here I checked it after \"get_alarm_definition\" (Ln 410) to make sure the updated information  got actually saved. Do you think it\u0027s necessary to check twice here?","commit_id":"df09e90dd5a29ad2b9bfa31d317e850e383e3c69"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0d57e632d2d77a4d36a7a1cc828f30f49832e7a9","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            alarm_actions\u003d[notification_id],"},{"line_number":457,"context_line":"            ok_actions\u003d[notification_id],"},{"line_number":458,"context_line":"            undetermined_actions\u003d[notification_id])"},{"line_number":459,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":460,"context_line":"        # Get and verify details of an alarm after update"},{"line_number":461,"context_line":"        resp, response_body \u003d self.monasca_client.get_alarm_definition("},{"line_number":462,"context_line":"            response_body_list[0][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_8eacce36","line":459,"updated":"2015-11-30 15:42:07.000000000","message":"You also need to verify response_body has the fields set correctly.","commit_id":"df09e90dd5a29ad2b9bfa31d317e850e383e3c69"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0d57e632d2d77a4d36a7a1cc828f30f49832e7a9","unresolved":false,"context_lines":[{"line_number":477,"context_line":"            id\u003dresponse_body_list[0][\u0027id\u0027],"},{"line_number":478,"context_line":"            name\u003dpatched_name"},{"line_number":479,"context_line":"        )"},{"line_number":480,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":481,"context_line":"        # Validate fields updated"},{"line_number":482,"context_line":"        resp, response_body \u003d self.monasca_client.get_alarm_definition("},{"line_number":483,"context_line":"            response_body_list[0][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_2e80428b","line":480,"updated":"2015-11-30 15:42:07.000000000","message":"You also need to verify response_body has the fields set correctly.","commit_id":"df09e90dd5a29ad2b9bfa31d317e850e383e3c69"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0d57e632d2d77a4d36a7a1cc828f30f49832e7a9","unresolved":false,"context_lines":[{"line_number":521,"context_line":"            ok_actions\u003d[notification_id],"},{"line_number":522,"context_line":"            undetermined_actions\u003d[notification_id]"},{"line_number":523,"context_line":"        )"},{"line_number":524,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":525,"context_line":"        # # Get and verify details of an alarm after update"},{"line_number":526,"context_line":"        resp, response_body \u003d self.monasca_client.get_alarm_definition("},{"line_number":527,"context_line":"            response_body_list[0][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_6e0baa2c","line":524,"updated":"2015-11-30 15:42:07.000000000","message":"You also need to verify body has the fields set correctly.","commit_id":"df09e90dd5a29ad2b9bfa31d317e850e383e3c69"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0d57e632d2d77a4d36a7a1cc828f30f49832e7a9","unresolved":false,"context_lines":[{"line_number":539,"context_line":"        # Delete alarm definitions"},{"line_number":540,"context_line":"        resp, response_body \u003d self.monasca_client.list_alarm_definitions()"},{"line_number":541,"context_line":"        self._verify_list_alarm_definitions_response_body(resp, response_body)"},{"line_number":542,"context_line":"        elements \u003d response_body[\u0027elements\u0027]"},{"line_number":543,"context_line":"        for element in elements:"},{"line_number":544,"context_line":"            if element[\u0027id\u0027] \u003d\u003d response_body_list[0][\u0027id\u0027]:"},{"line_number":545,"context_line":"                resp, body \u003d self.monasca_client.delete_alarm_definition("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_b11ed35d","line":542,"updated":"2015-11-30 15:42:07.000000000","message":"It would be best here to assert that at least Alarm Definition is returned, if none are returned, the test succeeds but isn\u0027t doing what you think it is","commit_id":"df09e90dd5a29ad2b9bfa31d317e850e383e3c69"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0d57e632d2d77a4d36a7a1cc828f30f49832e7a9","unresolved":false,"context_lines":[{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        self.assertEqual(alarm_definition[\u0027expression\u0027],"},{"line_number":618,"context_line":"                         str(response_body[\u0027expression\u0027]))"},{"line_number":619,"context_line":"        if \u0027description\u0027 in alarm_definition:"},{"line_number":620,"context_line":"            self.assertEqual(alarm_definition[\u0027description\u0027],"},{"line_number":621,"context_line":"                             str(response_body[\u0027description\u0027]))"},{"line_number":622,"context_line":"        if \u0027match_by\u0027 in alarm_definition:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_d1cd97b8","line":619,"updated":"2015-11-30 15:42:07.000000000","message":"Do you need to check the else cases on these? What should the value of description be in the response if it was not set on create? Ditto for the other fields","commit_id":"df09e90dd5a29ad2b9bfa31d317e850e383e3c69"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"c8167cf37dc19575a93e025ee4dd9d48ad27c7df","unresolved":false,"context_lines":[{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        self.assertEqual(alarm_definition[\u0027expression\u0027],"},{"line_number":618,"context_line":"                         str(response_body[\u0027expression\u0027]))"},{"line_number":619,"context_line":"        if \u0027description\u0027 in alarm_definition:"},{"line_number":620,"context_line":"            self.assertEqual(alarm_definition[\u0027description\u0027],"},{"line_number":621,"context_line":"                             str(response_body[\u0027description\u0027]))"},{"line_number":622,"context_line":"        if \u0027match_by\u0027 in alarm_definition:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_877d8cb3","line":619,"in_reply_to":"9a8ffd7b_d1cd97b8","updated":"2015-11-30 17:35:20.000000000","message":"Great point! Yes I do need else cases to check the default values for these fields.","commit_id":"df09e90dd5a29ad2b9bfa31d317e850e383e3c69"}]}
