)]}'
{"monasca_api/tests/test_alarms.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"452e64b04a1aec613efbab22fcf3bd2166ed1c4a","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        self.alarm_def_repo_mock.return_value.create_alarm_definition.return_value \u003d u\"00000001-0001-0001-0001-000000000001\""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        valid_expressions \u003d ["},{"line_number":251,"context_line":"            \"max(-_.千幸福的笑脸{घोड़ा\u003d馬,  \""},{"line_number":252,"context_line":"            \"dn2\u003ddv2,千幸福的笑脸घ\u003d千幸福的笑脸घ}) gte 100 \""},{"line_number":253,"context_line":"            \"times 3 \u0026\u0026 \""},{"line_number":254,"context_line":"            \"(min(ເຮືອນ{dn3\u003ddv3,家\u003dдом}) \u003c 10 or sum(biz{dn5\u003ddv5}) \u003e99 and \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_e9185086","line":251,"updated":"2015-12-03 01:24:20.000000000","message":"One thousand happy faces.","commit_id":"82797fd9f6f2b0cf82ed2e4b368b6953ef9cb9be"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"09ee8c9c33d536ed86c671795eb29d6821002286","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                              method\u003d\"PUT\","},{"line_number":420,"context_line":"                              body\u003djson.dumps(alarm_def))"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        self.assertEqual(self.srmock.status, \u0027422 Unprocessable Entity\u0027)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def test_alarm_definition_get_specific_alarm(self):"},{"line_number":425,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_7c5f370f","line":422,"updated":"2015-12-03 04:01:39.000000000","message":"Personally, I would prefer to see you do a put with the field in it and have it return 200 just to show you have valid data. Then iterate over the fields and do a deep_copy, then delete the current field, from the copy, put it and show API returns 422 to verify each field is checked properly.","commit_id":"82797fd9f6f2b0cf82ed2e4b368b6953ef9cb9be"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"1a654d2db7695f3557c239900cf42b57b3c23a20","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                              method\u003d\"PUT\","},{"line_number":393,"context_line":"                              body\u003djson.dumps(alarm_def))"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def test_alarm_definition_update_missing_fields(self):"},{"line_number":398,"context_line":"        self.alarm_def_repo_mock.return_value.get_alarm_definitions.return_value \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_19576203","line":395,"updated":"2016-01-08 21:31:03.000000000","message":"Shouldn\u0027t there be a check of the response vs expected_data here?","commit_id":"717c79239d85b6e504698786ecc2126d6b4632f5"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"a5b383b03e276ff063da75dc86f1cbcdde78763a","unresolved":false,"context_lines":[{"line_number":392,"context_line":"                              method\u003d\"PUT\","},{"line_number":393,"context_line":"                              body\u003djson.dumps(alarm_def))"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def test_alarm_definition_update_missing_fields(self):"},{"line_number":398,"context_line":"        self.alarm_def_repo_mock.return_value.get_alarm_definitions.return_value \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_3938263d","line":395,"in_reply_to":"fa69d971_19576203","updated":"2016-01-08 21:48:54.000000000","message":"Not sure why the expected data section is there, because the call should return the original values, but I will add a check for that.","commit_id":"717c79239d85b6e504698786ecc2126d6b4632f5"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"13aa8a00ca41b558a940687bd6d9248606608ffa","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":395,"context_line":"        result_def \u003d json.loads(result[0])"},{"line_number":396,"context_line":"        for key in expected_def.iterkeys():"},{"line_number":397,"context_line":"            self.assertEqual(result_def[key], expected_def[key])"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def test_alarm_definition_update_missing_fields(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_c69e3307","line":396,"range":{"start_line":396,"start_character":8,"end_line":396,"end_character":42},"updated":"2016-01-12 05:33:36.000000000","message":"The problem with doing the test this way is you don\u0027t catch if result_def has extra entries in it. Probably makes more sense to just have \u0027id\u0027: def_id in expected_def and doing a simple assertEqual","commit_id":"becf9803d183f215326d463989ec0859a78e31df"}]}