)]}'
{"monasca_tempest_tests/tests/api/test_alarms_state_history.py":[{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"e08e632550bafef49a276403c98c135b1baa282e","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        number_of_alarms \u003d len(elements)"},{"line_number":193,"context_line":"        if number_of_alarms \u003e\u003d MIN_HISTORY:"},{"line_number":194,"context_line":"            first_element \u003d elements[0]"},{"line_number":195,"context_line":"            elements_length \u003d len(elements)"},{"line_number":196,"context_line":"            query_parms \u003d \u0027?limit\u003d\u0027 + str(elements_length)"},{"line_number":197,"context_line":"            resp, response_body \u003d self.monasca_client.\\"},{"line_number":198,"context_line":"                list_alarms_state_history(query_parms)"},{"line_number":199,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":200,"context_line":"            elements \u003d response_body[\u0027elements\u0027]"},{"line_number":201,"context_line":"            self.assertEqual(elements_length, len(elements))"},{"line_number":202,"context_line":"            self.assertEqual(first_element, elements[0])"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_d249e3d1","line":199,"range":{"start_line":195,"start_character":12,"end_line":199,"end_character":46},"updated":"2016-01-12 19:25:50.000000000","message":"Why do this query again? With the limit set to the length of the elements, it is the same as the first query at the top of the test.","commit_id":"8e8472b60448cc22d2e0b82396ff2786ce586b96"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"bc05ff07bf010a5f457f989f9ca93d37be8b3085","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        for timer in xrange(constants.MAX_RETRIES):"},{"line_number":40,"context_line":"            for i in xrange(MIN_HISTORY):"},{"line_number":41,"context_line":"                # create some metrics to prime the system and create"},{"line_number":42,"context_line":"                # MIN_HISTORY alarms"},{"line_number":43,"context_line":"                metric \u003d helpers.create_metric(name\u003d\"name-\" + str(i + 1))"},{"line_number":44,"context_line":"                cls.monasca_client.create_metrics(metric)"},{"line_number":45,"context_line":"                # sleep 0.05 second between metrics to make sure timestamps"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_3d801046","line":42,"updated":"2016-01-13 20:09:38.000000000","message":"This is really waiting for the alarms to be created and then for them to change state so an Alarm State History is created","commit_id":"0205c414d8cf7236046bffb3b50ca1702d06e280"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"bc05ff07bf010a5f457f989f9ca93d37be8b3085","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        elements_set1 \u003d response_body[\u0027elements\u0027]"},{"line_number":192,"context_line":"        number_of_alarms \u003d len(elements_set1)"},{"line_number":193,"context_line":"        if number_of_alarms \u003e\u003d MIN_HISTORY:"},{"line_number":194,"context_line":"            elements_length \u003d len(elements_set1)"},{"line_number":195,"context_line":"            query_parms \u003d \u0027?limit\u003d\u0027 + str(MIN_HISTORY)"},{"line_number":196,"context_line":"            resp, response_body \u003d self.monasca_client.\\"},{"line_number":197,"context_line":"                list_alarms_state_history(query_parms)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_9da01ca1","line":194,"range":{"start_line":194,"start_character":12,"end_line":194,"end_character":27},"updated":"2016-01-13 20:09:38.000000000","message":"elements_length is the same as number_of_alarms. Remove elements_length","commit_id":"0205c414d8cf7236046bffb3b50ca1702d06e280"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"bc05ff07bf010a5f457f989f9ca93d37be8b3085","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        number_of_alarms \u003d len(elements_set1)"},{"line_number":193,"context_line":"        if number_of_alarms \u003e\u003d MIN_HISTORY:"},{"line_number":194,"context_line":"            elements_length \u003d len(elements_set1)"},{"line_number":195,"context_line":"            query_parms \u003d \u0027?limit\u003d\u0027 + str(MIN_HISTORY)"},{"line_number":196,"context_line":"            resp, response_body \u003d self.monasca_client.\\"},{"line_number":197,"context_line":"                list_alarms_state_history(query_parms)"},{"line_number":198,"context_line":"            self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_9dc9fc7a","line":195,"range":{"start_line":195,"start_character":42,"end_line":195,"end_character":53},"updated":"2016-01-13 20:09:38.000000000","message":"This should probably be number_of_alarms since the below test will fail if number_of_alarms is \u003e MIN_HISTORY and your test allows for that case","commit_id":"0205c414d8cf7236046bffb3b50ca1702d06e280"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"bc05ff07bf010a5f457f989f9ca93d37be8b3085","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            for index in xrange(MIN_HISTORY - 1):"},{"line_number":204,"context_line":"                alarm_history \u003d elements_set2[index]"},{"line_number":205,"context_line":"                max_limit \u003d len(elements_set2) - index"},{"line_number":206,"context_line":"                for limit in xrange(1, max_limit):"},{"line_number":207,"context_line":"                    first_index \u003d index + 1"},{"line_number":208,"context_line":"                    last_index \u003d first_index + limit"},{"line_number":209,"context_line":"                    expected_elements \u003d elements_set2[first_index:last_index]"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_53d4d51e","line":206,"range":{"start_line":206,"start_character":0,"end_line":206,"end_character":50},"updated":"2016-01-13 20:09:38.000000000","message":"This inner loop is probably overkill. It really doesn\u0027t test cases that wouldn\u0027t be covered by having just one loop","commit_id":"0205c414d8cf7236046bffb3b50ca1702d06e280"}]}