)]}'
{"java/src/main/java/monasca/api/app/validation/Validation.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"7016c95d9626bc512568ac9452c7fc1e7bd8dc9f","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        if (field.size() \u003e 1 \u0026\u0026 !field.get(1).equals(\"desc\") \u0026\u0026 !field.get(1).equals(\"asc\")) {"},{"line_number":242,"context_line":"          throw Exceptions.unprocessableEntity(String.format(\"Sort_by value %s must be \u0027asc\u0027 or \u0027desc\u0027\", field.get(1)));"},{"line_number":243,"context_line":"        }"},{"line_number":244,"context_line":"//        // Convert friendly names to column names"},{"line_number":245,"context_line":"//        String fieldName \u003d field.get(0);"},{"line_number":246,"context_line":"//        if (fieldName.equals(\"alarm_id\"))"},{"line_number":247,"context_line":"//          field.set(0, \"a.id\");"},{"line_number":248,"context_line":"//        if (fieldName.equals(\"alarm_definition_id\"))"},{"line_number":249,"context_line":"//          field.set(0, \"ad.id\");"},{"line_number":250,"context_line":"//        if (fieldName.equals(\"created_timestamp\"))"},{"line_number":251,"context_line":"//          field.set(0, \"created_at\");"},{"line_number":252,"context_line":"//        if (fieldName.equals(\"updated_timestamp\"))"},{"line_number":253,"context_line":"//          field.set(0, \"updated_at\");"},{"line_number":254,"context_line":"//        if (fieldName.equals(\"state_updated_timestamp\"))"},{"line_number":255,"context_line":"//          field.set(0, \"state_updated_at\");"},{"line_number":256,"context_line":"        sortByList.add(Joiner.on(\u0027 \u0027).join(field));"},{"line_number":257,"context_line":"      }"},{"line_number":258,"context_line":"    }"}],"source_content_type":"text/x-java","patch_set":3,"id":"7a5de9d1_96c3b837","line":255,"range":{"start_line":244,"start_character":0,"end_line":255,"end_character":45},"updated":"2016-02-01 19:04:14.000000000","message":"Just delete this code since it is commented out","commit_id":"3b1535ccf431874544b4faa426d5ebc3303f3846"}],"java/src/main/java/monasca/api/infrastructure/persistence/mysql/AlarmMySqlRepoImpl.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"0bd3dd5257103c90ec614f92659763f6a46dce5e","unresolved":false,"context_lines":[{"line_number":193,"context_line":"      sbWhere.append(\" and a.state_updated_at \u003e\u003d :stateUpdatedStart\");"},{"line_number":194,"context_line":"    }"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    sbWhere.append(\")\");"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    StringBuilder orderLimitOffsetClause \u003d new StringBuilder();"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-java","patch_set":1,"id":"7a5de9d1_eba290fc","line":196,"range":{"start_line":196,"start_character":4,"end_line":196,"end_character":11},"updated":"2016-01-29 19:00:17.000000000","message":"So, is this the main issue where you are adding a close parenthesis to the where clause.\n\norderLimitOffsetClause is just  a name change from sortByClause.","commit_id":"02a198cc74be6fdbf3b437cb8c112ee8ad49af46"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"b8cbd1c65e0eee224b0a64a5460592908298d32f","unresolved":false,"context_lines":[{"line_number":193,"context_line":"      sbWhere.append(\" and a.state_updated_at \u003e\u003d :stateUpdatedStart\");"},{"line_number":194,"context_line":"    }"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    sbWhere.append(\")\");"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    StringBuilder orderLimitOffsetClause \u003d new StringBuilder();"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-java","patch_set":1,"id":"7a5de9d1_4b42c4af","line":196,"range":{"start_line":196,"start_character":4,"end_line":196,"end_character":11},"in_reply_to":"7a5de9d1_eba290fc","updated":"2016-01-29 19:19:19.000000000","message":"Yes, precisely","commit_id":"02a198cc74be6fdbf3b437cb8c112ee8ad49af46"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"7016c95d9626bc512568ac9452c7fc1e7bd8dc9f","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    if (sortBy !\u003d null \u0026\u0026 !sortBy.isEmpty()) {"},{"line_number":199,"context_line":"      int i \u003d 0;"},{"line_number":200,"context_line":"      for(String field: sortBy) {"},{"line_number":201,"context_line":"        // Convert friendly names to column names"},{"line_number":202,"context_line":"        if (field.contains(\"alarm_id\"))"},{"line_number":203,"context_line":"          sortBy.set(i, field.replace(\"alarm_id\", \"a.id\"));"}],"source_content_type":"text/x-java","patch_set":3,"id":"7a5de9d1_96dad815","line":200,"updated":"2016-02-01 19:04:14.000000000","message":"Should be a space after the for","commit_id":"3b1535ccf431874544b4faa426d5ebc3303f3846"}]}
