)]}'
{"monasca_api/v2/reference/helpers.py":[{"author":{"_account_id":12512,"name":"Deklan Dieterly","email":"deklan.dieterly@hpe.com","username":"deklan"},"change_message_id":"20ab5bcb096cc04a933b4e55e915e0de0fb5871b","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            if isinstance(dimensions_param, basestring):"},{"line_number":176,"context_line":"                dimensions_str_array \u003d dimensions_param.split(\u0027,\u0027)"},{"line_number":177,"context_line":"            else:"},{"line_number":178,"context_line":"                dimensions_str_array \u003d []"},{"line_number":179,"context_line":"                for sublist in dimensions_param:"},{"line_number":180,"context_line":"                    dimensions_str_array.extend(sublist.split(\",\"))"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_845509fb","line":178,"range":{"start_line":178,"start_character":16,"end_line":178,"end_character":36},"updated":"2016-01-29 20:17:12.000000000","message":"Would it be prudent to explicitly check if it is a sequence?","commit_id":"83d9cfee92923ce9212ca904f825460788d565a5"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"6243382ffe694a1d0c3824cdbb13a4908f73d0a1","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            if isinstance(dimensions_param, basestring):"},{"line_number":176,"context_line":"                dimensions_str_array \u003d dimensions_param.split(\u0027,\u0027)"},{"line_number":177,"context_line":"            else:"},{"line_number":178,"context_line":"                dimensions_str_array \u003d []"},{"line_number":179,"context_line":"                for sublist in dimensions_param:"},{"line_number":180,"context_line":"                    dimensions_str_array.extend(sublist.split(\",\"))"},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_f5c26933","line":178,"range":{"start_line":178,"start_character":16,"end_line":178,"end_character":36},"in_reply_to":"7a5de9d1_845509fb","updated":"2016-01-29 21:53:55.000000000","message":"It wouldn\u0027t hurt at least. I\u0027ll make it explicit","commit_id":"83d9cfee92923ce9212ca904f825460788d565a5"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"84f8abe897e6e00cb77e9acb539dc8e6cb88bd2e","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            elif isinstance(dimensions_param, list):"},{"line_number":178,"context_line":"                dimensions_str_array \u003d []"},{"line_number":179,"context_line":"                for sublist in dimensions_param:"},{"line_number":180,"context_line":"                    dimensions_str_array.extend(sublist.split(\",\"))"},{"line_number":181,"context_line":"            else:"},{"line_number":182,"context_line":"                raise Exception(\"Error parsing dimensions, unknown format\")"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_80e79eab","line":180,"range":{"start_line":180,"start_character":41,"end_line":180,"end_character":47},"updated":"2016-02-09 16:42:37.000000000","message":"If I\u0027m understanding this block correctly it should be functionally equivalent to the previous code other than the addition of the isinstance check.  If that is the case then the previous code should be more efficient.","commit_id":"5d369388b26bafd8383631473d033a74f1ade2cd"}]}