)]}'
{"monasca_tempest_tests/tests/api/test_metrics.py":[{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"a73eb64f806824a55596b504a556617da0237ca5","unresolved":false,"context_lines":[{"line_number":534,"context_line":"                            \"metrics \u003d 0\""},{"line_number":535,"context_line":"                self.fail(error_msg)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    def _create_metrics(self, same_name):"},{"line_number":538,"context_line":"        name1 \u003d data_utils.rand_name(\u0027name1\u0027)"},{"line_number":539,"context_line":"        if same_name:"},{"line_number":540,"context_line":"            name2 \u003d name3 \u003d name1"},{"line_number":541,"context_line":"        else:"},{"line_number":542,"context_line":"            name2 \u003d data_utils.rand_name(\u0027name2\u0027)"},{"line_number":543,"context_line":"            name3 \u003d data_utils.rand_name(\u0027name3\u0027)"},{"line_number":544,"context_line":"        key_service \u003d data_utils.rand_name(\u0027service\u0027)"},{"line_number":545,"context_line":"        values \u003d [data_utils.rand_name(\u0027value1\u0027),"},{"line_number":546,"context_line":"                  data_utils.rand_name(\u0027value2\u0027)]"},{"line_number":547,"context_line":"        metrics \u003d [helpers.create_metric(name1, {key_service: values[0]}),"},{"line_number":548,"context_line":"                   helpers.create_metric(name2, {key_service: values[1]}),"},{"line_number":549,"context_line":"                   helpers.create_metric(name3, {\u0027key3\u0027: \u0027value3\u0027})]"},{"line_number":550,"context_line":"        resp, response_body \u003d self.monasca_client.create_metrics(metrics)"},{"line_number":551,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":552,"context_line":"        return metrics, name1, key_service, values"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_e795cc86","line":552,"range":{"start_line":537,"start_character":4,"end_line":552,"end_character":50},"updated":"2016-02-05 22:28:45.000000000","message":"Wouldn\u0027t be better to extent the helpers module to support the generation of multiple metrics? In this way it could be re-used in other tests if needed.","commit_id":"5f072cb844ecb74484d4733fd258869f4341bdca"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"d8d2f4045450107e1366396cb371b4a423caa8ee","unresolved":false,"context_lines":[{"line_number":534,"context_line":"                            \"metrics \u003d 0\""},{"line_number":535,"context_line":"                self.fail(error_msg)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    def _create_metrics(self, same_name):"},{"line_number":538,"context_line":"        name1 \u003d data_utils.rand_name(\u0027name1\u0027)"},{"line_number":539,"context_line":"        if same_name:"},{"line_number":540,"context_line":"            name2 \u003d name3 \u003d name1"},{"line_number":541,"context_line":"        else:"},{"line_number":542,"context_line":"            name2 \u003d data_utils.rand_name(\u0027name2\u0027)"},{"line_number":543,"context_line":"            name3 \u003d data_utils.rand_name(\u0027name3\u0027)"},{"line_number":544,"context_line":"        key_service \u003d data_utils.rand_name(\u0027service\u0027)"},{"line_number":545,"context_line":"        values \u003d [data_utils.rand_name(\u0027value1\u0027),"},{"line_number":546,"context_line":"                  data_utils.rand_name(\u0027value2\u0027)]"},{"line_number":547,"context_line":"        metrics \u003d [helpers.create_metric(name1, {key_service: values[0]}),"},{"line_number":548,"context_line":"                   helpers.create_metric(name2, {key_service: values[1]}),"},{"line_number":549,"context_line":"                   helpers.create_metric(name3, {\u0027key3\u0027: \u0027value3\u0027})]"},{"line_number":550,"context_line":"        resp, response_body \u003d self.monasca_client.create_metrics(metrics)"},{"line_number":551,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":552,"context_line":"        return metrics, name1, key_service, values"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_f2bda6d8","line":552,"range":{"start_line":537,"start_character":4,"end_line":552,"end_character":50},"in_reply_to":"5a5ae5dd_e795cc86","updated":"2016-02-24 22:12:59.000000000","message":"Hello Fabio, sorry for taking so long to reply your comment. I agree with your idea and will patch a new set with the changes. Thank you!","commit_id":"5f072cb844ecb74484d4733fd258869f4341bdca"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"5440eac9ee7f9005759226c6c21c8b6d14659676","unresolved":false,"context_lines":[{"line_number":534,"context_line":"                            \"metrics \u003d 0\""},{"line_number":535,"context_line":"                self.fail(error_msg)"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"    def _create_metrics(self, same_name):"},{"line_number":538,"context_line":"        name1 \u003d data_utils.rand_name(\u0027name1\u0027)"},{"line_number":539,"context_line":"        if same_name:"},{"line_number":540,"context_line":"            name2 \u003d name3 \u003d name1"},{"line_number":541,"context_line":"        else:"},{"line_number":542,"context_line":"            name2 \u003d data_utils.rand_name(\u0027name2\u0027)"},{"line_number":543,"context_line":"            name3 \u003d data_utils.rand_name(\u0027name3\u0027)"},{"line_number":544,"context_line":"        key_service \u003d data_utils.rand_name(\u0027service\u0027)"},{"line_number":545,"context_line":"        values \u003d [data_utils.rand_name(\u0027value1\u0027),"},{"line_number":546,"context_line":"                  data_utils.rand_name(\u0027value2\u0027)]"},{"line_number":547,"context_line":"        metrics \u003d [helpers.create_metric(name1, {key_service: values[0]}),"},{"line_number":548,"context_line":"                   helpers.create_metric(name2, {key_service: values[1]}),"},{"line_number":549,"context_line":"                   helpers.create_metric(name3, {\u0027key3\u0027: \u0027value3\u0027})]"},{"line_number":550,"context_line":"        resp, response_body \u003d self.monasca_client.create_metrics(metrics)"},{"line_number":551,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":552,"context_line":"        return metrics, name1, key_service, values"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_f263e63f","line":552,"range":{"start_line":537,"start_character":4,"end_line":552,"end_character":50},"in_reply_to":"bae84128_f2bda6d8","updated":"2016-02-24 22:20:55.000000000","message":"With more thoughts on this one, I think I would keep this function here instead of moving to helpers for now. Because here I need to create three very specific metrics with the same or different names and specific different dimensions. I don\u0027t have any other tests need to call this function for now. If there are in the future, I will definitely move this function into the helpers. Thanks.","commit_id":"5f072cb844ecb74484d4733fd258869f4341bdca"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"5948e82e58fb7d30c5abd9a6734e6b196326b61d","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                   helpers.create_metric(name3, {\u0027key3\u0027: \u0027value3\u0027})]"},{"line_number":576,"context_line":"        resp, response_body \u003d self.monasca_client.create_metrics(metrics)"},{"line_number":577,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":578,"context_line":"        return metrics, name1, key_service, values"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_6f3c0b30","line":578,"range":{"start_line":578,"start_character":8,"end_line":578,"end_character":14},"updated":"2016-03-01 14:56:55.000000000","message":"Why not just return the metrics here? All the data should already be included in that.","commit_id":"4de7c60b285769acc4551d8a2feea39cdeafcdba"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"f309f4c7f4d42f7bd7f29d8601fe6c512ee3bbf0","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                   helpers.create_metric(name3, {\u0027key3\u0027: \u0027value3\u0027})]"},{"line_number":576,"context_line":"        resp, response_body \u003d self.monasca_client.create_metrics(metrics)"},{"line_number":577,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":578,"context_line":"        return metrics, name1, key_service, values"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_85879260","line":578,"range":{"start_line":578,"start_character":8,"end_line":578,"end_character":14},"in_reply_to":"7af24918_1952d567","updated":"2016-03-02 00:54:01.000000000","message":"It makes for a long line where its used, but I don\u0027t really feel too strongly about it","commit_id":"4de7c60b285769acc4551d8a2feea39cdeafcdba"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"f28a58363fe1d4d8fbf3cfb44aa560f2a353bd60","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                   helpers.create_metric(name3, {\u0027key3\u0027: \u0027value3\u0027})]"},{"line_number":576,"context_line":"        resp, response_body \u003d self.monasca_client.create_metrics(metrics)"},{"line_number":577,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":578,"context_line":"        return metrics, name1, key_service, values"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_1952d567","line":578,"range":{"start_line":578,"start_character":8,"end_line":578,"end_character":14},"in_reply_to":"7af24918_6f3c0b30","updated":"2016-03-01 23:31:16.000000000","message":"I think returning four values makes it easier when you try to use these four later separately. Also it will reduce some redundant code because this function has been called four times.","commit_id":"4de7c60b285769acc4551d8a2feea39cdeafcdba"}]}