)]}'
{"docs/monasca-api-spec.md":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6fd68e3d1dc79d649325727ea4c0c0edd299a45b","unresolved":false,"context_lines":[{"line_number":2367,"context_line":"####Path Parameters"},{"line_number":2368,"context_line":"None"},{"line_number":2369,"context_line":""},{"line_number":2370,"context_line":"####Query Parameters"},{"line_number":2371,"context_line":"* alarm_definition_id (string, optional) - Alarm definition ID to filter by."},{"line_number":2372,"context_line":"* metric_name (string(255), optional) - Name of metric to filter by."},{"line_number":2373,"context_line":"* metric_dimensions ({string(255): string(255)}, optional) - Dimensions of metrics to filter by specified as a comma separated array of (key, value) pairs as `key1:value1,key1:value1,...`"}],"source_content_type":"text/x-markdown","patch_set":11,"id":"9abb7d3a_e9c42b60","line":2370,"range":{"start_line":2370,"start_character":0,"end_line":2370,"end_character":20},"updated":"2016-05-31 04:23:34.000000000","message":"According to the code, severity is a possible Query Parameter, but it isn\u0027t listed here","commit_id":"b9ab8c610b00aee148ec5918e8c76d526403016b"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"a23ade4c92165ed5a6339dc2c9609e95c2ccfe36","unresolved":false,"context_lines":[{"line_number":2367,"context_line":"####Path Parameters"},{"line_number":2368,"context_line":"None"},{"line_number":2369,"context_line":""},{"line_number":2370,"context_line":"####Query Parameters"},{"line_number":2371,"context_line":"* alarm_definition_id (string, optional) - Alarm definition ID to filter by."},{"line_number":2372,"context_line":"* metric_name (string(255), optional) - Name of metric to filter by."},{"line_number":2373,"context_line":"* metric_dimensions ({string(255): string(255)}, optional) - Dimensions of metrics to filter by specified as a comma separated array of (key, value) pairs as `key1:value1,key1:value1,...`"}],"source_content_type":"text/x-markdown","patch_set":11,"id":"9abb7d3a_fcb8fe12","line":2370,"range":{"start_line":2370,"start_character":0,"end_line":2370,"end_character":20},"in_reply_to":"9abb7d3a_e9c42b60","updated":"2016-06-01 18:24:34.000000000","message":"Done","commit_id":"b9ab8c610b00aee148ec5918e8c76d526403016b"}],"java/src/main/java/monasca/api/app/validation/Validation.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"592e5f558405addc8b0ee2cd2634d1948f9558ac","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    List\u003cAlarmSeverity\u003e severityList \u003d null;"},{"line_number":246,"context_line":"    if (severityStr !\u003d null \u0026\u0026 !severityStr.isEmpty()) {"},{"line_number":247,"context_line":"      severityList \u003d new ArrayList\u003c\u003e();"},{"line_number":248,"context_line":"      List\u003cString\u003e severities \u003d Lists.newArrayList(Splitter.on(\u0027|\u0027)"},{"line_number":249,"context_line":"                                                       .omitEmptyStrings()"},{"line_number":250,"context_line":"                                                       .trimResults()"},{"line_number":251,"context_line":"                                                       .split(severityStr));"}],"source_content_type":"text/x-java","patch_set":4,"id":"1a122d0e_993580f8","line":248,"range":{"start_line":248,"start_character":51,"end_line":248,"end_character":67},"updated":"2016-04-29 20:51:14.000000000","message":"You know what I am going to say here :)","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"72444ad1fbc9084b005c442b9e5a7a4eeda920e4","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    List\u003cAlarmSeverity\u003e severityList \u003d null;"},{"line_number":246,"context_line":"    if (severityStr !\u003d null \u0026\u0026 !severityStr.isEmpty()) {"},{"line_number":247,"context_line":"      severityList \u003d new ArrayList\u003c\u003e();"},{"line_number":248,"context_line":"      List\u003cString\u003e severities \u003d Lists.newArrayList(Splitter.on(\u0027|\u0027)"},{"line_number":249,"context_line":"                                                       .omitEmptyStrings()"},{"line_number":250,"context_line":"                                                       .trimResults()"},{"line_number":251,"context_line":"                                                       .split(severityStr));"}],"source_content_type":"text/x-java","patch_set":4,"id":"1a122d0e_00054b13","line":248,"range":{"start_line":248,"start_character":51,"end_line":248,"end_character":67},"in_reply_to":"1a122d0e_993580f8","updated":"2016-05-03 20:50:48.000000000","message":"Done","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"}],"java/src/main/java/monasca/api/domain/model/alarmdefinition/AlarmDefinitionRepo.java":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"e43635cb574f5ed1d3f73d836ec20a87d6fa244c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"   * Returns alarms for the given criteria."},{"line_number":50,"context_line":"   */"},{"line_number":51,"context_line":"  List\u003cAlarmDefinition\u003e find(String tenantId, String name, Map\u003cString, String\u003e dimensions,"},{"line_number":52,"context_line":"                             List\u003cAlarmSeverity\u003e severity, List\u003cString\u003e sortBy, String offset,"},{"line_number":53,"context_line":"                             int limit);"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  /**"}],"source_content_type":"text/x-java","patch_set":6,"id":"1a122d0e_bd76ec3c","line":52,"range":{"start_line":52,"start_character":49,"end_line":52,"end_character":57},"updated":"2016-05-04 17:14:03.000000000","message":"do you want to change this to severities as you did in previous files.","commit_id":"4a6f3fa70720f1dd9669dbe22c5e042a4c94a701"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"2f938bc2d37d9af2ffd29496bd8c0892cc2bfd2d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"   * Returns alarms for the given criteria."},{"line_number":50,"context_line":"   */"},{"line_number":51,"context_line":"  List\u003cAlarmDefinition\u003e find(String tenantId, String name, Map\u003cString, String\u003e dimensions,"},{"line_number":52,"context_line":"                             List\u003cAlarmSeverity\u003e severity, List\u003cString\u003e sortBy, String offset,"},{"line_number":53,"context_line":"                             int limit);"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  /**"}],"source_content_type":"text/x-java","patch_set":6,"id":"1a122d0e_a67c1821","line":52,"range":{"start_line":52,"start_character":49,"end_line":52,"end_character":57},"in_reply_to":"1a122d0e_bd76ec3c","updated":"2016-05-04 20:25:45.000000000","message":"Done","commit_id":"4a6f3fa70720f1dd9669dbe22c5e042a4c94a701"}],"java/src/main/java/monasca/api/infrastructure/persistence/hibernate/AlarmDefinitionSqlRepoImpl.java":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"e43635cb574f5ed1d3f73d836ec20a87d6fa244c","unresolved":false,"context_lines":[{"line_number":228,"context_line":"  @Override"},{"line_number":229,"context_line":"  @SuppressWarnings(\"unchecked\")"},{"line_number":230,"context_line":"  public List\u003cAlarmDefinition\u003e find(String tenantId, String name, Map\u003cString, String\u003e dimensions,"},{"line_number":231,"context_line":"                                    List\u003cAlarmSeverity\u003e severity, List\u003cString\u003e sortBy,"},{"line_number":232,"context_line":"                                    String offset, int limit) {"},{"line_number":233,"context_line":"    logger.trace(ORM_LOG_MARKER, \"find(...) entering...\");"},{"line_number":234,"context_line":"    if (sortBy !\u003d null \u0026\u0026 !sortBy.isEmpty()) {"}],"source_content_type":"text/x-java","patch_set":6,"id":"1a122d0e_dda2c899","line":231,"range":{"start_line":231,"start_character":56,"end_line":231,"end_character":64},"updated":"2016-05-04 17:14:03.000000000","message":"same here for name","commit_id":"4a6f3fa70720f1dd9669dbe22c5e042a4c94a701"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"2f938bc2d37d9af2ffd29496bd8c0892cc2bfd2d","unresolved":false,"context_lines":[{"line_number":228,"context_line":"  @Override"},{"line_number":229,"context_line":"  @SuppressWarnings(\"unchecked\")"},{"line_number":230,"context_line":"  public List\u003cAlarmDefinition\u003e find(String tenantId, String name, Map\u003cString, String\u003e dimensions,"},{"line_number":231,"context_line":"                                    List\u003cAlarmSeverity\u003e severity, List\u003cString\u003e sortBy,"},{"line_number":232,"context_line":"                                    String offset, int limit) {"},{"line_number":233,"context_line":"    logger.trace(ORM_LOG_MARKER, \"find(...) entering...\");"},{"line_number":234,"context_line":"    if (sortBy !\u003d null \u0026\u0026 !sortBy.isEmpty()) {"}],"source_content_type":"text/x-java","patch_set":6,"id":"1a122d0e_66a7a0bc","line":231,"range":{"start_line":231,"start_character":56,"end_line":231,"end_character":64},"in_reply_to":"1a122d0e_dda2c899","updated":"2016-05-04 20:25:45.000000000","message":"Done","commit_id":"4a6f3fa70720f1dd9669dbe22c5e042a4c94a701"}],"java/src/main/java/monasca/api/infrastructure/persistence/mysql/AlarmDefinitionMySqlRepoImpl.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"592e5f558405addc8b0ee2cd2634d1948f9558ac","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  @SuppressWarnings(\"unchecked\")"},{"line_number":141,"context_line":"  @Override"},{"line_number":142,"context_line":"  public List\u003cAlarmDefinition\u003e find(String tenantId, String name,"},{"line_number":143,"context_line":"      Map\u003cString, String\u003e dimensions, List\u003cAlarmSeverity\u003e severity,"},{"line_number":144,"context_line":"      List\u003cString\u003e sortBy, String offset, int limit) {"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"1a122d0e_545baf21","line":143,"range":{"start_line":143,"start_character":58,"end_line":143,"end_character":66},"updated":"2016-04-29 20:51:14.000000000","message":"Maybe it would sense to rename this to severities since it can be more than one","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"72444ad1fbc9084b005c442b9e5a7a4eeda920e4","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  @SuppressWarnings(\"unchecked\")"},{"line_number":141,"context_line":"  @Override"},{"line_number":142,"context_line":"  public List\u003cAlarmDefinition\u003e find(String tenantId, String name,"},{"line_number":143,"context_line":"      Map\u003cString, String\u003e dimensions, List\u003cAlarmSeverity\u003e severity,"},{"line_number":144,"context_line":"      List\u003cString\u003e sortBy, String offset, int limit) {"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"1a122d0e_c3ad1dec","line":143,"range":{"start_line":143,"start_character":58,"end_line":143,"end_character":66},"in_reply_to":"1a122d0e_545baf21","updated":"2016-05-03 20:50:48.000000000","message":"Done","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"592e5f558405addc8b0ee2cd2634d1948f9558ac","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        q.bind(\"name\", name);"},{"line_number":211,"context_line":"      }"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"      if (severity !\u003d null \u0026\u0026 severity.size() \u003e 0) {"},{"line_number":214,"context_line":"        for (int i \u003d 0; i \u003c severity.size(); i++) {"},{"line_number":215,"context_line":"          q.bind(\"severity\" + String.valueOf(i), severity.get(i).name());"},{"line_number":216,"context_line":"        }"}],"source_content_type":"text/x-java","patch_set":4,"id":"1a122d0e_b475e398","line":213,"range":{"start_line":213,"start_character":30,"end_line":213,"end_character":49},"updated":"2016-04-29 20:51:14.000000000","message":"!severity.isEmpty()","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"72444ad1fbc9084b005c442b9e5a7a4eeda920e4","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        q.bind(\"name\", name);"},{"line_number":211,"context_line":"      }"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"      if (severity !\u003d null \u0026\u0026 severity.size() \u003e 0) {"},{"line_number":214,"context_line":"        for (int i \u003d 0; i \u003c severity.size(); i++) {"},{"line_number":215,"context_line":"          q.bind(\"severity\" + String.valueOf(i), severity.get(i).name());"},{"line_number":216,"context_line":"        }"}],"source_content_type":"text/x-java","patch_set":4,"id":"1a122d0e_4380ed49","line":213,"range":{"start_line":213,"start_character":30,"end_line":213,"end_character":49},"in_reply_to":"1a122d0e_b475e398","updated":"2016-05-03 20:50:48.000000000","message":"Done","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"}],"java/src/main/java/monasca/api/infrastructure/persistence/mysql/AlarmMySqlRepoImpl.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"592e5f558405addc8b0ee2cd2634d1948f9558ac","unresolved":false,"context_lines":[{"line_number":184,"context_line":"      sbWhere.append(\" and a.state \u003d :state\");"},{"line_number":185,"context_line":"    }"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    if (severity !\u003d null \u0026\u0026 !severity.isEmpty()) {"},{"line_number":188,"context_line":"      sbWhere.append(\" and (\");"},{"line_number":189,"context_line":"      for (int i \u003d 0; i \u003c severity.size(); i++) {"},{"line_number":190,"context_line":"        sbWhere.append(\"ad.severity \u003d :severity\").append(i);"},{"line_number":191,"context_line":"        if (i \u003c severity.size() - 1) {"},{"line_number":192,"context_line":"          sbWhere.append(\" or \");"},{"line_number":193,"context_line":"        }"},{"line_number":194,"context_line":"      }"},{"line_number":195,"context_line":"      sbWhere.append(\") \");"},{"line_number":196,"context_line":"    }"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    if (lifecycleState !\u003d null) {"},{"line_number":199,"context_line":"      sbWhere.append(\" and a.lifecycle_state \u003d :lifecycleState\");"}],"source_content_type":"text/x-java","patch_set":4,"id":"1a122d0e_74b7cb39","line":196,"range":{"start_line":187,"start_character":0,"end_line":196,"end_character":5},"updated":"2016-04-29 20:51:14.000000000","message":"Is there somewhere you could put this code so it can be reused? It exists twice.","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"}],"java/src/test/java/monasca/api/infrastructure/persistence/mysql/AlarmDefinitionMySqlRepositoryImplTest.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"592e5f558405addc8b0ee2cd2634d1948f9558ac","unresolved":false,"context_lines":[{"line_number":288,"context_line":"  public void shouldFindBySeverity() {"},{"line_number":289,"context_line":"    assertEquals(Arrays.asList(alarmDef_234), repo.find(\"bob\", null, null, Lists.newArrayList(AlarmSeverity.HIGH), null, null, 1));"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    assertEquals(0, repo.find(\"bob\", null, null, Lists.newArrayList(AlarmSeverity.CRITICAL), null, null, 1).size());"},{"line_number":292,"context_line":"  }"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"  public void shouldDeleteById() {"}],"source_content_type":"text/x-java","patch_set":4,"id":"1a122d0e_f4c75b95","line":291,"range":{"start_line":291,"start_character":0,"end_line":291,"end_character":116},"updated":"2016-04-29 20:51:14.000000000","message":"You should add a test of the multiple severities","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"72444ad1fbc9084b005c442b9e5a7a4eeda920e4","unresolved":false,"context_lines":[{"line_number":288,"context_line":"  public void shouldFindBySeverity() {"},{"line_number":289,"context_line":"    assertEquals(Arrays.asList(alarmDef_234), repo.find(\"bob\", null, null, Lists.newArrayList(AlarmSeverity.HIGH), null, null, 1));"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    assertEquals(0, repo.find(\"bob\", null, null, Lists.newArrayList(AlarmSeverity.CRITICAL), null, null, 1).size());"},{"line_number":292,"context_line":"  }"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"  public void shouldDeleteById() {"}],"source_content_type":"text/x-java","patch_set":4,"id":"1a122d0e_dd02f6b3","line":291,"range":{"start_line":291,"start_character":0,"end_line":291,"end_character":116},"in_reply_to":"1a122d0e_f4c75b95","updated":"2016-05-03 20:50:48.000000000","message":"Done","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"}],"monasca_api/common/repositories/mysql/alarm_definitions_repository.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"592e5f558405addc8b0ee2cd2634d1948f9558ac","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        if severity:"},{"line_number":93,"context_line":"            severities \u003d severity.split(\u0027|\u0027)"},{"line_number":94,"context_line":"            parms.extend([s.encode(\u0027utf8\u0027) for s in severities])"},{"line_number":95,"context_line":"            where_clause +\u003d \" and (\" + \" or \".join([\"ad.severity \u003d %s\" for s in severities])"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        if sort_by is not None:"},{"line_number":98,"context_line":"            order_by_clause \u003d \" order by ad.\" + \",ad.\".join(sort_by)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_f4559bc1","line":95,"range":{"start_line":95,"start_character":13,"end_line":95,"end_character":92},"updated":"2016-04-29 20:51:14.000000000","message":"I don\u0027t see the closing \u0027)\u0027 on this","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"}],"monasca_api/common/repositories/mysql/alarms_repository.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"592e5f558405addc8b0ee2cd2634d1948f9558ac","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        if \u0027state\u0027 in query_parms:"},{"line_number":268,"context_line":"            state \u003d query_parms[\u0027state\u0027].split(\u0027|\u0027)"},{"line_number":269,"context_line":"            parms.append([s.encode(\u0027utf8\u0027) for s in state])"},{"line_number":270,"context_line":"            where_clause +\u003d \" and (\" + \" or \".join([\"a.state \u003d %s \" for s in state]) + \")\""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        if \u0027severity\u0027 in query_parms:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_b42de347","line":269,"range":{"start_line":269,"start_character":18,"end_line":269,"end_character":24},"updated":"2016-04-29 20:51:14.000000000","message":"Shouldn\u0027t this be an extend, not append?","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"72444ad1fbc9084b005c442b9e5a7a4eeda920e4","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        if \u0027state\u0027 in query_parms:"},{"line_number":268,"context_line":"            state \u003d query_parms[\u0027state\u0027].split(\u0027|\u0027)"},{"line_number":269,"context_line":"            parms.append([s.encode(\u0027utf8\u0027) for s in state])"},{"line_number":270,"context_line":"            where_clause +\u003d \" and (\" + \" or \".join([\"a.state \u003d %s \" for s in state]) + \")\""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        if \u0027severity\u0027 in query_parms:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_5d25465a","line":269,"range":{"start_line":269,"start_character":18,"end_line":269,"end_character":24},"in_reply_to":"1a122d0e_b42de347","updated":"2016-05-03 20:50:48.000000000","message":"Removing the multiple state option","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"e43635cb574f5ed1d3f73d836ec20a87d6fa244c","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            sub_query +\u003d \" and a.state \u003d %s \""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        if \u0027severity\u0027 in query_parms:"},{"line_number":272,"context_line":"            severity \u003d query_parms[\u0027severity\u0027].split(\u0027|\u0027)"},{"line_number":273,"context_line":"            parms.extend([s.encode(\u0027utf8\u0027) for s in severity])"},{"line_number":274,"context_line":"            sub_query +\u003d \" and (\" + \" or \".join([\"ad.severity \u003d %s\" for s in severity]) + \")\""},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_f05c0b1b","line":272,"range":{"start_line":272,"start_character":12,"end_line":272,"end_character":20},"updated":"2016-05-04 17:14:03.000000000","message":"severities","commit_id":"4a6f3fa70720f1dd9669dbe22c5e042a4c94a701"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"2f938bc2d37d9af2ffd29496bd8c0892cc2bfd2d","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            sub_query +\u003d \" and a.state \u003d %s \""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        if \u0027severity\u0027 in query_parms:"},{"line_number":272,"context_line":"            severity \u003d query_parms[\u0027severity\u0027].split(\u0027|\u0027)"},{"line_number":273,"context_line":"            parms.extend([s.encode(\u0027utf8\u0027) for s in severity])"},{"line_number":274,"context_line":"            sub_query +\u003d \" and (\" + \" or \".join([\"ad.severity \u003d %s\" for s in severity]) + \")\""},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_c97a05ba","line":272,"range":{"start_line":272,"start_character":12,"end_line":272,"end_character":20},"in_reply_to":"1a122d0e_f05c0b1b","updated":"2016-05-04 20:25:45.000000000","message":"Done","commit_id":"4a6f3fa70720f1dd9669dbe22c5e042a4c94a701"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6fd68e3d1dc79d649325727ea4c0c0edd299a45b","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        where_clause \u003d \" where ad.tenant_id \u003d %s \""},{"line_number":421,"context_line":"        parms.append(tenant_id)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        if \u0027alarm_definition_id\u0027 in query_parms:"},{"line_number":424,"context_line":"            parms.append(query_parms[\u0027alarm_definition_id\u0027])"},{"line_number":425,"context_line":"            where_clause +\u003d \" and ad.id \u003d %s \""},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_29e113d1","line":423,"range":{"start_line":423,"start_character":8,"end_line":423,"end_character":48},"updated":"2016-05-31 04:23:34.000000000","message":"The java alarm count resources allows severities as a query parameter","commit_id":"b9ab8c610b00aee148ec5918e8c76d526403016b"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"42d808060d6e004b6359e345b7a27e953f6ca342","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            where_clause +\u003d \" and a.state \u003d %s \""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"        if \u0027severity\u0027 in query_parms:"},{"line_number":432,"context_line":"            parms.append(query_parms[\u0027severity\u0027].encode(\u0027utf8\u0027))"},{"line_number":433,"context_line":"            where_clause +\u003d \" and ad.severity \u003d %s \""},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        if \u0027lifecycle_state\u0027 in query_parms:"},{"line_number":436,"context_line":"            parms.append(query_parms[\u0027lifecycle_state\u0027].encode(\u0027utf8\u0027))"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_089b5873","line":433,"range":{"start_line":432,"start_character":0,"end_line":433,"end_character":52},"updated":"2016-06-07 16:56:00.000000000","message":"Shouldn\u0027t severity be handled like it is in get_alarms()? The java code allows the multiple severities for alarm counts","commit_id":"908275faaae8fe4ed1f052fa6803911c0ebebd5d"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"2d8ec4fb970ce15d9fc63102f0a3ef8760619237","unresolved":false,"context_lines":[{"line_number":429,"context_line":"            where_clause +\u003d \" and a.state \u003d %s \""},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"        if \u0027severity\u0027 in query_parms:"},{"line_number":432,"context_line":"            parms.append(query_parms[\u0027severity\u0027].encode(\u0027utf8\u0027))"},{"line_number":433,"context_line":"            where_clause +\u003d \" and ad.severity \u003d %s \""},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"        if \u0027lifecycle_state\u0027 in query_parms:"},{"line_number":436,"context_line":"            parms.append(query_parms[\u0027lifecycle_state\u0027].encode(\u0027utf8\u0027))"}],"source_content_type":"text/x-python","patch_set":12,"id":"7aa08908_cc7152aa","line":433,"range":{"start_line":432,"start_character":0,"end_line":433,"end_character":52},"in_reply_to":"7aa08908_089b5873","updated":"2016-06-07 22:49:04.000000000","message":"Done","commit_id":"908275faaae8fe4ed1f052fa6803911c0ebebd5d"}],"monasca_api/common/repositories/sqla/alarm_definitions_repository.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"33b934a15804ba4c0d656d0e1ebd2d17af3d1939","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014,2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"# Copyright 2016 FUJITSU LIMITED"},{"line_number":3,"context_line":"# (C) Copyright 2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_0d031fb9","line":3,"range":{"start_line":3,"start_character":20,"end_line":3,"end_character":21},"updated":"2016-05-23 04:09:31.000000000","message":"I think that copyright is already here.","commit_id":"ca35b16b39e56df4e39f4e52509c1ec3bbcce9f1"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"9442d6256c22c5ba245e4585704bd440f4b6c2f3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014,2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"# Copyright 2016 FUJITSU LIMITED"},{"line_number":3,"context_line":"# (C) Copyright 2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_959ed060","line":3,"range":{"start_line":3,"start_character":20,"end_line":3,"end_character":21},"in_reply_to":"bab6814e_0d031fb9","updated":"2016-05-23 15:56:38.000000000","message":"Yes, you\u0027re right. Thanks","commit_id":"ca35b16b39e56df4e39f4e52509c1ec3bbcce9f1"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"21edf2ac3a2936e018f7f186c77043712789c6bf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014,2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"# Copyright 2016 FUJITSU LIMITED"},{"line_number":3,"context_line":"# (C) Copyright 2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_6fa14d46","line":3,"range":{"start_line":3,"start_character":29,"end_line":3,"end_character":36},"updated":"2016-05-25 22:02:19.000000000","message":"dont need both copyrights","commit_id":"ea46bb20dd3425fcd0c92fc4c3fd90ee2257c1b7"}],"monasca_api/common/repositories/sqla/alarms_repository.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6fd68e3d1dc79d649325727ea4c0c0edd299a45b","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                parms[\u0027b_md_name\u0027] \u003d query_parms[\u0027metric_name\u0027].encode(\u0027utf8\u0027)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"            if \u0027severity\u0027 in query_parms:"},{"line_number":289,"context_line":"                severities \u003d query_parms[\u0027severity\u0027].split(\u0027|\u0027)"},{"line_number":290,"context_line":"                query \u003d query.where("},{"line_number":291,"context_line":"                    or_(ad.c.severity \u003d\u003d bindparam(\u0027b_severity\u0027 + str(i)) for i in xrange(len(severities))))"},{"line_number":292,"context_line":"                for i, s in enumerate(severities):"},{"line_number":293,"context_line":"                    parms[\u0027b_severity\u0027 + str(i)] \u003d s.encode(\u0027utf8\u0027)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"            if \u0027state\u0027 in query_parms:"},{"line_number":296,"context_line":"                query \u003d query.where(a.c.state \u003d\u003d bindparam(\u0027b_state\u0027))"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_a9f4e386","line":293,"range":{"start_line":289,"start_character":0,"end_line":293,"end_character":67},"updated":"2016-05-31 04:23:34.000000000","message":"This code is duplicated 3 times","commit_id":"b9ab8c610b00aee148ec5918e8c76d526403016b"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"a23ade4c92165ed5a6339dc2c9609e95c2ccfe36","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                parms[\u0027b_md_name\u0027] \u003d query_parms[\u0027metric_name\u0027].encode(\u0027utf8\u0027)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"            if \u0027severity\u0027 in query_parms:"},{"line_number":289,"context_line":"                severities \u003d query_parms[\u0027severity\u0027].split(\u0027|\u0027)"},{"line_number":290,"context_line":"                query \u003d query.where("},{"line_number":291,"context_line":"                    or_(ad.c.severity \u003d\u003d bindparam(\u0027b_severity\u0027 + str(i)) for i in xrange(len(severities))))"},{"line_number":292,"context_line":"                for i, s in enumerate(severities):"},{"line_number":293,"context_line":"                    parms[\u0027b_severity\u0027 + str(i)] \u003d s.encode(\u0027utf8\u0027)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"            if \u0027state\u0027 in query_parms:"},{"line_number":296,"context_line":"                query \u003d query.where(a.c.state \u003d\u003d bindparam(\u0027b_state\u0027))"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_07c00a4f","line":293,"range":{"start_line":289,"start_character":0,"end_line":293,"end_character":67},"in_reply_to":"9abb7d3a_a9f4e386","updated":"2016-06-01 18:24:34.000000000","message":"I think there is enough of this code that should be cleaned up we should consider doing it separately.","commit_id":"b9ab8c610b00aee148ec5918e8c76d526403016b"}],"monasca_api/v2/common/validation.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"592e5f558405addc8b0ee2cd2634d1948f9558ac","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    for state in states:"},{"line_number":113,"context_line":"        if state not in VALID_ALARM_STATES:"},{"line_number":114,"context_line":"            raise HTTPUnprocessableEntityError(\"Unprocessable Entity\","},{"line_number":115,"context_line":"                                               \"state {} must be one of \u0027ALARM\u0027,\u0027OK\u0027,\u0027UNDETERMINED\u0027\".format(state))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"def validate_severity_query(severity_str):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_b4a203ac","line":115,"range":{"start_line":115,"start_character":73,"end_line":115,"end_character":99},"updated":"2016-04-29 20:51:14.000000000","message":"It would be nice if this message was built from VALID_ALARM_STATES instead of duplicating the values","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"72444ad1fbc9084b005c442b9e5a7a4eeda920e4","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    for state in states:"},{"line_number":113,"context_line":"        if state not in VALID_ALARM_STATES:"},{"line_number":114,"context_line":"            raise HTTPUnprocessableEntityError(\"Unprocessable Entity\","},{"line_number":115,"context_line":"                                               \"state {} must be one of \u0027ALARM\u0027,\u0027OK\u0027,\u0027UNDETERMINED\u0027\".format(state))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"def validate_severity_query(severity_str):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_5ddc2646","line":115,"range":{"start_line":115,"start_character":73,"end_line":115,"end_character":99},"in_reply_to":"1a122d0e_b4a203ac","updated":"2016-05-03 20:50:48.000000000","message":"removed the multiple state option","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"592e5f558405addc8b0ee2cd2634d1948f9558ac","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        if severity not in VALID_ALARM_DEFINITION_SEVERITIES:"},{"line_number":122,"context_line":"            raise HTTPUnprocessableEntityError("},{"line_number":123,"context_line":"                \"Unprocessable Entity\","},{"line_number":124,"context_line":"                \"severity {} must be one of \u0027CRITICAL\u0027,\u0027HIGH\u0027,\u0027MEDIUM\u0027,\u0027LOW\u0027\".format(severity))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_1492d756","line":124,"range":{"start_line":124,"start_character":44,"end_line":124,"end_character":77},"updated":"2016-04-29 20:51:14.000000000","message":"It would be nice if this message was built from VALID_ALARM_DEFINITION_SEVERITIES instead of duplicating the values","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"72444ad1fbc9084b005c442b9e5a7a4eeda920e4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        if severity not in VALID_ALARM_DEFINITION_SEVERITIES:"},{"line_number":122,"context_line":"            raise HTTPUnprocessableEntityError("},{"line_number":123,"context_line":"                \"Unprocessable Entity\","},{"line_number":124,"context_line":"                \"severity {} must be one of \u0027CRITICAL\u0027,\u0027HIGH\u0027,\u0027MEDIUM\u0027,\u0027LOW\u0027\".format(severity))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_3ddfaa3b","line":124,"range":{"start_line":124,"start_character":44,"end_line":124,"end_character":77},"in_reply_to":"1a122d0e_1492d756","updated":"2016-05-03 20:50:48.000000000","message":"Done","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"}],"monasca_tempest_tests/tests/api/test_alarms.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"592e5f558405addc8b0ee2cd2634d1948f9558ac","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            self.assertIn(alarm[\u0027alarm_definition\u0027][\u0027severity\u0027], [\u0027HIGH\u0027, \u0027CRITICAL\u0027])"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":363,"context_line":"    def test_list_alarms_by_lifecycle_state(self):"},{"line_number":364,"context_line":"        alarm_definition_ids, expected_metric \\"},{"line_number":365,"context_line":"            \u003d self._create_alarms_for_test_alarms(num\u003d1)"},{"line_number":366,"context_line":"        query_param \u003d \u0027?alarm_definition_id\u003d\u0027 + str(alarm_definition_ids[0])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_14a0178f","line":363,"range":{"start_line":363,"start_character":8,"end_line":363,"end_character":43},"updated":"2016-04-29 20:51:14.000000000","message":"Shouldn\u0027t you add test_list_alarms_by_state_multiple_values","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"72444ad1fbc9084b005c442b9e5a7a4eeda920e4","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            self.assertIn(alarm[\u0027alarm_definition\u0027][\u0027severity\u0027], [\u0027HIGH\u0027, \u0027CRITICAL\u0027])"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":363,"context_line":"    def test_list_alarms_by_lifecycle_state(self):"},{"line_number":364,"context_line":"        alarm_definition_ids, expected_metric \\"},{"line_number":365,"context_line":"            \u003d self._create_alarms_for_test_alarms(num\u003d1)"},{"line_number":366,"context_line":"        query_param \u003d \u0027?alarm_definition_id\u003d\u0027 + str(alarm_definition_ids[0])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_9de6be14","line":363,"range":{"start_line":363,"start_character":8,"end_line":363,"end_character":43},"in_reply_to":"1a122d0e_14a0178f","updated":"2016-05-03 20:50:48.000000000","message":"removed the multiple state option","commit_id":"996afc87e2066ed37d61670fad52ad331fb5ffe0"}]}