)]}'
{"monasca_api/common/repositories/mysql/alarms_repository.py":[{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"eb85723da9721cedc1f701298b064eceda63c5c2","unresolved":false,"context_lines":[{"line_number":331,"context_line":"                              # use custom ordering instead of alphanumeric"},{"line_number":332,"context_line":"                              \u0027severity\u0027: \u0027FIELD(severity, \"LOW\", \"MEDIUM\", \"HIGH\", \"CRITICAL\")\u0027,"},{"line_number":333,"context_line":"                              \u0027state\u0027: \u0027FIELD(state, \"OK\", \"UNDETERMINED\", \"ALARM\")\u0027}"},{"line_number":334,"context_line":"            received_cols \u003d []"},{"line_number":335,"context_line":"            order_columns \u003d []"},{"line_number":336,"context_line":"            for col in query_parms[\u0027sort_by\u0027]:"},{"line_number":337,"context_line":"                col_values \u003d col.split()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_7e646c21","line":334,"range":{"start_line":334,"start_character":12,"end_line":334,"end_character":25},"updated":"2016-02-16 16:47:10.000000000","message":"\u0027received_columns\u0027 could be replaced with a simple boolean flag","commit_id":"583b177e359c33d87f4d6c2d84f4e1202411dd35"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"eb85723da9721cedc1f701298b064eceda63c5c2","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        if \u0027sort_by\u0027 in query_parms:"},{"line_number":323,"context_line":"            # Convert friendly names to column names"},{"line_number":324,"context_line":"            columns_mapper \u003d {\u0027alarm_id\u0027: \u0027a.id\u0027,"},{"line_number":325,"context_line":"                              \u0027alarm_definition_id\u0027: \u0027ad.id\u0027,"},{"line_number":326,"context_line":"                              \u0027alarm_definition_name\u0027: \u0027ad.name\u0027,"},{"line_number":327,"context_line":"                              # check this here to avoid conflict with updated_timestamp"},{"line_number":328,"context_line":"                              \u0027state_updated_timestamp\u0027: \u0027a.state_updated_at\u0027,"},{"line_number":329,"context_line":"                              \u0027updated_timestamp\u0027: \u0027a.updated_at\u0027,"},{"line_number":330,"context_line":"                              \u0027created_timestamp\u0027: \u0027a.created_at\u0027,"},{"line_number":331,"context_line":"                              # use custom ordering instead of alphanumeric"},{"line_number":332,"context_line":"                              \u0027severity\u0027: \u0027FIELD(severity, \"LOW\", \"MEDIUM\", \"HIGH\", \"CRITICAL\")\u0027,"},{"line_number":333,"context_line":"                              \u0027state\u0027: \u0027FIELD(state, \"OK\", \"UNDETERMINED\", \"ALARM\")\u0027}"},{"line_number":334,"context_line":"            received_cols \u003d []"},{"line_number":335,"context_line":"            order_columns \u003d []"},{"line_number":336,"context_line":"            for col in query_parms[\u0027sort_by\u0027]:"},{"line_number":337,"context_line":"                col_values \u003d col.split()"},{"line_number":338,"context_line":"                col_name \u003d col_values[0]"},{"line_number":339,"context_line":"                order_column \u003d columns_mapper.get(col_name, col_name)"},{"line_number":340,"context_line":"                if len(col_values) \u003e 1:"},{"line_number":341,"context_line":"                    mode \u003d col_values[1]"},{"line_number":342,"context_line":"                    if mode and mode.lower() \u003d\u003d \u0027asc\u0027:"},{"line_number":343,"context_line":"                        order_column \u003d \"{} asc\".format(order_column)"},{"line_number":344,"context_line":"                    elif mode and mode.lower() \u003d\u003d \u0027desc\u0027:"},{"line_number":345,"context_line":"                        order_column \u003d \"{} desc\".format(order_column)"},{"line_number":346,"context_line":"                order_columns.append(order_column)"},{"line_number":347,"context_line":"                received_cols.append(col_name)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"            if \u0027alarm_id\u0027 not in received_cols:"},{"line_number":350,"context_line":"                order_columns.append(\u0027a.id\u0027)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"            order_by_clause \u003d \" order by {} \".format(\u0027,\u0027.join(order_columns))"},{"line_number":353,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_c1103904","line":350,"range":{"start_line":324,"start_character":12,"end_line":350,"end_character":44},"updated":"2016-02-16 16:47:10.000000000","message":"I would prefer to see the column replacement code in a separate method for readability.","commit_id":"583b177e359c33d87f4d6c2d84f4e1202411dd35"}]}