)]}'
{"monasca_api/v2/reference/helpers.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"46afbf60ab24bbaa360946e42ab226f86ef242f3","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        if \u0027id\u0027 in resource[limit - 1]:"},{"line_number":327,"context_line":"            new_offset \u003d resource[limit - 1][\u0027id\u0027]"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        if ((parsed_uri.path.find(\"alarm-definitions\") \u003e\u003d 0) or"},{"line_number":330,"context_line":"                (re.search(\"alarms$\", parsed_uri.path) is not None)):"},{"line_number":331,"context_line":"            old_offset \u003d 0"},{"line_number":332,"context_line":"            for param in old_query_params:"},{"line_number":333,"context_line":"                if param.find(\u0027offset\u0027) \u003e\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a3a1ecab","line":330,"range":{"start_line":329,"start_character":0,"end_line":330,"end_character":69},"updated":"2016-03-08 00:10:00.000000000","message":"This seems like a fragile way to make this decision. The code that calls paginate should specify what to use to create the new_offset. This code uses the uri to determine who is calling it and that makes it harder to add a new resource that uses ints for the offset.\n\nI also believe the same for using id vs timstamp. I know you didn\u0027t code that, but it might be good to fix that at the same time","commit_id":"fd39131cade06d7e045210721275c21e83bc33b4"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"bbc6d0513586497996f00263dd88ff4fb24ab341","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        if \u0027id\u0027 in resource[limit - 1]:"},{"line_number":327,"context_line":"            new_offset \u003d resource[limit - 1][\u0027id\u0027]"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        if ((parsed_uri.path.find(\"alarm-definitions\") \u003e\u003d 0) or"},{"line_number":330,"context_line":"                (re.search(\"alarms$\", parsed_uri.path) is not None)):"},{"line_number":331,"context_line":"            old_offset \u003d 0"},{"line_number":332,"context_line":"            for param in old_query_params:"},{"line_number":333,"context_line":"                if param.find(\u0027offset\u0027) \u003e\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_04f6e68e","line":330,"range":{"start_line":329,"start_character":0,"end_line":330,"end_character":69},"in_reply_to":"5aef4532_a3a1ecab","updated":"2016-03-08 02:00:30.000000000","message":"Done","commit_id":"fd39131cade06d7e045210721275c21e83bc33b4"}]}