)]}'
{"devstack/files/monasca-api/api-config.yml":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"790a47c085620b38f717f9245291a701e57f9085","unresolved":false,"context_lines":[{"line_number":24,"context_line":"accessedViaHttps: false"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Whether a database hint should be provided for queries"},{"line_number":27,"context_line":"provideDbHint: false"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Topic for publishing metrics to"},{"line_number":30,"context_line":"metricsTopic: metrics"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dab17558_ce2f12f5","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":13},"updated":"2016-05-06 03:55:34.000000000","message":"The change is really straight-forward. My only comment is whether you should have the hint specified in the config/yaml file, which would provide room to add additional hints in the future.\n\nSo, rather than have a boolean in the yaml/config file to enable/disable the hard-coded hint in the code, specify the hint the the yaml/config file so that you could add more hints in the future.\n\nBTW, my understanding from earlier on of the hint is that it is for fully replicating the data across the cluster. Is all the data fully replicated, as in the measurements table too, or are only the definitions, dimensions and def_dims tables replicated. The measurements table is huge, and I was assuming based on the earlier discussions with them that it was not fully replicated across the DB.","commit_id":"9c16341cf1975e5e7f1e47b4d571eab49920cd30"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"337b7f27dfa05e587ab71780ba99c0b2d71516c0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"accessedViaHttps: false"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Whether a database hint should be provided for queries"},{"line_number":27,"context_line":"provideDbHint: false"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Topic for publishing metrics to"},{"line_number":30,"context_line":"metricsTopic: metrics"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_8b7181ab","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":20},"updated":"2016-05-02 18:38:54.000000000","message":"This seems like a Vertica specific property, should it be in that section?","commit_id":"9c16341cf1975e5e7f1e47b4d571eab49920cd30"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"f44f70c27b2e1da904d6fbd543c2615fc1c01aea","unresolved":false,"context_lines":[{"line_number":24,"context_line":"accessedViaHttps: false"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Whether a database hint should be provided for queries"},{"line_number":27,"context_line":"provideDbHint: false"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Topic for publishing metrics to"},{"line_number":30,"context_line":"metricsTopic: metrics"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_eef0dacb","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":20},"in_reply_to":"1a122d0e_8b7181ab","updated":"2016-05-03 20:38:20.000000000","message":"good point -- will move to vertica related section.","commit_id":"9c16341cf1975e5e7f1e47b4d571eab49920cd30"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"e1a05565eadf9eb3bbb236b9c989618fe813e79e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"accessedViaHttps: false"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Whether a database hint should be provided for queries"},{"line_number":27,"context_line":"provideDbHint: false"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Topic for publishing metrics to"},{"line_number":30,"context_line":"metricsTopic: metrics"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_4ea10e46","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":20},"in_reply_to":"1a122d0e_eef0dacb","updated":"2016-05-03 20:47:24.000000000","message":"It might be really hard to move this into the vertica section because that class is a dropwizard class, so if it is too yucky don\u0027t do it.","commit_id":"9c16341cf1975e5e7f1e47b4d571eab49920cd30"}],"java/src/main/java/monasca/api/ApiConfig.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"337b7f27dfa05e587ab71780ba99c0b2d71516c0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  public String region;"},{"line_number":35,"context_line":"  @NotNull"},{"line_number":36,"context_line":"  public Boolean accessedViaHttps;"},{"line_number":37,"context_line":"  @NotNull"},{"line_number":38,"context_line":"  public Boolean provideDbHint \u003d false;"},{"line_number":39,"context_line":"  @NotEmpty"},{"line_number":40,"context_line":"  public String metricsTopic \u003d \"metrics\";"}],"source_content_type":"text/x-java","patch_set":4,"id":"1a122d0e_6b9985d0","line":37,"range":{"start_line":37,"start_character":2,"end_line":37,"end_character":10},"updated":"2016-05-02 18:38:54.000000000","message":"The issue that I see here is that if you place the new jar on a system with an old config file, the API will fail to start because of NotNull","commit_id":"9c16341cf1975e5e7f1e47b4d571eab49920cd30"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"f44f70c27b2e1da904d6fbd543c2615fc1c01aea","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  public String region;"},{"line_number":35,"context_line":"  @NotNull"},{"line_number":36,"context_line":"  public Boolean accessedViaHttps;"},{"line_number":37,"context_line":"  @NotNull"},{"line_number":38,"context_line":"  public Boolean provideDbHint \u003d false;"},{"line_number":39,"context_line":"  @NotEmpty"},{"line_number":40,"context_line":"  public String metricsTopic \u003d \"metrics\";"}],"source_content_type":"text/x-java","patch_set":4,"id":"1a122d0e_aecd4288","line":37,"range":{"start_line":37,"start_character":2,"end_line":37,"end_character":10},"in_reply_to":"1a122d0e_6b9985d0","updated":"2016-05-03 20:38:20.000000000","message":"yup - i believe you are correct, will remove the annotation.","commit_id":"9c16341cf1975e5e7f1e47b4d571eab49920cd30"}],"java/src/main/java/monasca/api/infrastructure/persistence/vertica/MeasurementVerticaRepoImpl.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"337b7f27dfa05e587ab71780ba99c0b2d71516c0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      @Named(\"vertica\") DBI db, ApiConfig config)"},{"line_number":90,"context_line":"  {"},{"line_number":91,"context_line":"    this.db \u003d db;"},{"line_number":92,"context_line":"    this.dbHint \u003d config.provideDbHint ? \"/*+KV(01)*/\" : \"\";"},{"line_number":93,"context_line":"  }"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  @Override"}],"source_content_type":"text/x-java","patch_set":4,"id":"1a122d0e_aba39dff","line":92,"range":{"start_line":92,"start_character":4,"end_line":92,"end_character":60},"updated":"2016-05-02 18:38:54.000000000","message":"This code is duplicated in the Vertica files. Isn\u0027t there some place this could be placed as utility method?","commit_id":"9c16341cf1975e5e7f1e47b4d571eab49920cd30"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"f44f70c27b2e1da904d6fbd543c2615fc1c01aea","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      @Named(\"vertica\") DBI db, ApiConfig config)"},{"line_number":90,"context_line":"  {"},{"line_number":91,"context_line":"    this.db \u003d db;"},{"line_number":92,"context_line":"    this.dbHint \u003d config.provideDbHint ? \"/*+KV(01)*/\" : \"\";"},{"line_number":93,"context_line":"  }"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"  @Override"}],"source_content_type":"text/x-java","patch_set":4,"id":"1a122d0e_0ea396b2","line":92,"range":{"start_line":92,"start_character":4,"end_line":92,"end_character":60},"in_reply_to":"1a122d0e_aba39dff","updated":"2016-05-03 20:38:20.000000000","message":"good catch, will find a central place to stick this","commit_id":"9c16341cf1975e5e7f1e47b4d571eab49920cd30"}]}