)]}'
{"java/src/main/java/monasca/api/infrastructure/persistence/vertica/AlarmStateHistoryVerticaRepoImpl.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"b54fcfecaff3f77bcbc85c9a61af21be38d0fcd6","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"      if (offset !\u003d null \u0026\u0026 !offset.isEmpty()) {"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        DateTime offset_dt \u003d new DateTime(offset);"},{"line_number":133,"context_line":"        verticaQuery.bind(\"offset\", formatDateFromMillis(offset_dt.getMillis()));"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":2,"id":"fa0719c6_ecff1aa8","line":132,"range":{"start_line":132,"start_character":8,"end_line":132,"end_character":16},"updated":"2016-03-23 01:16:54.000000000","message":"There is a possible problem in that the offset that is sent in as a query parameter is not a valid iso8601 timestamp. Therefore, the constructor to the DateTime object can raise an exception, such as IllegalArgumentException. Unfortunately, the offset isn\u0027t validated in the resource, and I\u0027m not sure that is the correct place, as the offset could be a different type, based on the database, such as Vertica or InfluxDB. \n\nProbably, best to add a try/catch block an throw\n\n      throw Exceptions.unprocessableEntity(\"...\")","commit_id":"250facd3b3f999d0c37bcc217702af09eb105454"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"ff06950189bce62d9917d41061a4738974f70c67","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"      if (offset !\u003d null \u0026\u0026 !offset.isEmpty()) {"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        DateTime offset_dt \u003d new DateTime(offset);"},{"line_number":133,"context_line":"        verticaQuery.bind(\"offset\", formatDateFromMillis(offset_dt.getMillis()));"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":2,"id":"fa0719c6_c73b0fd0","line":132,"range":{"start_line":132,"start_character":8,"end_line":132,"end_character":16},"in_reply_to":"fa0719c6_ecff1aa8","updated":"2016-03-23 01:43:10.000000000","message":"Good point! Thanks Roland","commit_id":"250facd3b3f999d0c37bcc217702af09eb105454"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"b54fcfecaff3f77bcbc85c9a61af21be38d0fcd6","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    if (startTime !\u003d null) {"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"      sb.append(\" and time_stamp \u003e :startTime\");"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    }"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"fa0719c6_8c277e63","line":194,"range":{"start_line":194,"start_character":33,"end_line":194,"end_character":34},"updated":"2016-03-23 01:16:54.000000000","message":"Why did you change fomr \u003e\u003d to \u003e?","commit_id":"250facd3b3f999d0c37bcc217702af09eb105454"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"ff06950189bce62d9917d41061a4738974f70c67","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    if (startTime !\u003d null) {"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"      sb.append(\" and time_stamp \u003e :startTime\");"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    }"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"fa0719c6_872117a2","line":194,"range":{"start_line":194,"start_character":33,"end_line":194,"end_character":34},"in_reply_to":"fa0719c6_8c277e63","updated":"2016-03-23 01:43:10.000000000","message":"It\u0027s \u003e instead of \u003e\u003d with influxdb and also our tempest test hmmm.","commit_id":"250facd3b3f999d0c37bcc217702af09eb105454"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"b54fcfecaff3f77bcbc85c9a61af21be38d0fcd6","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    if (endTime !\u003d null) {"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"      sb.append(\" and time_stamp \u003c :endTime\");"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    }"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"fa0719c6_6c2aea2d","line":200,"range":{"start_line":200,"start_character":22,"end_line":200,"end_character":32},"updated":"2016-03-23 01:16:54.000000000","message":"Same comment as above.","commit_id":"250facd3b3f999d0c37bcc217702af09eb105454"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"b54fcfecaff3f77bcbc85c9a61af21be38d0fcd6","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        logger.debug(\"binding offset: {}\", offset);"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        DateTime offset_dt \u003d new DateTime(offset);"},{"line_number":246,"context_line":"        verticaQuery.bind(\"offset\", formatDateFromMillis(offset_dt.getMillis()));"},{"line_number":247,"context_line":"        "},{"line_number":248,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":2,"id":"fa0719c6_cc21764f","line":245,"range":{"start_line":245,"start_character":17,"end_line":245,"end_character":26},"updated":"2016-03-23 01:16:54.000000000","message":"Seem similar comments as above.","commit_id":"250facd3b3f999d0c37bcc217702af09eb105454"}]}