)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9d5c160614083d37412746c6f36195a6177063bd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"update fails."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"With the fix, alarm-definition can be updated with match_by equals"},{"line_number":15,"context_line":"\"\" or \" \" or \u0027\u0027 or \u0027 \u0027 or [] when original match_by is empty."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Monasca client in tempest for alarm-definition-update was wrong. All"},{"line_number":18,"context_line":"the arguments for update alarm definition should be required."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a18252c_643698e7","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":61},"updated":"2016-04-13 14:05:09.000000000","message":"Space is probably not needed. Empty or [] should be sufficient","commit_id":"5b5043f390304a473a4514dd8362166316b0df3c"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"5e9c4f7de609e0857a77f8e3e9e459bfe638ad58","unresolved":false,"context_lines":[{"line_number":12,"context_line":"update fails."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"With the fix, alarm-definition can be updated with match_by equals"},{"line_number":15,"context_line":"\"\" or \" \" or \u0027\u0027 or \u0027 \u0027 or [] when original match_by is empty."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Monasca client in tempest for alarm-definition-update was wrong. All"},{"line_number":18,"context_line":"the arguments for update alarm definition should be required."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a18252c_84081493","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":61},"in_reply_to":"5a18252c_643698e7","updated":"2016-04-13 14:11:56.000000000","message":"OK I will change the code for that.","commit_id":"5b5043f390304a473a4514dd8362166316b0df3c"}],"monasca_api/common/repositories/sqla/alarm_definitions_repository.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9d5c160614083d37412746c6f36195a6177063bd","unresolved":false,"context_lines":[{"line_number":524,"context_line":"            else:"},{"line_number":525,"context_line":"                new_severity \u003d severity.encode(\u0027utf8\u0027)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"            if match_by is None or match_by \u003d\u003d [\" \"] or match_by \u003d\u003d [\"[]\"]:"},{"line_number":528,"context_line":"                new_match_by \u003d original_row[\u0027match_by\u0027]"},{"line_number":529,"context_line":"            else:"},{"line_number":530,"context_line":"                new_match_by \u003d \",\".join(match_by).encode(\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_843bf49b","line":527,"range":{"start_line":527,"start_character":0,"end_line":527,"end_character":75},"updated":"2016-04-13 14:05:09.000000000","message":"This is not correct. It would allow you to pass in [] on update if the old match_by was really hostname,url and have it work. It should only set it to original_row[\u0027match_by\u0027] for the patch case. For update, it should be an empty list","commit_id":"5b5043f390304a473a4514dd8362166316b0df3c"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"5e9c4f7de609e0857a77f8e3e9e459bfe638ad58","unresolved":false,"context_lines":[{"line_number":524,"context_line":"            else:"},{"line_number":525,"context_line":"                new_severity \u003d severity.encode(\u0027utf8\u0027)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"            if match_by is None or match_by \u003d\u003d [\" \"] or match_by \u003d\u003d [\"[]\"]:"},{"line_number":528,"context_line":"                new_match_by \u003d original_row[\u0027match_by\u0027]"},{"line_number":529,"context_line":"            else:"},{"line_number":530,"context_line":"                new_match_by \u003d \",\".join(match_by).encode(\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_a47a70ef","line":527,"range":{"start_line":527,"start_character":0,"end_line":527,"end_character":75},"in_reply_to":"5a18252c_843bf49b","updated":"2016-04-13 14:11:56.000000000","message":"Hmmm I need to spend more time on this. It checks new_match_by !\u003d original_row[\u0027match_by\u0027] later on line 532 though. Thanks Craig!","commit_id":"5b5043f390304a473a4514dd8362166316b0df3c"},{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"e6a455370b6573cdce64a6db255bba4454fb1363","unresolved":false,"context_lines":[{"line_number":526,"context_line":""},{"line_number":527,"context_line":"            encode_match_by \u003d \",\".join(match_by).encode(\u0027utf8\u0027) \\"},{"line_number":528,"context_line":"                if match_by is not None else None"},{"line_number":529,"context_line":"            if encode_match_by is None or encode_match_by \u003d\u003d \"[]\" or encode_match_by \u003d\u003d \"\":"},{"line_number":530,"context_line":"                if patch:"},{"line_number":531,"context_line":"                    new_match_by \u003d original_row[\u0027match_by\u0027]"},{"line_number":532,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_8f268dcc","line":529,"range":{"start_line":529,"start_character":15,"end_line":529,"end_character":90},"updated":"2016-04-18 10:09:17.000000000","message":"encode_match_by in [None, \"[]\", \"\"]\n\nWould it look better in this form?","commit_id":"3b714a7d1b9226bfb30ed133772dd6e4baaba4db"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"57b751546d2af45b33acf525d6e437f0740471c7","unresolved":false,"context_lines":[{"line_number":526,"context_line":""},{"line_number":527,"context_line":"            encode_match_by \u003d \",\".join(match_by).encode(\u0027utf8\u0027) \\"},{"line_number":528,"context_line":"                if match_by is not None else None"},{"line_number":529,"context_line":"            if encode_match_by is None or encode_match_by \u003d\u003d \"[]\" or encode_match_by \u003d\u003d \"\":"},{"line_number":530,"context_line":"                if patch:"},{"line_number":531,"context_line":"                    new_match_by \u003d original_row[\u0027match_by\u0027]"},{"line_number":532,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_87e82412","line":529,"range":{"start_line":529,"start_character":15,"end_line":529,"end_character":90},"in_reply_to":"1a122d0e_8f268dcc","updated":"2016-04-18 14:51:57.000000000","message":"Yes definitely! Thank you!","commit_id":"3b714a7d1b9226bfb30ed133772dd6e4baaba4db"}],"monasca_api/tests/test_ad_repository.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"9d5c160614083d37412746c6f36195a6177063bd","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                                                   None, None,"},{"line_number":430,"context_line":"                                                   True)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        self.repo.update_or_patch_alarm_definition(\u0027bob\u0027, \u0027234\u0027,"},{"line_number":433,"context_line":"                                                   None, None,"},{"line_number":434,"context_line":"                                                   None, False,"},{"line_number":435,"context_line":"                                                   None, None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_c4e16c00","line":432,"range":{"start_line":432,"start_character":9,"end_line":432,"end_character":64},"updated":"2016-04-13 14:05:09.000000000","message":"Is there a test that verifies that an exception is thrown if match_by changes?","commit_id":"5b5043f390304a473a4514dd8362166316b0df3c"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"5e9c4f7de609e0857a77f8e3e9e459bfe638ad58","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                                                   None, None,"},{"line_number":430,"context_line":"                                                   True)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        self.repo.update_or_patch_alarm_definition(\u0027bob\u0027, \u0027234\u0027,"},{"line_number":433,"context_line":"                                                   None, None,"},{"line_number":434,"context_line":"                                                   None, False,"},{"line_number":435,"context_line":"                                                   None, None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_8703f60c","line":432,"range":{"start_line":432,"start_character":9,"end_line":432,"end_character":64},"in_reply_to":"5a18252c_c4e16c00","updated":"2016-04-13 14:11:56.000000000","message":"I don\u0027t think so. I will add one!","commit_id":"5b5043f390304a473a4514dd8362166316b0df3c"}],"monasca_tempest_tests/services/monasca_client.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"3554c808ec83e30ae395448db24b8bb6b5d3e40c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        request_body[\u0027match_by\u0027] \u003d match_by"},{"line_number":158,"context_line":"        request_body[\u0027severity\u0027] \u003d severity"},{"line_number":159,"context_line":"        request_body[\u0027alarm_actions\u0027] \u003d alarm_actions"},{"line_number":160,"context_line":"        request_body[\u0027ok_actions\u0027] \u003d ok_actions"},{"line_number":161,"context_line":"        request_body[\u0027undetermined_actions\u0027] \u003d undetermined_actions"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        for key, value in kwargs.iteritems():"}],"source_content_type":"text/x-python","patch_set":15,"id":"dab17558_69d644f2","line":160,"range":{"start_line":160,"start_character":22,"end_line":160,"end_character":32},"updated":"2016-05-10 16:47:18.000000000","message":"would this take our ability to test not passing in an invalid amount of arguments away?  In this case when you call this method every field will be defined even if we set it to None. That is not always what a end user could do and not testing our API to make sure every field is passed in. With the old code you could say okay lets make sure our API is making sure all fields are passed in on an update and have a negative test to make sure it throws an error if you dont which we do not have a test for.","commit_id":"fe70afd5e944d71b0eee6b51ab2ace7d0f6e378f"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"caabb1612781a5dad5f93717f22343246f063476","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        request_body[\u0027match_by\u0027] \u003d match_by"},{"line_number":158,"context_line":"        request_body[\u0027severity\u0027] \u003d severity"},{"line_number":159,"context_line":"        request_body[\u0027alarm_actions\u0027] \u003d alarm_actions"},{"line_number":160,"context_line":"        request_body[\u0027ok_actions\u0027] \u003d ok_actions"},{"line_number":161,"context_line":"        request_body[\u0027undetermined_actions\u0027] \u003d undetermined_actions"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        for key, value in kwargs.iteritems():"}],"source_content_type":"text/x-python","patch_set":15,"id":"dab17558_bc06accb","line":160,"range":{"start_line":160,"start_character":22,"end_line":160,"end_character":32},"in_reply_to":"dab17558_69d644f2","updated":"2016-05-10 16:57:22.000000000","message":"Also our other update methods should match across this class update notification method is checking for none, this one isnt, neither is update alarm. We should do the same for whatever one we choose.","commit_id":"fe70afd5e944d71b0eee6b51ab2ace7d0f6e378f"}]}