)]}'
{"monasca_api/v2/reference/alarms.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"759a99537034e25c6c34e93aa6499724f19e7a46","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        old_alarm, time_ms \u003d self._alarms_repo.update_alarm(tenant_id, alarm_id,"},{"line_number":185,"context_line":"                                                            new_state,"},{"line_number":186,"context_line":"                                                            lifecycle_state, link)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # alarm_definition_id is the same for all rows."},{"line_number":189,"context_line":"        alarm_definition_id \u003d sub_alarm_rows[0][\u0027alarm_definition_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_cc05d37a","line":186,"range":{"start_line":186,"start_character":0,"end_line":186,"end_character":60},"updated":"2016-04-14 13:22:17.000000000","message":"So, the bug was on this line where old_state was being set, but that was really the old_alarm. Ooops.\n\nAs one possible nit-pick code improvement, maybe you could have just fixed this one line, then just set\n\nold_state \u003d old_alarm[\u0027state\u0027]\n\nThen, the rest of the code would have remained the same and been slightly moe concise/readable.","commit_id":"49b1155804b82db0758c8f951e07a2d7519b0276"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"afcc6538fc3407414aad3e5ffff4605fccaa64ea","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        old_alarm, time_ms \u003d self._alarms_repo.update_alarm(tenant_id, alarm_id,"},{"line_number":185,"context_line":"                                                            new_state,"},{"line_number":186,"context_line":"                                                            lifecycle_state, link)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # alarm_definition_id is the same for all rows."},{"line_number":189,"context_line":"        alarm_definition_id \u003d sub_alarm_rows[0][\u0027alarm_definition_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_23127f09","line":186,"range":{"start_line":186,"start_character":0,"end_line":186,"end_character":60},"in_reply_to":"5a18252c_cc05d37a","updated":"2016-04-14 19:30:09.000000000","message":"Sounds good also there is another bug here in line195. That\u0027s actually the main bug here to fix. We missed one/two input arguments for _send_alarm_event function.","commit_id":"49b1155804b82db0758c8f951e07a2d7519b0276"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"f6c85fc93efeac9a49b9b8381480d77faa9139b9","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                # alarms were also deleted, so don\u0027t send transition events."},{"line_number":241,"context_line":"                pass"},{"line_number":242,"context_line":"            else:"},{"line_number":243,"context_line":"                self._send_alarm_transitioned_event(tenant_id, alarm_id,"},{"line_number":244,"context_line":"                                                    alarm_definition_row,"},{"line_number":245,"context_line":"                                                    alarm_metric_rows,"},{"line_number":246,"context_line":"                                                    old_alarm[\u0027state\u0027], new_state,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_bc43456b","line":243,"range":{"start_line":243,"start_character":21,"end_line":243,"end_character":51},"updated":"2016-04-15 01:35:16.000000000","message":"I could find another bug by fixed above code in here.\n_send_alarm_transitioned_event method arguments are lacking.","commit_id":"49b1155804b82db0758c8f951e07a2d7519b0276"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"c23b10babafea64442f2e9d1f7149c8aae2bcb2e","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                # alarms were also deleted, so don\u0027t send transition events."},{"line_number":241,"context_line":"                pass"},{"line_number":242,"context_line":"            else:"},{"line_number":243,"context_line":"                self._send_alarm_transitioned_event(tenant_id, alarm_id,"},{"line_number":244,"context_line":"                                                    alarm_definition_row,"},{"line_number":245,"context_line":"                                                    alarm_metric_rows,"},{"line_number":246,"context_line":"                                                    old_alarm[\u0027state\u0027], new_state,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_fc0f7d34","line":243,"range":{"start_line":243,"start_character":21,"end_line":243,"end_character":51},"in_reply_to":"5a18252c_bc43456b","updated":"2016-04-15 01:37:37.000000000","message":"Sorry line is wrong. Please see line 207.","commit_id":"49b1155804b82db0758c8f951e07a2d7519b0276"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"c020dec455a25c4f855973f50107689bc616fe61","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                # alarms were also deleted, so don\u0027t send transition events."},{"line_number":241,"context_line":"                pass"},{"line_number":242,"context_line":"            else:"},{"line_number":243,"context_line":"                self._send_alarm_transitioned_event(tenant_id, alarm_id,"},{"line_number":244,"context_line":"                                                    alarm_definition_row,"},{"line_number":245,"context_line":"                                                    alarm_metric_rows,"},{"line_number":246,"context_line":"                                                    old_alarm[\u0027state\u0027], new_state,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_673d968e","line":243,"range":{"start_line":243,"start_character":21,"end_line":243,"end_character":51},"in_reply_to":"5a18252c_bc43456b","updated":"2016-04-15 01:49:22.000000000","message":"Yep you are right! line 207 is actually the main bug Im trying to fix here in this review :-)","commit_id":"49b1155804b82db0758c8f951e07a2d7519b0276"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"1dd8b764de4e8a5f000ffda731f1f3c5541ca920","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                # alarms were also deleted, so don\u0027t send transition events."},{"line_number":205,"context_line":"                pass"},{"line_number":206,"context_line":"            else:"},{"line_number":207,"context_line":"                self._send_alarm_transitioned_event(tenant_id, alarm_id,"},{"line_number":208,"context_line":"                                                    alarm_definition_row,"},{"line_number":209,"context_line":"                                                    alarm_metric_rows,"},{"line_number":210,"context_line":"                                                    old_state, new_state,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_85e7c411","line":207,"range":{"start_line":207,"start_character":21,"end_line":207,"end_character":51},"updated":"2016-04-15 14:53:54.000000000","message":"The number of this method\u0027s arguments is fewer than definition.\nSo I think it needs to add \u0027link\u0027 and \u0027lifecycle_state\u0027.","commit_id":"bfeed74afaa430d193d6135249deb90b1f240fc9"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"ab48a2f882618955b145548e7e87c8f338bb278a","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                # alarms were also deleted, so don\u0027t send transition events."},{"line_number":205,"context_line":"                pass"},{"line_number":206,"context_line":"            else:"},{"line_number":207,"context_line":"                self._send_alarm_transitioned_event(tenant_id, alarm_id,"},{"line_number":208,"context_line":"                                                    alarm_definition_row,"},{"line_number":209,"context_line":"                                                    alarm_metric_rows,"},{"line_number":210,"context_line":"                                                    old_state, new_state,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_657428cf","line":207,"range":{"start_line":207,"start_character":21,"end_line":207,"end_character":51},"in_reply_to":"1a122d0e_85e7c411","updated":"2016-04-15 14:55:51.000000000","message":"Ohh sorry I didn\u0027t see this part!! Thanks!","commit_id":"bfeed74afaa430d193d6135249deb90b1f240fc9"}]}