)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":20873,"name":"Laszlo Hegedus","email":"hegedues.laszlo@gmail.com","username":"laszloh"},"change_message_id":"78b052d170095cef534d80c9cc1011cadda23e84","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        fi"},{"line_number":140,"context_line":"    fi"},{"line_number":141,"context_line":"    if is_service_enabled monasca-persister; then"},{"line_number":142,"context_line":"        install_monasca_notification"},{"line_number":143,"context_line":"    fi"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a122d0e_9e29abf5","line":141,"range":{"start_line":141,"start_character":34,"end_line":141,"end_character":43},"updated":"2016-05-03 10:47:06.000000000","message":"notification","commit_id":"67439a29b626ab6565a7a4eb0cc1f59dc2177dca"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"853b8f34dfd4f6eceedefb00b96516f7cf351133","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        fi"},{"line_number":140,"context_line":"    fi"},{"line_number":141,"context_line":"    if is_service_enabled monasca-persister; then"},{"line_number":142,"context_line":"        install_monasca_notification"},{"line_number":143,"context_line":"    fi"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a122d0e_f5727de2","line":141,"range":{"start_line":141,"start_character":34,"end_line":141,"end_character":43},"in_reply_to":"1a122d0e_9e29abf5","updated":"2016-05-03 13:54:30.000000000","message":"Hmm, yes.  Whoops.  Thanks. Done.","commit_id":"67439a29b626ab6565a7a4eb0cc1f59dc2177dca"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"56931289c1e0f9ba0829200e9b677fe85cc01086","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        die \"Please set MONASCA_API_IMPLEMENTATION_LANG to either \\\"java\u0027\u0027 or \\\"python\\\"\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    fi"},{"line_number":124,"context_line":"    if is_service_enabled monasca-persister; then"},{"line_number":125,"context_line":"        if [[ \"${MONASCA_PERSISTER_IMPLEMENTATION_LANG,,}\" \u003d\u003d \u0027java\u0027 ]]; then"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"            install_monasca_persister_java"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a122d0e_040424c4","line":124,"range":{"start_line":124,"start_character":26,"end_line":124,"end_character":33},"updated":"2016-05-03 15:51:47.000000000","message":"should you be adding this for the api/agent as well? Weird that we only did three of our services but not the api.","commit_id":"bd25bacfa082557a5756822c8a7758b9c9dde62a"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"91851a707c41266a0b40ef095144774f80d7e56f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        die \"Please set MONASCA_API_IMPLEMENTATION_LANG to either \\\"java\u0027\u0027 or \\\"python\\\"\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    fi"},{"line_number":124,"context_line":"    if is_service_enabled monasca-persister; then"},{"line_number":125,"context_line":"        if [[ \"${MONASCA_PERSISTER_IMPLEMENTATION_LANG,,}\" \u003d\u003d \u0027java\u0027 ]]; then"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"            install_monasca_persister_java"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a122d0e_c457cc24","line":124,"range":{"start_line":124,"start_character":26,"end_line":124,"end_character":33},"in_reply_to":"1a122d0e_040424c4","updated":"2016-05-03 16:06:08.000000000","message":"I don\u0027t think so.  If you don\u0027t want the api installed then you wouldn\u0027t have this in the line of fire for devstack anyway would you?  And if the api is going to be installed then the agent really does need to be there.","commit_id":"bd25bacfa082557a5756822c8a7758b9c9dde62a"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"56931289c1e0f9ba0829200e9b677fe85cc01086","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        install_monasca_notification"},{"line_number":143,"context_line":"    fi"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    install_storm"},{"line_number":146,"context_line":"    if is_service_enabled monasca-thresh; then"},{"line_number":147,"context_line":"        install_monasca_thresh"},{"line_number":148,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a122d0e_a44f3033","line":145,"range":{"start_line":145,"start_character":4,"end_line":145,"end_character":17},"updated":"2016-05-03 15:51:47.000000000","message":"is there a use case of installing storm without the thresh. They are tied together for us","commit_id":"bd25bacfa082557a5756822c8a7758b9c9dde62a"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"21e066b311021b771eb31c964cc7885efc06035a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        install_monasca_notification"},{"line_number":143,"context_line":"    fi"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    install_storm"},{"line_number":146,"context_line":"    if is_service_enabled monasca-thresh; then"},{"line_number":147,"context_line":"        install_monasca_thresh"},{"line_number":148,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a122d0e_a5e433ac","line":145,"range":{"start_line":145,"start_character":4,"end_line":145,"end_character":17},"in_reply_to":"1a122d0e_38b978ed","updated":"2016-05-04 08:21:09.000000000","message":"Done.","commit_id":"bd25bacfa082557a5756822c8a7758b9c9dde62a"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"91851a707c41266a0b40ef095144774f80d7e56f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        install_monasca_notification"},{"line_number":143,"context_line":"    fi"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    install_storm"},{"line_number":146,"context_line":"    if is_service_enabled monasca-thresh; then"},{"line_number":147,"context_line":"        install_monasca_thresh"},{"line_number":148,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a122d0e_c4050c15","line":145,"range":{"start_line":145,"start_character":4,"end_line":145,"end_character":17},"in_reply_to":"1a122d0e_a44f3033","updated":"2016-05-03 16:06:08.000000000","message":"I don\u0027t know.  If there is not then I can add the condition here too.","commit_id":"bd25bacfa082557a5756822c8a7758b9c9dde62a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"c167d94fe51ef46501448852ea27f0c988a9862e","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        install_monasca_notification"},{"line_number":143,"context_line":"    fi"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    install_storm"},{"line_number":146,"context_line":"    if is_service_enabled monasca-thresh; then"},{"line_number":147,"context_line":"        install_monasca_thresh"},{"line_number":148,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a122d0e_38b978ed","line":145,"range":{"start_line":145,"start_character":4,"end_line":145,"end_character":17},"in_reply_to":"1a122d0e_c4050c15","updated":"2016-05-03 19:36:57.000000000","message":"Thresh is the only user of Storm. They are effectively the same thing so only install storm if thresh is enabled","commit_id":"bd25bacfa082557a5756822c8a7758b9c9dde62a"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"56931289c1e0f9ba0829200e9b677fe85cc01086","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        install_monasca_grafana"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    fi"},{"line_number":179,"context_line":"    if is_service_enabled monasca-smoke-test; then"},{"line_number":180,"context_line":"        install_monasca_smoke_test"},{"line_number":181,"context_line":"    fi"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a122d0e_a4d570e6","line":179,"range":{"start_line":179,"start_character":7,"end_line":179,"end_character":25},"updated":"2016-05-03 15:51:47.000000000","message":"also if we are adding this stuff in should we add to the vagrant file of enabling them so when someone does a vagrant up from the monasca api devstack environment everything is up and running ?\n\nIn the Vagrant file as of right now -\n\ndisable_all_services\nenable_service rabbit mysql key tempest horizon","commit_id":"bd25bacfa082557a5756822c8a7758b9c9dde62a"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"91851a707c41266a0b40ef095144774f80d7e56f","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        install_monasca_grafana"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    fi"},{"line_number":179,"context_line":"    if is_service_enabled monasca-smoke-test; then"},{"line_number":180,"context_line":"        install_monasca_smoke_test"},{"line_number":181,"context_line":"    fi"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a122d0e_4fc915ac","line":179,"range":{"start_line":179,"start_character":7,"end_line":179,"end_character":25},"in_reply_to":"1a122d0e_a4d570e6","updated":"2016-05-03 16:06:08.000000000","message":"I believe that enabling the monasca-api plugin enables all the monasca services by default.  The settings file enables a whole load of stuff.","commit_id":"bd25bacfa082557a5756822c8a7758b9c9dde62a"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"bbc18cc07dd5bc25c8eb6b1f19eacb9f45459101","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        install_monasca_grafana"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    fi"},{"line_number":179,"context_line":"    if is_service_enabled monasca-smoke-test; then"},{"line_number":180,"context_line":"        install_monasca_smoke_test"},{"line_number":181,"context_line":"    fi"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a122d0e_e3a9e27d","line":179,"range":{"start_line":179,"start_character":26,"end_line":179,"end_character":44},"updated":"2016-05-04 22:20:27.000000000","message":"This disables the smoke test in CI. If its going to match the other changes, then it should probably be enabled by default in the settings file.","commit_id":"c35f8fa838444c32f8b6500448e4a68b18c31d8d"},{"author":{"_account_id":9276,"name":"David Charles Kennedy","email":"david.c.kennedy@hpe.com","username":"darfed"},"change_message_id":"4304ad3ff84f1bb4c6076f4dc6dfa62f842f32eb","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        install_monasca_grafana"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    fi"},{"line_number":179,"context_line":"    if is_service_enabled monasca-smoke-test; then"},{"line_number":180,"context_line":"        install_monasca_smoke_test"},{"line_number":181,"context_line":"    fi"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a122d0e_6902a80d","line":179,"range":{"start_line":179,"start_character":26,"end_line":179,"end_character":44},"in_reply_to":"1a122d0e_e3a9e27d","updated":"2016-05-05 15:44:33.000000000","message":"Done","commit_id":"c35f8fa838444c32f8b6500448e4a68b18c31d8d"}]}
