)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"e7a7cb5306de5442202fc177a70f748a977f148a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ryan Brandt \u003cryan.brandt@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-20 16:43:15 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add python mutliple metrics for measurement and statistics"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I34ca2ae516e8945d92723a2165bef34e59d5053c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dada55a8_f1a665ac","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":19},"updated":"2016-07-21 14:21:36.000000000","message":"multiple","commit_id":"6dcf3f882f116d640df9371a0c7f20c1a247c650"}],"java/src/main/java/monasca/api/infrastructure/persistence/influxdb/InfluxV9MeasurementRepo.java":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"b6fdd6ec0367d7e1e3eadfc917d32868fb86f66e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * (C) Copyright 2014, 2016 Hewlett-Packard Development LP"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except"},{"line_number":5,"context_line":" * in compliance with the License. You may obtain a copy of the License at"}],"source_content_type":"text/x-java","patch_set":17,"id":"9a89bdaa_7efe04af","line":2,"range":{"start_line":2,"start_character":44,"end_line":2,"end_character":55},"updated":"2016-09-07 14:48:17.000000000","message":"(c) Copyright 2014,2016 Hewlett Packard Enterprise Development LP","commit_id":"6a1278c77d17375f86168ce1fc4aa43a3263a412"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7667c1cf045e7a9a92ba428146ee876cc2b2fc9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * (C) Copyright 2014, 2016 Hewlett Packard Development LP"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except"},{"line_number":5,"context_line":" * in compliance with the License. You may obtain a copy of the License at"}],"source_content_type":"text/x-java","patch_set":18,"id":"9a89bdaa_fd3859a2","line":2,"range":{"start_line":2,"start_character":36,"end_line":2,"end_character":43},"updated":"2016-09-07 15:14:04.000000000","message":"forgot enterprise","commit_id":"2e681a0d2cc8e15e46d6c5d8ca6a16376940a830"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"b6d5ab83b52be33d68ce346dc39b34a0b5c4940e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"              this.influxV9Utils.startTimePart(startTime),"},{"line_number":128,"context_line":"              this.influxV9Utils.dimPart(dimensions),"},{"line_number":129,"context_line":"              this.influxV9Utils.endTimePart(endTime),"},{"line_number":130,"context_line":"              groupByStr);"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    }"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-java","patch_set":20,"id":"9a89bdaa_5670090b","line":130,"range":{"start_line":130,"start_character":14,"end_line":130,"end_character":24},"updated":"2016-09-08 14:48:59.000000000","message":"why do you have group by here if merge metrics is false or null the group by will be  \"group by *\" which i dont think you want is it  since you are already doing group by above","commit_id":"4cc06a5d37ba55550e107979be0f5973348dc6c5"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"76534a4b0821b0d478285710f1efc43648517333","unresolved":false,"context_lines":[{"line_number":127,"context_line":"              this.influxV9Utils.startTimePart(startTime),"},{"line_number":128,"context_line":"              this.influxV9Utils.dimPart(dimensions),"},{"line_number":129,"context_line":"              this.influxV9Utils.endTimePart(endTime),"},{"line_number":130,"context_line":"              groupByStr);"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    }"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-java","patch_set":20,"id":"9a89bdaa_d184235f","line":130,"range":{"start_line":130,"start_character":14,"end_line":130,"end_character":24},"in_reply_to":"9a89bdaa_5670090b","updated":"2016-09-08 14:56:02.000000000","message":"If I don\u0027t include the \u0027group by *\u0027 here then the returned data doesn\u0027t include the set of dimensions. It should only happen if the query will return a single result.","commit_id":"4cc06a5d37ba55550e107979be0f5973348dc6c5"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"437a27b8bd294c3b1832368168c187c7a42617e1","unresolved":false,"context_lines":[{"line_number":127,"context_line":"              this.influxV9Utils.startTimePart(startTime),"},{"line_number":128,"context_line":"              this.influxV9Utils.dimPart(dimensions),"},{"line_number":129,"context_line":"              this.influxV9Utils.endTimePart(endTime),"},{"line_number":130,"context_line":"              groupByStr);"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    }"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-java","patch_set":20,"id":"9a89bdaa_b1523f33","line":130,"range":{"start_line":130,"start_character":14,"end_line":130,"end_character":24},"in_reply_to":"9a89bdaa_d184235f","updated":"2016-09-08 15:05:21.000000000","message":"I feel like this method could be written a lot simpler then. \n\ngroupByStr \u003d \"\"\nif (\"*\".equals(groupBy))  {\n\tgroupByStr \u003d this.influxV9Utils.groupByPart();\n}\nelse if (Boolean.FALSE.equals(mergeMetricsFlag)){\n\tif (!this.influxV9MetricDefinitionRepo.isAtMostOneSeries(tenantId, name, dimensions)){\n\t\tthrow new MultipleMetricsException(name, dimensions);\n\t}\n\tgroupByStr \u003d this.influxV9Utils.groupByPart();\n}\nq \u003d String.format(\"select value, value_meta %1$s where %2$s %3$s %4$s %5$s %6$s %7$s\", \n              this.influxV9Utils.namePart(name, true),\n              this.influxV9Utils.privateTenantIdPart(tenantId),\n              this.influxV9Utils.privateRegionPart(this.region),\n              this.influxV9Utils.startTimePart(startTime),\n              this.influxV9Utils.dimPart(dimensions),\n              this.influxV9Utils.endTimePart(endTime),\n              this.influxV9Utils.groupByPart());\n\nwhat do you think","commit_id":"4cc06a5d37ba55550e107979be0f5973348dc6c5"}],"java/src/main/java/monasca/api/infrastructure/persistence/influxdb/InfluxV9StatisticRepo.java":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"b6fdd6ec0367d7e1e3eadfc917d32868fb86f66e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * (C) Copyright 2014, 2016 Hewlett-Packard Development LP"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except"},{"line_number":5,"context_line":" * in compliance with the License. You may obtain a copy of the License at"}],"source_content_type":"text/x-java","patch_set":17,"id":"9a89bdaa_de239056","line":2,"range":{"start_line":2,"start_character":35,"end_line":2,"end_character":36},"updated":"2016-09-07 14:48:17.000000000","message":"(c) Copyright 2014,2016 Hewlett Packard Enterprise Development LP","commit_id":"6a1278c77d17375f86168ce1fc4aa43a3263a412"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7667c1cf045e7a9a92ba428146ee876cc2b2fc9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * (C) Copyright 2014, 2016 Hewlett Packard Development LP"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except"},{"line_number":5,"context_line":" * in compliance with the License. You may obtain a copy of the License at"}],"source_content_type":"text/x-java","patch_set":18,"id":"9a89bdaa_3d3f2188","line":2,"range":{"start_line":2,"start_character":44,"end_line":2,"end_character":55},"updated":"2016-09-07 15:14:04.000000000","message":"same here","commit_id":"2e681a0d2cc8e15e46d6c5d8ca6a16376940a830"}],"java/src/main/java/monasca/api/infrastructure/persistence/influxdb/InfluxV9Utils.java":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"d16c205e88463035ad94f893593c4aa88b60f2f9","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                      : \" group by time(300s), * fill(0)\";"},{"line_number":260,"context_line":"  }"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"  public String periodPart(int period, boolean mergeMetricsFlag) {"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    String periodStr \u003d period \u003e 0 ? String.format(\" group by time(%1$ds)\", period)"},{"line_number":265,"context_line":"                      : \" group by time(300s)\";"}],"source_content_type":"text/x-java","patch_set":20,"id":"9a89bdaa_765c2d4b","line":262,"range":{"start_line":262,"start_character":39,"end_line":262,"end_character":46},"updated":"2016-09-08 14:53:23.000000000","message":"isnt this of type Boolean in the other class that calls this method not the primative boolean","commit_id":"4cc06a5d37ba55550e107979be0f5973348dc6c5"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"3d2a15e0b4a24ceb932c71fff29d61091c4b829f","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                      : \" group by time(300s), * fill(0)\";"},{"line_number":260,"context_line":"  }"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"  public String periodPart(int period, boolean mergeMetricsFlag) {"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    String periodStr \u003d period \u003e 0 ? String.format(\" group by time(%1$ds)\", period)"},{"line_number":265,"context_line":"                      : \" group by time(300s)\";"}],"source_content_type":"text/x-java","patch_set":20,"id":"9a89bdaa_91e61b42","line":262,"range":{"start_line":262,"start_character":39,"end_line":262,"end_character":46},"in_reply_to":"9a89bdaa_765c2d4b","updated":"2016-09-08 14:57:58.000000000","message":"Yes, it is... I must have mistyped at some point. It does work this way as well, but I will change it.","commit_id":"4cc06a5d37ba55550e107979be0f5973348dc6c5"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"363492edc7ce396aa6a0917176aaa5cc007bf05b","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"  public String periodPart(int period, Boolean mergeMetricsFlag) {"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    String periodStr \u003d period \u003e 0 ? String.format(\" group by time(%1$ds)\", period)"},{"line_number":265,"context_line":"                      : \" group by time(300s)\";"},{"line_number":266,"context_line":"    periodStr +\u003d mergeMetricsFlag ? \" fill(0)\" : \", * fill(0)\";"},{"line_number":267,"context_line":""}],"source_content_type":"text/x-java","patch_set":22,"id":"7a8ec9b2_f05e0144","line":264,"updated":"2016-09-21 05:02:59.000000000","message":"Generally, concatenating strings in Java is not something that is considered a best practice. AFAIK this is equivalent to using StringBuilder, so I think I\u0027d see that here.","commit_id":"290cdfbfa29e119bb0fb84575d47c6e0e9e6f517"}],"monasca_api/common/repositories/influxdb/metrics_repository.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"01c84164e08f1ea95a806663e7420ecc8e3283cc","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"            result \u003d self.influxdb_client.query(query)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"            LOG.warn(result.raw)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"            if not result:"},{"line_number":312,"context_line":"                return json_measurement_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_4713970d","line":309,"range":{"start_line":309,"start_character":21,"end_line":309,"end_character":27},"updated":"2016-05-19 21:54:57.000000000","message":"meant to leave this here?","commit_id":"c0546d31bd6be9b175c7b8ca4bd61ea2ce585801"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"57408731401d0c5396061de9768a0bd7a5b5e9d8","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"            result \u003d self.influxdb_client.query(query)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"            LOG.warn(result.raw)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"            if not result:"},{"line_number":312,"context_line":"                return json_measurement_list"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_e046f24d","line":309,"range":{"start_line":309,"start_character":21,"end_line":309,"end_character":27},"in_reply_to":"bab6814e_4713970d","updated":"2016-05-19 22:30:52.000000000","message":"Oops, no. Removing","commit_id":"c0546d31bd6be9b175c7b8ca4bd61ea2ce585801"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"e7a7cb5306de5442202fc177a70f748a977f148a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"# Copyright 2014 Hewlett-Packard"},{"line_number":3,"context_line":"# (C) Copyright 2015,2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":4,"context_line":"# Copyright 2015 Cray Inc. All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_b1e6ade5","line":3,"range":{"start_line":3,"start_character":65,"end_line":3,"end_character":72},"updated":"2016-07-21 14:21:36.000000000","message":"hate to do this but i do not want to go back through and change copyrights later. Would you mind going through each file you changed and take out the company?","commit_id":"6dcf3f882f116d640df9371a0c7f20c1a247c650"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"5fff567d55234619950d31710042fc1e98fe1df5","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"            result \u003d self.influxdb_client.query(query)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"            LOG.warn(result.raw)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"            if not result:"},{"line_number":354,"context_line":"                return json_measurement_list"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_2a179fa4","line":351,"updated":"2016-07-28 03:56:00.000000000","message":"I think that it can be removed.","commit_id":"a0baf05a41ef06ab24b30d8bcdd91a23204473a0"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"201dbe06773182e9e4564a8bac500c8077d3670d","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"            result \u003d self.influxdb_client.query(query)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"            LOG.warn(result.raw)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"            if not result:"},{"line_number":354,"context_line":"                return json_measurement_list"}],"source_content_type":"text/x-python","patch_set":8,"id":"bacf61ea_d4b6eff7","line":351,"in_reply_to":"bacf61ea_2a179fa4","updated":"2016-08-04 20:20:49.000000000","message":"Done","commit_id":"a0baf05a41ef06ab24b30d8bcdd91a23204473a0"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"b6fdd6ec0367d7e1e3eadfc917d32868fb86f66e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"# Copyright 2014 Hewlett-Packard"},{"line_number":3,"context_line":"# (C) Copyright 2015,2016 Hewlett Packard Enterprise Development LP"},{"line_number":4,"context_line":"# Copyright 2015 Cray Inc. All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a89bdaa_7e1524e3","line":2,"range":{"start_line":2,"start_character":17,"end_line":2,"end_character":24},"updated":"2016-09-07 14:48:17.000000000","message":"take out and add 2014 below","commit_id":"6a1278c77d17375f86168ce1fc4aa43a3263a412"}],"monasca_api/common/repositories/metrics_repository.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"abea0ea5c549a2e5ab24c8672d23c4636faf7d14","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Hewlett-Packard"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_71ce242e","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":24},"updated":"2016-05-26 16:22:07.000000000","message":"here","commit_id":"ed74e2083684957ac35c87ee5ad6cace51ad2e6c"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"eeb16b9b97087e0fe3516a41d59ca8b95550b4b3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014,2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_dd49d961","line":1,"range":{"start_line":1,"start_character":65,"end_line":1,"end_character":72},"updated":"2016-07-20 22:46:42.000000000","message":"no company","commit_id":"6dcf3f882f116d640df9371a0c7f20c1a247c650"}],"monasca_api/tests/test_repositories.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"abea0ea5c549a2e5ab24c8672d23c4636faf7d14","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Cray Inc. All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_51ea0075","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":22},"updated":"2016-05-26 16:22:07.000000000","message":"add here","commit_id":"ed74e2083684957ac35c87ee5ad6cace51ad2e6c"}],"monasca_api/v2/reference/helpers.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"abea0ea5c549a2e5ab24c8672d23c4636faf7d14","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    return resource"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"def paginate_measurement(measurements, uri, limit):"},{"line_number":394,"context_line":"    parsed_uri \u003d urlparse.urlparse(uri)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    self_link \u003d build_base_uri(parsed_uri)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_716aa4ee","line":393,"range":{"start_line":393,"start_character":4,"end_line":393,"end_character":24},"updated":"2016-05-26 16:22:07.000000000","message":"should we call this paginate measurements now since you can pass multiple now?","commit_id":"ed74e2083684957ac35c87ee5ad6cace51ad2e6c"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"abea0ea5c549a2e5ab24c8672d23c4636faf7d14","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        for measurement in measurements:"},{"line_number":409,"context_line":"            if len(measurement[\u0027measurements\u0027]) \u003e\u003d limit:"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"                new_offset \u003d measurement[\u0027measurements\u0027][limit - 1][0]"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"                next_link \u003d build_base_uri(parsed_uri)"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_17cd0831","line":411,"range":{"start_line":411,"start_character":57,"end_line":411,"end_character":62},"updated":"2016-05-26 16:22:07.000000000","message":"what if the limit lands on zero? Lets say your limit is 10. There are three measurements in the list. Each with 5 measurements. So you hit the else in the two iterations and in result the limit is now 0 on the last iteration. You get to this point and you use a negative limit as an index and it will fail with an exception","commit_id":"ed74e2083684957ac35c87ee5ad6cace51ad2e6c"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"dc5ceebf6ae3edfd5b5a70eae77bc1885da06920","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        for measurement in measurements:"},{"line_number":409,"context_line":"            if len(measurement[\u0027measurements\u0027]) \u003e\u003d limit:"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"                new_offset \u003d measurement[\u0027measurements\u0027][limit - 1][0]"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"                next_link \u003d build_base_uri(parsed_uri)"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_374bec88","line":411,"range":{"start_line":411,"start_character":57,"end_line":411,"end_character":62},"in_reply_to":"bab6814e_17cd0831","updated":"2016-05-26 16:23:21.000000000","message":"actually thinking about it more you not run into this with the \u003d on the \u003e then","commit_id":"ed74e2083684957ac35c87ee5ad6cace51ad2e6c"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"abea0ea5c549a2e5ab24c8672d23c4636faf7d14","unresolved":false,"context_lines":[{"line_number":494,"context_line":"            if len(statistic[\u0027statistics\u0027]) \u003e\u003d limit:"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"                new_offset \u003d ("},{"line_number":497,"context_line":"                    statistic[\u0027statistics\u0027][limit - 1][0])"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"                next_link \u003d build_base_uri(parsed_uri)"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_f7e2049f","line":497,"range":{"start_line":497,"start_character":44,"end_line":497,"end_character":49},"updated":"2016-05-26 16:22:07.000000000","message":"same as above","commit_id":"ed74e2083684957ac35c87ee5ad6cace51ad2e6c"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"b6fdd6ec0367d7e1e3eadfc917d32868fb86f66e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Hewlett-Packard"},{"line_number":2,"context_line":"# Copyright 2015 Cray Inc. All Rights Reserved."},{"line_number":3,"context_line":"# Copyright 2016 Hewlett Packard Enterprise Development LP"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a89bdaa_1ee978e6","line":1,"range":{"start_line":1,"start_character":25,"end_line":1,"end_character":32},"updated":"2016-09-07 14:48:17.000000000","message":"same here","commit_id":"6a1278c77d17375f86168ce1fc4aa43a3263a412"}],"monasca_tempest_tests/tests/api/test_measurements.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"abea0ea5c549a2e5ab24c8672d23c4636faf7d14","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":262,"context_line":"    def test_list_measurements_with_group_by(self):"},{"line_number":263,"context_line":"        query_parms \u003d \u0027?name\u003d\u0027 + str(self._names_list[1]) + \\"},{"line_number":264,"context_line":"                      \u0027\u0026group_by\u003d*\u0027 + \\"},{"line_number":265,"context_line":"                      \u0027\u0026start_time\u003d\u0027 + str(self._start_time) + \\"},{"line_number":266,"context_line":"                      \u0027\u0026end_time\u003d\u0027 + str(self._end_time)"},{"line_number":267,"context_line":"        resp, response_body \u003d self.monasca_client.list_measurements("}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_74f0d2fd","line":264,"range":{"start_line":264,"start_character":38,"end_line":264,"end_character":39},"updated":"2016-05-26 16:22:07.000000000","message":"no tests with limit we should add that.","commit_id":"ed74e2083684957ac35c87ee5ad6cace51ad2e6c"}],"monasca_tempest_tests/tests/api/test_statistics.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"01c84164e08f1ea95a806663e7420ecc8e3283cc","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                if link[\u0027rel\u0027] \u003d\u003d \u0027next\u0027:"},{"line_number":247,"context_line":"                    next_link \u003d link[\u0027href\u0027]"},{"line_number":248,"context_line":"            if not next_link:"},{"line_number":249,"context_line":"                self.fail(\"No next link returned with query parameters: {}\".format(query_parms))"},{"line_number":250,"context_line":"            offset \u003d helpers.get_query_param(next_link, \"offset\")"},{"line_number":251,"context_line":"            # python api returns exact timestamp, but the test needs a rounded number"},{"line_number":252,"context_line":"            offset_period_index \u003d offset.find(\u0027.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_a796c349","line":249,"range":{"start_line":249,"start_character":30,"end_line":249,"end_character":34},"updated":"2016-05-19 21:54:57.000000000","message":"are there tempest tests we can add for multiple metrics","commit_id":"c0546d31bd6be9b175c7b8ca4bd61ea2ce585801"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"57408731401d0c5396061de9768a0bd7a5b5e9d8","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                if link[\u0027rel\u0027] \u003d\u003d \u0027next\u0027:"},{"line_number":247,"context_line":"                    next_link \u003d link[\u0027href\u0027]"},{"line_number":248,"context_line":"            if not next_link:"},{"line_number":249,"context_line":"                self.fail(\"No next link returned with query parameters: {}\".format(query_parms))"},{"line_number":250,"context_line":"            offset \u003d helpers.get_query_param(next_link, \"offset\")"},{"line_number":251,"context_line":"            # python api returns exact timestamp, but the test needs a rounded number"},{"line_number":252,"context_line":"            offset_period_index \u003d offset.find(\u0027.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_c0b12e49","line":249,"range":{"start_line":249,"start_character":30,"end_line":249,"end_character":34},"in_reply_to":"bab6814e_a796c349","updated":"2016-05-19 22:30:52.000000000","message":"Yeah, now that python and java will be supporting it. There are still some issues that will make testing a bit difficult though.","commit_id":"c0546d31bd6be9b175c7b8ca4bd61ea2ce585801"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"abea0ea5c549a2e5ab24c8672d23c4636faf7d14","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                          \u0027\u0026end_time\u003d\u0027 + end_time + \\"},{"line_number":242,"context_line":"                          \u0027\u0026limit\u003d1\u0027"},{"line_number":243,"context_line":"            resp, response_body \u003d self.monasca_client.list_measurements(query_parms)"},{"line_number":244,"context_line":"            next_link \u003d None"},{"line_number":245,"context_line":"            for link in response_body[\u0027links\u0027]:"},{"line_number":246,"context_line":"                if link[\u0027rel\u0027] \u003d\u003d \u0027next\u0027:"},{"line_number":247,"context_line":"                    next_link \u003d link[\u0027href\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_d7f6e05b","line":244,"range":{"start_line":244,"start_character":24,"end_line":244,"end_character":28},"updated":"2016-05-26 16:22:07.000000000","message":"no test for this functionality in statistics?","commit_id":"ed74e2083684957ac35c87ee5ad6cace51ad2e6c"}]}