)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Haneef Ali \u003chaneef.ali@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-29 09:56:31 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for  notification plugins in monacaapi"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This review"},{"line_number":10,"context_line":"  1) Removes the hard coded notification types"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"bacf61ea_df28dce4","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":51},"updated":"2016-07-29 18:40:43.000000000","message":"If you make another change, can you change this to monasca api? The misspelling is annoying me :)","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Haneef Ali \u003chaneef.ali@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-29 09:56:31 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds support for  notification plugins in monacaapi"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This review"},{"line_number":10,"context_line":"  1) Removes the hard coded notification types"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"bacf61ea_d4470f75","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":51},"in_reply_to":"bacf61ea_df28dce4","updated":"2016-07-30 06:14:03.000000000","message":"Done","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"}],"docs/monasca-api-spec.md":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"0fcf3198fc1caacfa81b885d77b480d4bce1bcd2","unresolved":false,"context_lines":[{"line_number":1816,"context_line":"## List supported Notification Method Types"},{"line_number":1817,"context_line":"List supported notification method types."},{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"### GET /v2.0/notification-methods/types/"},{"line_number":1820,"context_line":""},{"line_number":1821,"context_line":"#### Headers"},{"line_number":1822,"context_line":"* X-Auth-Token (string, required) - Keystone auth token"}],"source_content_type":"text/x-markdown","patch_set":1,"id":"1aa78d24_da28f4e4","line":1819,"range":{"start_line":1819,"start_character":4,"end_line":1819,"end_character":7},"updated":"2016-07-06 05:15:16.000000000","message":"HTTP Options and /v2.0/notification-methods ?\n\nFor me it seems like a decent way to retrieve all possible notification types as you inform about server capabilities for this endpoint.","commit_id":"2145dc144263f6b8f6eac1b32649976d4d81472f"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"60e699fa3686e4e3c9580b67167cd26635f45e80","unresolved":false,"context_lines":[{"line_number":1816,"context_line":"## List supported Notification Method Types"},{"line_number":1817,"context_line":"List supported notification method types."},{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"### GET /v2.0/notification-methods/types/"},{"line_number":1820,"context_line":""},{"line_number":1821,"context_line":"#### Headers"},{"line_number":1822,"context_line":"* X-Auth-Token (string, required) - Keystone auth token"}],"source_content_type":"text/x-markdown","patch_set":1,"id":"1aa78d24_ced92824","line":1819,"range":{"start_line":1819,"start_character":4,"end_line":1819,"end_character":7},"in_reply_to":"1aa78d24_3ac90f27","updated":"2016-07-06 20:30:25.000000000","message":"No, no..what I head in mind was something like\n\n GET /v2.0/notification-methods\n\nreturns list of actual notification methods. Those entities, each one of them have a notification type that server (monasca-api) supports. My idea was to use OPTIONS http method over the same endpoint that could, as a response, return list of all possible types of notifications that server is capable of processing.\n\nIn other words that would something like\n\n OPTIONS /v2.0/notification-methods\n\n {\n   types: [\"WEBHOOK\", \"PAGERGUDY\", \"EMAIL\", \"JIRA\", \"HIPCHAT\"]\n }\n\nbut again, I think I might have overused what OPTIONS can be used for, so I guess that initial idea here is right way to go.\n\nBTW, sorry if that comment was out of place. I am still trying to figure this OPTIONS and I still come back in my mind to article I read while log - http://zacstewart.com/2012/04/14/http-options-method.html.\n\nThat\u0027s why I suggested that as an option to consider.","commit_id":"2145dc144263f6b8f6eac1b32649976d4d81472f"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"ec693fa083061a04b4e2fe7cbe1f2511f815f630","unresolved":false,"context_lines":[{"line_number":1816,"context_line":"## List supported Notification Method Types"},{"line_number":1817,"context_line":"List supported notification method types."},{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"### GET /v2.0/notification-methods/types/"},{"line_number":1820,"context_line":""},{"line_number":1821,"context_line":"#### Headers"},{"line_number":1822,"context_line":"* X-Auth-Token (string, required) - Keystone auth token"}],"source_content_type":"text/x-markdown","patch_set":1,"id":"1aa78d24_3ac90f27","line":1819,"range":{"start_line":1819,"start_character":4,"end_line":1819,"end_character":7},"in_reply_to":"1aa78d24_da28f4e4","updated":"2016-07-06 17:55:05.000000000","message":"I\u0027m not sure what the comment is for. Are you suggesting to remove \"/type\" from the URL?\n\nGET /v2.0/notification-methods returns a list of all the currently defines notification methods. Adding query parameters to this query, should just filter the notification methods, not change the document that is returned. Just returning a list of the supported notification method types, is a new document, therefore, that is the reason for introducing a new endpoint.","commit_id":"2145dc144263f6b8f6eac1b32649976d4d81472f"},{"author":{"_account_id":22210,"name":"Matteus Sthefano Leite da Silva","email":"silvamatteus@lsd.ufcg.edu.br","username":"silvamatteus"},"change_message_id":"6a3a6c0d49948b48290708412ae06fb18022dbc4","unresolved":false,"context_lines":[{"line_number":1831,"context_line":"#### Request Examples"},{"line_number":1832,"context_line":"````"},{"line_number":1833,"context_line":"GET /v2.0/notification-methods/types"},{"line_number":1834,"context_line":"Host: 192.168.10.4:8080"},{"line_number":1835,"context_line":"X-Auth-Token: 2b8882ba2ec44295bf300aecb2caa4f7"},{"line_number":1836,"context_line":"Cache-Control: no-cache"},{"line_number":1837,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":8,"id":"fad55976_99d97286","line":1834,"range":{"start_line":1834,"start_character":19,"end_line":1834,"end_character":23},"updated":"2016-07-17 02:49:26.000000000","message":"Default port for Monasca API is 8070. There is also a patch to update it - https://review.openstack.org/#/c/343249/\n\nSome refs:\nhttps://github.com/openstack/monasca-api/blob/91851af169b0d7da590b1dedec1ad68b9490e56d/devstack/files/keystone/create_monasca_service.py#L203\n\nhttps://github.com/openstack/monasca-vagrant/search?utf8\u003d%E2%9C%93\u0026q\u003d8070\n\nhttps://github.com/openstack/monasca-ceilometer/blob/02ca4e80fe09e5ead44d3ff9829ed6e982cbbe3c/devstack/settings#L7","commit_id":"2bfaffb3ddf9ea6fc74e96695172edc95f9e75ac"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":196,"context_line":"      - [Status Code](#status-code-10)"},{"line_number":197,"context_line":"      - [Response Body](#response-body-12)"},{"line_number":198,"context_line":"      - [Response Examples](#response-examples-11)"},{"line_number":199,"context_line":"  - [Delete Notification Method](#delete-notification-method)"},{"line_number":200,"context_line":"    - [DELETE /v2.0/notification-methods/{notification_method_id}](#delete-v20notification-methodsnotification_method_id)"},{"line_number":201,"context_line":"      - [Headers](#headers-13)"},{"line_number":202,"context_line":"      - [Path Parameters](#path-parameters-13)"}],"source_content_type":"text/x-markdown","patch_set":16,"id":"dada55a8_444d5698","line":199,"range":{"start_line":199,"start_character":34,"end_line":199,"end_character":40},"updated":"2016-07-25 21:22:43.000000000","message":"shouldnt you have entry for the new resource here?","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":1947,"context_line":"#### Response Body"},{"line_number":1948,"context_line":"Returns a JSON list which has list of notification types supported"},{"line_number":1949,"context_line":""},{"line_number":1950,"context_line":"* type (string) - List of of notification methods"},{"line_number":1951,"context_line":""},{"line_number":1952,"context_line":""},{"line_number":1953,"context_line":"#### Response Examples"}],"source_content_type":"text/x-markdown","patch_set":16,"id":"dada55a8_a4b6d287","line":1950,"range":{"start_line":1950,"start_character":26,"end_line":1950,"end_character":28},"updated":"2016-07-25 21:22:43.000000000","message":"take out extra of","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":1947,"context_line":"#### Response Body"},{"line_number":1948,"context_line":"Returns a JSON list which has list of notification types supported"},{"line_number":1949,"context_line":""},{"line_number":1950,"context_line":"* type (string) - List of of notification methods"},{"line_number":1951,"context_line":""},{"line_number":1952,"context_line":""},{"line_number":1953,"context_line":"#### Response Examples"}],"source_content_type":"text/x-markdown","patch_set":16,"id":"dada55a8_647055dd","line":1950,"range":{"start_line":1950,"start_character":26,"end_line":1950,"end_character":28},"in_reply_to":"dada55a8_a4b6d287","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"526ef96244acb8b29998b54968faf4b9a4386531","unresolved":false,"context_lines":[{"line_number":196,"context_line":"      - [Status Code](#status-code-10)"},{"line_number":197,"context_line":"      - [Response Body](#response-body-12)"},{"line_number":198,"context_line":"      - [Response Examples](#response-examples-11)"},{"line_number":199,"context_line":"  - [Delete Notification Method](#delete-notification-method)"},{"line_number":200,"context_line":"    - [DELETE /v2.0/notification-methods/{notification_method_id}](#delete-v20notification-methodsnotification_method_id)"},{"line_number":201,"context_line":"      - [Headers](#headers-13)"},{"line_number":202,"context_line":"      - [Path Parameters](#path-parameters-13)"}],"source_content_type":"text/x-markdown","patch_set":19,"id":"dada55a8_a655fa50","line":199,"range":{"start_line":199,"start_character":34,"end_line":199,"end_character":40},"updated":"2016-07-26 19:10:57.000000000","message":"still need to add an entry up here","commit_id":"82d195d58a1dd8719fb7b4316517dfd2b43d38e6"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"04831477584f74cf4174023ac8da3d0859cad884","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003c!-- START doctoc generated TOC please keep comment here to allow auto update --\u003e"},{"line_number":8,"context_line":"\u003c!-- DON\u0027T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE --\u003e"},{"line_number":9,"context_line":"**Table of Contents**  *generated with [DocToc](https://github.com/thlorenz/doctoc)*"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- [Overview](#overview)"},{"line_number":12,"context_line":"  - [Metric Name and Dimensions](#metric-name-and-dimensions)"}],"source_content_type":"text/x-markdown","patch_set":20,"id":"dada55a8_d81d67bf","line":9,"range":{"start_line":9,"start_character":2,"end_line":9,"end_character":19},"updated":"2016-07-26 22:20:59.000000000","message":"Still need to regenerate this to add the new resource","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"a13151aef8a09d9a4bdd6a10b27d669a311958c9","unresolved":false,"context_lines":[{"line_number":1971,"context_line":"         \"type\":\"WEBHOOK\""},{"line_number":1972,"context_line":"      }"},{"line_number":1973,"context_line":"   ]"},{"line_number":1974,"context_line":"}"},{"line_number":1975,"context_line":"````"},{"line_number":1976,"context_line":"___"},{"line_number":1977,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":20,"id":"dada55a8_52095883","line":1974,"updated":"2016-07-26 20:45:39.000000000","message":"The links for each item are unresolvable and probably unnecessary. Also an ID of null is not very useful\n\n\n  \"elements\": [\n    {\n      \"id\": null,\n      \"links\": [\n        {\n          \"rel\": \"self\",\n          \"href\": \"http://192.168.10.6:8070/v2.0/notification-methods/types/null\"\n        }\n      ],\n      \"type\": \"EMAIL\"\n    },\n    {\n      \"id\": null,\n      \"links\": [\n        {\n          \"rel\": \"self\",\n          \"href\": \"http://192.168.10.6:8070/v2.0/notification-methods/types/null\"\n        }\n      ],\n      \"type\": \"PAGERDUTY\"\n    },\n    {\n      \"id\": null,\n      \"links\": [\n        {\n          \"rel\": \"self\",\n          \"href\": \"http://192.168.10.6:8070/v2.0/notification-methods/types/null\"\n        }\n      ],\n      \"type\": \"WEBHOOK\"\n    }\n  ]","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"e02907e69547b462625978a4b4f1a22fbd234567","unresolved":false,"context_lines":[{"line_number":1971,"context_line":"         \"type\":\"WEBHOOK\""},{"line_number":1972,"context_line":"      }"},{"line_number":1973,"context_line":"   ]"},{"line_number":1974,"context_line":"}"},{"line_number":1975,"context_line":"````"},{"line_number":1976,"context_line":"___"},{"line_number":1977,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":20,"id":"dada55a8_911aa5c4","line":1974,"in_reply_to":"dada55a8_52095883","updated":"2016-07-27 02:21:10.000000000","message":"I can\u0027t get rid of ID, so ID value is same as type and removed links for elements","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"948f68e7c12f65ad6ccb3e87c455a5dd34d741d2","unresolved":false,"context_lines":[{"line_number":1971,"context_line":"         \"type\":\"WEBHOOK\""},{"line_number":1972,"context_line":"      }"},{"line_number":1973,"context_line":"   ]"},{"line_number":1974,"context_line":"}"},{"line_number":1975,"context_line":"````"},{"line_number":1976,"context_line":"___"},{"line_number":1977,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":20,"id":"dada55a8_b8d513e6","line":1974,"in_reply_to":"dada55a8_52095883","updated":"2016-07-26 21:35:54.000000000","message":"Python version is fine","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"0ae67d0e9e8f844edba8856472d2449937456fd4","unresolved":false,"context_lines":[{"line_number":196,"context_line":"      - [Status Code](#status-code-11)"},{"line_number":197,"context_line":"      - [Response Body](#response-body-13)"},{"line_number":198,"context_line":"  - [List supported Notification Method Types](#list-supported-notification-method-types)"},{"line_number":199,"context_line":"    - [GET /v2.0/notification-methods/types/](#get-v20notification-methodstypes)"},{"line_number":200,"context_line":"      - [Headers](#headers-14)"},{"line_number":201,"context_line":"      - [Query Parameters](#query-parameters-14)"},{"line_number":202,"context_line":"      - [Request Body](#request-body-14)"}],"source_content_type":"text/x-markdown","patch_set":27,"id":"bacf61ea_3016f355","line":199,"range":{"start_line":199,"start_character":43,"end_line":199,"end_character":44},"updated":"2016-08-02 20:26:48.000000000","message":"nit: remove trailing slash","commit_id":"5a0801e9d9a915eb891c9c1e659fd673575db26b"},{"author":{"_account_id":20259,"name":"Clenimar Filemon","email":"clenimar@lsd.ufcg.edu.br","username":"clenimar"},"change_message_id":"0ae67d0e9e8f844edba8856472d2449937456fd4","unresolved":false,"context_lines":[{"line_number":1917,"context_line":"## List supported Notification Method Types"},{"line_number":1918,"context_line":"List supported notification method types."},{"line_number":1919,"context_line":""},{"line_number":1920,"context_line":"### GET /v2.0/notification-methods/types/"},{"line_number":1921,"context_line":""},{"line_number":1922,"context_line":"#### Headers"},{"line_number":1923,"context_line":"* X-Auth-Token (string, required) - Keystone auth token"}],"source_content_type":"text/x-markdown","patch_set":27,"id":"bacf61ea_0b2584ad","line":1920,"range":{"start_line":1920,"start_character":40,"end_line":1920,"end_character":41},"updated":"2016-08-02 20:26:48.000000000","message":"nit: remove trailing slash","commit_id":"5a0801e9d9a915eb891c9c1e659fd673575db26b"}],"java/src/main/java/monasca/api/MonApiApplication.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"45e9a9b10e79a6124ebceca25aa4ef0b5aead52f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright (c) 2014 Hewlett-Packard Development L.P."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except"},{"line_number":5,"context_line":" * in compliance with the License. You may obtain a copy of the License at"}],"source_content_type":"text/x-java","patch_set":19,"id":"dada55a8_c82c7e4c","line":2,"updated":"2016-07-26 17:54:00.000000000","message":"Copyright is still not correct.","commit_id":"82d195d58a1dd8719fb7b4316517dfd2b43d38e6"}],"java/src/main/java/monasca/api/app/command/CreateNotificationMethodCommand.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  public CreateNotificationMethodCommand() {this.period \u003d \"0\";}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  public CreateNotificationMethodCommand(String name, String  notificationMethodType, String address, String period) {"},{"line_number":42,"context_line":"    this.name \u003d name;"},{"line_number":43,"context_line":"    this.type \u003d notificationMethodType;"},{"line_number":44,"context_line":"    this.address \u003d address;"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_82d3cc5e","line":41,"range":{"start_line":41,"start_character":62,"end_line":41,"end_character":84},"updated":"2016-07-25 16:24:35.000000000","message":"Extra space should be removed.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  public CreateNotificationMethodCommand() {this.period \u003d \"0\";}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  public CreateNotificationMethodCommand(String name, String  notificationMethodType, String address, String period) {"},{"line_number":42,"context_line":"    this.name \u003d name;"},{"line_number":43,"context_line":"    this.type \u003d notificationMethodType;"},{"line_number":44,"context_line":"    this.address \u003d address;"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_0459995a","line":41,"range":{"start_line":41,"start_character":62,"end_line":41,"end_character":84},"in_reply_to":"dada55a8_82d3cc5e","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  public void validate(List\u003cInteger\u003e validPeriods) {"},{"line_number":84,"context_line":"    NotificationMethodValidation.validate(type, address, convertedPeriod, validPeriods );"},{"line_number":85,"context_line":"  }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  public void setPeriod(String period){"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_efe2632e","line":84,"range":{"start_line":84,"start_character":86,"end_line":84,"end_character":87},"updated":"2016-07-25 21:22:43.000000000","message":"why the extra space?","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":81,"context_line":"  }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  public void validate(List\u003cInteger\u003e validPeriods) {"},{"line_number":84,"context_line":"    NotificationMethodValidation.validate(type, address, convertedPeriod, validPeriods );"},{"line_number":85,"context_line":"  }"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  public void setPeriod(String period){"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_4431d10a","line":84,"range":{"start_line":84,"start_character":86,"end_line":84,"end_character":87},"in_reply_to":"dada55a8_efe2632e","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"}],"java/src/main/java/monasca/api/app/command/PatchNotificationMethodCommand.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return true;"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    public void validate(List\u003cInteger\u003e validPeriods ){"},{"line_number":72,"context_line":"        NotificationMethodValidation.validate(type, address, convertedPeriod,validPeriods);"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_42ba740b","line":71,"range":{"start_line":71,"start_character":52,"end_line":71,"end_character":54},"updated":"2016-07-25 16:24:35.000000000","message":"Extra space should be removed.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        return true;"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    public void validate(List\u003cInteger\u003e validPeriods ){"},{"line_number":72,"context_line":"        NotificationMethodValidation.validate(type, address, convertedPeriod,validPeriods);"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_4418b184","line":71,"range":{"start_line":71,"start_character":52,"end_line":71,"end_character":54},"in_reply_to":"dada55a8_42ba740b","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    public void validate(List\u003cInteger\u003e validPeriods ){"},{"line_number":72,"context_line":"        NotificationMethodValidation.validate(type, address, convertedPeriod,validPeriods);"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @JsonProperty(\"period\")"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_afbfcbfa","line":72,"range":{"start_line":72,"start_character":77,"end_line":72,"end_character":89},"updated":"2016-07-25 21:22:43.000000000","message":"add space back in here","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    public void validate(List\u003cInteger\u003e validPeriods ){"},{"line_number":72,"context_line":"        NotificationMethodValidation.validate(type, address, convertedPeriod,validPeriods);"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @JsonProperty(\"period\")"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_c40ca144","line":72,"range":{"start_line":72,"start_character":77,"end_line":72,"end_character":89},"in_reply_to":"dada55a8_afbfcbfa","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"}],"java/src/main/java/monasca/api/app/validation/NotificationMethodValidation.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    throw Exceptions.unprocessableEntity(\"Address %s is not of correct format\", address);"},{"line_number":40,"context_line":"            }"},{"line_number":41,"context_line":"        if (type.equals(\"WEBHOOK\")) {"},{"line_number":42,"context_line":"                if (!URL_VALIDATOR.isValid(address))"},{"line_number":43,"context_line":"                    throw Exceptions.unprocessableEntity(\"Address %s is not of correct format\", address);"},{"line_number":44,"context_line":"                if (period !\u003d 0 \u0026\u0026 !validPeriods.contains(period)){"},{"line_number":45,"context_line":"                    throw Exceptions.unprocessableEntity(\"%d is not a valid period\", period);"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_626df897","line":42,"updated":"2016-07-25 16:24:35.000000000","message":"Indentation looks to be wrong.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    throw Exceptions.unprocessableEntity(\"Address %s is not of correct format\", address);"},{"line_number":40,"context_line":"            }"},{"line_number":41,"context_line":"        if (type.equals(\"WEBHOOK\")) {"},{"line_number":42,"context_line":"                if (!URL_VALIDATOR.isValid(address))"},{"line_number":43,"context_line":"                    throw Exceptions.unprocessableEntity(\"Address %s is not of correct format\", address);"},{"line_number":44,"context_line":"                if (period !\u003d 0 \u0026\u0026 !validPeriods.contains(period)){"},{"line_number":45,"context_line":"                    throw Exceptions.unprocessableEntity(\"%d is not a valid period\", period);"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_e718c777","line":42,"in_reply_to":"dada55a8_626df897","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"0efd3158197768c54b01354040bea9c570e476e9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    public static void validate(String type, String address, int period,"},{"line_number":35,"context_line":"                                List\u003cInteger\u003e validPeriods) {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if (type.equals(\"EMAIL\")) {"},{"line_number":38,"context_line":"                if (!EmailValidator.getInstance(true).isValid(address))"},{"line_number":39,"context_line":"                    throw Exceptions.unprocessableEntity(\"Address %s is not of correct format\", address);"},{"line_number":40,"context_line":"            }"}],"source_content_type":"text/x-java","patch_set":18,"id":"dada55a8_34277d13","line":37,"range":{"start_line":37,"start_character":24,"end_line":37,"end_character":33},"updated":"2016-07-26 16:48:48.000000000","message":"Do we need to check if period !\u003d 0  for email type?","commit_id":"1c7d884511cbd618630e8225e63e1d0e0ec7a2ac"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"c06b235c36a20395be06727fea536d27aeaaf22c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    public static void validate(String type, String address, int period,"},{"line_number":35,"context_line":"                                List\u003cInteger\u003e validPeriods) {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if (type.equals(\"EMAIL\")) {"},{"line_number":38,"context_line":"                if (!EmailValidator.getInstance(true).isValid(address))"},{"line_number":39,"context_line":"                    throw Exceptions.unprocessableEntity(\"Address %s is not of correct format\", address);"},{"line_number":40,"context_line":"            }"}],"source_content_type":"text/x-java","patch_set":18,"id":"dada55a8_3222e4a3","line":37,"range":{"start_line":37,"start_character":24,"end_line":37,"end_character":33},"in_reply_to":"dada55a8_12008000","updated":"2016-07-26 20:29:19.000000000","message":"Yes thats why we need to check if (period !\u003d 0) here when type\u003demail right?","commit_id":"1c7d884511cbd618630e8225e63e1d0e0ec7a2ac"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"41abc3c1bd741f345741a35269a32f62a23f9722","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    public static void validate(String type, String address, int period,"},{"line_number":35,"context_line":"                                List\u003cInteger\u003e validPeriods) {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if (type.equals(\"EMAIL\")) {"},{"line_number":38,"context_line":"                if (!EmailValidator.getInstance(true).isValid(address))"},{"line_number":39,"context_line":"                    throw Exceptions.unprocessableEntity(\"Address %s is not of correct format\", address);"},{"line_number":40,"context_line":"            }"}],"source_content_type":"text/x-java","patch_set":18,"id":"dada55a8_526961bd","line":37,"range":{"start_line":37,"start_character":24,"end_line":37,"end_character":33},"in_reply_to":"dada55a8_34277d13","updated":"2016-07-26 17:45:08.000000000","message":"I thought periodic is allowed only for email","commit_id":"1c7d884511cbd618630e8225e63e1d0e0ec7a2ac"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"6e5f6f4a219abbf08df4cad1c633e6ac553182a7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    public static void validate(String type, String address, int period,"},{"line_number":35,"context_line":"                                List\u003cInteger\u003e validPeriods) {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if (type.equals(\"EMAIL\")) {"},{"line_number":38,"context_line":"                if (!EmailValidator.getInstance(true).isValid(address))"},{"line_number":39,"context_line":"                    throw Exceptions.unprocessableEntity(\"Address %s is not of correct format\", address);"},{"line_number":40,"context_line":"            }"}],"source_content_type":"text/x-java","patch_set":18,"id":"dada55a8_77ae0e2f","line":37,"range":{"start_line":37,"start_character":24,"end_line":37,"end_character":33},"in_reply_to":"dada55a8_526961bd","updated":"2016-07-26 20:24:24.000000000","message":"I thought its for webhook: \"The interval in seconds to periodically send the notification. Only can be set as a non zero value for WEBHOOK methods. Allowed periods for Webhooks by default are 0, 60.\"  from https://github.com/openstack/monasca-api/blob/master/docs/monasca-api-spec.md","commit_id":"1c7d884511cbd618630e8225e63e1d0e0ec7a2ac"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"ee1b79039eb92814c3b7a5081ad87bdb5987afb7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    public static void validate(String type, String address, int period,"},{"line_number":35,"context_line":"                                List\u003cInteger\u003e validPeriods) {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if (type.equals(\"EMAIL\")) {"},{"line_number":38,"context_line":"                if (!EmailValidator.getInstance(true).isValid(address))"},{"line_number":39,"context_line":"                    throw Exceptions.unprocessableEntity(\"Address %s is not of correct format\", address);"},{"line_number":40,"context_line":"            }"}],"source_content_type":"text/x-java","patch_set":18,"id":"dada55a8_12008000","line":37,"range":{"start_line":37,"start_character":24,"end_line":37,"end_character":33},"in_reply_to":"dada55a8_77ae0e2f","updated":"2016-07-26 20:28:02.000000000","message":"it is only for webhooks but this code is catching that right now with the third conditional period !\u003d 0 \u0026\u0026 !type.equals(\"WEBHOOK\")","commit_id":"1c7d884511cbd618630e8225e63e1d0e0ec7a2ac"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"574cc39bb714822f34fe03875b8453026ff16091","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                 throw Exceptions.unprocessableEntity(\"%d is not a valid period\", period);"},{"line_number":46,"context_line":"            }"},{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":"        if (period !\u003d 0 \u0026\u0026 !type.equals(\"WEBHOOK\")){"},{"line_number":49,"context_line":"               throw Exceptions.unprocessableEntity(\"Period can not be non zero for %s\", type);"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dada55a8_f2a04cf6","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":18},"updated":"2016-07-26 20:32:06.000000000","message":"if period is equal to 60 and the type is anything but webhook we will throw the exception here","commit_id":"1c7d884511cbd618630e8225e63e1d0e0ec7a2ac"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"b5489003419233a540b759cc0d29bb8e80d427aa","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                 throw Exceptions.unprocessableEntity(\"%d is not a valid period\", period);"},{"line_number":46,"context_line":"            }"},{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":"        if (period !\u003d 0 \u0026\u0026 !type.equals(\"WEBHOOK\")){"},{"line_number":49,"context_line":"               throw Exceptions.unprocessableEntity(\"Period can not be non zero for %s\", type);"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-java","patch_set":18,"id":"dada55a8_924c7043","line":48,"range":{"start_line":48,"start_character":12,"end_line":48,"end_character":18},"in_reply_to":"dada55a8_f2a04cf6","updated":"2016-07-26 20:34:42.000000000","message":"You are right! Sorry I didn\u0027t think that through......","commit_id":"1c7d884511cbd618630e8225e63e1d0e0ec7a2ac"}],"java/src/main/java/monasca/api/domain/model/notificationmethod/NotificationMethodType.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * (C) Copyright 2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except"},{"line_number":5,"context_line":" * in compliance with the License. You may obtain a copy of the License at"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_62c97878","line":2,"updated":"2016-07-25 16:24:35.000000000","message":"All the copyrights are incorrect in all the files. The \"Company\" should be removed. Just waiting for them to change it on us again.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"public String getType() {"},{"line_number":36,"context_line":"\treturn type;"},{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"public void setType(String type) {"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_56f23ed3","line":36,"range":{"start_line":36,"start_character":1,"end_line":36,"end_character":7},"updated":"2016-07-25 16:24:35.000000000","message":"The level of indentation is screwed up in this file. I didn\u0027t leave a comment for each one.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"8261d7cec4a4b7a050b6b2c827b3dcfe2600920b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"\t\t\treturn false;"},{"line_number":77,"context_line":"\t} else if (!type.equals(other.type))"},{"line_number":78,"context_line":"\t\treturn false;"},{"line_number":79,"context_line":"\treturn true;"},{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-java","patch_set":20,"id":"dada55a8_fdbf7dcd","line":79,"updated":"2016-07-26 22:18:39.000000000","message":"Indentation is incorrect in this file.","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"e02907e69547b462625978a4b4f1a22fbd234567","unresolved":false,"context_lines":[{"line_number":76,"context_line":"\t\t\treturn false;"},{"line_number":77,"context_line":"\t} else if (!type.equals(other.type))"},{"line_number":78,"context_line":"\t\treturn false;"},{"line_number":79,"context_line":"\treturn true;"},{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-java","patch_set":20,"id":"dada55a8_a0a4b54a","line":79,"in_reply_to":"dada55a8_fdbf7dcd","updated":"2016-07-27 02:21:10.000000000","message":"Done","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"public void setType(String type) {"},{"line_number":39,"context_line":"  this.type \u003d type;"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"public String getId() {return type;} "}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_1fa9d424","line":39,"range":{"start_line":39,"start_character":18,"end_line":39,"end_character":19},"updated":"2016-07-29 18:40:43.000000000","message":"You don\u0027t have .toUpperCase() on this. That doesn\u0027t seem consistent with NotificationMethod","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"cbfa6661e59e2f10432a9328e6a808fd887b2646","unresolved":false,"context_lines":[{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"public void setType(String type) {"},{"line_number":39,"context_line":"  this.type \u003d type;"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"public String getId() {return type;} "}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_334a0f56","line":39,"range":{"start_line":39,"start_character":18,"end_line":39,"end_character":19},"in_reply_to":"bacf61ea_1fa9d424","updated":"2016-07-29 19:40:50.000000000","message":"Correct, it isn\u0027t. The type is just a string and as we didnt\u0027 say it was case insensitive, it should be case sensitive, so lower case should work too.","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"public void setType(String type) {"},{"line_number":39,"context_line":"  this.type \u003d type;"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"public String getId() {return type;} "}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_5454bf1f","line":39,"range":{"start_line":39,"start_character":18,"end_line":39,"end_character":19},"in_reply_to":"bacf61ea_334a0f56","updated":"2016-07-30 06:14:03.000000000","message":"Some place we need to do case insensitive comparission. DB has \"EMAIL\", so if the user sends \"Email\" what should we do?","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"5dc837a6c7b0b2231d87f3ae3b0737ecf47051c3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"public void setType(String type) {"},{"line_number":39,"context_line":"  this.type \u003d type;"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"public String getId() {return type;} "}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_0cf7ac8b","line":39,"range":{"start_line":39,"start_character":18,"end_line":39,"end_character":19},"in_reply_to":"bacf61ea_5454bf1f","updated":"2016-08-01 15:24:06.000000000","message":"So, even though our API doesn\u0027t specify that the name is case insensitive, it looks like the validation does a toUpperCase when comparing. So, to continue with the prior behavior, I think Craig is correct, .toUpperCase just needs to be added here. \n\nSo, let\u0027s stick with the case insensitive compare and upper case everything.\n\nWe should probably update the docs at some point.\n\nSorry for the confusion.","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"}],"java/src/main/java/monasca/api/infrastructure/persistence/hibernate/NotificationMethodSqlRepoImpl.java":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            notificationMethodId);"},{"line_number":180,"context_line":"      }"},{"line_number":181,"context_line":"      db.setName(name);"},{"line_number":182,"context_line":"      db.setType(AlarmNotificationMethodType.valueOf(notificationMethodType));"},{"line_number":183,"context_line":"      db.setAddress(address);"},{"line_number":184,"context_line":"      db.setPeriod(period);"},{"line_number":185,"context_line":"      db.setUpdatedAt(this.getUTCNow());"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_efbf03a8","line":182,"range":{"start_line":182,"start_character":17,"end_line":182,"end_character":44},"updated":"2016-07-25 21:22:43.000000000","message":"this is calling the enum https://github.com/openstack/monasca-common/blob/master/java/monasca-common-model/src/main/java/monasca/common/model/alarm/AlarmNotificationMethodType.java with just the three original types is that correct?","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            notificationMethodId);"},{"line_number":180,"context_line":"      }"},{"line_number":181,"context_line":"      db.setName(name);"},{"line_number":182,"context_line":"      db.setType(AlarmNotificationMethodType.valueOf(notificationMethodType));"},{"line_number":183,"context_line":"      db.setAddress(address);"},{"line_number":184,"context_line":"      db.setPeriod(period);"},{"line_number":185,"context_line":"      db.setUpdatedAt(this.getUTCNow());"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_a7bfeffa","line":182,"range":{"start_line":182,"start_character":17,"end_line":182,"end_character":44},"in_reply_to":"dada55a8_efbf03a8","updated":"2016-07-25 23:04:07.000000000","message":"yes.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":71,"context_line":"          id,"},{"line_number":72,"context_line":"          tenantId,"},{"line_number":73,"context_line":"          name,"},{"line_number":74,"context_line":"          AlarmNotificationMethodType.valueOf(notificationMethodType),"},{"line_number":75,"context_line":"          address,"},{"line_number":76,"context_line":"          period,"},{"line_number":77,"context_line":"          now,"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_624f976b","line":74,"range":{"start_line":74,"start_character":10,"end_line":74,"end_character":69},"updated":"2016-07-29 18:40:43.000000000","message":"It doesn\u0027t seem like this is going to work since AlarmNotificationMethodType is enum with only EMAIL, WEBHOOK and PAGERDUTY","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"          id,"},{"line_number":72,"context_line":"          tenantId,"},{"line_number":73,"context_line":"          name,"},{"line_number":74,"context_line":"          AlarmNotificationMethodType.valueOf(notificationMethodType),"},{"line_number":75,"context_line":"          address,"},{"line_number":76,"context_line":"          period,"},{"line_number":77,"context_line":"          now,"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_542b1f94","line":74,"range":{"start_line":74,"start_character":10,"end_line":74,"end_character":69},"in_reply_to":"bacf61ea_624f976b","updated":"2016-07-30 06:14:03.000000000","message":"This is chicken and egg problem. This code is in monasca-common, and I can\u0027t change it without breaking others. I\u0027will have review where AlaramNotificationMethodType will be converted to class which has all the methods of Enum and constant of Enum. That is the only way to do it without breaking anything else","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"}],"java/src/main/java/monasca/api/infrastructure/persistence/hibernate/NotificationMethodTypesSqlRepoImpl.java":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * Copyright 2015 FUJITSU LIMITED"},{"line_number":3,"context_line":" * (C) Copyright 2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":4,"context_line":" *"},{"line_number":5,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_4f044f7d","line":2,"range":{"start_line":2,"start_character":18,"end_line":2,"end_character":25},"updated":"2016-07-25 21:22:43.000000000","message":"not fujitsu","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"      List\u003cNotificationMethodTypesDb\u003e resultList \u003d q.list();"},{"line_number":59,"context_line":"      for (NotificationMethodTypesDb type : resultList){"},{"line_number":60,"context_line":"    \t  notification_method_types.add(type.getName());"},{"line_number":61,"context_line":"      }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      return notification_method_types;"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_b6857a08","line":60,"updated":"2016-07-25 16:24:35.000000000","message":"indentation again","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"      List\u003cNotificationMethodTypesDb\u003e resultList \u003d q.list();"},{"line_number":59,"context_line":"      for (NotificationMethodTypesDb type : resultList){"},{"line_number":60,"context_line":"    \t  notification_method_types.add(type.getName());"},{"line_number":61,"context_line":"      }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      return notification_method_types;"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_071b5b1c","line":60,"in_reply_to":"dada55a8_b6857a08","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"}],"java/src/main/java/monasca/api/infrastructure/persistence/mysql/NotificationMethodMySqlRepoImpl.java":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    }"},{"line_number":110,"context_line":"  }"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  private boolean isValidNotificaitonMethodType(Handle h ,String notifMethod){"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"      String query \u003d \"  SELECT * from notification_method_type\";"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_0f7897f1","line":112,"range":{"start_line":112,"start_character":65,"end_line":112,"end_character":76},"updated":"2016-07-25 21:22:43.000000000","message":"we spell out notification method in the rest of the code probably should follow that here. also notification is misspelled","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    }"},{"line_number":110,"context_line":"  }"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  private boolean isValidNotificaitonMethodType(Handle h ,String notifMethod){"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"      String query \u003d \"  SELECT * from notification_method_type\";"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_47a1d3a8","line":112,"range":{"start_line":112,"start_character":65,"end_line":112,"end_character":76},"in_reply_to":"dada55a8_0f7897f1","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  private boolean isValidNotificaitonMethodType(Handle h ,String notifMethod){"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"      String query \u003d \"  SELECT * from notification_method_type\";"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"      Query\u003cMap\u003cString, Object\u003e\u003e q  \u003d h.createQuery(query);"},{"line_number":117,"context_line":"      List\u003cMap\u003cString, Object\u003e\u003e  result \u003d q.list();"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_767ca2eb","line":114,"updated":"2016-07-25 16:24:35.000000000","message":"Really shouldn\u0027t have a \"*\" in your select statement and should identify each column explicitly. If a column is added to the table, then problems could occur.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  private boolean isValidNotificaitonMethodType(Handle h ,String notifMethod){"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"      String query \u003d \"  SELECT * from notification_method_type\";"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"      Query\u003cMap\u003cString, Object\u003e\u003e q  \u003d h.createQuery(query);"},{"line_number":117,"context_line":"      List\u003cMap\u003cString, Object\u003e\u003e  result \u003d q.list();"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_c795c340","line":114,"in_reply_to":"dada55a8_767ca2eb","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":122,"context_line":"          if (method.equalsIgnoreCase(notifMethod))"},{"line_number":123,"context_line":"              return true;"},{"line_number":124,"context_line":"      }"},{"line_number":125,"context_line":"      return false;"},{"line_number":126,"context_line":"  }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_c7b316e8","line":125,"updated":"2016-07-25 16:24:35.000000000","message":"Indentation in this file is 2 chars, but you have it as 4 here.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":122,"context_line":"          if (method.equalsIgnoreCase(notifMethod))"},{"line_number":123,"context_line":"              return true;"},{"line_number":124,"context_line":"      }"},{"line_number":125,"context_line":"      return false;"},{"line_number":126,"context_line":"  }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_87990b71","line":125,"in_reply_to":"dada55a8_c7b316e8","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":205,"context_line":"      }"},{"line_number":206,"context_line":"      if(!isValidNotificaitonMethodType(h, notificationMethodType)){"},{"line_number":207,"context_line":"          throw new EntityNotFoundException("},{"line_number":208,"context_line":"          \"Not a valid notification method type %s \",  notificationMethodType);"},{"line_number":209,"context_line":"      }"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"      if (h"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_27cb1255","line":208,"range":{"start_line":208,"start_character":14,"end_line":208,"end_character":15},"updated":"2016-07-25 16:24:35.000000000","message":"The indentation here, which is 4 chars, doesn\u0027t match the indentation up above, which is 2.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":205,"context_line":"      }"},{"line_number":206,"context_line":"      if(!isValidNotificaitonMethodType(h, notificationMethodType)){"},{"line_number":207,"context_line":"          throw new EntityNotFoundException("},{"line_number":208,"context_line":"          \"Not a valid notification method type %s \",  notificationMethodType);"},{"line_number":209,"context_line":"      }"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"      if (h"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_47dd5313","line":208,"range":{"start_line":208,"start_character":14,"end_line":208,"end_character":15},"in_reply_to":"dada55a8_27cb1255","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        throw new EntityExistsException("},{"line_number":61,"context_line":"            \"Notification method %s \\\"%s\\\" already exists.\", tenantId, name);"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      if(!isValidNotificationMethodType(h, notificationMethodType)){"},{"line_number":64,"context_line":"            throw new EntityNotFoundException("},{"line_number":65,"context_line":"            \"Not a valid notification method type %s \",  notificationMethodType);"},{"line_number":66,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_e2438740","line":63,"updated":"2016-07-29 18:40:43.000000000","message":"Should be a space after the if","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        throw new EntityExistsException("},{"line_number":61,"context_line":"            \"Notification method %s \\\"%s\\\" already exists.\", tenantId, name);"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      if(!isValidNotificationMethodType(h, notificationMethodType)){"},{"line_number":64,"context_line":"            throw new EntityNotFoundException("},{"line_number":65,"context_line":"            \"Not a valid notification method type %s \",  notificationMethodType);"},{"line_number":66,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_34702b0b","line":63,"in_reply_to":"bacf61ea_e2438740","updated":"2016-07-30 06:14:03.000000000","message":"Done","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"  private boolean isValidNotificationMethodType(Handle h ,String notificationMethod){"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"   String query \u003d \"  SELECT name from notification_method_type\";"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"   Query\u003cMap\u003cString, Object\u003e\u003e q  \u003d h.createQuery(query);"},{"line_number":117,"context_line":"   List\u003cMap\u003cString, Object\u003e\u003e  result \u003d q.list();"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_427b738c","line":114,"range":{"start_line":114,"start_character":18,"end_line":114,"end_character":21},"updated":"2016-07-29 18:40:43.000000000","message":"Why the extra spaces at the front?","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        throw new EntityExistsException(\"Notification method %s \\\"%s\\\" already exists.\","},{"line_number":204,"context_line":"                  tenantId, name);"},{"line_number":205,"context_line":"      }"},{"line_number":206,"context_line":"      if(!isValidNotificationMethodType(h, notificationMethodType)){"},{"line_number":207,"context_line":"        throw new EntityNotFoundException("},{"line_number":208,"context_line":"        \"Not a valid notification method type %s \",  notificationMethodType);"},{"line_number":209,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_c295a387","line":206,"updated":"2016-07-29 18:40:43.000000000","message":"Need space after the if","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"}],"java/src/main/java/monasca/api/infrastructure/persistence/mysql/NotificationMethodTypesMySqlRepoImpl.java":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  @Override"},{"line_number":49,"context_line":"  public List\u003cString\u003e list_notification_method_types() {"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"\tList\u003cString\u003e  notification_method_types \u003d new ArrayList\u003cString\u003e();"},{"line_number":52,"context_line":"    try (Handle h \u003d db.open()) {"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_af84ebb0","line":49,"range":{"start_line":49,"start_character":22,"end_line":49,"end_character":52},"updated":"2016-07-25 21:22:43.000000000","message":"camalCase here","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  @Override"},{"line_number":49,"context_line":"  public List\u003cString\u003e list_notification_method_types() {"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"\tList\u003cString\u003e  notification_method_types \u003d new ArrayList\u003cString\u003e();"},{"line_number":52,"context_line":"    try (Handle h \u003d db.open()) {"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"      String query \u003d \"  SELECT * from notification_method_type\";"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_a704227e","line":51,"updated":"2016-07-25 16:24:35.000000000","message":"indentation","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\tList\u003cString\u003e  notification_method_types \u003d new ArrayList\u003cString\u003e();"},{"line_number":52,"context_line":"    try (Handle h \u003d db.open()) {"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"      String query \u003d \"  SELECT * from notification_method_type\";"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      Query\u003cMap\u003cString, Object\u003e\u003e q  \u003d h.createQuery(query);"},{"line_number":57,"context_line":"      List\u003cMap\u003cString, Object\u003e\u003e  result \u003d q.list();"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_073b6e39","line":54,"range":{"start_line":54,"start_character":38,"end_line":54,"end_character":62},"updated":"2016-07-25 16:24:35.000000000","message":"Should use select *. Queries should explicitly declare the columns of interest.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    List\u003cString\u003e  notification_method_types \u003d new ArrayList\u003cString\u003e();"},{"line_number":52,"context_line":"    try (Handle h \u003d db.open()) {"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"      String query \u003d \" SELECT name from notification_method_type\";"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      Query\u003cMap\u003cString, Object\u003e\u003e q  \u003d h.createQuery(query);"},{"line_number":57,"context_line":"      List\u003cMap\u003cString, Object\u003e\u003e  result \u003d q.list();"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_c2c9235b","line":54,"range":{"start_line":54,"start_character":22,"end_line":54,"end_character":23},"updated":"2016-07-29 18:40:43.000000000","message":"Why the extra space at the front?","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    List\u003cString\u003e  notification_method_types \u003d new ArrayList\u003cString\u003e();"},{"line_number":52,"context_line":"    try (Handle h \u003d db.open()) {"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"      String query \u003d \" SELECT name from notification_method_type\";"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"      Query\u003cMap\u003cString, Object\u003e\u003e q  \u003d h.createQuery(query);"},{"line_number":57,"context_line":"      List\u003cMap\u003cString, Object\u003e\u003e  result \u003d q.list();"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_54731f15","line":54,"range":{"start_line":54,"start_character":22,"end_line":54,"end_character":23},"in_reply_to":"bacf61ea_c2c9235b","updated":"2016-07-30 06:14:03.000000000","message":"Done","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"}],"java/src/main/java/monasca/api/resource/NotificationMethodResource.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  private final static List\u003cString\u003e ALLOWED_SORT_BY \u003d Arrays.asList(\"id\", \"name\", \"type\","},{"line_number":59,"context_line":"                                                                    \"address\", \"updated_at\","},{"line_number":60,"context_line":"                                                                    \"created_at\");"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  private final List\u003cInteger\u003e validPeriods;"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_c2d003f9","line":61,"updated":"2016-07-29 18:40:43.000000000","message":"Don\u0027t add blank lines to code you aren\u0027t changing","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  private final static List\u003cString\u003e ALLOWED_SORT_BY \u003d Arrays.asList(\"id\", \"name\", \"type\","},{"line_number":59,"context_line":"                                                                    \"address\", \"updated_at\","},{"line_number":60,"context_line":"                                                                    \"created_at\");"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  private final List\u003cInteger\u003e validPeriods;"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_14540751","line":61,"in_reply_to":"bacf61ea_c2d003f9","updated":"2016-07-30 06:14:03.000000000","message":"Done","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    this.persistUtils \u003d persistUtils;"},{"line_number":70,"context_line":"    this.validPeriods \u003d config.validNotificationPeriods \u003d\u003d null ? Arrays.asList(0, 60):"},{"line_number":71,"context_line":"            config.validNotificationPeriods;"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  @POST"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_62067787","line":72,"updated":"2016-07-29 18:40:43.000000000","message":"See above","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    this.persistUtils \u003d persistUtils;"},{"line_number":70,"context_line":"    this.validPeriods \u003d config.validNotificationPeriods \u003d\u003d null ? Arrays.asList(0, 60):"},{"line_number":71,"context_line":"            config.validNotificationPeriods;"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  @POST"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_b4c9bb28","line":72,"in_reply_to":"bacf61ea_62067787","updated":"2016-07-30 06:14:03.000000000","message":"Done","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"}],"java/src/main/java/monasca/api/resource/NotificationMethodTypesResource.java":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":42,"context_line":"public class NotificationMethodTypesResource {"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  NotificationMethodTypesRepo repo \u003d null;"},{"line_number":46,"context_line":"  private final PersistUtils persistUtils;"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_8f12c760","line":45,"range":{"start_line":45,"start_character":2,"end_line":45,"end_character":29},"updated":"2016-07-25 21:22:43.000000000","message":"should this be private like we do in the other resources","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":42,"context_line":"public class NotificationMethodTypesResource {"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  NotificationMethodTypesRepo repo \u003d null;"},{"line_number":46,"context_line":"  private final PersistUtils persistUtils;"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_07787bf1","line":45,"range":{"start_line":45,"start_character":2,"end_line":45,"end_character":29},"in_reply_to":"dada55a8_8f12c760","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  private List\u003cString\u003e  getNotificationMethodTypes()"},{"line_number":58,"context_line":"  {"},{"line_number":59,"context_line":"\t  return repo.list_notification_method_types();"},{"line_number":60,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_af206bb1","line":57,"range":{"start_line":57,"start_character":24,"end_line":57,"end_character":50},"updated":"2016-07-25 21:22:43.000000000","message":"is this a one line method that calls another method? is there reason for that?","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  private List\u003cString\u003e  getNotificationMethodTypes()"},{"line_number":58,"context_line":"  {"},{"line_number":59,"context_line":"\t  return repo.list_notification_method_types();"},{"line_number":60,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_67d4d7bc","line":57,"range":{"start_line":57,"start_character":24,"end_line":57,"end_character":50},"in_reply_to":"dada55a8_af206bb1","updated":"2016-07-25 23:04:07.000000000","message":"Removed","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  private List\u003cString\u003e  getNotificationMethodTypes()"},{"line_number":58,"context_line":"  {"},{"line_number":59,"context_line":"\t  return repo.list_notification_method_types();"},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  @GET"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_a7c70211","line":59,"updated":"2016-07-25 16:24:35.000000000","message":"indentation","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  private List\u003cString\u003e  getNotificationMethodTypes()"},{"line_number":58,"context_line":"  {"},{"line_number":59,"context_line":"\t  return repo.list_notification_method_types();"},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  @GET"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_07fd1b3a","line":59,"in_reply_to":"dada55a8_a7c70211","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"     List\u003cNotificationMethodType\u003e resources \u003d new ArrayList\u003cNotificationMethodType\u003e();"},{"line_number":70,"context_line":"     for (String method_type: getNotificationMethodTypes()){"},{"line_number":71,"context_line":"    \t resources.add(new NotificationMethodType(method_type));"},{"line_number":72,"context_line":"     }"},{"line_number":73,"context_line":"     "},{"line_number":74,"context_line":"     final int paging_limit \u003d this.persistUtils.getLimit(limit);"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_07d7eebf","line":71,"updated":"2016-07-25 16:24:35.000000000","message":"indentation","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"     List\u003cNotificationMethodType\u003e resources \u003d new ArrayList\u003cNotificationMethodType\u003e();"},{"line_number":70,"context_line":"     for (String method_type: getNotificationMethodTypes()){"},{"line_number":71,"context_line":"    \t resources.add(new NotificationMethodType(method_type));"},{"line_number":72,"context_line":"     }"},{"line_number":73,"context_line":"     "},{"line_number":74,"context_line":"     final int paging_limit \u003d this.persistUtils.getLimit(limit);"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_e7f72757","line":71,"in_reply_to":"dada55a8_07d7eebf","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":70,"context_line":"     for (String method_type: getNotificationMethodTypes()){"},{"line_number":71,"context_line":"    \t resources.add(new NotificationMethodType(method_type));"},{"line_number":72,"context_line":"     }"},{"line_number":73,"context_line":"     "},{"line_number":74,"context_line":"     final int paging_limit \u003d this.persistUtils.getLimit(limit);"},{"line_number":75,"context_line":"     return Links.paginate(paging_limit,"},{"line_number":76,"context_line":"             Links.hydrate(resources, uriInfo),"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_47f8c649","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":5},"updated":"2016-07-25 16:24:35.000000000","message":"is there a space or tab here? Gerrit shows it as red.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"     for (String method_type: getNotificationMethodTypes()){"},{"line_number":71,"context_line":"    \t resources.add(new NotificationMethodType(method_type));"},{"line_number":72,"context_line":"     }"},{"line_number":73,"context_line":"     "},{"line_number":74,"context_line":"     final int paging_limit \u003d this.persistUtils.getLimit(limit);"},{"line_number":75,"context_line":"     return Links.paginate(paging_limit,"},{"line_number":76,"context_line":"             Links.hydrate(resources, uriInfo),"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_479553e2","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":5},"in_reply_to":"dada55a8_47f8c649","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"0f07d78be6ae403ca6c4e87fafe9716d6658a3c4","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"     List\u003cNotificationMethodType\u003e resources \u003d new ArrayList\u003cNotificationMethodType\u003e();"},{"line_number":64,"context_line":"     for (String method_type: repo.listNotificationMethodTypes()){"},{"line_number":65,"context_line":"       resources.add(new NotificationMethodType(method_type));"},{"line_number":66,"context_line":"     }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"     final int paging_limit \u003d this.persistUtils.getLimit(limit);"}],"source_content_type":"text/x-java","patch_set":20,"id":"dada55a8_e2799594","line":65,"range":{"start_line":65,"start_character":25,"end_line":65,"end_character":47},"updated":"2016-07-26 22:47:33.000000000","message":"The ID is a part of the AbstractEntity the this class inherits from. You may be able to override it in the class, but I would be fine with either adding an integer value (adjusted for offset) as the ID, or re-using the name as the id.\nThe metric-names resource had a similar issue.","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"e02907e69547b462625978a4b4f1a22fbd234567","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"     List\u003cNotificationMethodType\u003e resources \u003d new ArrayList\u003cNotificationMethodType\u003e();"},{"line_number":64,"context_line":"     for (String method_type: repo.listNotificationMethodTypes()){"},{"line_number":65,"context_line":"       resources.add(new NotificationMethodType(method_type));"},{"line_number":66,"context_line":"     }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"     final int paging_limit \u003d this.persistUtils.getLimit(limit);"}],"source_content_type":"text/x-java","patch_set":20,"id":"dada55a8_d109bd96","line":65,"range":{"start_line":65,"start_character":25,"end_line":65,"end_character":47},"in_reply_to":"dada55a8_e2799594","updated":"2016-07-27 02:21:10.000000000","message":"Reusing name as ID","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"04831477584f74cf4174023ac8da3d0859cad884","unresolved":false,"context_lines":[{"line_number":71,"context_line":"             uriInfo);"},{"line_number":72,"context_line":"  }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":20,"id":"dada55a8_ec87cc5e","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":2},"updated":"2016-07-26 22:20:59.000000000","message":"No spaces","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"e02907e69547b462625978a4b4f1a22fbd234567","unresolved":false,"context_lines":[{"line_number":71,"context_line":"             uriInfo);"},{"line_number":72,"context_line":"  }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":20,"id":"dada55a8_6023ddbd","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":2},"in_reply_to":"dada55a8_ec87cc5e","updated":"2016-07-27 02:21:10.000000000","message":"Done","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  @Timed"},{"line_number":58,"context_line":"  @Produces(MediaType.APPLICATION_JSON)"},{"line_number":59,"context_line":"  public Object list(@Context UriInfo uriInfo,  @QueryParam(\"sort_by\") String sortByStr,"},{"line_number":60,"context_line":"              @QueryParam(\"offset\") String offset,"},{"line_number":61,"context_line":"              @QueryParam(\"limit\") String limit) throws UnsupportedEncodingException {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"     List\u003cNotificationMethodType\u003e resources \u003d new ArrayList\u003cNotificationMethodType\u003e();"},{"line_number":64,"context_line":"     for (String method_type: repo.listNotificationMethodTypes()){"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_a2818fc5","line":61,"range":{"start_line":60,"start_character":14,"end_line":61,"end_character":35},"updated":"2016-07-29 18:40:43.000000000","message":"The API doc does not specify you can pass offset and limit and your repo doesn\u0027t handle them. Remove them","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  @Timed"},{"line_number":58,"context_line":"  @Produces(MediaType.APPLICATION_JSON)"},{"line_number":59,"context_line":"  public Object list(@Context UriInfo uriInfo,  @QueryParam(\"sort_by\") String sortByStr,"},{"line_number":60,"context_line":"              @QueryParam(\"offset\") String offset,"},{"line_number":61,"context_line":"              @QueryParam(\"limit\") String limit) throws UnsupportedEncodingException {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"     List\u003cNotificationMethodType\u003e resources \u003d new ArrayList\u003cNotificationMethodType\u003e();"},{"line_number":64,"context_line":"     for (String method_type: repo.listNotificationMethodTypes()){"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_54e15f99","line":61,"range":{"start_line":60,"start_character":14,"end_line":61,"end_character":35},"in_reply_to":"bacf61ea_a2818fc5","updated":"2016-07-30 06:14:03.000000000","message":"Done","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"}],"java/src/test/java/monasca/api/infrastructure/persistence/hibernate/NotificationMethodSqlRepositoryImplTest.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"ac3281a44f136859c86f2cf57fd42ecc01ab4d79","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  private static final String NOTIFICATION_METHOD_WEBHOOK \u003d \"WEBHOOK\";"},{"line_number":52,"context_line":"  private static final String NOTIFICATION_METHOD_EMAIL   \u003d \"EMAIL\";"},{"line_number":53,"context_line":"  private static final String NOTIFICATION_METHOD_PAGERDUTY   \u003d \"PAGERDUTY\";"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  @BeforeMethod"},{"line_number":56,"context_line":"  protected void beforeMethod() throws Exception {"}],"source_content_type":"text/x-java","patch_set":26,"id":"bacf61ea_0d531c3a","line":53,"range":{"start_line":53,"start_character":10,"end_line":53,"end_character":16},"updated":"2016-08-01 19:40:57.000000000","message":"extra spaces","commit_id":"2e8e0b15a53954576c91404738bdb604e6a79060"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"f40c10f89816248b4cc036d3a2fa3bf979b1b167","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  private static final String NOTIFICATION_METHOD_WEBHOOK \u003d \"WEBHOOK\";"},{"line_number":52,"context_line":"  private static final String NOTIFICATION_METHOD_EMAIL   \u003d \"EMAIL\";"},{"line_number":53,"context_line":"  private static final String NOTIFICATION_METHOD_PAGERDUTY   \u003d \"PAGERDUTY\";"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  @BeforeMethod"},{"line_number":56,"context_line":"  protected void beforeMethod() throws Exception {"}],"source_content_type":"text/x-java","patch_set":26,"id":"bacf61ea_08b4aa32","line":53,"range":{"start_line":53,"start_character":10,"end_line":53,"end_character":16},"in_reply_to":"bacf61ea_0d531c3a","updated":"2016-08-01 19:49:22.000000000","message":"Done","commit_id":"2e8e0b15a53954576c91404738bdb604e6a79060"}],"java/src/test/java/monasca/api/infrastructure/persistence/hibernate/NotificationMethodTypesSqlRepositoryImplTest.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@Test(groups \u003d \"orm\")"},{"line_number":32,"context_line":"public class NotificationMethodTypesSqlRepositoryImplTest {"},{"line_number":33,"context_line":"\tNotificationMethodTypesSqlRepoImpl repo \u003d null;"},{"line_number":34,"context_line":"  private SessionFactory sessionFactory;"},{"line_number":35,"context_line":"  private Transaction tx;"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_478f26cc","line":33,"updated":"2016-07-25 16:24:35.000000000","message":"indentation","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@Test(groups \u003d \"orm\")"},{"line_number":32,"context_line":"public class NotificationMethodTypesSqlRepositoryImplTest {"},{"line_number":33,"context_line":"\tNotificationMethodTypesSqlRepoImpl repo \u003d null;"},{"line_number":34,"context_line":"  private SessionFactory sessionFactory;"},{"line_number":35,"context_line":"  private Transaction tx;"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_e753a737","line":33,"in_reply_to":"dada55a8_478f26cc","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      session.beginTransaction();"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"      for (String method: DEFAULT_NOTIFICATION_METHODS){"},{"line_number":65,"context_line":"    \t  SQLQuery insertQuery \u003d session.createSQLQuery(\"INSERT INTO NOTIFICATION_METHOD_TYPE (name) VALUES(?)\");"},{"line_number":66,"context_line":"    \t  insertQuery.setParameter(0, method);"},{"line_number":67,"context_line":"    \t  insertQuery.executeUpdate();"},{"line_number":68,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_c7b9567b","line":65,"updated":"2016-07-25 16:24:35.000000000","message":"indentation","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      session.beginTransaction();"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"      for (String method: DEFAULT_NOTIFICATION_METHODS){"},{"line_number":65,"context_line":"    \t  SQLQuery insertQuery \u003d session.createSQLQuery(\"INSERT INTO NOTIFICATION_METHOD_TYPE (name) VALUES(?)\");"},{"line_number":66,"context_line":"    \t  insertQuery.setParameter(0, method);"},{"line_number":67,"context_line":"    \t  insertQuery.executeUpdate();"},{"line_number":68,"context_line":"      }"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_4718b384","line":65,"in_reply_to":"dada55a8_c7b9567b","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"04831477584f74cf4174023ac8da3d0859cad884","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  private SessionFactory sessionFactory;"},{"line_number":35,"context_line":"  private Transaction tx;"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":" private final static List\u003cString\u003e DEFAULT_NOTIFICATION_METHODS \u003d Arrays.asList(\"Email\", \"PagerDuty\", \"WebHook\");"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  @BeforeMethod"},{"line_number":40,"context_line":"  protected void beforeMethod() throws Exception {"}],"source_content_type":"text/x-java","patch_set":20,"id":"dada55a8_8ccf307e","line":37,"updated":"2016-07-26 22:20:59.000000000","message":"indents should be multiple of 2","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"e02907e69547b462625978a4b4f1a22fbd234567","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  private SessionFactory sessionFactory;"},{"line_number":35,"context_line":"  private Transaction tx;"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":" private final static List\u003cString\u003e DEFAULT_NOTIFICATION_METHODS \u003d Arrays.asList(\"Email\", \"PagerDuty\", \"WebHook\");"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  @BeforeMethod"},{"line_number":40,"context_line":"  protected void beforeMethod() throws Exception {"}],"source_content_type":"text/x-java","patch_set":20,"id":"dada55a8_16ea2b74","line":37,"in_reply_to":"dada55a8_8ccf307e","updated":"2016-07-27 02:21:10.000000000","message":"Done","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      }"},{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  @Test(groups \u003d \"orm\")"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_42ced32e","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":0},"updated":"2016-07-29 18:40:43.000000000","message":"Too many blank lines","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      }"},{"line_number":76,"context_line":"    }"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  @Test(groups \u003d \"orm\")"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_d4a26f4a","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":0},"in_reply_to":"bacf61ea_42ced32e","updated":"2016-07-30 06:14:03.000000000","message":"Done","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"}],"java/src/test/java/monasca/api/infrastructure/persistence/mysql/NotificationMethodMySqlRepositoryImplTest.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"8261d7cec4a4b7a050b6b2c827b3dcfe2600920b","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    assertEquals(nms, Arrays.asList(new NotificationMethod(\"123\", \"MyEmail\","},{"line_number":113,"context_line":"    \t\tNOTIFICATION_METHOD_EMAIL, \"a@b\", 0),new NotificationMethod(\"124\", \"OtherEmail\","},{"line_number":114,"context_line":"    \t\t\t\tNOTIFICATION_METHOD_EMAIL, \"a@b\", 0)));"},{"line_number":115,"context_line":"  }"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  public void shouldUpdate() {"}],"source_content_type":"text/x-java","patch_set":20,"id":"dada55a8_ddd8b920","line":114,"updated":"2016-07-26 22:18:39.000000000","message":"more indentation being flagged","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"e02907e69547b462625978a4b4f1a22fbd234567","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    assertEquals(nms, Arrays.asList(new NotificationMethod(\"123\", \"MyEmail\","},{"line_number":113,"context_line":"    \t\tNOTIFICATION_METHOD_EMAIL, \"a@b\", 0),new NotificationMethod(\"124\", \"OtherEmail\","},{"line_number":114,"context_line":"    \t\t\t\tNOTIFICATION_METHOD_EMAIL, \"a@b\", 0)));"},{"line_number":115,"context_line":"  }"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  public void shouldUpdate() {"}],"source_content_type":"text/x-java","patch_set":20,"id":"dada55a8_c055691e","line":114,"in_reply_to":"dada55a8_ddd8b920","updated":"2016-07-27 02:21:10.000000000","message":"Done","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  private static final String NOTIFICATION_METHOD_WEBHOOK \u003d \"WEBHOOK\";"},{"line_number":47,"context_line":"  private static final String NOTIFICATION_METHOD_EMAIL   \u003d \"EMAIL\";"},{"line_number":48,"context_line":"  private static final String NOTIFICATION_METHOD_PAGERDUTY   \u003d \"PAGERDUTY\";"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  @BeforeClass"},{"line_number":51,"context_line":"  protected void beforeClass() throws Exception {"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_82d44bbd","line":48,"range":{"start_line":48,"start_character":58,"end_line":48,"end_character":63},"updated":"2016-07-29 18:40:43.000000000","message":"weird spacing","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  private static final String NOTIFICATION_METHOD_WEBHOOK \u003d \"WEBHOOK\";"},{"line_number":47,"context_line":"  private static final String NOTIFICATION_METHOD_EMAIL   \u003d \"EMAIL\";"},{"line_number":48,"context_line":"  private static final String NOTIFICATION_METHOD_PAGERDUTY   \u003d \"PAGERDUTY\";"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  @BeforeClass"},{"line_number":51,"context_line":"  protected void beforeClass() throws Exception {"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_7492a3f7","line":48,"range":{"start_line":48,"start_character":58,"end_line":48,"end_character":63},"in_reply_to":"bacf61ea_82d44bbd","updated":"2016-07-30 06:14:03.000000000","message":"Done","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"}],"java/src/test/java/monasca/api/infrastructure/persistence/mysql/NotificationMethodTypeMySqlRepositoryImplTest.java":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  private final static List\u003cString\u003e DEFAULT_NOTIFICATION_METHODS \u003d Arrays.asList(\"Email\", \"PagerDuty\", \"WebHook\");"},{"line_number":41,"context_line":"  "},{"line_number":42,"context_line":"  @BeforeClass"},{"line_number":43,"context_line":"  protected void beforeClass() throws Exception {"},{"line_number":44,"context_line":"    db \u003d new DBI(\"jdbc:h2:mem:test;MODE\u003dMySQL\");"},{"line_number":45,"context_line":"    handle \u003d db.open();"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_e76d7a05","line":42,"updated":"2016-07-25 16:24:35.000000000","message":"space","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  private final static List\u003cString\u003e DEFAULT_NOTIFICATION_METHODS \u003d Arrays.asList(\"Email\", \"PagerDuty\", \"WebHook\");"},{"line_number":41,"context_line":"  "},{"line_number":42,"context_line":"  @BeforeClass"},{"line_number":43,"context_line":"  protected void beforeClass() throws Exception {"},{"line_number":44,"context_line":"    db \u003d new DBI(\"jdbc:h2:mem:test;MODE\u003dMySQL\");"},{"line_number":45,"context_line":"    handle \u003d db.open();"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_0707db1c","line":42,"in_reply_to":"dada55a8_e76d7a05","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  private void  create_notification_method_types() {"},{"line_number":64,"context_line":"    try (Handle h \u003d db.open()) {"},{"line_number":65,"context_line":"      h.begin();"},{"line_number":66,"context_line":"      for (String methodType : DEFAULT_NOTIFICATION_METHODS){"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_aa3a1932","line":63,"range":{"start_line":63,"start_character":16,"end_line":63,"end_character":48},"updated":"2016-07-25 21:22:43.000000000","message":"camalCase","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  private void  create_notification_method_types() {"},{"line_number":64,"context_line":"    try (Handle h \u003d db.open()) {"},{"line_number":65,"context_line":"      h.begin();"},{"line_number":66,"context_line":"      for (String methodType : DEFAULT_NOTIFICATION_METHODS){"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_7a574e02","line":63,"range":{"start_line":63,"start_character":16,"end_line":63,"end_character":48},"in_reply_to":"dada55a8_aa3a1932","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    try (Handle h \u003d db.open()) {"},{"line_number":65,"context_line":"      h.begin();"},{"line_number":66,"context_line":"      for (String methodType : DEFAULT_NOTIFICATION_METHODS){"},{"line_number":67,"context_line":"    \t  h.insert(\"insert into notification_method_type (name) values (?)\", methodType);"},{"line_number":68,"context_line":"      }"},{"line_number":69,"context_line":"      h.commit();"},{"line_number":70,"context_line":"    }"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_c77036df","line":67,"updated":"2016-07-25 16:24:35.000000000","message":"indentation","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    try (Handle h \u003d db.open()) {"},{"line_number":65,"context_line":"      h.begin();"},{"line_number":66,"context_line":"      for (String methodType : DEFAULT_NOTIFICATION_METHODS){"},{"line_number":67,"context_line":"    \t  h.insert(\"insert into notification_method_type (name) values (?)\", methodType);"},{"line_number":68,"context_line":"      }"},{"line_number":69,"context_line":"      h.commit();"},{"line_number":70,"context_line":"    }"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_1a50d209","line":67,"in_reply_to":"dada55a8_c77036df","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"8261d7cec4a4b7a050b6b2c827b3dcfe2600920b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    try (Handle h \u003d db.open()) {"},{"line_number":65,"context_line":"      h.begin();"},{"line_number":66,"context_line":"      for (String methodType : DEFAULT_NOTIFICATION_METHODS){"},{"line_number":67,"context_line":"    \t  h.insert(\"insert into notification_method_type (name) values (?)\", methodType);"},{"line_number":68,"context_line":"      }"},{"line_number":69,"context_line":"      h.commit();"},{"line_number":70,"context_line":"    }"}],"source_content_type":"text/x-java","patch_set":20,"id":"dada55a8_9df92183","line":67,"updated":"2016-07-26 22:18:39.000000000","message":"indentation","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"e02907e69547b462625978a4b4f1a22fbd234567","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    try (Handle h \u003d db.open()) {"},{"line_number":65,"context_line":"      h.begin();"},{"line_number":66,"context_line":"      for (String methodType : DEFAULT_NOTIFICATION_METHODS){"},{"line_number":67,"context_line":"    \t  h.insert(\"insert into notification_method_type (name) values (?)\", methodType);"},{"line_number":68,"context_line":"      }"},{"line_number":69,"context_line":"      h.commit();"},{"line_number":70,"context_line":"    }"}],"source_content_type":"text/x-java","patch_set":20,"id":"dada55a8_0032e10f","line":67,"in_reply_to":"dada55a8_9df92183","updated":"2016-07-27 02:21:10.000000000","message":"Done","commit_id":"fe3386bbf12a7f4a82bb085917b97fe82f3769f4"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"ac3281a44f136859c86f2cf57fd42ecc01ab4d79","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  private void  createNotificationMethodTypes() {"},{"line_number":64,"context_line":"    try (Handle h \u003d db.open()) {"},{"line_number":65,"context_line":"      h.begin();"},{"line_number":66,"context_line":"      for (String methodType : DEFAULT_NOTIFICATION_METHODS){"}],"source_content_type":"text/x-java","patch_set":26,"id":"bacf61ea_4d1eb470","line":63,"range":{"start_line":63,"start_character":16,"end_line":63,"end_character":45},"updated":"2016-08-01 19:40:57.000000000","message":"there is an extra space","commit_id":"2e8e0b15a53954576c91404738bdb604e6a79060"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"f40c10f89816248b4cc036d3a2fa3bf979b1b167","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  private void  createNotificationMethodTypes() {"},{"line_number":64,"context_line":"    try (Handle h \u003d db.open()) {"},{"line_number":65,"context_line":"      h.begin();"},{"line_number":66,"context_line":"      for (String methodType : DEFAULT_NOTIFICATION_METHODS){"}],"source_content_type":"text/x-java","patch_set":26,"id":"bacf61ea_e8231654","line":63,"range":{"start_line":63,"start_character":16,"end_line":63,"end_character":45},"in_reply_to":"bacf61ea_4d1eb470","updated":"2016-08-01 19:49:22.000000000","message":"Done","commit_id":"2e8e0b15a53954576c91404738bdb604e6a79060"}],"java/src/test/java/monasca/api/resource/NotificationMethodResourceTest.java":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  private static final String NOTIFICATION_METHOD_WEBHOOK \u003d \"WEBHOOK\";"},{"line_number":51,"context_line":"  private static final String NOTIFICATION_METHOD_EMAIL   \u003d \"EMAIL\";"},{"line_number":52,"context_line":"  private static final String NOTIFICATION_METHOD_PAGERDUTY   \u003d \"PAGERDUTY\";"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  @Override"},{"line_number":55,"context_line":"  protected void setupResources() throws Exception {"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_e204274b","line":52,"range":{"start_line":52,"start_character":59,"end_line":52,"end_character":62},"updated":"2016-07-29 18:40:43.000000000","message":"Weird spacing","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  private static final String NOTIFICATION_METHOD_WEBHOOK \u003d \"WEBHOOK\";"},{"line_number":51,"context_line":"  private static final String NOTIFICATION_METHOD_EMAIL   \u003d \"EMAIL\";"},{"line_number":52,"context_line":"  private static final String NOTIFICATION_METHOD_PAGERDUTY   \u003d \"PAGERDUTY\";"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  @Override"},{"line_number":55,"context_line":"  protected void setupResources() throws Exception {"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_34b30b9a","line":52,"range":{"start_line":52,"start_character":59,"end_line":52,"end_character":62},"in_reply_to":"bacf61ea_e204274b","updated":"2016-07-30 06:14:03.000000000","message":"Done","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"}],"java/src/test/java/monasca/api/resource/NotificationMethodTypeResourceTest.java":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"f125d5c6797fb7ee9fe7496a693ed6f236c99037","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  public void shouldList() {"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    List\u003cString\u003e ls\u003d (List) client().resource(\"/v2.0/notification-methods/types\").get(List.class);"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-java","patch_set":5,"id":"1aa78d24_d69ba364","line":43,"updated":"2016-07-12 05:03:06.000000000","message":"Could you add the test that would support two use cases:\n\n1) entry in configuration has more values than default notification types\n2) entry in configuration has just one value\n\n?","commit_id":"9a139ed00679e00bf404a9a6acfe2f370281c904"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"26a9dfef12689c50d51a20a42ef371c797c2ca10","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  public void shouldList() {"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    List\u003cString\u003e ls\u003d (List) client().resource(\"/v2.0/notification-methods/types\").get(List.class);"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-java","patch_set":5,"id":"1aa78d24_e0df8838","line":43,"in_reply_to":"1aa78d24_d69ba364","updated":"2016-07-13 19:40:27.000000000","message":"Done","commit_id":"9a139ed00679e00bf404a9a6acfe2f370281c904"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    config.validNotificationPeriods \u003d Arrays.asList(0, 60);"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    List\u003cString\u003e NOTIFICATION_METHODS \u003d Arrays.asList(\"Email\", \"PagerDuty\", \"WebHook\");"},{"line_number":48,"context_line":"    "},{"line_number":49,"context_line":"    NotificationMethodTypesRepo repo \u003d mock(NotificationMethodTypesRepo.class);"},{"line_number":50,"context_line":"    when(repo.list_notification_method_types())"},{"line_number":51,"context_line":"        .thenReturn(NOTIFICATION_METHODS);"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_c7479675","line":48,"updated":"2016-07-25 16:24:35.000000000","message":"space/tab and several other spots in this file.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    config.validNotificationPeriods \u003d Arrays.asList(0, 60);"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    List\u003cString\u003e NOTIFICATION_METHODS \u003d Arrays.asList(\"Email\", \"PagerDuty\", \"WebHook\");"},{"line_number":48,"context_line":"    "},{"line_number":49,"context_line":"    NotificationMethodTypesRepo repo \u003d mock(NotificationMethodTypesRepo.class);"},{"line_number":50,"context_line":"    when(repo.list_notification_method_types())"},{"line_number":51,"context_line":"        .thenReturn(NOTIFICATION_METHODS);"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_ba68a6bb","line":48,"in_reply_to":"dada55a8_c7479675","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  private Set\u003cString\u003e getNotificationMethods(List\u003c?\u003e elements)"},{"line_number":61,"context_line":"  {"},{"line_number":62,"context_line":"     Set\u003cString\u003e  rNotificationMethods \u003d new TreeSet\u003cString\u003e();"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"     for ( Object p : elements){"},{"line_number":65,"context_line":"         Map mp \u003d (Map)p;"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_0a7885f1","line":62,"range":{"start_line":62,"start_character":18,"end_line":62,"end_character":38},"updated":"2016-07-25 21:22:43.000000000","message":"better name then rNotificationMethods? is this supposed to be returnNotificationMethods or resultNotificationMethods?","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  private Set\u003cString\u003e getNotificationMethods(List\u003c?\u003e elements)"},{"line_number":61,"context_line":"  {"},{"line_number":62,"context_line":"     Set\u003cString\u003e  rNotificationMethods \u003d new TreeSet\u003cString\u003e();"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"     for ( Object p : elements){"},{"line_number":65,"context_line":"         Map mp \u003d (Map)p;"}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_1a9e12b8","line":62,"range":{"start_line":62,"start_character":18,"end_line":62,"end_character":38},"in_reply_to":"dada55a8_0a7885f1","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  public void shouldListCorrectNotifcaitonTypes() throws Exception"},{"line_number":74,"context_line":"  {"},{"line_number":75,"context_line":"      List\u003cPaged\u003e pages  \u003d  (List\u003cPaged\u003e) client().resource(\"/v2.0/notification-methods/types\").get(Paged.class).elements;"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_ca54ad55","line":73,"range":{"start_line":73,"start_character":14,"end_line":73,"end_character":47},"updated":"2016-07-25 21:22:43.000000000","message":"notification spelled wrong","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  public void shouldListCorrectNotifcaitonTypes() throws Exception"},{"line_number":74,"context_line":"  {"},{"line_number":75,"context_line":"      List\u003cPaged\u003e pages  \u003d  (List\u003cPaged\u003e) client().resource(\"/v2.0/notification-methods/types\").get(Paged.class).elements;"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_7a7c6e72","line":73,"range":{"start_line":73,"start_character":14,"end_line":73,"end_character":47},"in_reply_to":"dada55a8_ca54ad55","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":99,"context_line":"      pages  \u003d  (List\u003cPaged\u003e) client().resource(\"/v2.0/notification-methods/types\").get(Paged.class).elements;"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      responseGot \u003d getNotificationMethods(pages);"},{"line_number":102,"context_line":"      expectedNotificationMethodTypes \u003d new TreeSet\u003cString\u003e(Arrays.asList(\"EMAIL\", \"TYPE1\", \"TYPE2\", \"TYPE3\"));"},{"line_number":103,"context_line":"      assertEquals(responseGot, expectedNotificationMethodTypes);"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-java","patch_set":16,"id":"dada55a8_6ad4a1bc","line":102,"range":{"start_line":102,"start_character":52,"end_line":102,"end_character":58},"updated":"2016-07-25 21:22:43.000000000","message":"should we do a negative test?","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    addResources(resource);"},{"line_number":55,"context_line":"  }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  private Set\u003cString\u003e getNotificationMethods(List\u003c?\u003e elements)"},{"line_number":61,"context_line":"  {"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_a29d0f0c","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":0},"updated":"2016-07-29 18:40:43.000000000","message":"Too many blank lines","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    addResources(resource);"},{"line_number":55,"context_line":"  }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  private Set\u003cString\u003e getNotificationMethods(List\u003c?\u003e elements)"},{"line_number":61,"context_line":"  {"}],"source_content_type":"text/x-java","patch_set":24,"id":"bacf61ea_74a90324","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":0},"in_reply_to":"bacf61ea_a29d0f0c","updated":"2016-07-30 06:14:03.000000000","message":"Done","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"}],"java/src/test/resources/monasca/api/infrastructure/persistence/mysql/notification_method_type.sql":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":1,"context_line":"CREATE TABLE `notification_method_type` ("},{"line_number":2,"context_line":"  `name` varchar(20) NOT NULL DEFAULT \u0027\u0027,"},{"line_number":3,"context_line":"  PRIMARY KEY (`name`)"},{"line_number":4,"context_line":");"}],"source_content_type":"text/x-sql","patch_set":16,"id":"dada55a8_ca02ed3d","line":1,"range":{"start_line":1,"start_character":14,"end_line":1,"end_character":38},"updated":"2016-07-25 21:22:43.000000000","message":"i dont see this in the devstack schema file","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"CREATE TABLE `notification_method_type` ("},{"line_number":2,"context_line":"  `name` varchar(20) NOT NULL DEFAULT \u0027\u0027,"},{"line_number":3,"context_line":"  PRIMARY KEY (`name`)"},{"line_number":4,"context_line":");"}],"source_content_type":"text/x-sql","patch_set":16,"id":"dada55a8_dae2ba2e","line":1,"range":{"start_line":1,"start_character":14,"end_line":1,"end_character":38},"in_reply_to":"dada55a8_ca02ed3d","updated":"2016-07-25 23:04:07.000000000","message":"Devstack files/schema/ already has this table","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"}],"monasca_api/api/notifications_api_v2.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"796cf11235f8175419cbacff65dd99836d1ebd90","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014,2016 Hewlett Packard Enterprise Development LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_e2b26793","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":67},"updated":"2016-07-29 18:40:43.000000000","message":"Since you didn\u0027t actually make any changes other than the copyright, you don\u0027t have to update the copyright","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014,2016 Hewlett Packard Enterprise Development LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_946ab7ec","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":67},"in_reply_to":"bacf61ea_e2b26793","updated":"2016-07-30 06:14:03.000000000","message":"Done","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"}],"monasca_api/api/notificationstype_api_v2.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Hewlett-Packard"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_62dcd812","line":1,"updated":"2016-07-25 16:24:35.000000000","message":"Copyright.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"}],"monasca_api/common/repositories/mysql/notification_method_type_repository.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"f35a80efd4855ca89be458a87e61587d436d7dab","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        super(NotificationMethodTypeRepository, self).__init__()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def list_notification_method_types(self):"},{"line_number":31,"context_line":"        query \u003d \"select name from notification_method_type\""},{"line_number":32,"context_line":"        rows \u003d self._execute_query(query)"},{"line_number":33,"context_line":"        return rows"}],"source_content_type":"text/x-python","patch_set":21,"id":"bacf61ea_37b19090","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":38},"updated":"2016-07-28 21:38:05.000000000","message":"This needs the @mysql_repository.mysql_try_catch_block decorator to properly translate from mysql errors to errors we\u0027re going to surface to the user.","commit_id":"66af542b96e120daa87e4ee1d5f0ed79b565b8dc"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"0fe68385ed998dd1eaa419afc0fd0e23b980027a","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        super(NotificationMethodTypeRepository, self).__init__()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def list_notification_method_types(self):"},{"line_number":31,"context_line":"        query \u003d \"select name from notification_method_type\""},{"line_number":32,"context_line":"        rows \u003d self._execute_query(query)"},{"line_number":33,"context_line":"        return rows"}],"source_content_type":"text/x-python","patch_set":21,"id":"bacf61ea_2aa2a2ae","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":38},"in_reply_to":"bacf61ea_37b19090","updated":"2016-07-29 15:05:15.000000000","message":"Done","commit_id":"66af542b96e120daa87e4ee1d5f0ed79b565b8dc"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"762a0fc2bbd0e2f9843d3b863c5d675cf651a56f","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        super(NotificationMethodTypeRepository, self).__init__()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @sql_repository.sql_try_catch_block"},{"line_number":31,"context_line":"    def list_notification_method_types(self):"},{"line_number":32,"context_line":"        query \u003d \"select name from notification_method_type\""},{"line_number":33,"context_line":"        rows \u003d self._execute_query(query)"}],"source_content_type":"text/x-python","patch_set":22,"id":"bacf61ea_8a22aeff","line":30,"updated":"2016-07-29 15:09:25.000000000","message":"This needs to be @mysql_repository.mysql_try_catch_block\n\nYou\u0027re not importing a sql_repository in this file.","commit_id":"94853730db24394f9af495b18f935fa1f281a973"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"c15539f40c4d473731d2eae615f271513485b473","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(NotificationMethodTypeRepository, self).__init__()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @sql_repository.sql_try_catch_block"},{"line_number":32,"context_line":"    def list_notification_method_types(self):"},{"line_number":33,"context_line":"        query \u003d \"select name from notification_method_type\""},{"line_number":34,"context_line":"        rows \u003d self._execute_query(query)"},{"line_number":35,"context_line":"        return rows"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_ca8f86ca","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":38},"updated":"2016-07-29 15:12:36.000000000","message":"This needs to be @mysql_repository.mysql_try_catch_block\n\nThe sqla decorator is slightly different.  Use the one from the existing mysql_repository import and remove the sqla import.","commit_id":"138e5470f6337d8f53738b22dc5091e3583c9905"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"4d4ef6bf354403363faa082a349f480e0f3bf258","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(NotificationMethodTypeRepository, self).__init__()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @sql_repository.sql_try_catch_block"},{"line_number":32,"context_line":"    def list_notification_method_types(self):"},{"line_number":33,"context_line":"        query \u003d \"select name from notification_method_type\""},{"line_number":34,"context_line":"        rows \u003d self._execute_query(query)"},{"line_number":35,"context_line":"        return rows"}],"source_content_type":"text/x-python","patch_set":23,"id":"bacf61ea_a78884c6","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":38},"in_reply_to":"bacf61ea_ca8f86ca","updated":"2016-07-29 17:00:53.000000000","message":"Sorry. Fixed it","commit_id":"138e5470f6337d8f53738b22dc5091e3583c9905"}],"monasca_api/common/repositories/sqla/notification_method_type_repository.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def list_notification_method_types(self):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        with self._db_engine.connect() as conn:"},{"line_number":42,"context_line":"            LOG.debug(\u0027Orm query {%s}\u0027, str(self._nmt_query))"},{"line_number":43,"context_line":"            notification_method_types \u003d conn.execute(self._nmt_query).fetchall()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"            return [row[0] for row in notification_method_types]"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_ea01b107","line":42,"range":{"start_line":42,"start_character":27,"end_line":42,"end_character":32},"updated":"2016-07-25 21:22:43.000000000","message":"do we need to log here?","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def list_notification_method_types(self):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        with self._db_engine.connect() as conn:"},{"line_number":42,"context_line":"            LOG.debug(\u0027Orm query {%s}\u0027, str(self._nmt_query))"},{"line_number":43,"context_line":"            notification_method_types \u003d conn.execute(self._nmt_query).fetchall()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"            return [row[0] for row in notification_method_types]"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_3a3796b1","line":42,"range":{"start_line":42,"start_character":27,"end_line":42,"end_character":32},"in_reply_to":"dada55a8_ea01b107","updated":"2016-07-25 23:04:07.000000000","message":"I will remove it","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"}],"monasca_api/v2/reference/__init__.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"f7b2c1aa5142be4555ef252f26b7f81471340d18","unresolved":false,"context_lines":[{"line_number":33,"context_line":"               cfg.ListOpt(\u0027valid_notification_periods\u0027, default\u003d[0, 60],"},{"line_number":34,"context_line":"                           help\u003d\u0027Valid periods for notification methods\u0027),"},{"line_number":35,"context_line":"               cfg.ListOpt(\u0027valid_notification_method_types\u0027, default\u003d[\"Email\", \"PagerDuty\", \"WebHook\"],"},{"line_number":36,"context_line":"                           help\u003d\u0027Valid notification method types\u0027)"},{"line_number":37,"context_line":"               ]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"cfg.CONF.register_opts(global_opts)"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_d513b25a","line":36,"range":{"start_line":36,"start_character":39,"end_line":36,"end_character":51},"updated":"2016-07-25 21:22:43.000000000","message":"do you use this in the code?","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":33,"context_line":"               cfg.ListOpt(\u0027valid_notification_periods\u0027, default\u003d[0, 60],"},{"line_number":34,"context_line":"                           help\u003d\u0027Valid periods for notification methods\u0027),"},{"line_number":35,"context_line":"               cfg.ListOpt(\u0027valid_notification_method_types\u0027, default\u003d[\"Email\", \"PagerDuty\", \"WebHook\"],"},{"line_number":36,"context_line":"                           help\u003d\u0027Valid notification method types\u0027)"},{"line_number":37,"context_line":"               ]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"cfg.CONF.register_opts(global_opts)"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_1a61f2a8","line":36,"range":{"start_line":36,"start_character":39,"end_line":36,"end_character":51},"in_reply_to":"dada55a8_d513b25a","updated":"2016-07-25 23:04:07.000000000","message":"No, forgot to remove it","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"0efd3158197768c54b01354040bea9c570e476e9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\"\"\""},{"line_number":32,"context_line":"global_opts \u003d [cfg.StrOpt(\u0027region\u0027, help\u003d\u0027Region that API is running in\u0027),"},{"line_number":33,"context_line":"               cfg.ListOpt(\u0027valid_notification_periods\u0027, default\u003d[0, 60],"},{"line_number":34,"context_line":"                           help\u003d\u0027Valid periods for notification methods\u0027),"},{"line_number":35,"context_line":"               ]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"cfg.CONF.register_opts(global_opts)"}],"source_content_type":"text/x-python","patch_set":18,"id":"dada55a8_37b01f43","line":34,"range":{"start_line":34,"start_character":73,"end_line":34,"end_character":74},"updated":"2016-07-26 16:48:48.000000000","message":"do we have an extra , here?","commit_id":"1c7d884511cbd618630e8225e63e1d0e0ec7a2ac"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"41abc3c1bd741f345741a35269a32f62a23f9722","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\"\"\""},{"line_number":32,"context_line":"global_opts \u003d [cfg.StrOpt(\u0027region\u0027, help\u003d\u0027Region that API is running in\u0027),"},{"line_number":33,"context_line":"               cfg.ListOpt(\u0027valid_notification_periods\u0027, default\u003d[0, 60],"},{"line_number":34,"context_line":"                           help\u003d\u0027Valid periods for notification methods\u0027),"},{"line_number":35,"context_line":"               ]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"cfg.CONF.register_opts(global_opts)"}],"source_content_type":"text/x-python","patch_set":18,"id":"dada55a8_72b3c54d","line":34,"range":{"start_line":34,"start_character":73,"end_line":34,"end_character":74},"in_reply_to":"dada55a8_37b01f43","updated":"2016-07-26 17:45:08.000000000","message":"That should be fine. Any how I will remove it","commit_id":"1c7d884511cbd618630e8225e63e1d0e0ec7a2ac"}],"monasca_api/v2/reference/notifications.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"d56b9e4efcddf1d8d3f1f64070e6642df70a1131","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    notifications_request_body_schema as schemas_notifications)"},{"line_number":24,"context_line":"from monasca_api.v2.common.schemas import exceptions as schemas_exceptions"},{"line_number":25,"context_line":"from monasca_api.v2.common import validation"},{"line_number":26,"context_line":"from monasca_api.v2.reference import helpers"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_f03c8d94","line":26,"range":{"start_line":26,"start_character":1,"end_line":26,"end_character":44},"updated":"2016-07-21 20:01:45.000000000","message":"You removed the resource import but this provides the decorator used on all the database access methods in this file.","commit_id":"9f5419c6dfd7fa967545f23f189eaab734e7a207"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"d56b9e4efcddf1d8d3f1f64070e6642df70a1131","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    \"A notification method with name {} already exists with id {}\""},{"line_number":72,"context_line":"                    .format(name, found_notification_id))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _validate_notification_method_type_exist(self, nmt):"},{"line_number":75,"context_line":"        notification_methods \u003d self._notification_method_type_repo.list_notification_method_types(notification_method)"},{"line_number":76,"context_line":"        exists \u003d nmt.upper() in notification_methods"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_b5004703","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":48},"updated":"2016-07-21 20:01:45.000000000","message":"This seems to be dead code that isn\u0027t referenced anywhere else.","commit_id":"9f5419c6dfd7fa967545f23f189eaab734e7a207"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"c93702f709d85f5f9d6c3762846f85ecfb63ce0e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            if found_notification_id !\u003d expected_id:"},{"line_number":69,"context_line":"                LOG.warn(\"Found existing notification method for {} with tenant_id {} with unexpected id {}\""},{"line_number":70,"context_line":"                         .format(name, tenant_id, found_notification_id))"},{"line_number":71,"context_line":"                raise falcon.HTTPBadRequest("},{"line_number":72,"context_line":"                    \"A notification method with name {} already exists with id {}\""},{"line_number":73,"context_line":"                    .format(name, found_notification_id))"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_b19216f4","line":71,"range":{"start_line":71,"start_character":29,"end_line":71,"end_character":43},"updated":"2016-07-21 21:45:00.000000000","message":"Why did this change?  A duplicate entry should be a 409 shouldn\u0027t it?","commit_id":"6ce88b911ec9cb0b25959da0b027fd40ab069c97"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"dbd72bcfb5ca84c8aa407ae7c30f4fd4e79c9f33","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            if found_notification_id !\u003d expected_id:"},{"line_number":69,"context_line":"                LOG.warn(\"Found existing notification method for {} with tenant_id {} with unexpected id {}\""},{"line_number":70,"context_line":"                         .format(name, tenant_id, found_notification_id))"},{"line_number":71,"context_line":"                raise falcon.HTTPBadRequest("},{"line_number":72,"context_line":"                    \"A notification method with name {} already exists with id {}\""},{"line_number":73,"context_line":"                    .format(name, found_notification_id))"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_140e6be4","line":71,"range":{"start_line":71,"start_character":29,"end_line":71,"end_character":43},"in_reply_to":"dada55a8_b19216f4","updated":"2016-07-22 01:21:31.000000000","message":"My mistake.  It is getting hard rebasing dependent reviews, Will fix it.","commit_id":"6ce88b911ec9cb0b25959da0b027fd40ab069c97"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"1a9ef89e41ed980144ce13569e2b09770800e8f6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        if not exists:"},{"line_number":80,"context_line":"                LOG.warn(\"Found no notification method type  {} . Did you install/enable the plugin for that type?\""},{"line_number":81,"context_line":"                         .format(nmt))"},{"line_number":82,"context_line":"                raise exceptions.AlreadyExistsException(\"Not a valid notification method type {} \".format(nmt))"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @resource.resource_try_catch_block"},{"line_number":85,"context_line":"    def _create_notification(self, tenant_id, notification, uri):"}],"source_content_type":"text/x-python","patch_set":12,"id":"dada55a8_ebb58931","line":82,"range":{"start_line":82,"start_character":33,"end_line":82,"end_character":55},"updated":"2016-07-22 16:52:25.000000000","message":"It doesn\u0027t seem like not finding the data you\u0027re after should raise an AlreadyExistsException.","commit_id":"6ce88b911ec9cb0b25959da0b027fd40ab069c97"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"c82e1f5905b5290945d99973ca3f9ab989304883","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        exists \u003d nmt.upper() in notification_methods"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        if not exists:"},{"line_number":80,"context_line":"                LOG.warn(\"Found no notification method type  {} . Did you install/enable the plugin for that type?\""},{"line_number":81,"context_line":"                         .format(nmt))"},{"line_number":82,"context_line":"                raise falcon.HTTPBadRequest(\u0027Bad Request\u0027, \"Not a valid notification method type {} \".format(nmt))"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_04f87e48","line":80,"range":{"start_line":80,"start_character":16,"end_line":80,"end_character":19},"updated":"2016-07-25 20:10:18.000000000","message":"Is the tabbing here too deep?","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        exists \u003d nmt.upper() in notification_methods"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        if not exists:"},{"line_number":80,"context_line":"                LOG.warn(\"Found no notification method type  {} . Did you install/enable the plugin for that type?\""},{"line_number":81,"context_line":"                         .format(nmt))"},{"line_number":82,"context_line":"                raise falcon.HTTPBadRequest(\u0027Bad Request\u0027, \"Not a valid notification method type {} \".format(nmt))"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_faf17ece","line":80,"range":{"start_line":80,"start_character":16,"end_line":80,"end_character":19},"in_reply_to":"dada55a8_04f87e48","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"0ccdefdd20c8500edc6482045e234b1d6759b30d","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _validate_notification_method_type_exist(self, nmt):"},{"line_number":76,"context_line":"        notification_methods \u003d self._notification_method_type_repo.list_notification_method_types()"},{"line_number":77,"context_line":"        exists \u003d nmt.upper() in notification_methods"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        if not exists:"},{"line_number":80,"context_line":"            LOG.warn(\"Found no notification method type  {} . Did you install/enable the plugin for that type?\""}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_581a427e","line":77,"updated":"2016-07-29 19:39:24.000000000","message":"This upper should be removed too. The Notification Method Type is a string. We didn\u0027t make it case insensitive.","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"39febce5d9ee0b58246560eafe3e1883bfc938c9","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _validate_notification_method_type_exist(self, nmt):"},{"line_number":76,"context_line":"        notification_methods \u003d self._notification_method_type_repo.list_notification_method_types()"},{"line_number":77,"context_line":"        exists \u003d nmt.upper() in notification_methods"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        if not exists:"},{"line_number":80,"context_line":"            LOG.warn(\"Found no notification method type  {} . Did you install/enable the plugin for that type?\""}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_1477e7d3","line":77,"in_reply_to":"bacf61ea_581a427e","updated":"2016-07-30 06:14:03.000000000","message":"Database has it as \"EMAIL\". So if the user sends \"Email\" should we throw invalid notification type?  I don\u0027t think so.\n\nSomewhere we need to do case insensitive comparison","commit_id":"3a3517240f282e4a0e04881f6aa661d90842f32a"}],"monasca_api/v2/reference/notificationstype.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"d56b9e4efcddf1d8d3f1f64070e6642df70a1131","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def on_get(self, req, res):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        result \u003d self._notification_method_type_repo.list_notification_method_types()"},{"line_number":35,"context_line":"        res.body \u003d helpers.dumpit_utf8(dict(types\u003dresult))"},{"line_number":36,"context_line":"        res.status \u003d falcon.HTTP_200"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_501f595a","line":34,"range":{"start_line":34,"start_character":17,"end_line":34,"end_character":85},"updated":"2016-07-21 20:01:45.000000000","message":"This call needs to be broken out into a self method and wrapped with a @resource.resource_try_catch_block decorator so that we don\u0027t let exceptions bubble up to gunicorn.","commit_id":"9f5419c6dfd7fa967545f23f189eaab734e7a207"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def on_get(self, req, res):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # This is to provide consistency. Pagination is not really supported here as there"},{"line_number":42,"context_line":"        # are no that many rows"},{"line_number":43,"context_line":"        limit \u003d helpers.get_limit(req)"},{"line_number":44,"context_line":"        result \u003d self._list_notifications(req.uri, limit)"}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_4219d478","line":41,"range":{"start_line":41,"start_character":60,"end_line":41,"end_character":66},"updated":"2016-07-25 16:24:35.000000000","message":"not supported yet","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def on_get(self, req, res):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # This is to provide consistency. Pagination is not really supported here as there"},{"line_number":42,"context_line":"        # are no that many rows"},{"line_number":43,"context_line":"        limit \u003d helpers.get_limit(req)"},{"line_number":44,"context_line":"        result \u003d self._list_notifications(req.uri, limit)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_a2fff0ff","line":42,"updated":"2016-07-25 16:24:35.000000000","message":"no -\u003e not","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def on_get(self, req, res):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # This is to provide consistency. Pagination is not really supported here as there"},{"line_number":42,"context_line":"        # are no that many rows"},{"line_number":43,"context_line":"        limit \u003d helpers.get_limit(req)"},{"line_number":44,"context_line":"        result \u003d self._list_notifications(req.uri, limit)"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_bacee680","line":42,"in_reply_to":"dada55a8_a2fff0ff","updated":"2016-07-25 23:04:07.000000000","message":"Done","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"}],"monasca_tempest_tests/tests/api/test_notification_method_type.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"20b51af8102bca9585293f5e195762b6794d0624","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        resp, response_body \u003d self.monasca_client.list_notification_method_types()"},{"line_number":41,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_e25a8882","line":42,"updated":"2016-07-25 16:24:35.000000000","message":"I think there could be some more Tempest tests added, such as negative tests, and also testing whether the response object contains the right stuff, like links, elements, elements is a list, and elements contains expected types.","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"6c3eb6f1294167a3c21f7b84be7d1066021d20cf","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        resp, response_body \u003d self.monasca_client.list_notification_method_types()"},{"line_number":41,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"dada55a8_faadfe88","line":42,"in_reply_to":"dada55a8_e25a8882","updated":"2016-07-25 23:04:07.000000000","message":"Will do it","commit_id":"a37af62314b692268174f9cf7ddb551bfbaa84da"}],"monasca_tempest_tests/tests/api/test_notification_methods.py":[{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"dfda5f1d6fd5a9481b28449405f11b70a1eeb189","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                          self.monasca_client.create_notifications,"},{"line_number":152,"context_line":"                          notification)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":155,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":156,"context_line":"    def test_create_notification_method_with_invalid_type(self):"},{"line_number":157,"context_line":"        notification \u003d helpers.create_notification(type\u003d\u0027random\u0027)"},{"line_number":158,"context_line":"        self.assertRaises((exceptions.BadRequest, exceptions.UnprocessableEntity),"},{"line_number":159,"context_line":"                          self.monasca_client.create_notifications,"},{"line_number":160,"context_line":"                          notification)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":163,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"}],"source_content_type":"text/x-python","patch_set":18,"id":"dada55a8_7773b74e","line":160,"range":{"start_line":154,"start_character":4,"end_line":160,"end_character":39},"updated":"2016-07-26 16:53:28.000000000","message":"This test failed with \"tempest.lib.exceptions.NotFound: Object not found Details: {u\u0027internal_code\u0027: u\u002767a952cc9c97f873\u0027, u\u0027message\u0027: u\u0027Not a valid notification method type random \u0027, u\u0027code\u0027: 404, u\u0027details\u0027: u\u0027\u0027}\"","commit_id":"1c7d884511cbd618630e8225e63e1d0e0ec7a2ac"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"41abc3c1bd741f345741a35269a32f62a23f9722","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                          self.monasca_client.create_notifications,"},{"line_number":152,"context_line":"                          notification)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":155,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"},{"line_number":156,"context_line":"    def test_create_notification_method_with_invalid_type(self):"},{"line_number":157,"context_line":"        notification \u003d helpers.create_notification(type\u003d\u0027random\u0027)"},{"line_number":158,"context_line":"        self.assertRaises((exceptions.BadRequest, exceptions.UnprocessableEntity),"},{"line_number":159,"context_line":"                          self.monasca_client.create_notifications,"},{"line_number":160,"context_line":"                          notification)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":163,"context_line":"    @test.attr(type\u003d[\u0027negative\u0027])"}],"source_content_type":"text/x-python","patch_set":18,"id":"dada55a8_3294ad89","line":160,"range":{"start_line":154,"start_character":4,"end_line":160,"end_character":39},"in_reply_to":"dada55a8_7773b74e","updated":"2016-07-26 17:45:08.000000000","message":"Will look into it","commit_id":"1c7d884511cbd618630e8225e63e1d0e0ec7a2ac"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"dfda5f1d6fd5a9481b28449405f11b70a1eeb189","unresolved":false,"context_lines":[{"line_number":791,"context_line":"            notification)"},{"line_number":792,"context_line":"        id \u003d response_body[\u0027id\u0027]"},{"line_number":793,"context_line":"        self.assertEqual(201, resp.status)"},{"line_number":794,"context_line":"        self.assertRaises((exceptions.BadRequest, exceptions.NotFound, exceptions.UnprocessableEntity),"},{"line_number":795,"context_line":"                          self.monasca_client.patch_notification_method, id, type\u003d\u0027random\u0027)"},{"line_number":796,"context_line":"        resp, response_body \u003d \\"},{"line_number":797,"context_line":"            self.monasca_client.delete_notification_method(id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"dada55a8_d7b543ed","line":794,"range":{"start_line":794,"start_character":61,"end_line":794,"end_character":69},"updated":"2016-07-26 16:53:28.000000000","message":"In java tempest tests log it shows: \"tempest.lib.exceptions.NotFound: Object not found\"","commit_id":"1c7d884511cbd618630e8225e63e1d0e0ec7a2ac"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"41abc3c1bd741f345741a35269a32f62a23f9722","unresolved":false,"context_lines":[{"line_number":791,"context_line":"            notification)"},{"line_number":792,"context_line":"        id \u003d response_body[\u0027id\u0027]"},{"line_number":793,"context_line":"        self.assertEqual(201, resp.status)"},{"line_number":794,"context_line":"        self.assertRaises((exceptions.BadRequest, exceptions.NotFound, exceptions.UnprocessableEntity),"},{"line_number":795,"context_line":"                          self.monasca_client.patch_notification_method, id, type\u003d\u0027random\u0027)"},{"line_number":796,"context_line":"        resp, response_body \u003d \\"},{"line_number":797,"context_line":"            self.monasca_client.delete_notification_method(id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"dada55a8_d2e9d11b","line":794,"range":{"start_line":794,"start_character":61,"end_line":794,"end_character":69},"in_reply_to":"dada55a8_d7b543ed","updated":"2016-07-26 17:45:08.000000000","message":"Looking into it","commit_id":"1c7d884511cbd618630e8225e63e1d0e0ec7a2ac"}]}