)]}'
{"monasca_tempest_tests/tests/api/base.py":[{"author":{"_account_id":21264,"name":"Hasan","email":"htuncer@us.ibm.com","username":"htuncer"},"change_message_id":"97c736e3feb03b65b274d878661bce2ce741e939","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def resource_cleanup(cls):"},{"line_number":58,"context_line":"        super(BaseMonascaTest, cls).resource_cleanup()"},{"line_number":59,"context_line":"        resp, response_body \u003d cls.monasca_client.list_alarm_definitions()"},{"line_number":60,"context_line":"        if resp.status \u003d\u003d 200:"},{"line_number":61,"context_line":"            if \u0027elements\u0027 in response_body:"},{"line_number":62,"context_line":"                elements \u003d response_body[\u0027elements\u0027]"},{"line_number":63,"context_line":"                for element in elements:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7ac969e8_9a99dd22","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":30},"updated":"2016-08-12 23:20:38.000000000","message":"What if the resp.status is not 200 ? I believe those cases should be handled or at least logged.","commit_id":"1b1206cf8024f8dedae0769b40a3e1b8b7b79908"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0d6dee749eef19fcf889fae16d1853070c400440","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def resource_cleanup(cls):"},{"line_number":58,"context_line":"        super(BaseMonascaTest, cls).resource_cleanup()"},{"line_number":59,"context_line":"        resp, response_body \u003d cls.monasca_client.list_alarm_definitions()"},{"line_number":60,"context_line":"        if resp.status \u003d\u003d 200:"},{"line_number":61,"context_line":"            if \u0027elements\u0027 in response_body:"},{"line_number":62,"context_line":"                elements \u003d response_body[\u0027elements\u0027]"},{"line_number":63,"context_line":"                for element in elements:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_55014f05","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":30},"in_reply_to":"7ac969e8_9a99dd22","updated":"2016-08-17 15:22:13.000000000","message":"In case the error is not a 2xx an error will be raised.\nIn general the response status should be validated using expected_success in the service client itself: http://git.openstack.org/cgit/openstack/tempest/tree/tempest/lib/common/rest_client.py#n218\n\nThis is not something that I touched in this patch, so this should be addressed by a separate patch.","commit_id":"1b1206cf8024f8dedae0769b40a3e1b8b7b79908"}],"monasca_tempest_tests/tests/api/test_read_only_role.py":[{"author":{"_account_id":21264,"name":"Hasan","email":"htuncer@us.ibm.com","username":"htuncer"},"change_message_id":"97c736e3feb03b65b274d878661bce2ce741e939","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":51,"context_line":"    def test_list_metrics_success(self):"},{"line_number":52,"context_line":"        resp, response_body \u003d self.monasca_client.list_metrics()"},{"line_number":53,"context_line":"        #"},{"line_number":54,"context_line":"        # Validate the call succeeds with empty result (we didn\u0027t"},{"line_number":55,"context_line":"        # create any metrics)"},{"line_number":56,"context_line":"        #"},{"line_number":57,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":58,"context_line":"        self.assertEqual(0, len(response_body[\u0027elements\u0027]))"},{"line_number":59,"context_line":"        self.assertTrue(response_body[\u0027links\u0027][0][\u0027href\u0027].endswith(\u0027/v2.0/metrics\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7ac969e8_9a16fda5","line":56,"range":{"start_line":53,"start_character":0,"end_line":56,"end_character":9},"updated":"2016-08-12 23:20:38.000000000","message":"Minor thing, just wanted to point out. These comments are not pythonic. See https://www.python.org/dev/peps/pep-0008/#comments","commit_id":"1b1206cf8024f8dedae0769b40a3e1b8b7b79908"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0d6dee749eef19fcf889fae16d1853070c400440","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":51,"context_line":"    def test_list_metrics_success(self):"},{"line_number":52,"context_line":"        resp, response_body \u003d self.monasca_client.list_metrics()"},{"line_number":53,"context_line":"        #"},{"line_number":54,"context_line":"        # Validate the call succeeds with empty result (we didn\u0027t"},{"line_number":55,"context_line":"        # create any metrics)"},{"line_number":56,"context_line":"        #"},{"line_number":57,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":58,"context_line":"        self.assertEqual(0, len(response_body[\u0027elements\u0027]))"},{"line_number":59,"context_line":"        self.assertTrue(response_body[\u0027links\u0027][0][\u0027href\u0027].endswith(\u0027/v2.0/metrics\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_383c8ac7","line":56,"range":{"start_line":53,"start_character":0,"end_line":56,"end_character":9},"in_reply_to":"7ac969e8_9a16fda5","updated":"2016-08-17 15:22:13.000000000","message":"I agree. Not something I touched though, so it should be addressed in a different patch.","commit_id":"1b1206cf8024f8dedae0769b40a3e1b8b7b79908"}]}