)]}'
{"devstack/files/schema/mon_mysql.sql":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"f6682bb68aa3159d3dace3a130001485f4fb0d36","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  `expression` longtext COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":181,"context_line":"  `created_at` datetime NOT NULL,"},{"line_number":182,"context_line":"  `updated_at` datetime NOT NULL,"},{"line_number":183,"context_line":"  `state` varchar(20) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":184,"context_line":"  PRIMARY KEY (`id`),"},{"line_number":185,"context_line":"  KEY `fk_sub_alarm` (`alarm_id`),"},{"line_number":186,"context_line":"  KEY `fk_sub_alarm_expr` (`sub_expression_id`),"}],"source_content_type":"text/x-sql","patch_set":1,"id":"bacf61ea_0fed978b","line":183,"updated":"2016-07-27 21:37:49.000000000","message":"Shouldn\u0027t that be constrained with alarm_state table ?","commit_id":"fde128a2c896b28434363f33ce7977392dc7c1c6"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"fd4a4b745c9df44983272aa777d5ccec39db87b1","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  `expression` longtext COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":181,"context_line":"  `created_at` datetime NOT NULL,"},{"line_number":182,"context_line":"  `updated_at` datetime NOT NULL,"},{"line_number":183,"context_line":"  `state` varchar(20) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":184,"context_line":"  PRIMARY KEY (`id`),"},{"line_number":185,"context_line":"  KEY `fk_sub_alarm` (`alarm_id`),"},{"line_number":186,"context_line":"  KEY `fk_sub_alarm_expr` (`sub_expression_id`),"}],"source_content_type":"text/x-sql","patch_set":2,"id":"bacf61ea_b36f8691","line":183,"range":{"start_line":183,"start_character":0,"end_line":183,"end_character":58},"updated":"2016-07-28 05:49:58.000000000","message":"This isn\u0027t going to work. The current Threshold Engine is not setting this field so all attempts to create sub_alarms fail. That is why the tests fail with no alarms being created. We need a default value on this field that is valid","commit_id":"02eb55ed1f6271fbdc05b4483b0ffa8c0a4b0922"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"9fe9f37c2ca3e8d533d5aa1cffabb2a1d04b9259","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  `expression` longtext COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":181,"context_line":"  `created_at` datetime NOT NULL,"},{"line_number":182,"context_line":"  `updated_at` datetime NOT NULL,"},{"line_number":183,"context_line":"  `state` varchar(20) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT \u0027OK\u0027,"},{"line_number":184,"context_line":"  PRIMARY KEY (`id`),"},{"line_number":185,"context_line":"  KEY `fk_sub_alarm` (`alarm_id`),"},{"line_number":186,"context_line":"  KEY `fk_sub_alarm_expr` (`sub_expression_id`),"}],"source_content_type":"text/x-sql","patch_set":3,"id":"bacf61ea_29627f3e","line":183,"range":{"start_line":183,"start_character":67,"end_line":183,"end_character":69},"updated":"2016-08-01 04:40:49.000000000","message":"Wouldn\u0027t be safer to assume UNDETERMINED ?","commit_id":"6b2b88f3cab46cd442369b22da3624611b871169"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"200d61b1c844375faa8890c7665c653d654e42dc","unresolved":false,"context_lines":[{"line_number":180,"context_line":"  `expression` longtext COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":181,"context_line":"  `created_at` datetime NOT NULL,"},{"line_number":182,"context_line":"  `updated_at` datetime NOT NULL,"},{"line_number":183,"context_line":"  `state` varchar(20) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT \u0027OK\u0027,"},{"line_number":184,"context_line":"  PRIMARY KEY (`id`),"},{"line_number":185,"context_line":"  KEY `fk_sub_alarm` (`alarm_id`),"},{"line_number":186,"context_line":"  KEY `fk_sub_alarm_expr` (`sub_expression_id`),"}],"source_content_type":"text/x-sql","patch_set":3,"id":"bacf61ea_aa29288c","line":183,"range":{"start_line":183,"start_character":67,"end_line":183,"end_character":69},"in_reply_to":"bacf61ea_29627f3e","updated":"2016-08-01 13:32:16.000000000","message":"It doesn\u0027t really matter. The column just has to be there and have a default state so that sub alarms can be created with the old code which does not set state. My thought was that most existing sub alarms would have OK state since Alarms normally should be in the OK state","commit_id":"6b2b88f3cab46cd442369b22da3624611b871169"}]}