)]}'
{"monasca_api/v2/reference/metrics.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"7d24e9815f63c54ce6c9be4ddad3de251e87f464","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def on_get(self, req, res):"},{"line_number":300,"context_line":"        helpers.validate_authorization(req, self._get_metrics_authorized_roles)"},{"line_number":301,"context_line":"        tenant_id \u003d helpers.get_tenant_id(req)"},{"line_number":302,"context_line":"        dimensions \u003d helpers.get_query_dimensions(req)"},{"line_number":303,"context_line":"        helpers.validate_query_dimensions(dimensions)"},{"line_number":304,"context_line":"        offset \u003d helpers.get_query_param(req, \u0027offset\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_615b5d55","line":301,"range":{"start_line":301,"start_character":28,"end_line":301,"end_character":41},"updated":"2016-12-12 20:56:49.000000000","message":"Based on the documentation, docs/monasca-api-spec.md, this should be get_x_tenant_or_tenant_id.\n\nSame for DimensionValues andDimensionNames","commit_id":"154bf921ee75a23e3c12464b5897e9feb4c2ef47"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"8fdc32cc73ebf633fb672483dcc91ece5abc28ff","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    def on_get(self, req, res):"},{"line_number":300,"context_line":"        helpers.validate_authorization(req, self._get_metrics_authorized_roles)"},{"line_number":301,"context_line":"        tenant_id \u003d helpers.get_tenant_id(req)"},{"line_number":302,"context_line":"        dimensions \u003d helpers.get_query_dimensions(req)"},{"line_number":303,"context_line":"        helpers.validate_query_dimensions(dimensions)"},{"line_number":304,"context_line":"        offset \u003d helpers.get_query_param(req, \u0027offset\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_5a3f1f25","line":301,"range":{"start_line":301,"start_character":28,"end_line":301,"end_character":41},"in_reply_to":"1a6eadb0_615b5d55","updated":"2016-12-13 01:04:43.000000000","message":"Done","commit_id":"154bf921ee75a23e3c12464b5897e9feb4c2ef47"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"cc49f6a456452a603205cbba2c474bc5bac03b8e","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def on_get(self, req, res):"},{"line_number":175,"context_line":"        helpers.validate_authorization(req, self._get_metrics_authorized_roles)"},{"line_number":176,"context_line":"        tenant_id \u003d helpers.get_tenant_id(req)"},{"line_number":177,"context_line":"        name \u003d helpers.get_query_name(req, True)"},{"line_number":178,"context_line":"        helpers.validate_query_name(name)"},{"line_number":179,"context_line":"        dimensions \u003d helpers.get_query_dimensions(req)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_a4771039","line":176,"range":{"start_line":176,"start_character":28,"end_line":176,"end_character":41},"updated":"2016-12-13 18:28:33.000000000","message":"_delegate_authorized_roles is set in __init__ but not used. I think get_x_tenant_or_tenant_id should also be used here. Sorry, missed that one on the last review.","commit_id":"997702fe303016652164c987fe0fa777341a5579"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"3df5d0b7cd543042d835c5d4dd17231a417d943d","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def on_get(self, req, res):"},{"line_number":175,"context_line":"        helpers.validate_authorization(req, self._get_metrics_authorized_roles)"},{"line_number":176,"context_line":"        tenant_id \u003d helpers.get_tenant_id(req)"},{"line_number":177,"context_line":"        name \u003d helpers.get_query_name(req, True)"},{"line_number":178,"context_line":"        helpers.validate_query_name(name)"},{"line_number":179,"context_line":"        dimensions \u003d helpers.get_query_dimensions(req)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_10bab06e","line":176,"range":{"start_line":176,"start_character":28,"end_line":176,"end_character":41},"in_reply_to":"1a6eadb0_a4771039","updated":"2016-12-14 01:11:34.000000000","message":"Done","commit_id":"997702fe303016652164c987fe0fa777341a5579"}],"monasca_tempest_tests/tests/api/test_metrics.py":[{"author":{"_account_id":20033,"name":"Artur Basiak","email":"artur.basiak@ts.fujitsu.com","username":"abasiak"},"change_message_id":"7380973aed4416ca104120a3701b33e84bd87ac0","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            metric, tenant_id\u003dtenant[\u0027id\u0027])"},{"line_number":429,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":430,"context_line":"        query_param \u003d \u0027?tenant_id\u003d\u0027 + str(tenant[\u0027id\u0027])"},{"line_number":431,"context_line":"        for i in xrange(constants.MAX_RETRIES):"},{"line_number":432,"context_line":"            resp, response_body \u003d self.monasca_client.list_metrics(query_param)"},{"line_number":433,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":434,"context_line":"            elements \u003d response_body[\u0027elements\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_93935da3","line":431,"range":{"start_line":431,"start_character":17,"end_line":431,"end_character":23},"updated":"2016-12-13 06:24:06.000000000","message":"Code should be compatible with python3.5 so please use range() from six module.","commit_id":"b0e6c5a988426f8110b96097749b908fd131e806"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"36db77b125063d9078a5e621c445786fcaed5e2f","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            metric, tenant_id\u003dtenant[\u0027id\u0027])"},{"line_number":429,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":430,"context_line":"        query_param \u003d \u0027?tenant_id\u003d\u0027 + str(tenant[\u0027id\u0027])"},{"line_number":431,"context_line":"        for i in xrange(constants.MAX_RETRIES):"},{"line_number":432,"context_line":"            resp, response_body \u003d self.monasca_client.list_metrics(query_param)"},{"line_number":433,"context_line":"            self.assertEqual(200, resp.status)"},{"line_number":434,"context_line":"            elements \u003d response_body[\u0027elements\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_b1b92cec","line":431,"range":{"start_line":431,"start_character":17,"end_line":431,"end_character":23},"in_reply_to":"1a6eadb0_93935da3","updated":"2016-12-13 09:15:37.000000000","message":"Done","commit_id":"b0e6c5a988426f8110b96097749b908fd131e806"}]}
