)]}'
{"monasca_api/v2/reference/alarm_definitions.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"56575a45367c6060b5caef34a8e04149b23b6ed0","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        undetermined_actions_list \u003d get_comma_separated_str_as_list("},{"line_number":266,"context_line":"            alarm_definition_row[\u0027undetermined_actions\u0027])"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        description \u003d (alarm_definition_row[\u0027description\u0027]"},{"line_number":269,"context_line":"                       if alarm_definition_row[\u0027description\u0027] is not None else None)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        expression \u003d alarm_definition_row[\u0027expression\u0027].decode(\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_0d8f932a","line":268,"range":{"start_line":268,"start_character":44,"end_line":268,"end_character":57},"updated":"2016-11-17 23:27:16.000000000","message":"I\u0027m just kind of lost. How come you had to remove the .decode(\u0027utf8\u0027) from description but not \u0027expression\u0027?","commit_id":"cfa4e8781b426597058a37a56fd1ecd4322147d1"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"4e66ab07bb3384c3de861cb1da747a8d1204731c","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        undetermined_actions_list \u003d get_comma_separated_str_as_list("},{"line_number":266,"context_line":"            alarm_definition_row[\u0027undetermined_actions\u0027])"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        description \u003d (alarm_definition_row[\u0027description\u0027]"},{"line_number":269,"context_line":"                       if alarm_definition_row[\u0027description\u0027] is not None else None)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        expression \u003d alarm_definition_row[\u0027expression\u0027].decode(\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_84f0d592","line":268,"range":{"start_line":268,"start_character":44,"end_line":268,"end_character":57},"in_reply_to":"7a77a97e_0d8f932a","updated":"2016-11-18 05:46:19.000000000","message":"Expression has only ascii character so it is safe to decode(\u0027utf8\u0027), but description which has non-ascii character is failed to decode(\u0027utf8\u0027).\nI think it is meaningless to decode(\u0027utf8\u0027) ascii character, so I will remove decode next patch set.","commit_id":"cfa4e8781b426597058a37a56fd1ecd4322147d1"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"b481971e17910707116d394f367c45d627ef82d5","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        undetermined_actions_list \u003d get_comma_separated_str_as_list("},{"line_number":266,"context_line":"            alarm_definition_row[\u0027undetermined_actions\u0027])"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        description \u003d (alarm_definition_row[\u0027description\u0027]"},{"line_number":269,"context_line":"                       if alarm_definition_row[\u0027description\u0027] is not None else None)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        expression \u003d alarm_definition_row[\u0027expression\u0027].decode(\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_8b97748f","line":268,"range":{"start_line":268,"start_character":44,"end_line":268,"end_character":57},"in_reply_to":"7a77a97e_460bfe7c","updated":"2016-11-24 10:29:39.000000000","message":"I added a test pettern which is metric name, dimensions names/values and value meta names/values having non-ascii characters.\ninfluxdb client have to be version up to handle utf8 correctly.","commit_id":"cfa4e8781b426597058a37a56fd1ecd4322147d1"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"7fffe7a99404704087f6ff4ea410da16af315ceb","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        undetermined_actions_list \u003d get_comma_separated_str_as_list("},{"line_number":266,"context_line":"            alarm_definition_row[\u0027undetermined_actions\u0027])"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        description \u003d (alarm_definition_row[\u0027description\u0027]"},{"line_number":269,"context_line":"                       if alarm_definition_row[\u0027description\u0027] is not None else None)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        expression \u003d alarm_definition_row[\u0027expression\u0027].decode(\u0027utf8\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_460bfe7c","line":268,"range":{"start_line":268,"start_character":44,"end_line":268,"end_character":57},"in_reply_to":"7a77a97e_84f0d592","updated":"2016-11-18 21:15:36.000000000","message":"expression can have non-ascii characters in it since the metric name and dimensions names/values can be non-ascii.","commit_id":"cfa4e8781b426597058a37a56fd1ecd4322147d1"}]}