)]}'
{"monasca_api/v2/common/schemas/alarm_definition_request_body_schema.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"7caca7d1762358f0076a7b6e22808f62005c0bb7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"MAX_ITEM_LENGTH \u003d 50"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def validate_action_list(v, action_type):"},{"line_number":34,"context_line":"    if not isinstance(v, list):"},{"line_number":35,"context_line":"        raise Invalid(\u0027Not a list: {}\u0027.format(type(v)))"},{"line_number":36,"context_line":"    for i in v:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_dafc2674","line":33,"range":{"start_line":33,"start_character":25,"end_line":33,"end_character":26},"updated":"2016-11-12 15:34:37.000000000","message":"could we use a more descriptive parameter name then v?","commit_id":"47cf87560672c7015aa65fa6cf553638deffc55b"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"a1d59978a488d925d956adb4caf9ba489cbb3184","unresolved":false,"context_lines":[{"line_number":30,"context_line":"MAX_ITEM_LENGTH \u003d 50"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def validate_action_list(v, action_type):"},{"line_number":34,"context_line":"    if not isinstance(v, list):"},{"line_number":35,"context_line":"        raise Invalid(\u0027Not a list: {}\u0027.format(type(v)))"},{"line_number":36,"context_line":"    for i in v:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_8a033b0f","line":33,"range":{"start_line":33,"start_character":25,"end_line":33,"end_character":26},"in_reply_to":"9a629dbe_dafc2674","updated":"2016-11-14 20:03:04.000000000","message":"Good idea, esp since it helped me to see that my loops were wrong","commit_id":"47cf87560672c7015aa65fa6cf553638deffc55b"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"cdb5161c026c5eb529c697c407e3541ca9b35918","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def validate_action_list(notification_ids, action_type):"},{"line_number":34,"context_line":"    if not isinstance(notification_ids, list):"},{"line_number":35,"context_line":"        raise Invalid(\u0027Not a list: {}\u0027.format(type(notification_ids)))"},{"line_number":36,"context_line":"    existing \u003d []"},{"line_number":37,"context_line":"    for notification_id in notification_ids:"},{"line_number":38,"context_line":"        if not isinstance(notification_id, (str, unicode)):"},{"line_number":39,"context_line":"            raise Invalid(\u0027list item \u003c{}\u003e -\u003e {} not one of (str, unicode)\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_7d06a821","line":36,"range":{"start_line":36,"start_character":15,"end_line":36,"end_character":17},"updated":"2016-11-14 22:16:04.000000000","message":"Could make this a set instead of a list, but the difference is probably not significant.","commit_id":"750cdc12c2d0a44eda21c50a27323b58cdc3f716"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"34e45da6c37a1e82c97774bdc676f3eec8bf24bb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def validate_action_list(notification_ids, action_type):"},{"line_number":34,"context_line":"    if not isinstance(notification_ids, list):"},{"line_number":35,"context_line":"        raise Invalid(\u0027Not a list: {}\u0027.format(type(notification_ids)))"},{"line_number":36,"context_line":"    existing \u003d []"},{"line_number":37,"context_line":"    for notification_id in notification_ids:"},{"line_number":38,"context_line":"        if not isinstance(notification_id, (str, unicode)):"},{"line_number":39,"context_line":"            raise Invalid(\u0027list item \u003c{}\u003e -\u003e {} not one of (str, unicode)\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_d4bf51f9","line":36,"range":{"start_line":36,"start_character":15,"end_line":36,"end_character":17},"in_reply_to":"7a77a97e_7d06a821","updated":"2016-11-16 07:21:46.000000000","message":"I don\u0027t this that would matter here. Variable is scoped to only this function and function is meant to verify just a single type of the action. I am cool with that.","commit_id":"750cdc12c2d0a44eda21c50a27323b58cdc3f716"}]}