)]}'
{"monasca_api/expression_parser/alarm_expr_parser.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"6a3a0d30d162b704c7f9a8867e324add3ad6748f","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    period \u003d int(tokens[0])"},{"line_number":194,"context_line":"    if period \u003d\u003d 0:"},{"line_number":195,"context_line":"        raise pyparsing.ParseFatalException(instr, loc,"},{"line_number":196,"context_line":"                                            \"Period must be 0\")"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    if (period % 60) !\u003d 0:"},{"line_number":199,"context_line":"        raise pyparsing.ParseFatalException(instr, loc,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_83d79cbe","line":196,"range":{"start_line":196,"start_character":44,"end_line":196,"end_character":63},"updated":"2016-11-29 22:07:35.000000000","message":"Isn\u0027t this if verifying that period is 0?","commit_id":"c19714612731f116db25c6671f8e3ce114a53dba"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"c28ba00fcf77ceda7b09f96ae153d0f38b765467","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    period \u003d int(tokens[0])"},{"line_number":194,"context_line":"    if period \u003d\u003d 0:"},{"line_number":195,"context_line":"        raise pyparsing.ParseFatalException(instr, loc,"},{"line_number":196,"context_line":"                                            \"Period must be 0\")"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    if (period % 60) !\u003d 0:"},{"line_number":199,"context_line":"        raise pyparsing.ParseFatalException(instr, loc,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_49ebe3b0","line":196,"range":{"start_line":196,"start_character":44,"end_line":196,"end_character":63},"in_reply_to":"5a74a57a_83d79cbe","updated":"2016-11-29 22:48:38.000000000","message":"Good catch. Fixed.","commit_id":"c19714612731f116db25c6671f8e3ce114a53dba"},{"author":{"_account_id":18286,"name":"Shinya Kawabata","email":"s-kawabata@wx.jp.nec.com","username":"kawabata"},"change_message_id":"d05956e5fe9bac14dfc486b46fc5398d00ad2688","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        raise pyparsing.ParseFatalException(instr, loc,"},{"line_number":200,"context_line":"                                            \"Period {} must be a multiple of 60\""},{"line_number":201,"context_line":"                                            .format(period))"},{"line_number":202,"context_line":"    return period"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"def periodsValidation(instr, loc, tokens):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_6f133a0e","line":202,"range":{"start_line":202,"start_character":4,"end_line":202,"end_character":17},"updated":"2016-11-30 02:46:19.000000000","message":"It should return string type object.\nIt is failed to create alarm-definition including period and periods.","commit_id":"a1c503a86eb548776a8b141b7ffa89eddd68f388"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"55beb90af74bc90570c54e5e30d6519665d1ed0a","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        raise pyparsing.ParseFatalException(instr, loc,"},{"line_number":200,"context_line":"                                            \"Period {} must be a multiple of 60\""},{"line_number":201,"context_line":"                                            .format(period))"},{"line_number":202,"context_line":"    return period"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"def periodsValidation(instr, loc, tokens):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_437a0f25","line":202,"range":{"start_line":202,"start_character":4,"end_line":202,"end_character":17},"in_reply_to":"5a74a57a_6f133a0e","updated":"2017-01-09 05:10:48.000000000","message":"You are right. Thanks Shinya","commit_id":"a1c503a86eb548776a8b141b7ffa89eddd68f388"}],"monasca_api/tests/test_alarm_expression.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"6e0c85b17976eb7a02bcb05fc59984801fe8b3ff","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from monasca_api.expression_parser.alarm_expr_parser import AlarmExprParser"},{"line_number":16,"context_line":"import pyparsing"},{"line_number":17,"context_line":"import unittest"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_10e756e5","line":15,"updated":"2017-01-13 09:04:48.000000000","message":"nit: would mind movie this import down below unittest + import alarm_expr_perser module instead of AlarmExprParser as OS suggests ?","commit_id":"7d7ded93b3b9a722591ebd8a59166c1b9099a1f9"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6b92b466a9b9cb8f41e0f51fd872e91a669e7e64","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from monasca_api.expression_parser.alarm_expr_parser import AlarmExprParser"},{"line_number":16,"context_line":"import pyparsing"},{"line_number":17,"context_line":"import unittest"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a3c09a3_e0dbb1eb","line":15,"in_reply_to":"7a3c09a3_10e756e5","updated":"2017-01-13 23:18:39.000000000","message":"Done","commit_id":"7d7ded93b3b9a722591ebd8a59166c1b9099a1f9"}],"monasca_api/v2/reference/alarm_definitions.py":[{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"06ff43550e7930cc561a300892cdfbdd46850141","unresolved":false,"context_lines":[{"line_number":497,"context_line":"                pyparsing.ParseFatalException) as ex:"},{"line_number":498,"context_line":"            LOG.exception(ex)"},{"line_number":499,"context_line":"            title \u003d \"Invalid alarm expression\".encode(\u0027utf8\u0027)"},{"line_number":500,"context_line":"            msg \u003d \"parser failed on expression \u0027{}\u0027 at column {}: \".format("},{"line_number":501,"context_line":"                  expression.encode(\u0027utf8\u0027), str(ex.column).encode(\u0027utf8\u0027),"},{"line_number":502,"context_line":"                  ex.msg.encode(\u0027utf8\u0027))"},{"line_number":503,"context_line":"            raise HTTPUnprocessableEntityError(title, msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_423762e3","line":500,"range":{"start_line":500,"start_character":64,"end_line":500,"end_character":66},"updated":"2017-01-12 22:14:31.000000000","message":"missing \u0027{}\u0027 for last variable","commit_id":"0623c47710a3dca8d84fcc1d74fe308ab54cba10"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"c8a61e3ba96d152a4c4ad8fda9557e6afb52b8f5","unresolved":false,"context_lines":[{"line_number":497,"context_line":"                pyparsing.ParseFatalException) as ex:"},{"line_number":498,"context_line":"            LOG.exception(ex)"},{"line_number":499,"context_line":"            title \u003d \"Invalid alarm expression\".encode(\u0027utf8\u0027)"},{"line_number":500,"context_line":"            msg \u003d \"parser failed on expression \u0027{}\u0027 at column {}: \".format("},{"line_number":501,"context_line":"                  expression.encode(\u0027utf8\u0027), str(ex.column).encode(\u0027utf8\u0027),"},{"line_number":502,"context_line":"                  ex.msg.encode(\u0027utf8\u0027))"},{"line_number":503,"context_line":"            raise HTTPUnprocessableEntityError(title, msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_9d30cf09","line":500,"range":{"start_line":500,"start_character":64,"end_line":500,"end_character":66},"in_reply_to":"7a3c09a3_423762e3","updated":"2017-01-12 22:56:42.000000000","message":"Done","commit_id":"0623c47710a3dca8d84fcc1d74fe308ab54cba10"}]}
