)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"90da934a76243e01e5a6a02da83d3313089d0e7d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"MON_DB_HOSTS\u003d$(echo \"${MON_DB_HOSTS[@]}\" | tr \u0027 \u0027 \u0027\\n\u0027 | sort -u | tr \u0027\\n\u0027 \u0027 \u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# system user\u0026group for monasca services"},{"line_number":84,"context_line":"# other services, in example: kafka, storm, grafana"},{"line_number":85,"context_line":"# are not included in this array as they are"},{"line_number":86,"context_line":"# user\u0026group for monasca dependencies"},{"line_number":87,"context_line":"MONASCA_SYSTEM_GROUP\u003d\"monasca\""},{"line_number":88,"context_line":"MONASCA_API_USER\u003d\"mon-api\""},{"line_number":89,"context_line":"MONASCA_PERSISTER_USER\u003d\"mon-persister\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba2be162_8018bf76","line":86,"range":{"start_line":84,"start_character":0,"end_line":86,"end_character":37},"updated":"2017-03-03 14:07:56.000000000","message":"The first line is enough. Please remove the following ones.","commit_id":"64368b126537fb17b8f4863b97ffcf5e5acddeef"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"90da934a76243e01e5a6a02da83d3313089d0e7d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"MONASCA_PERSISTER_USER\u003d\"mon-persister\""},{"line_number":90,"context_line":"MONASCA_NOTIFICATION_USER\u003d\"mon-notification\""},{"line_number":91,"context_line":"MONASCA_THRESH_USER\u003d\"mon-thresh\""},{"line_number":92,"context_line":"declare -A MONASCA_SYSTEM_USERS\u003d("},{"line_number":93,"context_line":"    [\"${MONASCA_API_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""},{"line_number":94,"context_line":"    [\"${MONASCA_PERSISTER_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""},{"line_number":95,"context_line":"    [\"${MONASCA_NOTIFICATION_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba2be162_a04ea36c","line":92,"range":{"start_line":92,"start_character":11,"end_line":92,"end_character":31},"updated":"2017-03-03 14:07:56.000000000","message":"Should be MONASCA_SYSTEM_GROUPS","commit_id":"64368b126537fb17b8f4863b97ffcf5e5acddeef"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"21ad3b7730b4ccb1140743e0905fb716a983359d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"MONASCA_PERSISTER_USER\u003d\"mon-persister\""},{"line_number":90,"context_line":"MONASCA_NOTIFICATION_USER\u003d\"mon-notification\""},{"line_number":91,"context_line":"MONASCA_THRESH_USER\u003d\"mon-thresh\""},{"line_number":92,"context_line":"declare -A MONASCA_SYSTEM_USERS\u003d("},{"line_number":93,"context_line":"    [\"${MONASCA_API_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""},{"line_number":94,"context_line":"    [\"${MONASCA_PERSISTER_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""},{"line_number":95,"context_line":"    [\"${MONASCA_NOTIFICATION_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba2be162_da01bf07","line":92,"range":{"start_line":92,"start_character":11,"end_line":92,"end_character":31},"in_reply_to":"ba2be162_a04ea36c","updated":"2017-03-03 15:51:50.000000000","message":"It is the list of users, why should it be named MONASCA_SYSTEM_GROUPS?","commit_id":"64368b126537fb17b8f4863b97ffcf5e5acddeef"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"71388cfa26cc866386a6c34fcf4ba3bb7e9b34fd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"MONASCA_PERSISTER_USER\u003d\"mon-persister\""},{"line_number":90,"context_line":"MONASCA_NOTIFICATION_USER\u003d\"mon-notification\""},{"line_number":91,"context_line":"MONASCA_THRESH_USER\u003d\"mon-thresh\""},{"line_number":92,"context_line":"declare -A MONASCA_SYSTEM_USERS\u003d("},{"line_number":93,"context_line":"    [\"${MONASCA_API_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""},{"line_number":94,"context_line":"    [\"${MONASCA_PERSISTER_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""},{"line_number":95,"context_line":"    [\"${MONASCA_NOTIFICATION_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba2be162_189b1c67","line":92,"range":{"start_line":92,"start_character":11,"end_line":92,"end_character":31},"in_reply_to":"ba2be162_da01bf07","updated":"2017-03-06 13:59:28.000000000","message":"It is the associative array of system groups where system users are used as keys.","commit_id":"64368b126537fb17b8f4863b97ffcf5e5acddeef"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"90da934a76243e01e5a6a02da83d3313089d0e7d","unresolved":false,"context_lines":[{"line_number":727,"context_line":"    for user in \"${!MONASCA_SYSTEM_USERS[@]}\"; do"},{"line_number":728,"context_line":"        group\u003d\"${MONASCA_SYSTEM_USERS[$user]}\""},{"line_number":729,"context_line":"        sudo groupadd \"${group}\" || true"},{"line_number":730,"context_line":"        sudo useradd -g \"${group}\" -G \"${STACK_USER}\" -s /bin/bash -d /opt/monasca -m \"${user}\" || true"},{"line_number":731,"context_line":"    done"},{"line_number":732,"context_line":"}"},{"line_number":733,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba2be162_a03863a1","line":730,"range":{"start_line":730,"start_character":35,"end_line":730,"end_character":53},"updated":"2017-03-03 14:07:56.000000000","message":"It\u0027s not correct. Please remove.","commit_id":"64368b126537fb17b8f4863b97ffcf5e5acddeef"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"90da934a76243e01e5a6a02da83d3313089d0e7d","unresolved":false,"context_lines":[{"line_number":727,"context_line":"    for user in \"${!MONASCA_SYSTEM_USERS[@]}\"; do"},{"line_number":728,"context_line":"        group\u003d\"${MONASCA_SYSTEM_USERS[$user]}\""},{"line_number":729,"context_line":"        sudo groupadd \"${group}\" || true"},{"line_number":730,"context_line":"        sudo useradd -g \"${group}\" -G \"${STACK_USER}\" -s /bin/bash -d /opt/monasca -m \"${user}\" || true"},{"line_number":731,"context_line":"    done"},{"line_number":732,"context_line":"}"},{"line_number":733,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba2be162_00b76ff5","line":730,"range":{"start_line":730,"start_character":54,"end_line":730,"end_character":85},"updated":"2017-03-03 14:07:56.000000000","message":"What was wrong with system users? Why do we want to create home directories? And do we want to use the same home directory for all these users?","commit_id":"64368b126537fb17b8f4863b97ffcf5e5acddeef"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"21ad3b7730b4ccb1140743e0905fb716a983359d","unresolved":false,"context_lines":[{"line_number":727,"context_line":"    for user in \"${!MONASCA_SYSTEM_USERS[@]}\"; do"},{"line_number":728,"context_line":"        group\u003d\"${MONASCA_SYSTEM_USERS[$user]}\""},{"line_number":729,"context_line":"        sudo groupadd \"${group}\" || true"},{"line_number":730,"context_line":"        sudo useradd -g \"${group}\" -G \"${STACK_USER}\" -s /bin/bash -d /opt/monasca -m \"${user}\" || true"},{"line_number":731,"context_line":"    done"},{"line_number":732,"context_line":"}"},{"line_number":733,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba2be162_5ab94f78","line":730,"range":{"start_line":730,"start_character":54,"end_line":730,"end_character":85},"in_reply_to":"ba2be162_00b76ff5","updated":"2017-03-03 15:51:50.000000000","message":"Our security people asked that these accounts not have home directories and not be allowed to login. Makes sense to keep those restrictions in devstack.","commit_id":"64368b126537fb17b8f4863b97ffcf5e5acddeef"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"bafb8e90aa0c93b1e94190e1a6a50deb7f35a535","unresolved":false,"context_lines":[{"line_number":727,"context_line":"    for user in \"${!MONASCA_SYSTEM_USERS[@]}\"; do"},{"line_number":728,"context_line":"        group\u003d\"${MONASCA_SYSTEM_USERS[$user]}\""},{"line_number":729,"context_line":"        sudo groupadd \"${group}\" || true"},{"line_number":730,"context_line":"        sudo useradd -g \"${group}\" -G \"${STACK_USER}\" -s /bin/bash -d /opt/monasca -m \"${user}\" || true"},{"line_number":731,"context_line":"    done"},{"line_number":732,"context_line":"}"},{"line_number":733,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba2be162_f27a1f87","line":730,"range":{"start_line":730,"start_character":54,"end_line":730,"end_character":85},"in_reply_to":"ba2be162_5ab94f78","updated":"2017-03-03 18:50:35.000000000","message":"Well we have a little problem then.\nWithout ability to login, after setting mon-apo user/group to wsgi configuration, Apache is incapable of running monasca-api because it says that cannot find /home/mon-api :/","commit_id":"64368b126537fb17b8f4863b97ffcf5e5acddeef"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"f61432b7398380d4933d8becd52383f3d6793cd1","unresolved":false,"context_lines":[{"line_number":727,"context_line":"    for user in \"${!MONASCA_SYSTEM_USERS[@]}\"; do"},{"line_number":728,"context_line":"        group\u003d\"${MONASCA_SYSTEM_USERS[$user]}\""},{"line_number":729,"context_line":"        sudo groupadd \"${group}\" || true"},{"line_number":730,"context_line":"        sudo useradd -g \"${group}\" -G \"${STACK_USER}\" -s /bin/bash -d /opt/monasca -m \"${user}\" || true"},{"line_number":731,"context_line":"    done"},{"line_number":732,"context_line":"}"},{"line_number":733,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba2be162_00959e85","line":730,"range":{"start_line":730,"start_character":54,"end_line":730,"end_character":85},"in_reply_to":"ba2be162_f27a1f87","updated":"2017-03-03 19:05:31.000000000","message":"I will retest that with creating users without ability to login to  confirm that statement.","commit_id":"64368b126537fb17b8f4863b97ffcf5e5acddeef"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"90da934a76243e01e5a6a02da83d3313089d0e7d","unresolved":false,"context_lines":[{"line_number":732,"context_line":"}"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"function clean_system_accounts {"},{"line_number":735,"context_line":"    for user in \"${!MONASCA_SYSTEM_USERS}\"; do"},{"line_number":736,"context_line":"        sudo userdel --force \"${user}\" || true"},{"line_number":737,"context_line":"    done"},{"line_number":738,"context_line":"    sudo groupdel \"${MONASCA_SYSTEM_GROUP}\" || true"},{"line_number":739,"context_line":"}"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"function install_openjdk_8_jdk {"}],"source_content_type":"text/x-sh","patch_set":8,"id":"ba2be162_a6aebce3","line":738,"range":{"start_line":735,"start_character":4,"end_line":738,"end_character":51},"updated":"2017-03-03 14:07:56.000000000","message":"You should use the array here as well.","commit_id":"64368b126537fb17b8f4863b97ffcf5e5acddeef"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"0c7ae8dff340bd93167099d78ac78e6cab3a520d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"MONASCA_PERSISTER_USER\u003d\"mon-persister\""},{"line_number":82,"context_line":"MONASCA_NOTIFICATION_USER\u003d\"mon-notification\""},{"line_number":83,"context_line":"MONASCA_THRESH_USER\u003d\"mon-thresh\""},{"line_number":84,"context_line":"declare -A MONASCA_SYSTEM_USERS\u003d("},{"line_number":85,"context_line":"    [\"${MONASCA_API_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""},{"line_number":86,"context_line":"    [\"${MONASCA_PERSISTER_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""},{"line_number":87,"context_line":"    [\"${MONASCA_NOTIFICATION_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""}],"source_content_type":"text/x-sh","patch_set":16,"id":"9a30ddce_d82d3e47","line":84,"range":{"start_line":84,"start_character":11,"end_line":84,"end_character":31},"updated":"2017-03-10 15:24:36.000000000","message":"I still mean it should be called MONASCA_SYSTEM_GROUPS or GROUPS_BY_USER.","commit_id":"3e9b51694175d91c41f6e53f185a57f26cac41ab"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"7e5dc6a554a24e2bbb2c83857b2482bfd70e0c30","unresolved":false,"context_lines":[{"line_number":81,"context_line":"MONASCA_PERSISTER_USER\u003d\"mon-persister\""},{"line_number":82,"context_line":"MONASCA_NOTIFICATION_USER\u003d\"mon-notification\""},{"line_number":83,"context_line":"MONASCA_THRESH_USER\u003d\"mon-thresh\""},{"line_number":84,"context_line":"declare -A MONASCA_SYSTEM_USERS\u003d("},{"line_number":85,"context_line":"    [\"${MONASCA_API_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""},{"line_number":86,"context_line":"    [\"${MONASCA_PERSISTER_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""},{"line_number":87,"context_line":"    [\"${MONASCA_NOTIFICATION_USER}\"]\u003d\"${MONASCA_SYSTEM_GROUP}\""}],"source_content_type":"text/x-sh","patch_set":16,"id":"3a1ff146_a8ce1781","line":84,"range":{"start_line":84,"start_character":11,"end_line":84,"end_character":31},"in_reply_to":"9a30ddce_d82d3e47","updated":"2017-03-15 06:17:05.000000000","message":"It cannot be called *GROUPS* because keys are the names of the users, not groups. So having that said better option would be USERS_BY_GROUP which after I add monasca\u0027d become MONASCA_USERS_BY_GROUP and that effectively is not far from MONASCA_SYSTEM_USERS IMHO. \n\nI can go with MONASCA_SYSTEM_USERS_BY_GROUP if you prefer it this way, but that\u0027s longer and does not change too much.","commit_id":"3e9b51694175d91c41f6e53f185a57f26cac41ab"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"0c7ae8dff340bd93167099d78ac78e6cab3a520d","unresolved":false,"context_lines":[{"line_number":716,"context_line":"    for user in \"${!MONASCA_SYSTEM_USERS[@]}\"; do"},{"line_number":717,"context_line":"        group\u003d\"${MONASCA_SYSTEM_USERS[$user]}\""},{"line_number":718,"context_line":"        sudo groupadd -f \"${group}\" || true"},{"line_number":719,"context_line":"        sudo useradd -g \"${group}\" -G \"${STACK_USER}\" -r \"${user}\" || true"},{"line_number":720,"context_line":"    done"},{"line_number":721,"context_line":"}"},{"line_number":722,"context_line":""}],"source_content_type":"text/x-sh","patch_set":16,"id":"9a30ddce_d889be27","line":719,"range":{"start_line":719,"start_character":54,"end_line":719,"end_character":56},"updated":"2017-03-10 15:24:36.000000000","message":"Would prefer using \u0027--system\u0027. I always have to think a while what \u0027-r\u0027 actually means.","commit_id":"3e9b51694175d91c41f6e53f185a57f26cac41ab"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"7e5dc6a554a24e2bbb2c83857b2482bfd70e0c30","unresolved":false,"context_lines":[{"line_number":716,"context_line":"    for user in \"${!MONASCA_SYSTEM_USERS[@]}\"; do"},{"line_number":717,"context_line":"        group\u003d\"${MONASCA_SYSTEM_USERS[$user]}\""},{"line_number":718,"context_line":"        sudo groupadd -f \"${group}\" || true"},{"line_number":719,"context_line":"        sudo useradd -g \"${group}\" -G \"${STACK_USER}\" -r \"${user}\" || true"},{"line_number":720,"context_line":"    done"},{"line_number":721,"context_line":"}"},{"line_number":722,"context_line":""}],"source_content_type":"text/x-sh","patch_set":16,"id":"3a1ff146_68825f02","line":719,"range":{"start_line":719,"start_character":54,"end_line":719,"end_character":56},"in_reply_to":"9a30ddce_d889be27","updated":"2017-03-15 06:17:05.000000000","message":"Done","commit_id":"3e9b51694175d91c41f6e53f185a57f26cac41ab"}]}