)]}'
{"devstack/files/schema/mon_mysql.sql":[{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"03b7e6c8e6efdbdad9658f75feb227f4719e3134","unresolved":false,"context_lines":[{"line_number":183,"context_line":"CREATE TABLE `alarm_rule` ("},{"line_number":184,"context_line":"  `alarm_rule_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":185,"context_line":"  `alarm_definition_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":186,"context_line":"  PRIMARY KEY (`alarm_rule_id`,`alarm_definition_id`),"},{"line_number":187,"context_line":") ENGINE\u003dInnoDB DEFAULT CHARSET\u003dutf8mb4 COLLATE\u003dutf8mb4_unicode_ci;"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"SET foreign_key_checks \u003d 1;"}],"source_content_type":"text/x-sql","patch_set":1,"id":"1a1ced50_68bc096d","line":186,"range":{"start_line":186,"start_character":53,"end_line":186,"end_character":54},"updated":"2017-03-17 21:30:54.000000000","message":"I think you don\u0027t need this coma.","commit_id":"3e357351be5bec8b77960aa771c23cc9a1d2b573"},{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"f4764d8c5c543b5c9d71f98b72c6972ddaf59c8a","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"CREATE TABLE `alarm_rule` ("},{"line_number":184,"context_line":"  `alarm_rule_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":185,"context_line":"  `alarm_definition_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":186,"context_line":"  PRIMARY KEY (`alarm_rule_id`,`alarm_definition_id`)"},{"line_number":187,"context_line":") ENGINE\u003dInnoDB DEFAULT CHARSET\u003dutf8mb4 COLLATE\u003dutf8mb4_unicode_ci;"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-sql","patch_set":2,"id":"1a1ced50_07ecc4f1","line":185,"range":{"start_line":185,"start_character":3,"end_line":185,"end_character":22},"updated":"2017-03-22 19:07:45.000000000","message":"I think this should be alarm_id since an alarm could be effected differently than another but still have the same alarm definition as the other.","commit_id":"6e4e0745cf3498a1843488c9b761a99efa7f63b6"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b16e076e8f47a5621ec99b69d983ba4ce21d4d54","unresolved":false,"context_lines":[{"line_number":181,"context_line":");"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"CREATE TABLE `alarm_rule` ("},{"line_number":184,"context_line":"  `alarm_rule_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":185,"context_line":"  `alarm_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":186,"context_line":"  KEY `fk_rules_alarm_id` (`alarm_id`),"},{"line_number":187,"context_line":"  PRIMARY KEY (`alarm_rule_id`,`alarm_id`),"}],"source_content_type":"text/x-sql","patch_set":6,"id":"bff0334d_b2407309","line":184,"range":{"start_line":184,"start_character":3,"end_line":184,"end_character":16},"updated":"2017-04-06 00:01:45.000000000","message":"alarm_rule_id is also a foreign key. Doesn\u0027t it need the KEY and CONSTRAINT lines for it, too? That would cause these entries to be deleted if the rule was deleted","commit_id":"e515085bb76224299dc3b2557af071db2a7afec1"},{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"40a96f4ed45e82937cca28d45cde36678602f70c","unresolved":false,"context_lines":[{"line_number":181,"context_line":");"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"CREATE TABLE `alarm_rule` ("},{"line_number":184,"context_line":"  `alarm_rule_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":185,"context_line":"  `alarm_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":186,"context_line":"  KEY `fk_rules_alarm_id` (`alarm_id`),"},{"line_number":187,"context_line":"  PRIMARY KEY (`alarm_rule_id`,`alarm_id`),"}],"source_content_type":"text/x-sql","patch_set":6,"id":"bff0334d_441a657d","line":184,"range":{"start_line":184,"start_character":3,"end_line":184,"end_character":16},"in_reply_to":"bff0334d_b2407309","updated":"2017-04-06 17:03:48.000000000","message":"Done.\nI have to add in some inheritance and dependence in the API reviews, but I think this is a better way to do it.","commit_id":"e515085bb76224299dc3b2557af071db2a7afec1"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"4ba19b48690ea6815c2200a8942d04096950cd8f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"CREATE TABLE `alarm_rule` ("},{"line_number":106,"context_line":"  `alarm_rule_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":107,"context_line":"  `alarm_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":108,"context_line":"  `inhibition_source_id` varchar(36) COLLATE utf8mb4_unicode_ci DEFAULT NULL,"},{"line_number":109,"context_line":"  KEY `fk_rules_alarm_id` (`alarm_id`),"},{"line_number":110,"context_line":"  PRIMARY KEY (`alarm_rule_id`,`alarm_id`),"},{"line_number":111,"context_line":"  CONSTRAINT `fk_rules_alarm_id` FOREIGN KEY (`alarm_id`) REFERENCES `alarm` (`id`) ON DELETE CASCADE,"}],"source_content_type":"text/x-sql","patch_set":19,"id":"1f013ff3_8488a771","line":108,"range":{"start_line":108,"start_character":3,"end_line":108,"end_character":23},"updated":"2017-05-12 23:38:29.000000000","message":"Is this a foreign key? There is no constraint for it below","commit_id":"9dfb29b21cd5bf0cc5c7b079d8712ebb12614a83"},{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"e59bf1ccae1d54e776bd96e32422be0c062f9978","unresolved":false,"context_lines":[{"line_number":105,"context_line":"CREATE TABLE `alarm_rule` ("},{"line_number":106,"context_line":"  `alarm_rule_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":107,"context_line":"  `alarm_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":108,"context_line":"  `inhibition_source_id` varchar(36) COLLATE utf8mb4_unicode_ci DEFAULT NULL,"},{"line_number":109,"context_line":"  KEY `fk_rules_alarm_id` (`alarm_id`),"},{"line_number":110,"context_line":"  PRIMARY KEY (`alarm_rule_id`,`alarm_id`),"},{"line_number":111,"context_line":"  CONSTRAINT `fk_rules_alarm_id` FOREIGN KEY (`alarm_id`) REFERENCES `alarm` (`id`) ON DELETE CASCADE,"}],"source_content_type":"text/x-sql","patch_set":19,"id":"1f013ff3_aeaec3e4","line":108,"range":{"start_line":108,"start_character":3,"end_line":108,"end_character":23},"in_reply_to":"1f013ff3_8488a771","updated":"2017-05-15 16:17:28.000000000","message":"Done","commit_id":"9dfb29b21cd5bf0cc5c7b079d8712ebb12614a83"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6fa5c775e468e9d026a8d4e2c7e0f9d6450bec44","unresolved":false,"context_lines":[{"line_number":105,"context_line":"CREATE TABLE `alarm_rule` ("},{"line_number":106,"context_line":"  `alarm_rule_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":107,"context_line":"  `alarm_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":108,"context_line":"  `inhibition_source_id` varchar(36) COLLATE utf8mb4_unicode_ci DEFAULT NULL, "},{"line_number":109,"context_line":"  KEY `fk_rules_alarm_id` (`alarm_id`),"},{"line_number":110,"context_line":"  PRIMARY KEY (`alarm_rule_id`,`alarm_id`),"},{"line_number":111,"context_line":"  CONSTRAINT `fk_rules_alarm_id` FOREIGN KEY (`alarm_id`) REFERENCES `alarm` (`id`) ON DELETE CASCADE,"}],"source_content_type":"text/x-sql","patch_set":20,"id":"1f013ff3_aef803c4","line":108,"range":{"start_line":108,"start_character":77,"end_line":108,"end_character":78},"updated":"2017-05-15 16:24:47.000000000","message":"Trailing space? Can\u0027t quite tell","commit_id":"2843a8ede9002c40ccab70fba3f20ae5dc2c67a2"},{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"35d52c51f788f25756e38f7defe91977394cc84c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"CREATE TABLE `alarm_rule` ("},{"line_number":106,"context_line":"  `alarm_rule_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":107,"context_line":"  `alarm_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":108,"context_line":"  `inhibition_source_id` varchar(36) COLLATE utf8mb4_unicode_ci DEFAULT NULL, "},{"line_number":109,"context_line":"  KEY `fk_rules_alarm_id` (`alarm_id`),"},{"line_number":110,"context_line":"  PRIMARY KEY (`alarm_rule_id`,`alarm_id`),"},{"line_number":111,"context_line":"  CONSTRAINT `fk_rules_alarm_id` FOREIGN KEY (`alarm_id`) REFERENCES `alarm` (`id`) ON DELETE CASCADE,"}],"source_content_type":"text/x-sql","patch_set":20,"id":"1f013ff3_0e1ff76c","line":108,"range":{"start_line":108,"start_character":77,"end_line":108,"end_character":78},"in_reply_to":"1f013ff3_aef803c4","updated":"2017-05-15 16:41:12.000000000","message":"Done","commit_id":"2843a8ede9002c40ccab70fba3f20ae5dc2c67a2"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"c963720ea2471446073dcd1a9c5b8672fe0454f7","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  `alarm_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":108,"context_line":"  `inhibition_source_id` varchar(36) COLLATE utf8mb4_unicode_ci DEFAULT NULL,"},{"line_number":109,"context_line":"  KEY `fk_rules_alarm_id` (`alarm_id`),"},{"line_number":110,"context_line":"  PRIMARY KEY (`alarm_rule_id`,`alarm_id`),"},{"line_number":111,"context_line":"  CONSTRAINT `fk_alarm_rule_definition_id` FOREIGN KEY (`alarm_rule_id`) REFERENCES `alarm_rule_definition` (`id`) ON DELETE CASCADE,"},{"line_number":112,"context_line":"  CONSTRAINT `fk_rules_alarm_id` FOREIGN KEY (`alarm_id`) REFERENCES `alarm` (`id`) ON DELETE CASCADE,"},{"line_number":113,"context_line":"  CONSTRAINT `fk_inhibition_source_id` FOREIGN KEY (`inhibition_source_id`) REFERENCES `alarm` (`id`) ON DELETE CASCADE"}],"source_content_type":"text/x-sql","patch_set":23,"id":"ff0f0b1f_8f2c3448","line":110,"range":{"start_line":110,"start_character":2,"end_line":110,"end_character":42},"updated":"2017-05-18 00:17:28.000000000","message":"I believe that this says you can\u0027t have a two entries with the same alarm_rule_id and alarm_id but with different inhibition_source_id values. Is that what you want? Does your code prevent that case?","commit_id":"1b97074e02efee542f9de754b60ed1a811332c51"},{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"a44998ac08fbb95235a77836d5da5296d9e39373","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  `alarm_id` varchar(36) COLLATE utf8mb4_unicode_ci NOT NULL,"},{"line_number":108,"context_line":"  `inhibition_source_id` varchar(36) COLLATE utf8mb4_unicode_ci DEFAULT NULL,"},{"line_number":109,"context_line":"  KEY `fk_rules_alarm_id` (`alarm_id`),"},{"line_number":110,"context_line":"  PRIMARY KEY (`alarm_rule_id`,`alarm_id`),"},{"line_number":111,"context_line":"  CONSTRAINT `fk_alarm_rule_definition_id` FOREIGN KEY (`alarm_rule_id`) REFERENCES `alarm_rule_definition` (`id`) ON DELETE CASCADE,"},{"line_number":112,"context_line":"  CONSTRAINT `fk_rules_alarm_id` FOREIGN KEY (`alarm_id`) REFERENCES `alarm` (`id`) ON DELETE CASCADE,"},{"line_number":113,"context_line":"  CONSTRAINT `fk_inhibition_source_id` FOREIGN KEY (`inhibition_source_id`) REFERENCES `alarm` (`id`) ON DELETE CASCADE"}],"source_content_type":"text/x-sql","patch_set":23,"id":"ff0f0b1f_3a60a4a5","line":110,"range":{"start_line":110,"start_character":2,"end_line":110,"end_character":42},"in_reply_to":"ff0f0b1f_8f2c3448","updated":"2017-05-18 22:22:41.000000000","message":"Your right. One alarm id can be associated with several rule ids. Ill remove that in the put-together review","commit_id":"1b97074e02efee542f9de754b60ed1a811332c51"}],"devstack/files/schema/mon_postgresql.sql":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b16e076e8f47a5621ec99b69d983ba4ce21d4d54","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    ADD CONSTRAINT fk_alarm_noticication_method_type FOREIGN KEY (type) REFERENCES notification_method_type (name);"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"ALTER TABLE ONLY  alarm_rule"},{"line_number":222,"context_line":"    ADD CONSTRAINT fk_rules_alarm_id FOREIGN KEY (alarm_id) REFRENCES alarm (id) ON DELETE CASCADE;"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"---"},{"line_number":225,"context_line":"-- data for enum tables"}],"source_content_type":"text/x-sql","patch_set":6,"id":"bff0334d_12515fd9","line":222,"range":{"start_line":222,"start_character":4,"end_line":222,"end_character":90},"updated":"2017-04-06 00:01:45.000000000","message":"Don\u0027t you need this for alarm_rule_id, too?","commit_id":"e515085bb76224299dc3b2557af071db2a7afec1"},{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"40a96f4ed45e82937cca28d45cde36678602f70c","unresolved":false,"context_lines":[{"line_number":219,"context_line":"    ADD CONSTRAINT fk_alarm_noticication_method_type FOREIGN KEY (type) REFERENCES notification_method_type (name);"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"ALTER TABLE ONLY  alarm_rule"},{"line_number":222,"context_line":"    ADD CONSTRAINT fk_rules_alarm_id FOREIGN KEY (alarm_id) REFRENCES alarm (id) ON DELETE CASCADE;"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"---"},{"line_number":225,"context_line":"-- data for enum tables"}],"source_content_type":"text/x-sql","patch_set":6,"id":"bff0334d_04145d4d","line":222,"range":{"start_line":222,"start_character":4,"end_line":222,"end_character":90},"in_reply_to":"bff0334d_12515fd9","updated":"2017-04-06 17:03:48.000000000","message":"Done","commit_id":"e515085bb76224299dc3b2557af071db2a7afec1"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"4ba19b48690ea6815c2200a8942d04096950cd8f","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"CREATE TABLE alarm_rule ("},{"line_number":77,"context_line":"    alarm_rule_id character varying(255) NOT NULL,"},{"line_number":78,"context_line":"    alarm_id character varying(255) NOT NULL,"},{"line_number":79,"context_line":"    inhibition_source_id character varying (255)"},{"line_number":80,"context_line":");"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-sql","patch_set":19,"id":"1f013ff3_04ab77d6","line":78,"range":{"start_line":78,"start_character":4,"end_line":78,"end_character":12},"updated":"2017-05-12 23:38:29.000000000","message":"Is this a foreign key? There is no constraint for it below","commit_id":"9dfb29b21cd5bf0cc5c7b079d8712ebb12614a83"},{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"135b422d3bbc23c71c11861cf2a4d77cad6d8d2d","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"CREATE TABLE alarm_rule ("},{"line_number":77,"context_line":"    alarm_rule_id character varying(255) NOT NULL,"},{"line_number":78,"context_line":"    alarm_id character varying(255) NOT NULL,"},{"line_number":79,"context_line":"    inhibition_source_id character varying (255)"},{"line_number":80,"context_line":");"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-sql","patch_set":19,"id":"1f013ff3_13c16055","line":78,"range":{"start_line":78,"start_character":4,"end_line":78,"end_character":12},"in_reply_to":"1f013ff3_04ab77d6","updated":"2017-05-15 16:02:48.000000000","message":"It absolutely is a foreign key, but it corresponds to a table that is in a different review. MySql doesn\u0027t like a foreign key constraint to a table that doesn\u0027t exist, so I\u0027m thinking I should leave this variable out completely and maybe move it\u0027s declaration to the inhibition review.","commit_id":"9dfb29b21cd5bf0cc5c7b079d8712ebb12614a83"},{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"e59bf1ccae1d54e776bd96e32422be0c062f9978","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"CREATE TABLE alarm_rule ("},{"line_number":77,"context_line":"    alarm_rule_id character varying(255) NOT NULL,"},{"line_number":78,"context_line":"    alarm_id character varying(255) NOT NULL,"},{"line_number":79,"context_line":"    inhibition_source_id character varying (255)"},{"line_number":80,"context_line":");"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-sql","patch_set":19,"id":"1f013ff3_0ea017f4","line":78,"range":{"start_line":78,"start_character":4,"end_line":78,"end_character":12},"in_reply_to":"1f013ff3_13c16055","updated":"2017-05-15 16:17:28.000000000","message":"Never mind, I was thinking incorrectly.","commit_id":"9dfb29b21cd5bf0cc5c7b079d8712ebb12614a83"}]}