)]}'
{"monasca_api/common/repositories/sqla/models.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"b2dadead7c74521d1b9b006f159c715f3b096b50","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                 Column(\u0027state\u0027, String(20)),"},{"line_number":34,"context_line":"                 Column(\u0027lifecycle_state\u0027, String(50)),"},{"line_number":35,"context_line":"                 Column(\u0027link\u0027, String(512)),"},{"line_number":36,"context_line":"                 Column(\u0027inhibited\u0027, String(36)),"},{"line_number":37,"context_line":"                 Column(\u0027silenced\u0027, String(36)),"},{"line_number":38,"context_line":"                 Column(\u0027created_at\u0027, DateTime),"},{"line_number":39,"context_line":"                 Column(\u0027state_updated_at\u0027, DateTime),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_bcab97d4","line":36,"range":{"start_line":36,"start_character":37,"end_line":36,"end_character":47},"updated":"2017-06-12 15:25:29.000000000","message":"Shouldn\u0027t this be a Boolean?","commit_id":"69949faae302613d02b4ca20e7cf2661e2bf6965"},{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"046c8bf5112ae6b611139abefa85d5d34039a8eb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                 Column(\u0027state\u0027, String(20)),"},{"line_number":34,"context_line":"                 Column(\u0027lifecycle_state\u0027, String(50)),"},{"line_number":35,"context_line":"                 Column(\u0027link\u0027, String(512)),"},{"line_number":36,"context_line":"                 Column(\u0027inhibited\u0027, String(36)),"},{"line_number":37,"context_line":"                 Column(\u0027silenced\u0027, String(36)),"},{"line_number":38,"context_line":"                 Column(\u0027created_at\u0027, DateTime),"},{"line_number":39,"context_line":"                 Column(\u0027state_updated_at\u0027, DateTime),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_c4954ae6","line":36,"range":{"start_line":36,"start_character":37,"end_line":36,"end_character":47},"in_reply_to":"7f231b9d_bcab97d4","updated":"2017-06-12 23:23:15.000000000","message":"Done","commit_id":"69949faae302613d02b4ca20e7cf2661e2bf6965"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"114170a2982621da6252dc8620c125342cde149c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                 Column(\u0027state\u0027, String(20)),"},{"line_number":34,"context_line":"                 Column(\u0027lifecycle_state\u0027, String(50)),"},{"line_number":35,"context_line":"                 Column(\u0027link\u0027, String(512)),"},{"line_number":36,"context_line":"                 Column(\u0027inhibited\u0027, String(36)),"},{"line_number":37,"context_line":"                 Column(\u0027silenced\u0027, String(36)),"},{"line_number":38,"context_line":"                 Column(\u0027created_at\u0027, DateTime),"},{"line_number":39,"context_line":"                 Column(\u0027state_updated_at\u0027, DateTime),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_2285f208","line":36,"range":{"start_line":36,"start_character":37,"end_line":36,"end_character":47},"in_reply_to":"7f231b9d_c4954ae6","updated":"2017-06-13 16:54:50.000000000","message":"Were you thinking to put the rule ID in here instead of just boolean?","commit_id":"69949faae302613d02b4ca20e7cf2661e2bf6965"}],"monasca_api/tests/sqlite_alarm.sql":[{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"27a9e5ed67b8383cccbeb47abee2fefc7c28a14c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  `state` varchar(20) NOT NULL,"},{"line_number":45,"context_line":"  `lifecycle_state` varchar(50) DEFAULT NULL,"},{"line_number":46,"context_line":"  `link` varchar(512) DEFAULT NULL,"},{"line_number":47,"context_line":"  `inhibited` tinyint(1) NOT NULL DEFAULT \u00270\u0027,"},{"line_number":48,"context_line":"  `silenced` tinyint(1) NOT NULL DEFAULT \u00270\u0027,"},{"line_number":49,"context_line":"  `created_at` datetime NOT NULL,"},{"line_number":50,"context_line":"  `state_updated_at` datetime,"}],"source_content_type":"text/x-sql","patch_set":9,"id":"5f201791_8a476d4c","line":47,"range":{"start_line":47,"start_character":43,"end_line":47,"end_character":44},"updated":"2017-06-21 18:57:30.000000000","message":"should default to be False or 0?","commit_id":"969d4d96babf7a3c167d8b3aa61c8aac20b4e170"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"7c737653545f8dca4caad7bd4920f81dfca8cbbd","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  `state` varchar(20) NOT NULL,"},{"line_number":45,"context_line":"  `lifecycle_state` varchar(50) DEFAULT NULL,"},{"line_number":46,"context_line":"  `link` varchar(512) DEFAULT NULL,"},{"line_number":47,"context_line":"  `inhibited` tinyint(1) NOT NULL DEFAULT \u00270\u0027,"},{"line_number":48,"context_line":"  `silenced` tinyint(1) NOT NULL DEFAULT \u00270\u0027,"},{"line_number":49,"context_line":"  `created_at` datetime NOT NULL,"},{"line_number":50,"context_line":"  `state_updated_at` datetime,"}],"source_content_type":"text/x-sql","patch_set":9,"id":"3f1d235d_17cd5265","line":47,"range":{"start_line":47,"start_character":43,"end_line":47,"end_character":44},"in_reply_to":"5f201791_8a476d4c","updated":"2017-07-05 11:36:18.000000000","message":"+1","commit_id":"969d4d96babf7a3c167d8b3aa61c8aac20b4e170"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"27a9e5ed67b8383cccbeb47abee2fefc7c28a14c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  `lifecycle_state` varchar(50) DEFAULT NULL,"},{"line_number":46,"context_line":"  `link` varchar(512) DEFAULT NULL,"},{"line_number":47,"context_line":"  `inhibited` tinyint(1) NOT NULL DEFAULT \u00270\u0027,"},{"line_number":48,"context_line":"  `silenced` tinyint(1) NOT NULL DEFAULT \u00270\u0027,"},{"line_number":49,"context_line":"  `created_at` datetime NOT NULL,"},{"line_number":50,"context_line":"  `state_updated_at` datetime,"},{"line_number":51,"context_line":"  `updated_at` datetime NOT NULL,"}],"source_content_type":"text/x-sql","patch_set":9,"id":"5f201791_6a7651a7","line":48,"updated":"2017-06-21 18:57:30.000000000","message":"same here","commit_id":"969d4d96babf7a3c167d8b3aa61c8aac20b4e170"}],"monasca_api/tests/test_a_repository.py":[{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"7c737653545f8dca4caad7bd4920f81dfca8cbbd","unresolved":false,"context_lines":[{"line_number":892,"context_line":"            conn.execute(silence_query)"},{"line_number":893,"context_line":"            conn.execute(inhibit_query)"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"        self.alarm1[\u0027inhibited\u0027] \u003d True"},{"line_number":896,"context_line":"        self.alarm1[\u0027silenced\u0027] \u003d True"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"        res \u003d self.repo.get_alarms(tenant_id\u003d\u0027Not a tenant id\u0027, limit\u003d1)"},{"line_number":899,"context_line":"        self.assertEqual(res, [])"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f1d235d_570ceaea","line":896,"range":{"start_line":895,"start_character":0,"end_line":896,"end_character":38},"updated":"2017-07-05 11:36:18.000000000","message":"stick to the same order like in lines 889-893","commit_id":"969d4d96babf7a3c167d8b3aa61c8aac20b4e170"}],"monasca_tempest_tests/tests/api/test_alarms.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"6d31710bbaaf50b28498bf5ce19d7dcd97799529","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"                break"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"    def _verify_alarm_keys(self, response_body):"},{"line_number":1056,"context_line":"        expected_keys \u003d [\u0027id\u0027,"},{"line_number":1057,"context_line":"                         \u0027links\u0027,"},{"line_number":1058,"context_line":"                         \u0027alarm_definition\u0027,"},{"line_number":1059,"context_line":"                         \u0027metrics\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f201791_ecf4c25d","line":1056,"range":{"start_line":1056,"start_character":8,"end_line":1056,"end_character":21},"updated":"2017-06-21 17:27:45.000000000","message":"What is the reason you didn\u0027t just add inhibited and silenced into this?","commit_id":"969d4d96babf7a3c167d8b3aa61c8aac20b4e170"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"fd8056153f1a902f3f098a245368a9dfeac7f28e","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"                break"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"    def _verify_alarm_keys(self, response_body):"},{"line_number":1056,"context_line":"        expected_keys \u003d [\u0027id\u0027,"},{"line_number":1057,"context_line":"                         \u0027links\u0027,"},{"line_number":1058,"context_line":"                         \u0027alarm_definition\u0027,"},{"line_number":1059,"context_line":"                         \u0027metrics\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f201791_c7cb21a3","line":1056,"range":{"start_line":1056,"start_character":8,"end_line":1056,"end_character":21},"in_reply_to":"5f201791_0c637e1c","updated":"2017-06-21 17:46:54.000000000","message":"Ok, makes sense","commit_id":"969d4d96babf7a3c167d8b3aa61c8aac20b4e170"},{"author":{"_account_id":22157,"name":"Andrea Adams","email":"aadams@hpe.com","username":"andrea.adams"},"change_message_id":"483ebfcfe05b259517f892a5d03cea82e49304b8","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"                break"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"    def _verify_alarm_keys(self, response_body):"},{"line_number":1056,"context_line":"        expected_keys \u003d [\u0027id\u0027,"},{"line_number":1057,"context_line":"                         \u0027links\u0027,"},{"line_number":1058,"context_line":"                         \u0027alarm_definition\u0027,"},{"line_number":1059,"context_line":"                         \u0027metrics\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f201791_0c637e1c","line":1056,"range":{"start_line":1056,"start_character":8,"end_line":1056,"end_character":21},"in_reply_to":"5f201791_ecf4c25d","updated":"2017-06-21 17:29:49.000000000","message":"It will fail the java tests, and we didn\u0027t want to make this dependent on the other API review or re-write the code in the other API review","commit_id":"969d4d96babf7a3c167d8b3aa61c8aac20b4e170"}]}
