)]}'
{"monasca_api/v2/reference/alarm_definitions.py":[{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"91394ac407ab7553d842f8b43c1e640ccea128fb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    @resource.resource_try_catch_block"},{"line_number":134,"context_line":"    def on_put(self, req, res, alarm_definition_id\u003dNone):"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        if alarm_definition_id is not None:"},{"line_number":137,"context_line":"            helpers.validate_authorization(req, self._default_authorized_roles)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            alarm_definition \u003d helpers.from_json(req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_53a37c01","line":136,"range":{"start_line":136,"start_character":8,"end_line":136,"end_character":43},"updated":"2017-06-06 19:48:18.000000000","message":"It might be better here to test if the alarm_definition_id is none and then raise if it is.  That way we can see the immediate exit without having to read down the rest of the function and we don\u0027t have to have an else block for the if.","commit_id":"eebd4b6fb6fb53dd3dc417c2e852fd280fb1b316"},{"author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"change_message_id":"91394ac407ab7553d842f8b43c1e640ccea128fb","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            res.body \u003d helpers.to_json(result)"},{"line_number":170,"context_line":"            res.status \u003d falcon.HTTP_200"},{"line_number":171,"context_line":"        else:"},{"line_number":172,"context_line":"            res.status \u003d falcon.HTTP_422"},{"line_number":173,"context_line":"            raise HTTPUnprocessableEntityError(\u0027Unprocessable Entity\u0027,"},{"line_number":174,"context_line":"                                               \u0027Alarm definition ID not provided\u0027)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_9374749e","line":172,"range":{"start_line":172,"start_character":12,"end_line":172,"end_character":40},"updated":"2017-06-06 19:48:18.000000000","message":"With the raise call on the next line down I\u0027m not certain this line does anything.  The decorator should catch the raise and generate the proper exception.","commit_id":"eebd4b6fb6fb53dd3dc417c2e852fd280fb1b316"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"cb383128c9e4df6a4b7c81a2034fdf3e302c6804","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            res.body \u003d helpers.to_json(result)"},{"line_number":170,"context_line":"            res.status \u003d falcon.HTTP_200"},{"line_number":171,"context_line":"        else:"},{"line_number":172,"context_line":"            res.status \u003d falcon.HTTP_422"},{"line_number":173,"context_line":"            raise HTTPUnprocessableEntityError(\u0027Unprocessable Entity\u0027,"},{"line_number":174,"context_line":"                                               \u0027Alarm definition ID not provided\u0027)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_adbb87c2","line":172,"range":{"start_line":172,"start_character":12,"end_line":172,"end_character":40},"in_reply_to":"df140735_9374749e","updated":"2017-06-07 04:49:15.000000000","message":"+1","commit_id":"eebd4b6fb6fb53dd3dc417c2e852fd280fb1b316"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"72552746a5a3bdb689a0657d1b2f1c93e59ef4fa","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    @resource.resource_try_catch_block"},{"line_number":134,"context_line":"    def on_put(self, req, res, alarm_definition_id\u003dNone):"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        if alarm_definition_id is None:"},{"line_number":137,"context_line":"            raise HTTPUnprocessableEntityError(\u0027Unprocessable Entity\u0027,"},{"line_number":138,"context_line":"                                               \u0027Alarm definition ID not provided\u0027)"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_32efbdb1","line":136,"range":{"start_line":136,"start_character":8,"end_line":136,"end_character":38},"updated":"2017-06-07 17:22:33.000000000","message":"If you change this to:\n\nif not alarm_definition_id:\n\nIt handles an alarm_definition_id of \"\" as well","commit_id":"9719445d85f10ea7777cad40b7c1535b06ca7b21"}]}